| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-09-19 | |||
| 11:20:59 | openstackgerrit | Ian Wienand proposed openstack/openstacksdk master: Handle empty values in regions https://review.openstack.org/601485 | |
| 12:02:56 | openstackgerrit | Merged openstack/os-client-config master: fix bug link in readme https://review.openstack.org/597558 | |
| 12:43:54 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Run all tasks through the threadpool https://review.openstack.org/603739 | |
| 13:04:12 | AJaeger | mordred: could you see scrollback on #openstack-infra and help promoting a job, please? | |
| 13:12:43 | openstackgerrit | Merged openstack/microversion-parse master: Copy zuul job settings from project-config https://review.openstack.org/599448 | |
| 13:12:44 | openstackgerrit | Merged openstack/microversion-parse master: Add python36 jobs to microversion-parse https://review.openstack.org/599539 | |
| 14:42:45 | openstackgerrit | Merged openstack/openstacksdk master: Listing objects to return Munch objects https://review.openstack.org/596780 | |
| 14:54:02 | ml | do new implementations require the use of tenant_id or can I completely drop it in favor or project_id? | |
| 14:58:02 | mordred | ml: please use project_id - I would prefer the word tenant showed up nowhere :) | |
| 14:58:37 | ml | excellent, less work | |
| 15:03:51 | openstackgerrit | Merged openstack/openstacksdk master: baremetal: implement validate_node https://review.openstack.org/599533 | |
| 15:07:54 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | |
| 15:56:34 | mordred | dtantsur: ok. I think I figure out the bifrost test failure | |
| 15:56:47 | dtantsur | \o/ | |
| 15:57:07 | dtantsur | so, what's it? | |
| 15:57:33 | mordred | dtantsur: tl;dr - when noauth and endpoint are used, things are weird - so I've got some code adding a conditional for "did the user set overrides, if so just trust the user" | |
| 15:58:00 | dtantsur | mordred: how does it play with our looooong text for api-sig? | |
| 15:58:15 | dtantsur | I remember thinking really hard on a few bits around endpoint-override.. | |
| 15:58:52 | mordred | I *think* it's correct - but we should definitely walk through it and make sure | |
| 15:59:10 | mordred | also - I think I found a minor-ish bug in keystoneauth ... but maybe it's not one | |
| 15:59:42 | mordred | kmalloc, cmurphy: in keystoneauth's discovery cache, we cache http://localhost:6385/ separately from http://localhost:6385 | |
| 16:00:17 | mordred | so if someone puts in an endpoint_override with http://localhost:6385 and then the discovery document or catalog has http://localhost:6385/ - I *think* we're ignoring the cache and making a second call | |
| 16:00:21 | kmalloc | *blink* | |
| 16:00:42 | cmurphy | yay | |
| 16:02:30 | dtantsur | Oo | |
| 16:02:30 | mordred | cmurphy: not me not me | |
| 16:02:48 | kmalloc | mordred: so... Fwiw, the URL with the trailing slash is often different. With exception of the first slash | |
| 16:02:59 | kmalloc | So sounds like we need an rstrip | |
| 16:03:23 | kmalloc | mordred: it was either you or jamielennox I think. | |
| 16:03:28 | kmalloc | mordred: :P | |
| 16:03:39 | mordred | kmalloc: I'm going to blame jamielennox because he's not going to defend himself which is safer for me | |
| 16:03:43 | kmalloc | Heheheh | |
| 16:03:52 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 16:04:53 | mordred | dtantsur, kmalloc, cmurphy: https://review.openstack.org/#/c/600292/5..6/openstack/service_description.py - wit that change, openstack.baremetal is the correct proxy object in a devstack | |
| 16:05:49 | kmalloc | My eyes are bleeding. | |
| 16:06:01 | mordred | they should be | |
| 16:06:14 | mordred | that means you still have some amount of sanity | |
| 16:06:42 | kmalloc | Oh it's ok, I lost most of my sanity in the 10000 lines for flask | |
| 16:07:09 | kmalloc | My eyes are only bleeding because of the number of files changed and the number of loc. | |
| 16:07:14 | kmalloc | Not the content of the patch. | |
| 16:08:16 | dtantsur | mordred: will it work with an unversioned endpoint? | |
| 16:08:17 | mordred | kmalloc: MOST of it is removing useless lines from tests | |
| 16:08:23 | kmalloc | mordred: exactly | |
| 16:08:29 | mordred | dtantsur: I believe so | |
| 16:09:04 | mordred | dtantsur: well, I say that ... but actually no, I think it still won't | |
| 16:09:18 | mordred | I think there is still one more "bug" preventing that from working | |
| 16:09:24 | dtantsur | \o/ | |
| 16:09:45 | mordred | which is - in most of the codepaths in keystoneauth if someone gives an endpoint_override we treat it as unassailable fact | |
| 16:09:57 | mordred | that means we don't do discovery on it | |
| 16:10:06 | mordred | since the user gave us the endpoint | |
| 16:10:11 | dtantsur | aha, and this is something that I think I changed in the API SIG patch ;) | |
| 16:10:18 | mordred | heh | |
| 16:10:25 | dtantsur | because that means we're still stuck with versioned endpoints everywhere | |
| 16:10:39 | dtantsur | aaaand microversion discovery also? | |
| 16:10:51 | mordred | yeah- we need to figure out when it is the correct thing to do to do the discovery logic even with an endpoint override | |
| 16:11:01 | dtantsur | man we need to dedicate a whole day in Berlin in November just to sit down and go through this mess | |
| 16:11:06 | mordred | for microversion discovery it will do the fetch on the endpoint override | |
| 16:11:12 | mordred | dtantsur: ++ | |
| 16:11:13 | mordred | seriouslyu | |
| 16:11:27 | mordred | because therea re like 12 competing use cases | |
| 16:11:32 | dtantsur | yep | |
| 16:12:22 | dtantsur | ideally, I'd prefer to endpoint-override to be unversioned (but support versioned ones too) | |
| 16:12:32 | dtantsur | my head hurts just from thinking about it.. | |
| 16:16:20 | mordred | dtantsur: yeah. such awesomeness | |
| 16:16:56 | dtantsur | the next two functions are also awesome: they handle the fact that some API use empty string instead of null :) | |
| 16:17:08 | dtantsur | which is not an issue for Python but a big issue for a statically typed language :D | |
| 16:32:18 | mordred | dtantsur|afk: ok. I think I have the versioned/unversioned thing handled | |
| 16:35:13 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 19:33:03 | openstackgerrit | Merged openstack/openstacksdk master: Explicitly set logging levels for external libs https://review.openstack.org/602085 | |
| 21:33:39 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Run all tasks through the threadpool https://review.openstack.org/603739 | |
| 23:47:10 | openstackgerrit | Merged openstack/openstacksdk master: Update baremetal objects with fields added up to Rocky https://review.openstack.org/599420 | |
| #openstack-sdks - 2018-09-20 | |||
| 06:34:48 | AJaeger | Shrews, mordred, can you approve https://review.openstack.org/#/c/594393/ , please? | |
| 06:35:27 | AJaeger | please also review https://review.openstack.org/#/c/603563/ - that finishes python3-first goal | |
| 12:45:23 | Shrews | AJaeger: mordred: why does that shade job need to be in stable/queens branch when the job itself requires shade master? | |
| 12:46:09 | AJaeger | Shrews: that job is *today* configured this way in project-config. If it's wrong, good that we figure that one finally out ;) | |
| 12:46:47 | Shrews | i don't see that job in project config, only a reference to it for ansible/ansible | |
| 12:47:13 | AJaeger | Shrews: let's double check - which job exactly do you mean? | |
| 12:47:22 | mordred | Shrews: oh, good point - I don't think it needs to be there | |
| 12:47:23 | Shrews | shade-ansible-stable-2.5-functional-devstack | |
| 12:47:53 | AJaeger | Shrews: ah, we can remove it as well completely. | |
| 12:47:58 | mordred | AJaeger, Shrews: lemme fix real quick | |
| 12:49:06 | AJaeger | mordred, Shrews - indeed, why was it added there? | |
| 12:50:19 | AJaeger | Shrews: ah see, it - mordred changed shade-ansible-functional-devstack which was in-repo... We could remove that one as well... | |
| 12:50:37 | mordred | AJaeger, Shrews: remote: https://review.openstack.org/594393 import zuul job settings from project-config | |
| 12:51:36 | AJaeger | LGTM, want to +2A directly? | |
| 12:53:11 | mordred | wfm - look good to you Shrews ? | |
| 12:53:24 | Shrews | looking | |
| 12:55:19 | AJaeger | mordred: want to +2A https://review.openstack.org/#/c/597579 as well? I expect dhellmann to remove his WIP from it once 594393 merged... | |
| 12:55:53 | Shrews | where is openstack-cover-jobs template? | |
| 12:56:45 | AJaeger | Shrews: in openstack-zuul-jobs - as announed in openstack-dev mailing list | |
| 12:56:53 | AJaeger | bbl | |
| 12:57:16 | Shrews | oh, my repo wasn't up-to-date | |
| 12:57:17 | Shrews | :) | |
| 12:57:34 | Shrews | +3 | |
| 13:30:48 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 13:55:28 | AJaeger | mordred: do you know why https://review.openstack.org/600941 fails? | |
| 13:56:25 | mordred | AJaeger: I'm going to blame elves | |
| 13:57:09 | mordred | AJaeger: lots of timeout exceptions - maybe just got a super slow node? | |
| 13:57:12 | AJaeger | so, recheck again? | |
| 13:57:29 | mordred | yeah. :( | |