| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-08-09 | |||
| 16:56:58 | elmiko | sorry gang, meeting is long | |
| 16:57:30 | cdent | elmiko: look what you made me do | |
| 16:58:01 | elmiko | i love that joke though | |
| 17:00:00 | edleafe | elmiko: you should read the minutes. We totally trashed you | |
| 17:03:28 | cdent | "love"? | |
| 17:10:56 | elmiko | haha | |
| 18:40:06 | openstackgerrit | Merged openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 18:56:25 | mordred | boom | |
| 18:57:04 | mordred | dtroyer: we're just about half done with the 2 items I wanted to get done before a 1.0 | |
| 18:58:07 | mordred | dtroyer: I'm gonna try to get the other bit written next week - but hopefully will be on target for an early-cycle 1.0 so that we can actually start work in earnest on using it | |
| 19:51:04 | dtroyer | mordred: I like these words that I read… | |
| 19:56:06 | mordred | dtroyer: \o/ | |
| 19:57:00 | mordred | dtroyer: I'm probably going to start with glance support in osc - since I've got to do some surgery on that for sdk anyway so it'll all be paged in | |
| 20:10:18 | samueldmq | heya, do https://storyboard.openstack.org/#!/story/2003401 and https://storyboard.openstack.org/#!/story/2003402 make sense at all to you? | |
| 22:46:30 | openstackgerrit | Merged openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | |
| #openstack-sdks - 2018-08-10 | |||
| 01:35:38 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 05:38:30 | openstackgerrit | Lajos Katona proposed openstack/python-openstackclient master: Detailed help message for QoS max-burst-kbps value https://review.openstack.org/588168 | |
| 05:44:45 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 06:36:21 | usr2033 | hi, i have a simple code like this. https://paste.ofcode.org/t6eXJ2gx9MA9QX7UAGQrTF i have a fundamental problem i guess. Openstack calls takes random time for return and i couldn't handle this. Execution of this code returns four different value for same input. What is the best practice for this problem? | |
| 06:38:08 | openstackgerrit | Chen proposed openstack/python-openstackclient master: Fix inconsistency (nit) https://review.openstack.org/572771 | |
| 06:44:23 | usr2033 | i couldn't different response even one line "os_connection.list_projects()" | |
| 07:59:55 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 09:27:04 | usr2033 | i think i found the problem. list_servers function can handle or work with undefined identity service version but list_projects function call does not. | |
| 12:06:08 | mordred | usr2033: ah- sorry about that - the very next thing on my todo list is to finish plumbing in version discovery so that _everything_ can work without a defined service version | |
| 12:59:45 | dtantsur | wait, does Image API really allow you to set random string attributes on an Image object? O___o | |
| 13:25:41 | mordred | dtantsur: yup | |
| 13:25:49 | mordred | dtantsur: that was one of the changes in image api v2 | |
| 13:25:58 | mordred | dtantsur: it got rid of the "properties" attribute | |
| 13:26:08 | dtantsur | wownotwow | |
| 13:26:16 | mordred | and instead put user-defined key/value metadata into the main image object itself | |
| 13:26:18 | mordred | right? | |
| 13:26:46 | mordred | in shade we chose to ignore that design choice and continue to present it as properties even if the service is running v2 | |
| 13:27:16 | mordred | which is what I expect to do to fix the brokenness around image in sdk currently | |
| 13:27:50 | mordred | dtantsur: what's even better is that operators can define top-level keys to be "reserved" in their config | |
| 13:28:23 | dtantsur | O.M.G. | |
| 13:28:34 | mordred | dtantsur: you can't un-know that | |
| 13:30:03 | dtantsur | unfortunately | |
| 13:30:12 | dtantsur | I'm looking into JSON patch support.. and it's a mess | |
| 13:31:07 | dtantsur | I'll throw a half-finished patch soon just to collect opinions | |
| 13:34:31 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Correct update operations for baremetal https://review.openstack.org/590770 | |
| 13:34:32 | dtantsur | mordred: wdyt about the overall approach ^^^ ? | |
| 13:40:55 | mordred | dtantsur: I suppose we can't just assume jsonpatch should be used if commit_message = 'PATCH' can we? | |
| 13:42:46 | usr2033 | mordred: thanks for response. i had a problem with get_project function. Normally get_project function in cloud/openstackcloud.py accept domain_id but in use like in get_compute_quota i can't pass domain_id to function. I had patched for that file for myself. I opened story in https://storyboard.openstack.org/#!/story/2003285 | |
| 13:43:58 | mordred | dtantsur: overall approach looks good | |
| 13:44:57 | dtantsur | mordred: I assumed HTTP PATCH can also be used with an incomplete resource representation | |
| 13:45:13 | dtantsur | though openstack services seem to use PUT for that | |
| 13:47:05 | mordred | yah - they do seem to - but I think you're right- better safe than sorry | |
| 13:49:38 | mordred | maybe we could default it to None, then have a little method like def _use_json_patch(self): if self.commit_method is None: return self.commit_method == 'PATCH' ; else return self.commit_method | |
| 13:49:52 | mordred | but maybe that'stoo much - dunno, just thinking out loud | |
| 14:30:08 | openstackgerrit | Alan Bishop proposed openstack/python-openstackclient master: Deprecate volume create --project and --user options https://review.openstack.org/575804 | |
| 14:53:38 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix the heat template resource more cleaner https://review.openstack.org/590786 | |
| 14:53:42 | mordred | Shrews: ^^ | |
| 15:21:01 | cdent | mordred: I wish to register my informal +1 on dtantsur as sdk core | |
| 15:32:25 | mordred | cdent: so noted | |
| 15:32:41 | cdent | he's OK | |
| 15:32:52 | cdent | someday might even get a huzzah | |
| 15:39:27 | mordred | cdent: wow. that's pretty strong | |
| 15:39:36 | cdent | ikr | |
| 15:41:51 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add simple create/show/delete functional tests for all baremetal resources https://review.openstack.org/590806 | |
| 15:42:00 | openstackgerrit | Tim Rozet proposed openstack/python-openstackclient master: Cinder: Add version checking https://review.openstack.org/590807 | |
| 15:43:17 | dtantsur | wow, I real huzzah! | |
| 15:43:27 | dtantsur | I must be really cool! | |
| 15:44:00 | dtantsur | * a real huzzah | |
| 15:54:45 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add simple create/show/delete functional tests for all baremetal resources https://review.openstack.org/590806 | |
| 16:10:48 | openstackgerrit | Merged openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | |
| 16:12:47 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Correct update operations for baremetal https://review.openstack.org/590770 | |
| 16:18:58 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Correct update operations for baremetal https://review.openstack.org/590770 | |
| 16:19:10 | dtantsur | mordred: I found an inconsistency while working on ^^^ | |
| 16:19:41 | dtantsur | when for a field the server name does not match our name (e.g. instance_uuid vs instance_id for nodes), we use the former when accessing it but the latter when updating | |
| 16:19:59 | dtantsur | e.g. node.instance_id but self.conn.node_update(node, instance_uuid='...') | |
| 16:25:42 | mordred | dtantsur: oh awesome | |
| 16:30:58 | openstackgerrit | Merged openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 16:34:43 | mordred | zomg | |
| 16:34:45 | mordred | that happened | |
| 16:34:50 | mordred | MIND BLOWN | |
| 16:36:49 | dtantsur | lol | |
| 16:39:17 | Shrews | mordred: my mind will be blown if nothing breaks because of it :) | |
| 16:40:21 | mordred | Shrews: that'll totally be true for at least some definition of "nothing" | |
| 16:40:48 | mordred | see - now I just have to finish wiring in the discovery code ... | |
| 16:41:50 | dtantsur | "just" | |
| 16:46:10 | mordred | dtantsur: it should be "easy" - I "just" need to make a new descriptor to handle attaching proxy objects to the connection that can handle instantiating and connecting the correct versioned proxy. and then I "just" need to write another one to stick onto the attached proxy that will add a proxy object for each version of the service found in the cloud | |
| 16:46:26 | mordred | piece of cake | |
| 16:47:57 | mordred | dtantsur: my thinking so far has been make conn.image be the version of the service that's found via discovery (taking config overrides in to account) - but also have conn.image.v1 and conn.image.v2 be explicit instance of openstack.image.v1._proxy.Proxy and openstack.image.v2._proxy.Proxy | |
| 16:48:11 | mordred | does that make sense and/or sound like a somewhat unterrible idea? | |
| 16:51:32 | dtantsur | mordred: are you going to provide a common subset of v1 and v2 via conn.image? | |
| 16:51:51 | dtantsur | and #2: are we going to do it even for services with only one major version? | |
| 16:52:19 | mordred | dtantsur: for #2 - I think so - although I doubt it'll ever get used | |
| 16:53:07 | dtantsur | yeah, so for e.g. baremetal, conn.baremetal and conn.v1.baremetal is the same. what about image? | |
| 16:53:19 | dtantsur | conn.image - is it latest or a common subset? | |
| 16:53:19 | mordred | dtantsur: for #1 - it's a really great question - I had been thinking of just making what shows up in conn.image be different based on whats found- which is what happens today if you just set the config variable differently | |
| 16:53:46 | dtantsur | this is probably the realistic option, even though it's not great from interoperability PoV | |
| 16:53:57 | mordred | BUT - the shade layer is designed as an abstraction layer - maybe it would be worth making an 'unversioned' proxy that is what gets attached in those cases | |
| 16:54:26 | mordred | and if you wanted a specific version's semantics you can always just do conn.image.v2.create_image | |
| 16:54:58 | dtantsur | okay, so conn.image.create_image can behave differently, but conn.image.v2.create_image is the same? | |
| 16:55:17 | mordred | yah. that would be the easier path | |
| 16:55:40 | dtantsur | the easiest, but also quite confusing for consumers.. | |
| 16:55:42 | mordred | and a user can always do conn.image.get_endpoint_info() to find out what version it is | |
| 16:55:44 | mordred | yah | |
| 16:55:52 | mordred | yah | |
| 16:56:08 | mordred | maybe I'll take a stab at it for image, since we already have all of the logic to handle it in the shade code | |