| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-08-06 | |||
| 16:43:31 | mordred | otoh - it makes debugging it easier - because I was going CRAZY trying to figure out how the patch was breaking it | |
| 16:43:48 | mordred | turns out - it wasn't :) | |
| 16:45:27 | dtantsur | this happens and usually is quite frustrating indeed :) | |
| 18:17:59 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | |
| 18:18:19 | mordred | dtantsur|afk: ^^ that's a test that shows the breakage | |
| 19:14:31 | Leo_m | hi, where in git can I see the methods of each service of the connection object, for ex. conn.identity.users() where conn is the openstack sdk connection object | |
| 19:15:57 | mordred | Leo_m: that one is either in http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/identity/v3/_proxy.py#n660 or http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/identity/v2/_proxy.py#n250 | |
| 19:21:57 | Leo_m | mordred: thx! do you know how to set a timeout on those type of calls in case the cloud is unavailable? | |
| 19:23:23 | Leo_m | maybe in the clouds.yaml config, or the connection object creation or a method service call? | |
| 19:25:29 | mordred | Leo_m: you can set "api_timeout" in clouds.yaml - or you should be able to pass api_timeout to the Connection constructor | |
| 19:44:10 | Leo_m | mordred: thanks! that did it. btw, couldn't find all the params the clouds.yaml file can have, just found a couple of examples. | |
| 20:00:50 | mordred | Leo_m: yeah - sorry about that - it's an unfortunately long-lived bug that the docs for clouds.yaml are incomplete | |
| 21:15:10 | Leo_m | mordred: no worries, thanks for the feedback! | |
| 23:58:44 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 23:58:44 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | |
| 23:58:45 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | |
| 23:58:45 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | |
| 23:58:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| #openstack-sdks - 2018-08-07 | |||
| 06:01:36 | openstackgerrit | wangqi proposed openstack/osc-lib master: Remove PyPI downloads https://review.openstack.org/589369 | |
| 09:33:16 | openstackgerrit | Jens Harbott (frickler) proposed openstack/python-openstackclient master: Fix broken gate jobs https://review.openstack.org/587005 | |
| 11:05:07 | frickler | dtroyer: ^^ func tests have passed for this one now, should be ready to unblock the gate once the final slow legacy job finishes | |
| 11:06:52 | openstackgerrit | Chen proposed openstack/python-openstackclient master: Refactor 'server migrate' https://review.openstack.org/589012 | |
| 12:20:15 | mordred | frickler: it's green! | |
| 12:29:20 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | |
| 12:29:21 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | |
| 12:29:21 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | |
| 12:29:21 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 12:29:22 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 12:34:15 | frickler | mordred: oh, you are OSC core now, congrats :) may I suggest that you single-approve that patch if noone else comes along today in order to unblock gate? | |
| 12:34:37 | dtroyer | frickler: +++ and thanks for pushing that along | |
| 12:36:50 | frickler | dtroyer: no problem, I was glad to see https://review.openstack.org/558824 approved when I returned from holiday and sad when I noticed that it is still stuck in gate. but I assume it will have to wait until after FF now anyway? | |
| 12:40:21 | dtroyer | frickler: apologies for fouling up the dependency there, it looked like 516701 was still unsettled when I went through the backlog, I see I mis-read it… | |
| 12:42:48 | mordred | frickler, dtroyer yay for that patch! | |
| 12:43:03 | mordred | rods: I believe I finally got https://review.openstack.org/530835 working! | |
| 12:43:57 | mordred | rods: (also, split it apart into multiple patches so it's easier to read) | |
| 12:52:50 | tosky | I noticed that openstackclient-check-plugins is failing on stable/queens and stable/pike; while it is non voting right now, I guess that idea is to stabilize it | |
| 12:53:31 | tosky | you probably know about the issue already, but it seems to be related to python-tripleoclient stable/{queens,pike} which installs tripleo-common from master | |
| 12:53:48 | tosky | and there is a conflicting requirements on the version of python-ironicclient | |
| 12:57:38 | openstackgerrit | Monty Taylor proposed openstack/os-service-types master: Add missing release notes https://review.openstack.org/589458 | |
| 13:00:11 | mordred | tosky: that would seem to me to be a bug in python-tripleoclient - does it not follow global-requirements and upper-constraints.txt ? | |
| 13:01:53 | tosky | mordred: it seems it does use them: http://git.openstack.org/cgit/openstack/python-tripleoclient/tree/tox.ini?h=stable/queens | |
| 13:02:21 | tosky | let me share the log from my saharaclient job | |
| 13:02:23 | tosky | http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/ | |
| 13:03:00 | tosky | python-tripleoclient seems to be correctly from stable/queens: http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/job-output.txt.gz#_2018-08-06_19_16_48_339526 | |
| 13:03:35 | tosky | but then tripleo-common is 9.2.0: http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/job-output.txt.gz#_2018-08-06_19_21_53_839209 | |
| 13:03:46 | tosky | while 8.6.x is the last version on stable/queens | |
| 13:07:05 | mordred | wow. that's just fantastic | |
| 13:08:09 | mordred | tosky: tripleo-common===8.6.3 is in the upper-constraints file for stable/queens | |
| 13:11:28 | mordred | tosky: ah- the check plugins job does not respect upper-constraints | |
| 13:13:10 | tosky | ah | |
| 13:13:29 | tosky | something had to be wrong | |
| 13:19:24 | Shrews | mordred: https://review.openstack.org/588656 must have been fun | |
| 13:19:43 | mordred | Shrews: so much fun | |
| 13:19:59 | mordred | Shrews: but if you think that one was fun, you should meet my friend https://review.openstack.org/589250 | |
| 13:20:58 | Shrews | mordred: u have weird friends | |
| 13:23:24 | openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | |
| 13:23:27 | mordred | tosky: ^^ | |
| 13:25:53 | tosky | I miss some of the logic of the joke, but that's fine :D | |
| 13:26:28 | tosky | oh, pbrx is a real thing | |
| 13:29:06 | tosky | what is the difference between pip freeze and pbr freeze? | |
| 13:33:35 | openstackgerrit | Merged openstack/os-service-types master: Add missing release notes https://review.openstack.org/589458 | |
| 13:38:50 | tosky | something did not work | |
| 13:53:45 | openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | |
| 13:56:34 | mordred | tosky: pbr freeze emits some extra info about git shas | |
| 13:57:11 | mordred | tosky: I figured in this case it might be a nice addition so we can check things | |
| 13:58:34 | tosky | ack | |
| 14:05:15 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 14:05:40 | mordred | Shrews: I *think* that ^^ is going to pass this time | |
| 14:05:59 | mordred | Shrews: I hope you'll enjoy the change in openstack/tests/functional/image/v2/test_image.py | |
| 14:06:26 | Shrews | mordred: i'm still digesting 589250 now that i have coffee | |
| 14:06:32 | Shrews | mordred: something doesn't seem right | |
| 14:07:06 | Shrews | mordred: you never set the alias_flag attr afaict | |
| 14:07:16 | mordred | yes - that's correct | |
| 14:07:38 | Shrews | mordred: and the set and immediately delete the seen_flag | |
| 14:07:39 | mordred | the alias_flag is the thing we need to check to see if it's already been set | |
| 14:07:53 | mordred | well, the getattr may not seem like a call into a recursion stack ... but it is | |
| 14:08:38 | mordred | so setting the flag before the getattr is a way for the check in the getattr call to know it shouldn't itself make a subsequent getattr call | |
| 14:09:29 | mordred | Shrews: http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/object_store/v1/container.py#n44 and http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/object_store/v1/container.py#n51 | |
| 14:09:40 | mordred | Shrews: are the example case that make this whole thing go batty | |
| 14:10:19 | mordred | count is aliased to object_count and object_count is aliased to count - if _neither_ are set, without some sort of something, the infinite recursion happens | |
| 14:10:51 | mordred | Shrews: (also, this took me literally the entire work day yesterday to wrap my head around, so if you're even partially following it on a first coffee, you're doing great) | |
| 14:12:34 | Shrews | mordred: ok, follow the alias thing now. but: setattr(instance, seen_flag, True); value = ; delattr(instance, seen_flag) | |
| 14:12:46 | Shrews | don't get the set-then-delete | |
| 14:13:42 | Shrews | oh! | |
| 14:13:47 | Shrews | ok, coffee just kicked in | |
| 14:13:52 | mordred | \o/ | |
| 14:13:53 | Shrews | mordred: duh | |
| 14:14:21 | mordred | Shrews: should we add a comment there to help future-us understand what the heck is going on? | |
| 14:14:51 | Shrews | meh, i've been away for a week so i'm just slow. up to you | |
| 14:15:15 | mordred | writing comments is hard | |
| 14:15:40 | Shrews | yah | |
| 14:16:14 | mordred | adriant: if you get a sec when your around, could you check out https://review.openstack.org/#/q/topic:resource-dict - and most importantly make sure it doesn't break you? | |
| 14:16:43 | mordred | it's one of the last 2 breaking API changes on the list before a 1.0 | |
| 14:17:52 | Shrews | mordred: it totally not apparent (until you pasted those container lines) how that test was testing recursion. maybe a comment in that test? | |
| 14:18:13 | mordred | Shrews: ++ | |
| 14:25:31 | mordred | Shrews: ok in that case, I'm adding a comment to the method too | |
| 14:25:55 | Shrews | k. sorry | |
| 14:27:04 | mordred | no - it's a good point - the chances we understand this in a months' time are pretty low | |
| 14:27:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 14:27:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | |