| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-07-23 | |||
| 14:09:02 | dtroyer | Luzi: we have had sporadic problems with volume tests over the years, this feels like a real bug somewhere. It is possible that cinderclient has a change in it that we need to account for, or isn't backward-compatible. I'll make some time to look at it after lunch… | |
| 14:09:15 | pasm | (hope this is the right place to ask) | |
| 14:09:33 | Luzi | dtroyer: thank you :) | |
| 14:09:36 | dtroyer | pasm: it is! | |
| 14:09:40 | pasm | :-) | |
| 14:09:47 | dtroyer | and that looks oddly familiar... | |
| 14:10:50 | dtroyer | pasm: I think it was laready fined here: https://review.openstack.org/#/c/581886/ | |
| 14:11:47 | pasm | dtroyer: it is incopmlete | |
| 14:11:52 | dtroyer | and that was released last week as 1.11.0 | |
| 14:11:55 | dtroyer | ah, ok | |
| 14:11:59 | dtroyer | grrr... | |
| 14:12:03 | pasm | dtroyer: there is another occurrence of issubclass() | |
| 14:12:23 | dtroyer | so are you set up to contribute to OpenStack via Gerrit (all the accounts, etc?) | |
| 14:12:50 | pasm | no, totally new | |
| 14:13:59 | pasm | can you link me a guide about your review workflow? | |
| 14:14:27 | dtroyer | https://docs.openstack.org/contributors/common/setup-gerrit.html is the specifics of Gerrit | |
| 14:14:41 | dtroyer | much of that doc should be useful | |
| 14:16:02 | dtroyer | pasm: if you''d like to create a bug you can do it in https://storyboard.openstack.org/#!/project/974 (it would be osc-lib's first in storyboard :) | |
| 14:18:10 | pasm | I'll try with Gerrit | |
| 14:19:27 | pasm | dtroyer: If I understood well, by setting up git-review I only have to push my change. Is it correct? | |
| 14:20:55 | dtroyer | pasm: the command would be 'git review' rather than push but that's basically what it does, plus some other Gerrit details | |
| 14:21:29 | dtroyer | the first time you run git review in a repo it sets itself up | |
| 14:21:38 | pasm | dtroyer: ok, I'll try... | |
| 14:32:00 | openstackgerrit | Ryan Brady proposed openstack-infra/shade master: Add support for static routes https://review.openstack.org/580661 | |
| 14:32:10 | pasm | dtroyer: I should be ready to run "git review", could you confirm me some steps? | |
| 14:32:21 | dtroyer | pasm: ok | |
| 14:32:56 | pasm | dtroyer: 1) clone from https://git.openstack.org/openstack/osc-lib | |
| 14:33:44 | pasm | dtroyer: 2) do changes (withot commit) | |
| 14:34:03 | pasm | dtroyer: 3) git review -s | |
| 14:34:12 | pasm | dtroyer: 4) git commit | |
| 14:34:20 | pasm | dtroyer: is it correct? | |
| 14:34:55 | dtroyer | I'd swap 2 and 3 to make sure you have everything happy before you have uncommitted changes lying about but it works either way | |
| 14:36:03 | dtroyer | and then git review to submit to gerrit | |
| 14:37:09 | pasm | dtroyer: after "git commit"? | |
| 14:37:11 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions https://review.openstack.org/584905 | |
| 14:37:20 | dtroyer | pasm: yes | |
| 14:37:21 | mordred | dtroyer: ^^ there's that command I was mentioning on friday | |
| 14:38:42 | dtroyer | mordred: nice! | |
| 14:42:38 | openstackgerrit | Paolo Smiraglia proposed openstack/osc-lib master: Change issubclass() to isinstance() https://review.openstack.org/584920 | |
| 14:45:16 | pasm | dtroyer: more easy than expected... thanks again! | |
| 14:45:35 | dtroyer | pasm: \o/ thank you! | |
| 14:46:35 | pasm | dtroyer: and now? someone will took in charge my review request? | |
| 14:47:57 | dtroyer | pasm: yes. we are in a freeze on osc-lib so it may be a bit before it merges, unless we decide that a py37 issue is critical :) | |
| 14:49:05 | pasm | dtroyer: ok, I asked just for personal knowledge | |
| 14:50:04 | mordred | lgtm | |
| 14:50:46 | pasm | dtroyer: back to work now... ciao! | |
| 15:15:57 | mordred | dtroyer: I'm looking at the volume snapshot ting ... | |
| 15:17:18 | mordred | ugh. it seems like size is a required value now, even though for "create volume from snapshot" the volume size will be the size of the snapshot | |
| 15:20:56 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create https://review.openstack.org/584932 | |
| 15:21:06 | mordred | dtroyer: I *think* that will take care of it | |
| 15:33:05 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create https://review.openstack.org/584932 | |
| 15:35:42 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create https://review.openstack.org/584932 | |
| 15:36:18 | mordred | dtroyer: also - spoke with smcginnis and jungleboyj in #openstack-cinder - it's a server-side bug they're going to fix | |
| 15:36:32 | mordred | dtroyer: but the osc patch should be harmless, so we might want to land it to unbreak the gate anway | |
| 15:40:13 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create https://review.openstack.org/584932 | |
| 15:42:50 | mordred | https://review.openstack.org/#/c/584944/ <-- cinder fix | |
| 15:44:01 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: DNM - Testing cinder fix https://review.openstack.org/584948 | |
| 15:49:41 | dtroyer | mordred: ++ on unbreaking. since it doesn't require another API call, its fine to leave in | |
| 15:55:09 | mordred | coolio | |
| 15:56:16 | mordred | dtroyer: for that versions command - I also think being able to see it by single service would be a useful filter - but I need to add a new call to keystoneauth for that (I completely didn't think about that case when adding the original call) - so maybe that'll be an improvement for stein | |
| 15:56:58 | mordred | (obviously someone can filter - but the ksa command sure will still run discovery on every endpoint) | |
| 15:57:37 | dtroyer | Adding a client-side filter would be fine until we get the query argument to the call | |
| 15:58:20 | dtroyer | until ksa is updated it'll take the same amount of time anyway | |
| 15:58:32 | mordred | dtroyer: nod. good call. so you thnk it should just be a filter to that same command? so "openstack versions list --service-type=compute" ? | |
| 15:58:50 | dtroyer | yeah | |
| 15:59:07 | mordred | woot. I'll get that updated during this next phone call while I'm ignoring people | |
| 15:59:21 | mordred | kk | |
| 16:01:23 | dtroyer | mordred: confirm —service, we use it elsewhere for that, —service-type is used in network for a neutron thing | |
| 16:27:15 | openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Add container-infra as an alias for magnum https://review.openstack.org/584963 | |
| 16:27:34 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions https://review.openstack.org/584905 | |
| 16:28:05 | mordred | dtroyer: okie. there's filter by service - as well as by status. it'll let you specify service by any known alias | |
| 16:33:12 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions https://review.openstack.org/584905 | |
| 17:06:34 | openstackgerrit | Toure Dunnon proposed openstack-infra/shade master: python-shade expose MTU setting. https://review.openstack.org/578861 | |
| 17:27:33 | lbragstad | curious if i can get some reviews on https://review.openstack.org/#/q/status:open+project:openstack/python-openstackclient+branch:master+topic:bp/unified-limits before client freeze on Thursday? | |
| 17:33:05 | dtroyer | lbragstad: yup, those are on my short list | |
| 17:35:07 | mordred | dtroyer, adriant, rods, slaweq, dtantsur|afk, Qiming: just as a heads-up - Shrews just restarted infra's nodepool ... so as of now nodepool is running on openstacksdk instead of shade in production | |
| 17:35:31 | dtroyer | no pressure there! :) | |
| 17:35:34 | mordred | it's _mostly_ identical code - so that's mostly a "it looks like we didn't break anything in the merge" | |
| 17:35:37 | mordred | dtroyer: :) | |
| 17:35:37 | Shrews | well, 1 node of nodepool | |
| 17:35:53 | mordred | Shrews: ssh. the other thing sounds more impressive ;) | |
| 17:37:35 | mordred | dtroyer: bwahahaha. my DNM patch to test the cinder fix didn't test anything at all because it didn't touch any code files :) | |
| 17:38:59 | dtroyer | lbragstad: did you see my comments on https://review.openstack.org/#/c/574475/ last week? | |
| 17:55:36 | openstackgerrit | Merged openstack/service-types-authority master: Add container-infra as an alias for magnum https://review.openstack.org/584963 | |
| 18:08:53 | PagliaccisCloud | would someone mind giving me a hand with this bugfix? zuul keeps failing at creating a volume snap but I didn't changed anything having to do with cinder :/ https://review.openstack.org/#/c/584484/ | |
| 18:14:43 | mordred | PagliaccisCloud: there is a recent cinder bug that is causing it. a patch is up to fix it | |
| 18:15:09 | PagliaccisCloud | ah ok, thanks mordred. i'll wait it out then. | |
| 18:15:12 | mordred | PagliaccisCloud: https://review.openstack.org/#/c/584944/ | |
| 18:15:17 | mordred | is the patch in question | |
| 18:32:55 | lbragstad | dtroyer: oh - i didn't (my dashboard query is sensitive to votes < 0) | |
| 18:33:10 | lbragstad | dtroyer: thanks for the feedback, i'll get those addressed or responded to today | |
| 18:34:34 | dtroyer | lbragstad:, thanks, IIRC the idea applies to both review | |
| 18:36:01 | slaweq | mordred: nice :) | |
| 18:39:09 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create https://review.openstack.org/584932 | |
| 18:41:15 | dtroyer | mordred: minor fix ^^^^ | |
| 18:43:21 | mordred | dtroyer: ++ thanks! | |
| 19:16:58 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix error with image show when image name is None https://review.openstack.org/529464 | |
| 19:17:59 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix error with image show when image name is None https://review.openstack.org/529464 | |
| 19:29:17 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions https://review.openstack.org/584905 | |
| 20:12:15 | lbragstad | dtroyer: i'm getting an odd error addressing one of your comments | |