| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-07-02 | |||
| 18:47:24 | tellesnobrega | we need for a sahara patch | |
| 18:47:24 | tellesnobrega | I have a patch for osc-lib that I would love to see in before the release | |
| 18:47:24 | tellesnobrega | dtroyer, awesome. Thanks | |
| 19:06:12 | dtroyer | ok, good to know. I'll be able to look at these later this afternoon | |
| 19:17:42 | wacuuu | hi, i tried to push my change to gerrit by git remote add gerrit https://git.openstack.org/openstack/openstacksdk && git review. it exited with 104. Have i done something wrong? Forgive me if i'm doing something wrong, but i did not find any clear instructions how to, so that is why i experimented a bit | |
| 19:19:10 | Shrews | wacuuu: hrm, i don't think it's necessary to manually add the remote anymore with recent git-review. A 'git review -s' would also do it | |
| 19:19:56 | Shrews | i think the automatic setting of it uses ssh (at least it does for me) | |
| 19:24:36 | mordred | wacuuu, Shrews: if git review finds a gerrit remote, it won't update anything... | |
| 19:24:54 | mordred | my gerrit remote uses ssh://mordred@review.openstack.org:29418/openstack/openstacksdk.git as the url | |
| 19:25:31 | mordred | BUT - you should be able to 'git remote remove gerrit && git review -s' in the openstacksdk repo and it should set it up properly for you | |
| 19:25:41 | mordred | have you added your ssh key to your account in gerrit? | |
| 19:26:10 | mordred | https://review.openstack.org/#/settings/ssh-keys | |
| 19:26:10 | wacuuu | yes i did | |
| 19:26:21 | mordred | cool | |
| 19:26:35 | Shrews | mordred: i do not understand your words. there must be a gerrit remote | |
| 19:26:47 | Shrews | you just pasted yours | |
| 19:27:02 | mordred | Shrews: yes - there must be- but if one has been added by hand first, git review will not modify it | |
| 19:27:08 | Shrews | oh | |
| 19:27:19 | mordred | Shrews: I frequently make bad words | |
| 19:28:36 | mordred | mmm. crunchy | |
| 19:29:43 | wacuuu | could you take a look http://paste.openstack.org/show/724795/ ? | |
| 19:31:20 | mordred | hrm. that's not fun | |
| 19:31:35 | mordred | wacuuu: does this command work for you? ssh -p 29418 review.openstack.org gerrit ls-projects | wc -l | |
| 19:31:51 | mordred | wacuuu: (make sure to do the wc -l - otherwise the command will print 1958 lines) | |
| 19:32:07 | wacuuu | nop. got hit by permision denied | |
| 19:32:08 | Shrews | that's head scratching for multiple raisins | |
| 19:32:43 | wacuuu | key is bad i assume | |
| 19:32:53 | mordred | kk. so that means either somehting doesn't like your ssh key, that somethign is blocking your access to 29418 or something is weird with username | |
| 19:33:35 | Shrews | fwiw, that seems like an older git-review | |
| 19:33:48 | mordred | you can doublecheck that gerrit agrees your username is wacuuu at https://review.openstack.org/#/settings/ | |
| 19:34:52 | mordred | yes - it does seem like an older git-review- although I would expect it to still work | |
| 19:36:24 | Shrews | me too, it just failed at failing properly in that paste | |
| 19:36:40 | mordred | ++ | |
| 19:36:49 | wacuuu | yyyy i think username is ok, i will try to regenerate pub from priavate | |
| 19:51:11 | wacuuu | i will try one more thing: push this from other machine. because i don't have to many ideas what could be wrong. btw: does username change happens immediatly or it needs time to propagate? | |
| 19:55:38 | mordred | it should happen immediately | |
| 20:00:48 | wacuuu | different server, permision denied :/ | |
| 20:13:06 | wacuuu | gerrit at it's full might. mordred, your test passed. review still doesn't work :) | |
| 20:20:10 | openstackgerrit | Jakub Walecki proposed openstack/openstacksdk master: Implementing solution for 2002563 issue from story board https://review.openstack.org/579679 | |
| 20:23:43 | wacuuu | oooo why do i have to always mess things up; i did not click out the agreement in settings. i found it because i tried git push <remote> HEAD:refs/for/master and then i got response that agreement is not done | |
| 20:24:03 | wacuuu | thanks a lot for help though | |
| #openstack-sdks - 2018-07-03 | |||
| 00:03:48 | openstackgerrit | Merged openstack/osc-lib master: Delete the output in "find_bulk" api https://review.openstack.org/575372 | |
| 00:50:00 | openstackgerrit | Merged openstack/osc-lib master: Add OpenTracing based driver id https://review.openstack.org/566493 | |
| 04:11:40 | openstackgerrit | Merged openstack/osc-lib master: fix tox python3 overrides https://review.openstack.org/572915 | |
| 06:15:13 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768 | |
| 06:18:10 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768 | |
| 06:26:29 | Luzi | mordred: I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class? | |
| 07:32:36 | openstackgerrit | huangshan proposed openstack/openstacksdk master: Add vip_qos_policy_id options for loadbalancer https://review.openstack.org/579794 | |
| 09:38:40 | openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Add error message when using "set" command without all optional arguments https://review.openstack.org/579515 | |
| 12:15:47 | dtantsur | mordred: morning! any comments/suggestions on https://etherpad.openstack.org/p/microversions-better-than-beer ? particularly, a catchy title? | |
| 12:16:03 | dtantsur | also do you really want to participate or am I being too pushy to force it on you? :) | |
| 12:38:12 | frickler | dtantsur: mordred mentioned earlier in infra that he needs to do some bookkeeping before anything else, not sure whether that will apply here, too | |
| 12:39:04 | dtantsur | frickler: oh, I see, thanks! | |
| 13:24:21 | mordred | dtantsur: morning! | |
| 13:25:11 | mordred | dtantsur: definitely want to participate ... | |
| 13:26:54 | frickler | dtroyer: could you add https://review.openstack.org/516701 and https://review.openstack.org/558824 to your review list, please? would be great to get these in for this cycle and also still have time to amend the Neutron docs accordingly | |
| 13:27:58 | dtantsur | mordred: cool! no big pressure, but let's try to propose it by EOW since I'm out next week | |
| 13:29:00 | mordred | ++ | |
| 13:29:06 | mordred | dtantsur: I'm adding terrible titles | |
| 13:29:55 | dtantsur | "Dmitry used Microversions and you won't believe what happened next..." AAAaaaaAAAAaaa :D | |
| 13:30:45 | mordred | :) | |
| 13:31:25 | mordred | that one is growing on me | |
| 13:31:43 | dtantsur | mordred: I think #3 (unbearable lightness) is at the right crossing of being fun and acceptable for the audience :) | |
| 13:31:55 | dtantsur | but yes, #2 is so great | |
| 13:32:13 | mordred | \o/ | |
| 13:32:30 | mordred | also - white trash fast food is currently closed, so it's maybe not a great metaphor | |
| 13:33:22 | dtantsur | mordred: is it some known thing? | |
| 13:34:26 | dtantsur | I mean, this fast food thing | |
| 13:34:49 | mordred | dtantsur: http://www.whitetrashfastfood.com/ - it's my favorite berlin restaurant (or, it was) | |
| 13:35:06 | dtroyer | frickler: will do… I'm wrapping up osc-lib first then back to osc itself | |
| 13:35:38 | dtantsur | mordred: oh that's pity | |
| 13:36:10 | mordred | yah. I'm hoping it comes back | |
| 13:37:00 | dtantsur | yep. it's not even too far from my place (but in a, well, "funny" neighborhood) | |
| 13:37:14 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | |
| 13:39:20 | frickler | dtroyer: cool, thx. I also asked a question about handling microversions, not sure whether this has been discussed globally already. mordred and dtantsur might also be interested. https://review.openstack.org/#/c/577768/4/openstackclient/compute/v2/keypair.py@84 | |
| 13:39:53 | dtantsur | s/this/his/ | |
| 13:40:09 | Luzi | mordred, I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class? | |
| 13:40:32 | dtantsur | frickler: well, I left the same comment on an earlier revision | |
| 13:41:58 | mordred | I think that's about as good as one can do before we plumb all the discovery stuff through - since the model there is assuming a configured api version | |
| 13:42:22 | frickler | dtantsur: oh, that was on the other review. but good to see we seem to agree | |
| 13:42:29 | dtantsur | oh, right, another one | |
| 13:42:44 | dtantsur | mordred: cannot we do version = max('2.2', os_compute_api_version) here? | |
| 13:43:02 | mordred | not without checking to see what api versions the remote side supports | |
| 13:43:05 | dtantsur | another thing to consider: we ended up with defaulting --os-baremetal-api-version to the known latest in ironicclient | |
| 13:43:30 | dtantsur | mordred: why not? the requested will fail reasonably if the remote side only supports 2.1, no? | |
| 13:44:28 | mordred | ah - hrm. yeah - I suppose so in this case | |
| 13:45:01 | dtantsur | assuming we can provide a microversion per request in OSC | |
| 13:45:20 | mordred | we can using sdk - not so much with novaclient | |
| 13:45:44 | dtantsur | which one is used by OSC? | |
| 13:45:47 | mordred | *except* - at least in my world, if a user has explicity set a config value for a specific microversion in compute_api_version - I would argue that we should not override that setting | |
| 13:46:23 | mordred | dtantsur: novaclient for now - although at some point we're hoping to get things shifted over to sdk - dean is waiting on a 1.0 from sdk before starting in on that | |
| 13:46:28 | dtantsur | yep, so maybe if os_compute_api_version is None: os_compute_api_version = '2.2' elif os_compute_api_version < '2.2': boom | |
| 13:46:51 | mordred | dtantsur: yah- I think that would be good and upwards compatible with a future where compute_api_version might not be set | |
| 13:47:17 | mordred | (today it'll always be set because of defaults - but once we've got the discovery stuff finished plumbed through, it can start being None and things working) | |
| 13:47:45 | dtantsur | ah, random defaults, similar to 1.6 in ironic? :) | |
| 13:47:48 | mordred | yup | |
| 13:48:01 | dtantsur | * 1.9 in ironicclient and 1.6 in openstacksdk because we LOVE consistency | |
| 13:48:08 | mordred | \o/ | |
| 13:48:37 | mordred | well - I've almost got the last discovery patch for sdk written in my head - so hopefully we're almost there | |
| 13:48:57 | mordred | Luzi: hello! yes - I agree, putting it in OpenStackCloud is not the right place ... | |