| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-06-29 | |||
| 14:58:29 | dtantsur | mordred: any suggestions on a title for https://etherpad.openstack.org/p/microversions-better-than-beer ? or any other comments? | |
| 15:03:27 | dhellmann | dtroyer , mordred : putting the image signing stuff into the sdk layer seems reasonable to me | |
| 15:08:04 | mordred | 745787 | |
| 15:08:08 | mordred | gah | |
| 16:21:05 | ssbarnea | anyone here that can help reviewing/merging stuff into cliff? | |
| 16:26:31 | ssbarnea | https://review.openstack.org/#/c/579025/ | |
| 16:26:43 | ssbarnea | https://review.openstack.org/#/c/574846/ | |
| 16:32:23 | dtroyer | ssbarnea: looking… | |
| 16:32:53 | ssbarnea | thanks! | |
| 16:33:29 | dtroyer | +2 on the first, I already did the second one… | |
| 17:59:39 | ssbarnea | dtroyer: now the question it would be how long it will take to get the +Workflow on these. | |
| 18:00:27 | dtroyer | dhellmann: got a sec for some cliff? https://review.openstack.org/#/c/574846/ https://review.openstack.org/#/c/579025/ | |
| 18:00:53 | dtroyer | ssbarnea: we're getting close to freeze in a few weeks, best get some time on it all | |
| 18:01:47 | dhellmann | dtroyer : looking | |
| 18:02:51 | dhellmann | dtroyer : LGTM, +2a for both | |
| 18:03:00 | dtroyer | thanks! | |
| 18:03:02 | dhellmann | dtroyer : how do you feel about turning of the pypy jobs? those are non-voting anyway | |
| 18:03:05 | dhellmann | I can do it if you agree | |
| 18:03:12 | dhellmann | I think infra will want your +1 | |
| 18:03:29 | dtroyer | sounds good | |
| 18:03:35 | dhellmann | ok, I'll add you to the review | |
| 18:03:54 | dtroyer | there are two backports in the queue also for cmd2 | |
| 18:08:29 | dhellmann | ok, I starred those so I will see the email when zuul finishes the tests | |
| 18:09:35 | dtroyer | I'm not aware of anything else coming up, I can prepare releases for Monday | |
| 18:09:42 | dhellmann | sounds good | |
| 18:17:49 | openstackgerrit | Merged openstack/python-openstackclient master: Adding api_version to FakeApp https://review.openstack.org/576833 | |
| 19:34:12 | openstackgerrit | Merged openstack/cliff master: Build universal wheels https://review.openstack.org/574846 | |
| 19:40:28 | openstackgerrit | Merged openstack/cliff master: Assure executable name is kept when app is called as module https://review.openstack.org/579025 | |
| 20:15:28 | openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Support filtering port with IP address substring https://review.openstack.org/532324 | |
| #openstack-sdks - 2018-06-30 | |||
| 13:26:17 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 13:30:18 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 15:54:22 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 16:02:51 | wacuuu | hi. I've got a problem with testing. I changed one thing in code, it resulted in change in uri. Now request contains some extra fields. I'm trying to make proper tests for last few days and i have no idea where to look in code. It would be a simple change to let know tox that request contains extra field. Where to start? | |
| 16:05:05 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 16:13:59 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 19:05:45 | frickler | wacuuu: usually the structure of the tests follows the structure of the code. for further clues, maybe you can show us your change? | |
| 19:24:12 | wacuuu | https://storyboard.openstack.org/#!/story/2002563 | |
| 19:24:56 | wacuuu | frickler:the efect it gives is that it expands uri for additional filter with domain_id | |
| #openstack-sdks - 2018-07-01 | |||
| 00:55:57 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422 | |
| 07:01:25 | frickler | wacuuu: so IIUC the solution would be to amend all the affected URI mocks with the new parameter, like this http://paste.openstack.org/show/724684/ (modulo pep8) | |
| 07:02:43 | frickler | wacuuu: of course this will need expanding for all the other tests, but it does get one test to pass for me again | |
| 07:04:14 | frickler | wacuuu: looking at these tests, it may also be useful to untangle the mess of repetitions a bit, but that would be a different issue I think. also not sure what mordred and others would think of that | |
| 07:04:29 | wacuuu | frickler: Thanks a lot! I will do this as soon as possible. | |
| 07:05:13 | wacuuu | about the second i will try to ask them when i understand the issue and become more fluent in this code | |
| 07:06:16 | frickler | wacuuu: also, in regard to your earlier question, don't be afraid to submit patches with failing tests, we can then help to iterate on them and get things fixed | |
| 07:06:58 | wacuuu | ok, will do in future | |
| 17:29:00 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Expand error code document to expect clarity https://review.openstack.org/577118 | |
| 17:37:01 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Add links to errors-example.json https://review.openstack.org/578369 | |
| #openstack-sdks - 2018-07-02 | |||
| 01:38:57 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386 | |
| 09:35:27 | nobuto | Hello, regarding https://review.openstack.org/#/c/565152/ I submitted it a while ago, but don't know how to get a review from core reviewers for +2. Can somebody review it? | |
| 11:04:38 | openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: [WIP]Add error message when using "set" command without all optional arguments https://review.openstack.org/579515 | |
| 11:30:05 | openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/osc-lib master: Adding api_version to FakeAPP https://review.openstack.org/579523 | |
| 12:24:04 | tellesnobrega | hi folks, I sent out a patch that we need on saharaclient to implement a new feature. The patch is https://review.openstack.org/#/c/579523 | |
| 12:24:20 | tellesnobrega | my question is, when is the next released planned? | |
| 12:56:46 | Luzi | mordred: I have been looking through openstacksdk, but i don't think the openstackcloud class is a suitable place for the signature generator. Where do you think we can add the signature generator class? | |
| 13:45:05 | openstackgerrit | Nobuto Murata proposed openstack/python-openstackclient master: Support --community in openstack image list https://review.openstack.org/565152 | |
| 13:48:06 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | |
| 14:27:03 | openstackgerrit | Merged openstack/openstacksdk master: Add release note link in README https://review.openstack.org/578672 | |
| 14:27:03 | openstackgerrit | Merged openstack/openstacksdk master: Add Magnum cluster support https://review.openstack.org/578097 | |
| 16:40:01 | mriedem | mordred: one question inline https://review.openstack.org/#/c/578960/ | |
| 17:55:28 | tellesnobrega | dhellmann, do you know when the next release of osc-lib will be? | |
| 18:36:03 | dtroyer | tellesnobrega: soon? I want to get that and cliff out this week yet in advance of the upcoming freeze by at least a week. OSC will follow with at least one more release | |
| 18:47:24 | tellesnobrega | we need for a sahara patch | |
| 18:47:24 | tellesnobrega | I have a patch for osc-lib that I would love to see in before the release | |
| 18:47:24 | tellesnobrega | dtroyer, awesome. Thanks | |
| 19:06:12 | dtroyer | ok, good to know. I'll be able to look at these later this afternoon | |
| 19:17:42 | wacuuu | hi, i tried to push my change to gerrit by git remote add gerrit https://git.openstack.org/openstack/openstacksdk && git review. it exited with 104. Have i done something wrong? Forgive me if i'm doing something wrong, but i did not find any clear instructions how to, so that is why i experimented a bit | |
| 19:19:10 | Shrews | wacuuu: hrm, i don't think it's necessary to manually add the remote anymore with recent git-review. A 'git review -s' would also do it | |
| 19:19:56 | Shrews | i think the automatic setting of it uses ssh (at least it does for me) | |
| 19:24:36 | mordred | wacuuu, Shrews: if git review finds a gerrit remote, it won't update anything... | |
| 19:24:54 | mordred | my gerrit remote uses ssh://mordred@review.openstack.org:29418/openstack/openstacksdk.git as the url | |
| 19:25:31 | mordred | BUT - you should be able to 'git remote remove gerrit && git review -s' in the openstacksdk repo and it should set it up properly for you | |
| 19:25:41 | mordred | have you added your ssh key to your account in gerrit? | |
| 19:26:10 | mordred | https://review.openstack.org/#/settings/ssh-keys | |
| 19:26:10 | wacuuu | yes i did | |
| 19:26:21 | mordred | cool | |
| 19:26:35 | Shrews | mordred: i do not understand your words. there must be a gerrit remote | |
| 19:26:47 | Shrews | you just pasted yours | |
| 19:27:02 | mordred | Shrews: yes - there must be- but if one has been added by hand first, git review will not modify it | |
| 19:27:08 | Shrews | oh | |
| 19:27:19 | mordred | Shrews: I frequently make bad words | |
| 19:28:36 | mordred | mmm. crunchy | |
| 19:29:43 | wacuuu | could you take a look http://paste.openstack.org/show/724795/ ? | |
| 19:31:20 | mordred | hrm. that's not fun | |
| 19:31:35 | mordred | wacuuu: does this command work for you? ssh -p 29418 review.openstack.org gerrit ls-projects | wc -l | |
| 19:31:51 | mordred | wacuuu: (make sure to do the wc -l - otherwise the command will print 1958 lines) | |
| 19:32:07 | wacuuu | nop. got hit by permision denied | |
| 19:32:08 | Shrews | that's head scratching for multiple raisins | |
| 19:32:43 | wacuuu | key is bad i assume | |
| 19:32:53 | mordred | kk. so that means either somehting doesn't like your ssh key, that somethign is blocking your access to 29418 or something is weird with username | |
| 19:33:35 | Shrews | fwiw, that seems like an older git-review | |
| 19:33:48 | mordred | you can doublecheck that gerrit agrees your username is wacuuu at https://review.openstack.org/#/settings/ | |
| 19:34:52 | mordred | yes - it does seem like an older git-review- although I would expect it to still work | |
| 19:36:24 | Shrews | me too, it just failed at failing properly in that paste | |
| 19:36:40 | mordred | ++ | |
| 19:36:49 | wacuuu | yyyy i think username is ok, i will try to regenerate pub from priavate | |
| 19:51:11 | wacuuu | i will try one more thing: push this from other machine. because i don't have to many ideas what could be wrong. btw: does username change happens immediatly or it needs time to propagate? | |
| 19:55:38 | mordred | it should happen immediately | |
| 20:00:48 | wacuuu | different server, permision denied :/ | |
| 20:13:06 | wacuuu | gerrit at it's full might. mordred, your test passed. review still doesn't work :) | |