Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-06-29
01:48:13 openstackgerrit Chen proposed openstack/python-openstackclient master: Fix a typo https://review.openstack.org/572771
02:47:42 openstackgerrit Merged openstack/python-openstackclient master: Add ability to filter image list by tag https://review.openstack.org/575256
03:25:26 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
06:22:47 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add DNS support to floating IP commands https://review.openstack.org/558824
08:52:27 openstackgerrit wu.chunyang proposed openstack/openstacksdk master: Add release note link in README https://review.openstack.org/578672
08:59:08 openstackgerrit wu.chunyang proposed openstack/openstacksdk master: Add release note link in README https://review.openstack.org/578672
09:49:14 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
11:43:07 dtantsur mordred: morning! dumped more thoughts in https://etherpad.openstack.org/p/microversions-better-than-beer
11:59:47 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
12:01:22 mordred dtantsur: morning! awesome
12:09:57 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
12:10:36 openstackgerrit Chen proposed openstack/python-openstackclient master: Compute: Add description support for server https://review.openstack.org/568549
12:31:12 dtroyer dhellmann: if you have a minute and need a break today to think about something a bit different than py3 and TC-stuff, I'd love to hear your thoughts on https://etherpad.openstack.org/p/osc-included_image_signing. tl;dr: signing code that wants to be used in both OSC and server-side (nova so far), and an appropriate place for it to live.
12:35:11 mordred dtroyer: seems like functionality we'd want in sdk too
12:36:05 dtroyer mordred: I didn't think about that long, I suppose I had oslo on my brain a bit much
12:36:29 dtroyer is nova ready to use sdk? have they already added it as a dep?
12:36:51 mordred they haven't - I wasn't going to push on it until we cut the 1.0
12:37:27 dtroyer agreed there, I wonder if this is enough of a reason to start
12:37:27 mordred but it shouldn't be an issue for it to. that said - looking at cursive real quick, I don't think sdk would want to pick it up as a depend
12:37:45 mordred dtroyer: I can make some initial patches to check it out
12:37:56 dtroyer I don't think you need to, the signing bits don't use the rest of cursive as far as I saw last night
12:38:04 mordred cool
12:38:05 dtroyer it was just a home
12:38:30 dtroyer pile on to that ML thread and see what Josephine thinks
12:38:34 mordred well - image signing code _definitely_ would be welcome in sdk
12:38:36 mordred will do
12:43:35 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960
12:43:51 mordred dtantsur: speaking of microversions ^^
12:47:58 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139
12:48:13 mordred dtroyer: also - ^^ that's still WIP - but I figured I should maybe not just keep it on my laptop
12:59:58 mordred Shrews: if you get a moment this morning, would you take a peek at https://review.openstack.org/#/c/579015/ and https://review.openstack.org/#/c/578960/
13:19:33 Luzi dtroyer, mordred: I think using openstacksdk is a good idea, i already wrote an email. Thank you both :)
13:20:36 dtroyer Luzi: good to hear… and glad you found us here :)
13:26:19 mordred Luzi: \o/ yay
13:30:52 mordred Luzi: I'll try to write down some more notes - but fwiw in the image upload code in the shade portion of sdk (in openstack/cloud/openstackcloud.py) we currently have code that calculates md5 and sha256 hashes for images before uploading them - and it does a similar thing to the main loop in your cursive patch (iterate over file, call hasher.update(chunk))
13:31:02 mordred so I think there is a really great place to hook the code in
13:31:19 mordred in terms of using it in the image upload code there
13:32:46 mordred Shrews: thanks!
13:34:35 Luzi mordred: thanks, I will have a look at this
13:50:26 Shrews mordred: np
13:57:46 openstackgerrit Merged openstack/python-openstackclient master: Display private flavors in server list https://review.openstack.org/540633
14:08:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Use shade create_image method in upload_image https://review.openstack.org/579168
14:08:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add connection backreference to proxy instances https://review.openstack.org/579167
14:09:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960
14:24:26 frickler Luzi: when you talk about nova support, is this just the "openstack server image create" command or something inside nova services? the former would only seem to affect OSC and not nova as a project, I guess
14:27:06 Luzi frickler: it should be just that command, but the compute host has to do the signing
14:27:51 frickler Luzi: ah, yeah, after thinking about it a bit more that seems reasonable
14:31:03 openstackgerrit Merged openstack/openstacksdk master: Hardcode v2.0 onto end of neutron endpoints https://review.openstack.org/579015
14:58:29 dtantsur mordred: any suggestions on a title for https://etherpad.openstack.org/p/microversions-better-than-beer ? or any other comments?
15:03:27 dhellmann dtroyer , mordred : putting the image signing stuff into the sdk layer seems reasonable to me
15:08:04 mordred 745787
15:08:08 mordred gah
16:21:05 ssbarnea anyone here that can help reviewing/merging stuff into cliff?
16:26:31 ssbarnea https://review.openstack.org/#/c/579025/
16:26:43 ssbarnea https://review.openstack.org/#/c/574846/
16:32:23 dtroyer ssbarnea: looking…
16:32:53 ssbarnea thanks!
16:33:29 dtroyer +2 on the first, I already did the second one…
17:59:39 ssbarnea dtroyer: now the question it would be how long it will take to get the +Workflow on these.
18:00:27 dtroyer dhellmann: got a sec for some cliff? https://review.openstack.org/#/c/574846/ https://review.openstack.org/#/c/579025/
18:00:53 dtroyer ssbarnea: we're getting close to freeze in a few weeks, best get some time on it all
18:01:47 dhellmann dtroyer : looking
18:02:51 dhellmann dtroyer : LGTM, +2a for both
18:03:00 dtroyer thanks!
18:03:02 dhellmann dtroyer : how do you feel about turning of the pypy jobs? those are non-voting anyway
18:03:05 dhellmann I can do it if you agree
18:03:12 dhellmann I think infra will want your +1
18:03:29 dtroyer sounds good
18:03:35 dhellmann ok, I'll add you to the review
18:03:54 dtroyer there are two backports in the queue also for cmd2
18:08:29 dhellmann ok, I starred those so I will see the email when zuul finishes the tests
18:09:35 dtroyer I'm not aware of anything else coming up, I can prepare releases for Monday
18:09:42 dhellmann sounds good
18:17:49 openstackgerrit Merged openstack/python-openstackclient master: Adding api_version to FakeApp https://review.openstack.org/576833
19:34:12 openstackgerrit Merged openstack/cliff master: Build universal wheels https://review.openstack.org/574846
19:40:28 openstackgerrit Merged openstack/cliff master: Assure executable name is kept when app is called as module https://review.openstack.org/579025
20:15:28 openstackgerrit Hongbin Lu proposed openstack/python-openstackclient master: Support filtering port with IP address substring https://review.openstack.org/532324
#openstack-sdks - 2018-06-30
13:26:17 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
13:30:18 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
15:54:22 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
16:02:51 wacuuu hi. I've got a problem with testing. I changed one thing in code, it resulted in change in uri. Now request contains some extra fields. I'm trying to make proper tests for last few days and i have no idea where to look in code. It would be a simple change to let know tox that request contains extra field. Where to start?
16:05:05 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
16:13:59 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
19:05:45 frickler wacuuu: usually the structure of the tests follows the structure of the code. for further clues, maybe you can show us your change?
19:24:12 wacuuu https://storyboard.openstack.org/#!/story/2002563
19:24:56 wacuuu frickler:the efect it gives is that it expands uri for additional filter with domain_id
#openstack-sdks - 2018-07-01
00:55:57 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
07:01:25 frickler wacuuu: so IIUC the solution would be to amend all the affected URI mocks with the new parameter, like this http://paste.openstack.org/show/724684/ (modulo pep8)
07:02:43 frickler wacuuu: of course this will need expanding for all the other tests, but it does get one test to pass for me again
07:04:14 frickler wacuuu: looking at these tests, it may also be useful to untangle the mess of repetitions a bit, but that would be a different issue I think. also not sure what mordred and others would think of that
07:04:29 wacuuu frickler: Thanks a lot! I will do this as soon as possible.
07:05:13 wacuuu about the second i will try to ask them when i understand the issue and become more fluent in this code
07:06:16 frickler wacuuu: also, in regard to your earlier question, don't be afraid to submit patches with failing tests, we can then help to iterate on them and get things fixed
07:06:58 wacuuu ok, will do in future
17:29:00 openstackgerrit Chris Dent proposed openstack/api-wg master: Expand error code document to expect clarity https://review.openstack.org/577118
17:37:01 openstackgerrit Chris Dent proposed openstack/api-wg master: Add links to errors-example.json https://review.openstack.org/578369
#openstack-sdks - 2018-07-02
01:38:57 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
09:35:27 nobuto Hello, regarding https://review.openstack.org/#/c/565152/ I submitted it a while ago, but don't know how to get a review from core reviewers for +2. Can somebody review it?
11:04:38 openstackgerrit yanpuqing proposed openstack/python-openstackclient master: [WIP]Add error message when using "set" command without all optional arguments https://review.openstack.org/579515
11:30:05 openstackgerrit Telles Mota Vidal Nóbrega proposed openstack/osc-lib master: Adding api_version to FakeAPP https://review.openstack.org/579523

Earlier   Later