| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-06-28 | |||
| 18:58:18 | nicolas_o | mriedem: mordred: I am afraid it's still broken with the patch. The API is not happy unless I pass block_migration: False, disk_over_commit: False. | |
| 18:58:51 | nicolas_o | This is how I got it to work with 2.1 api: https://github.com/nicolasochem/openstacksdk/commit/4a912a026a218e3b146fe1408c460608873ecfd4 | |
| 18:59:49 | mriedem | nicolas_o: that's for different reasons https://developer.openstack.org/api-ref/compute/#live-migrate-server-os-migratelive-action | |
| 19:00:10 | mriedem | the block_migration parameter was removed from the api in 2.24 | |
| 19:00:22 | mriedem | oh sorry, it was re-typed | |
| 19:00:30 | mordred | wow. this is fun | |
| 19:00:46 | mriedem | 2.25 allows you to send block_migration=auto | |
| 19:00:52 | mriedem | meaning, "you figure out if i'm using shared disk or not" | |
| 19:01:18 | mriedem | disk_over_commit was removed in 2.25 | |
| 19:01:32 | mriedem | https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-mitaka | |
| 19:01:54 | mriedem | i'm kind of worried that no one is reading our microversion history or api reference docs... | |
| 19:02:18 | mordred | mriedem: there's a lot of it - and I'm literally just now adding the very first use of a microversion :) | |
| 19:02:26 | mriedem | heh yeah i know | |
| 19:02:31 | mordred | so - I promise I'll read it more | |
| 19:02:33 | mriedem | i started https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc | |
| 19:03:17 | nicolas_o | Thanks for that. I just want to use the sdk to do something like: self.cloud.compute.live_migrate_server(id, host=host_id) | |
| 19:03:43 | mordred | yup. hopefully we'll get you there :) | |
| 19:03:58 | openstackgerrit | Alessandro Nesta proposed openstack/osc-lib master: Add release note link in README https://review.openstack.org/578459 | |
| 19:04:10 | mriedem | i'm not sure what the best default logic there is then, i'd say if you're specifying >= 2.25 and block_migration isn't specified, use 'auto'; | |
| 19:04:20 | mriedem | if < 2.25 and host isn't specified, default to True? | |
| 19:04:42 | mriedem | if you're specifying a host, then we might want to require block_migration since you should know if that host is on shared storage and < 2.25 | |
| 19:04:50 | mriedem | it's a complicated matrix | |
| 19:05:01 | openstackgerrit | Alessandro Nesta proposed openstack/osc-lib master: Add release note link in README https://review.openstack.org/578459 | |
| 19:23:16 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | |
| 19:23:40 | mordred | mriedem: how does that look logically ... (ignore the fact that the code is overly repetitive - we can write cleverer code later) | |
| 19:26:14 | mriedem | oh wait we passed a law on nit picking didn't we? | |
| 19:38:29 | mriedem | mordred: supports_microversion is <= right? | |
| 19:44:35 | mriedem | mordred: comments inline | |
| 19:45:30 | mordred | mriedem: yes - <= ... and thanks! | |
| 19:48:48 | mriedem | and a late comment | |
| 19:48:55 | mriedem | 'host' is required in the body always, even if host=None | |
| 19:48:56 | mriedem | it's dumb | |
| 19:49:06 | mriedem | "The host to which to migrate the server. If this parameter is None, the scheduler chooses a host." | |
| 19:56:16 | rm_work | dtroyer: thanks for pushing that tag change through :) | |
| 19:59:21 | rm_work | mordred: was it you i was talking to about fixing some of the neutron version discovery issues that were introduced in 0.10? | |
| 19:59:36 | rm_work | I don't remember where we left that | |
| 20:01:16 | rm_work | looks like it's still not working in 0.14.x for me, though the message is a bit clearer :P | |
| 20:23:15 | rm_work | Failed to contact the endpoint at https://openstack:9696 for discovery. Fallback to using that endpoint as the base url. | |
| 20:23:21 | rm_work | NotFoundException: 404: Client Error for url: https://openstack:9696/networks, Not Found | |
| 20:23:29 | rm_work | ^^ on Liberty | |
| 20:56:01 | mordred | rm_work: I *think* we have a fix for that in master and I'm a bad person who has not cut a release for you yet | |
| 20:56:12 | rm_work | lol np, i can test it | |
| 20:56:22 | rm_work | you have a CR? | |
| 20:56:24 | rm_work | or, SHA | |
| 20:56:29 | rm_work | i can apply | |
| 20:56:36 | rm_work | or i guess i could just checkout master | |
| 20:56:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | |
| 20:56:57 | mordred | mriedem: ^^ updates. thanks for the feedback btw - super helpful! | |
| 20:56:59 | mordred | rm_work: looking | |
| 20:57:00 | rm_work | yeah sec i'll just switch to master | |
| 20:57:03 | rm_work | don't worry about it | |
| 20:57:04 | mordred | ok. cool | |
| 20:57:31 | rm_work | hmmmmmmm | |
| 20:57:48 | mordred | it's also possible that we looked at this, I said "oh, I see the issue and will write a patch" and then didn't | |
| 20:57:56 | rm_work | yeah i think it's the latter | |
| 20:58:03 | rm_work | master seems to be the same | |
| 20:58:26 | mordred | yes! | |
| 20:58:30 | mordred | I remember the thing now | |
| 20:58:54 | rm_work | yeah everyone using this cloud is stuck on 0.9.x which is just sad T_T | |
| 20:58:59 | mordred | kmalloc: ^^ on older clouds, neutron's version discovery document is auth protected (because of course it is) | |
| 20:59:06 | rm_work | lolol yes | |
| 20:59:26 | mordred | kmalloc: I kind of think we should just update ksa to send a token if it has one when doing discovery | |
| 20:59:42 | mordred | kmalloc: (but not to get a token if it doesn't already have one perhaps) | |
| 21:00:05 | mordred | kmalloc: or else I can probably work around it in SDK - but it's definitely a weird gotcha for folks | |
| 21:00:08 | rm_work | wouldn't that just make the error inconsistent then? :( | |
| 21:00:39 | kmalloc | Hmm | |
| 21:00:44 | mordred | rm_work: hrm. good point | |
| 21:01:05 | kmalloc | Yeah it is weird | |
| 21:01:53 | rm_work | can you assume that if it is auth protected, that it's one of the old versions pre-discovery? and that tells you what the endpoint is? :P or is it still variable? | |
| 21:01:56 | mordred | kmalloc: the sdk answer will basically be "if network_endpoint_override is None and not catalog_url.endswith('/v2.0'): network_endpoint_override = catalog_url + '/v2.0' | |
| 21:02:20 | mordred | rm_work: well - *generaly* no - but for neutron it turns out there is one and only one version if it's old | |
| 21:02:26 | rm_work | yes | |
| 21:02:30 | rm_work | that is what i was thinking | |
| 21:08:45 | mordred | AHHHHH | |
| 21:12:31 | rm_work | :P | |
| 21:14:07 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Hardcode v2.0 onto end of neutron endpoints https://review.openstack.org/579015 | |
| 21:14:17 | mordred | rm_work: ^^ untested yet - but maybe that'll fix it for you | |
| 21:14:31 | rm_work | will try it | |
| 21:15:24 | rm_work | mordred: A++ :) | |
| 21:15:31 | rm_work | thanks | |
| 21:15:43 | mordred | rm_work: it worked? | |
| 21:15:45 | rm_work | yep | |
| 21:15:48 | mordred | yay! | |
| 21:15:53 | mordred | I will update that patch with some tests | |
| 21:16:09 | rm_work | review: A++, would bother mordred about patches again | |
| 21:16:14 | mordred | :) | |
| 21:16:28 | rm_work | thanks muchly | |
| 21:16:35 | mordred | kmalloc: ^^ in case you wanna look at the evil hacky thing | |
| 21:16:37 | rm_work | starting to have stuff we'd like to have past 0.9.x :P | |
| 21:27:16 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Hardcode v2.0 onto end of neutron endpoints https://review.openstack.org/579015 | |
| 21:33:45 | kmalloc | K | |
| 21:57:32 | openstackgerrit | Sorin Sbarnea proposed openstack/cliff master: Assure executable name is kept when app is called as module https://review.openstack.org/579025 | |
| 22:11:51 | openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Implement support for project limits https://review.openstack.org/575211 | |
| 22:11:51 | openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Implement support for registered limits https://review.openstack.org/574475 | |
| 23:08:59 | kmalloc | mordred: looking at evil hacky-thing now that i am not on mobile | |
| 23:09:41 | kmalloc | mordred: gross, but hey, if it fixes it | |
| #openstack-sdks - 2018-06-29 | |||
| 01:48:13 | openstackgerrit | Chen proposed openstack/python-openstackclient master: Fix a typo https://review.openstack.org/572771 | |
| 02:47:42 | openstackgerrit | Merged openstack/python-openstackclient master: Add ability to filter image list by tag https://review.openstack.org/575256 | |
| 03:25:26 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386 | |
| 06:22:47 | openstackgerrit | Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add DNS support to floating IP commands https://review.openstack.org/558824 | |