Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-05-24
16:00:45 gtema ok, hopefully would be no merge conflict
16:01:48 mordred ah - that was just one of the files - still need to do the actions one - lemme see if I can crank out a patch real quick
16:02:00 gtema ok
16:06:38 mordred gtema: http://paste.openstack.org/show/721908 it probably needs to go into your patch, since we need the code to use the sdk and not just shade for it to work properly
16:07:17 mordred gtema: that patch is the first one - but it should e pretty easy to do the rest - the url call is the same, https://developer.openstack.org/api-ref/compute/#servers-run-an-action-servers-action has the payloads needed for the others
16:07:40 mordred gtema: (I can make the rest if you want - whichever you think it easier)
16:09:35 gtema mordred: please make them, since it's an evening here in Germany and my wife will shortly start blaming ;-)
16:11:55 mordred :)
16:12:36 mordred ok. I think maybe let's just land your PR now - and we can do the nova_client cleanup as a followup as a bugfix
16:12:37 gtema I assume for servers.start it's json={'os-start'
16:12:55 mordred http://paste.openstack.org/show/721909
16:13:03 mordred gtema: I went ahead and did the whole set ^^
16:13:21 gtema great, PR will be updated in couple of minutes
16:13:33 mordred sweet. thanks - and thanks for doing the PR - it looks great!
16:13:44 gtema thanks
16:17:14 gtema mordred: it's there
16:19:36 gtema mordred: thanks for helping
16:31:24 mordred gtema: found one more if you're still around: http://paste.openstack.org/show/721911
16:31:58 gtema yes, still here
16:37:31 gtema mordred: ok, rebase completed and new module os_server_metadata is also part of the change
16:37:57 mordred sweet. thanks!
16:41:26 gtema mordred: another nova_client usage: os_server: L543 - remove_floating_ip
16:42:32 mordred gtema: yah - there's a pr up for that one
16:42:46 mordred gtema: I'm gonna see if I can get all of these in today
16:43:18 gtema ok
16:43:53 gtema right, missed that already. Code-search
16:46:14 gtema mordred: do you know if one can "recheck" in github ansible - 3 last jobs were cancelled due to the following changes and now it stucked
17:06:34 gtema mordred: I am off for today. If further changes are necessary - just leave a note. I will cover them tomorrow morning ASAP.
#openstack-sdks - 2018-05-25
00:09:03 harlowja did shade ever release with the fix to http://paste.openstack.org/show/721925/ ?
00:10:09 harlowja https://review.openstack.org/#/c/564861/ i think was the fix
00:10:14 harlowja but doesn't ever seem to have gotten released?
01:29:00 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
02:45:51 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
06:18:22 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
08:55:39 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Several improvements to resource.wait_for_status https://review.openstack.org/570538
09:16:48 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Several improvements to resource.wait_for_status https://review.openstack.org/570538
12:00:54 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Several improvements to resource.wait_for_status https://review.openstack.org/570538
14:34:07 gtema mordred: any progress on https://github.com/ansible/ansible/pull/40532? ansible-dev is already buzzing around todays dev-freeze
16:10:43 openstackgerrit Harald Jensås proposed openstack/python-openstackclient master: Allow setting network-segment on subnet update https://review.openstack.org/523974
17:18:24 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: allow passing ansible variables to ansible tests https://review.openstack.org/570600
17:20:45 mordred gtema: up and working on it now
17:31:55 gtema mordred: aren't sdk.OpenStackCloudException sdk.exceptions.OpenStackCloudException in ansible PR?
17:34:57 mordred gtema: wait - are they? I just tried importng locally
17:35:01 mordred gtema: >>> import openstack
17:35:03 mordred >>> openstack.OpenStackCloudException
17:35:08 mordred AttributeError: module 'openstack' has no attribute 'OpenStackCloudException'
17:35:30 mordred gtema: it's possible I'm not using my brain properly though
17:35:37 gtema exactly because of that I did that
17:36:00 gtema I tried also small POC and sdk.OpenStackCloudException was not working
17:38:12 gtema I was verifying by testing os_auth and trying a bad credentials
17:38:56 mordred gtema: yah ... so the ansible modules shoul duse sdk.exceptions.OpenStackCloudException yes?
17:39:26 gtema mordred: yupp
17:40:38 mordred cool - do you have time to fix the places that are using sdk.OpenStackCloudException ? Or we could just do it as a followup if you don't
17:40:59 gtema where have you found direct use?
17:41:36 gtema I see, os_itonic
17:41:38 gtema noing now
17:41:42 mordred gtema: I left inline comments on the PR - if you search for 'sdk.Open' it'll show them
17:41:44 mordred sweet
17:43:23 gtema mordred: went out
17:46:16 mordred gtema: crap. sorry - I just landed a pr that made a conflict with yours. can you rebase?
17:47:09 gtema yes, I see it already
17:47:12 gtema working
17:48:27 gtema so I should just remove this _get_aloowed_project, right?
17:48:47 mordred yah
17:51:58 gtema mordred: ready
17:59:45 mordred \o/
18:03:31 gtema mordred: crap, again shippable stucked
18:04:16 mordred gtema: yah - I just asked how to re-trigger it
18:04:45 gtema as I know either admin retriggers it or close-open PR
18:04:54 mordred ugh
18:06:27 gtema mordred: should I close-open?
18:06:56 mordred gtema: yah - let's try that
18:08:11 gtema ok, from second reopen started
18:09:11 gtema mordred: am away for now (8PM) will periodically come back to check IRC
18:09:30 mordred gtema: kk. I'll merge the pr as soon as it turns green
18:09:37 gtema great. Thanks
18:09:50 gtema oh crap, again cancelled
18:10:20 gtema in this case I think admins should retrigger
18:15:10 mordred gtema: ok. we'll just wait for it to run I suppose. it should be fine since it passed before. I'll keep watching it
18:28:07 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Remove app_name config tests https://review.openstack.org/569673
19:45:26 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Don't display router's is_ha and is_distributed attributes always https://review.openstack.org/567620
19:54:57 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Make max_burst_kbps option as optional for bw limit QoS rule https://review.openstack.org/567828
#openstack-sdks - 2018-05-26
02:55:21 openstackgerrit Merged openstack-infra/shade master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569425
03:10:55 openstackgerrit Merged openstack/os-client-config master: Remove app_name config tests https://review.openstack.org/569673
03:14:13 openstackgerrit Merged openstack/openstacksdk master: Avoid globally modifying yaml library https://review.openstack.org/568705
03:20:42 openstackgerrit Merged openstack/openstacksdk master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569422
15:29:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Plumb additional_user_agent support throughout https://review.openstack.org/569666
19:09:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Plumb additional_user_agent and collect_timings support throughout https://review.openstack.org/569666
#openstack-sdks - 2018-05-27
13:22:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
13:22:21 mordred dtantsur|afk: ^^ updated - thanks for the review!
13:43:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add ansible functional tests https://review.openstack.org/570678
13:55:18 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add ansible functional tests https://review.openstack.org/570678
13:55:33 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Update ansible test job to run against stable-2.5 https://review.openstack.org/570680
13:58:03 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Remove shade-ansible-devel job https://review.openstack.org/570682
14:18:29 openstackgerrit Merged openstack-infra/shade master: Switch to iterable version of server listing (and expose iterable method) https://review.openstack.org/569503
15:17:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
15:17:25 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
15:17:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
15:22:58 openstackgerrit Merged openstack/openstacksdk master: Several improvements to resource.wait_for_status https://review.openstack.org/570538
15:24:19 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add ansible functional tests https://review.openstack.org/570678

Earlier   Later