Posted	Nick	Remark
#openstack-sdks - 2018-05-18
14:02:54	gtema	mordred: " makes me wonder how to fix the situation
14:14:19	mordred	gtema: it looks to me like it defaults to None... ah
14:16:28	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569422
14:16:34	mordred	gtema: how about that ^^ ?
14:18:01	gtema	great. Was also thinking about that, but was confused by this comment. shade will also need the same, since ansible is having same problem
14:19:38	gtema	mordred: what is the plan to switch ansible from shade to sdk?
14:20:03	mordred	gtema: yes - we'll need the same patch for shade
14:22:09	mordred	gtema: there's two parts to the plane. one is to make shade a thin wrapper around openstacksdk like we just did with os-client-config. the other is to update the ansible modules... I think we could start that transition in the modules before the thin-shim layer is done for ansible 2.6 - as shade for ansible 2.5 already has a dependency on openstacksdk, so people should already have it installed
14:23:34	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569425
14:23:41	mordred	gtema: there's the cherry-pick to shade
14:24:00	gtema	mordred: thanks
14:24:58	gtema	mordred: do you which me to start some work on transition?
14:26:07	gtema	mordred: ah those typos: do you wish, that I start?
14:28:49	mordred	gtema: :) yes - that would be great - although my brain is totally distracted by the summit next week so I may not be able to provide much help until it's over
14:29:16	mordred	gtema: if you wnated to start thinking about the modules though, https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/openstack.py#L111 is probably a good place to start
14:30:02	gtema	mordred: no problem. Kurt will ping you if necessary ;-)
14:30:13	mordred	maybe a PR that changes that method to just import openstack and create a connection through sdk - and then update any of the modules that are declaring a minimum shade version or are using the 'shade' return value (usually for exception handling)
14:30:17	mordred	gtema: awesome :)
16:39:50	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569422
18:42:24	openstackgerrit	Joshua Harlow proposed openstack-infra/shade master: Add 'on_chunk_cb' param to list_servers https://review.openstack.org/569491
18:42:26	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Turn osc-functional-devstack-tips to nonvoting https://review.openstack.org/569492
18:45:31	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Turn osc-functional-devstack-tips to nonvoting https://review.openstack.org/569493
18:46:41	mordred	dhellmann: https://review.openstack.org/#/c/569398/ is green after your recheck
18:46:55	mordred	dhellmann: well, it's green on voting jobs
19:24:45	openstackgerrit	Joshua Harlow proposed openstack-infra/shade master: Switch to iterable version of server listing (and expose iterable method) https://review.openstack.org/569503
19:25:24	openstackgerrit	Joshua Harlow proposed openstack-infra/shade master: Switch to iterable version of server listing (and expose iterable method) https://review.openstack.org/569503
20:08:44	openstackgerrit	Slawek Kaplonski proposed openstack/python-openstackclient master: Don't display router's is_ha and is_distributed attributes always https://review.openstack.org/567620
20:17:23	openstackgerrit	Slawek Kaplonski proposed openstack/python-openstackclient master: Make max_burst_kbps option as optional for bw limit QoS rule https://review.openstack.org/567828
20:43:36	openstackgerrit	Merged openstack/python-openstackclient master: Update command test for volume.v3 https://review.openstack.org/569398
21:17:37	openstackgerrit	Joshua Harlow proposed openstack-infra/shade master: Switch to iterable version of server listing (and expose iterable method) https://review.openstack.org/569503
#openstack-sdks - 2018-05-19
13:34:18	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
13:34:18	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
15:48:30	openstackgerrit	Merged openstack/openstacksdk master: Enable bare metal unit tests https://review.openstack.org/569401
#openstack-sdks - 2018-05-20
19:30:33	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Plumb additional_user_agent support throughout https://review.openstack.org/569666
21:30:55	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Remove app_name config tests https://review.openstack.org/569673
21:31:13	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Plumb additional_user_agent support throughout https://review.openstack.org/569666
21:38:03	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Add release note for the vendor data regression https://review.openstack.org/569675
22:54:04	openstackgerrit	Merged openstack/openstacksdk master: baremetal: refuse to inspect associated machines https://review.openstack.org/569375
22:58:29	openstackgerrit	Merged openstack/os-client-config master: fix saltstack breakage introduced in v1.31.0 https://review.openstack.org/569291
23:04:54	openstackgerrit	Merged openstack/os-client-config master: Add release note for the vendor data regression https://review.openstack.org/569675
#openstack-sdks - 2018-05-21
03:36:03	openstackgerrit	Trent Lloyd proposed openstack/python-openstackclient master: openstack image list: Support for community images https://review.openstack.org/569692
06:25:47	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
07:48:31	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
19:50:33	openstackgerrit	Matt Smith (_alastor_) proposed openstack/openstacksdk master: Adding block_storage v3 API support https://review.openstack.org/566355
20:27:44	openstackgerrit	Joshua Harlow proposed openstack-infra/shade master: Switch to iterable version of server listing (and expose iterable method) https://review.openstack.org/569503
21:49:25	Guest83262	mordred: you around? I tried to catch you after your sdk talk, but you move too fast :)
#openstack-sdks - 2018-05-22
05:55:29	openstackgerrit	sonu proposed openstack/openstacksdk master: Fix filter style consistency for keystone assignment API https://review.openstack.org/569924
07:45:01	openstackgerrit	Chason Chan proposed openstack/python-openstackclient master: Update the content about Import Format https://review.openstack.org/569931
08:53:37	frickler	mordred: another hit on the "import openstack.py" ansible issue in #openstack. maybe a rename of that script in the ansible repo would be helpful?
08:54:17	gtema	fricker: I work on PR for 2.6 to switch from shade to openstacksdk
08:54:50	gtema	import importlib
08:54:55	gtema	sdk = importlib.import_module('openstack')
08:55:44	gtema	frickler: ^ ^
11:27:53	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
11:31:29	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
13:43:34	openstackgerrit	Artem Goncharov proposed openstack-infra/shade master: Allow explicitly setting enable_snat to either value https://review.openstack.org/569425
14:16:16	openstackgerrit	Daniel Speichert proposed openstack/openstacksdk master: Added few image properties to Image class https://review.openstack.org/544049
16:42:06	openstackgerrit	Slawek Kaplonski proposed openstack/python-openstackclient master: Make max_burst_kbps option as optional for bw limit QoS rule https://review.openstack.org/567828
16:42:17	openstackgerrit	Slawek Kaplonski proposed openstack/python-openstackclient master: Don't display router's is_ha and is_distributed attributes always https://review.openstack.org/567620
#openstack-sdks - 2018-05-23
07:35:18	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
09:20:50	openstackgerrit	lei zhang proposed openstack/python-openstackclient master: Add cliff project link https://review.openstack.org/570150
10:45:09	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
15:37:55	frickler	mordred: seems this bug still affects ocata+pike stable branches, would you have time to look into backporting? https://storyboard.openstack.org/#!/story/1733258
15:38:19	frickler	side note: would be interesting to discuss how we should track backports in storyboard
#openstack-sdks - 2018-05-24
00:41:30	openstackgerrit	Merged openstack/openstacksdk master: Decode additional heat files https://review.openstack.org/567648
00:41:30	openstackgerrit	Merged openstack/openstacksdk master: Added few image properties to Image class https://review.openstack.org/544049
05:54:23	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
11:37:13	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
11:54:24	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
12:00:16	dtantsur	mordred: hey! is my impression right that things exposed through proxies in openstacksdk (connection.compute.* etc) are a bit more low-level than things on connection itself?
12:01:19	gtema	dtansur: yes, you are right. Sometimes even much more low-level. They are basically the "basic rest calls" wrappers mostly
12:03:40	dtantsur	I see, it makes sense
12:03:49	dtantsur	so, this is intended, right?
12:04:33	gtema	well, yes. The connection methods are then giving a higher level of abstraction. So to say "function"
12:09:34	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386
12:29:34	gtema	hey SDK/shade/ansible cores: I've found out, that May 25. is the community freeze for ansible 2.6 (https://docs.ansible.com/ansible/devel/roadmap/ROADMAP_2_6.html). If we want to land shade retirement (see https://github.com/ansible/ansible/pull/40532) - it's really time to review the PR. Otherwise we might be late for 2.6
15:38:47	mordred	gtema: awesome! I just started looking at it last night - looks great - I should be ale to actually look today
15:46:07	gtema	mordred: great. I just found, that in the meanwhile new module was added: os_server_metadata. I am fighting with rebasing. If it doesn't work we can still merge PR and then additional PR to switch new module (is not a conflicting change)
15:53:07	mordred	gtema: yah - I think merge one and then do an additional is fine if the conflicts suck too much
15:53:53	dtantsur	cdent: hey, is there a meeting today?
15:54:54	cdent	dtantsur: I reckon not. I also reckon we forgot to announce that there's not. If you're inclined to show up in case any one else does, that would probably be useful
15:55:08	mordred	gtema: there's one more thing we should do that's an issue - I think someone maybe started looking at it already ... (also, I can hopefully help a bit -today isn't as busy)
15:55:24	dtantsur	cdent: I can be here, but if everyone else is on the Forum...
15:57:30	mordred	gtema: which is any place using cloud.nova_client we need to replace those calls since sdk doesn't have novaclient connnections
15:57:55	mordred	it's mostly going to be lib/ansible/modules/cloud/openstack/os_server_action.py
15:59:21	mordred	I think we need to add a few calls to sdk - but in the mean time the action calls are pretty easy rest calls, so we can just use the rest passthrough and then in 2.6 replace the rest calls with proper sdk method calls
15:59:35	gtema	mordred: ooh, yes
15:59:52	mordred	oh - nevermind: https://github.com/ansible/ansible/pull/40462
15:59:53	gtema	so let's decide what to do now
16:00:45	gtema	ok, hopefully would be no merge conflict
16:01:48	mordred	ah - that was just one of the files - still need to do the actions one - lemme see if I can crank out a patch real quick
16:02:00	gtema	ok
16:06:38	mordred	gtema: http://paste.openstack.org/show/721908 it probably needs to go into your patch, since we need the code to use the sdk and not just shade for it to work properly
16:07:17	mordred	gtema: that patch is the first one - but it should e pretty easy to do the rest - the url call is the same, https://developer.openstack.org/api-ref/compute/#servers-run-an-action-servers-action has the payloads needed for the others
16:07:40	mordred	gtema: (I can make the rest if you want - whichever you think it easier)
16:09:35	gtema	mordred: please make them, since it's an evening here in Germany and my wife will shortly start blaming ;-)
16:11:55	mordred	:)
16:12:36	mordred	ok. I think maybe let's just land your PR now - and we can do the nova_client cleanup as a followup as a bugfix
16:12:37	gtema	I assume for servers.start it's json={'os-start'
16:12:55	mordred	http://paste.openstack.org/show/721909

Earlier   Later