Earlier  
Posted Nick Remark
#openstack-sdks - 2018-05-10
16:52:10 openstackgerrit Merged openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
16:55:00 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Fix F405 additional strictness https://review.openstack.org/567645
16:55:00 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Remove service-type override tests https://review.openstack.org/567602
16:59:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Bump default timeout values https://review.openstack.org/567647
16:59:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add ipaddress and futures to lower-constraints https://review.openstack.org/567611
17:00:49 mordred slaweq, Shrews: ^^ the timeout patch there doesn't make me super happy - but we're getting random test timeouts on otherwise functional tests enough that I think doing that is better than just playing the recheck dance on every patch
17:04:36 openstackgerrit Sergey Skripnick proposed openstack/openstacksdk master: Decode additional heat files https://review.openstack.org/567648
17:04:40 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Remove service-type override tests https://review.openstack.org/567602
17:09:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
17:10:08 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add get_volume_limits() support https://review.openstack.org/564507
18:05:19 openstackgerrit Merged openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237
18:05:19 openstackgerrit Merged openstack/openstacksdk master: Bugfix for block_storage not selecting the correct proxy https://review.openstack.org/566740
19:05:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
19:05:40 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
19:05:45 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
19:05:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
19:31:51 openstackgerrit Merged openstack/openstacksdk master: Bump default timeout values https://review.openstack.org/567647
19:36:04 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Remove default values of router's is_ha and is_distributed arguments https://review.openstack.org/567606
19:37:39 mordred Shrews, slaweq, rods: https://review.openstack.org/#/c/564494 is finally ready for review (jeez)
20:21:49 rods mordred ^^ lgtm
20:22:12 mordred rods: thanks!
20:56:28 openstackgerrit Merged openstack/openstacksdk master: Add ipaddress and futures to lower-constraints https://review.openstack.org/567611
21:48:29 openstackgerrit Merged openstack/os-client-config master: Fix F405 additional strictness https://review.openstack.org/567645
21:48:30 openstackgerrit Merged openstack/os-client-config master: Remove service-type override tests https://review.openstack.org/567602
21:59:47 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added few image properties to Image class https://review.openstack.org/544049
22:29:18 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Populate Image.properties https://review.openstack.org/544544
23:26:42 openstackgerrit Merged openstack/openstacksdk master: Remove default values of router's is_ha and is_distributed arguments https://review.openstack.org/567606
#openstack-sdks - 2018-05-11
00:02:50 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fix interface argument to get_all_version_data https://review.openstack.org/567702
02:35:09 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
02:54:37 openstackgerrit Merged openstack/keystoneauth master: Fix interface argument to get_all_version_data https://review.openstack.org/567702
02:57:39 openstackgerrit huangshan proposed openstack/python-openstackclient master: Update http links in docs https://review.openstack.org/567729
03:13:18 openstackgerrit huangshan proposed openstack/openstackclient master: Update http links in doc https://review.openstack.org/567732
06:44:56 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
08:21:09 openstackgerrit Merged openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
11:06:13 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Make max_burst_kbps option as optional for bw limit QoS rule https://review.openstack.org/567828
14:00:02 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Reenable osc-functional-devstack-tips and neutron-grenade https://review.openstack.org/549309
14:00:16 mordred slaweq, Shrew, rods: if you get bored today, I'd love reviews on https://review.openstack.org/#/q/topic:service-type-aliases+status:open and https://review.openstack.org/#/q/topic:test-updates+status:open
14:00:45 slaweq mordred: since I'm in RH I'm never bored
14:00:50 slaweq mordred: but I will take a look :)
14:00:52 mordred slaweq: hehe
14:05:55 slaweq mordred: https://review.openstack.org/#/c/547225/1 is for stable/queens and it doesn't look like cherry-pick, is it intentional?
14:08:51 mordred slaweq: I can't remember if it was intentional - but it's definitely mislabeled
14:09:46 mordred slaweq: yah - was a cherry-pick ... but I don't think we need it anymore - I'm just going to abandon
14:09:59 slaweq one less to check :)
14:10:02 slaweq thx
14:10:08 mordred \o/
14:25:44 Shrews mordred: reviewed the test series, but the other is going to take more brain power than i can spare at the moment while figuring out multi-label stuff
14:42:43 Shrews mordred: ok, i did review the first couple of the other series until i found an issue.
14:47:39 mordred Shrews: kk. thanks! (also yeah - multi-label)
15:45:25 openstackgerrit Merged openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254
15:51:35 openstackgerrit Merged openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255
17:52:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add get_volume_limits() support https://review.openstack.org/564507
19:00:50 openstackgerrit Merged openstack/openstacksdk master: Reenable osc-functional-devstack-tips and neutron-grenade https://review.openstack.org/549309
#openstack-sdks - 2018-05-12
15:32:53 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix recent pep8 issues https://review.openstack.org/567996
17:43:47 shellfishers TESTING TESTING
17:49:50 shellfishers TESTING TESTING
#openstack-sdks - 2018-05-13
13:14:12 openstackgerrit Merged openstack-infra/shade master: Fix recent pep8 issues https://review.openstack.org/567996
13:25:52 openstackgerrit XiaojueGuan proposed openstack/api-wg master: Trivial: update url to new url https://review.openstack.org/568075
13:45:48 openstackgerrit Merged openstack/openstacksdk master: Add get_volume_limits() support https://review.openstack.org/564507
14:54:24 openstackgerrit Merged openstack/api-wg master: Trivial: update url to new url https://review.openstack.org/568075
#openstack-sdks - 2018-05-14
06:33:36 openstackgerrit Lingyong Xu proposed openstack/cliff master: Trivial: Fix the pep8 warning The yaml should start with "---" https://review.openstack.org/568205
09:15:18 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Make max_burst_kbps option as optional for bw limit QoS rule https://review.openstack.org/567828
09:23:07 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for QoS policy https://review.openstack.org/547810
09:24:22 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
12:15:47 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added few image properties to Image class https://review.openstack.org/544049
14:17:18 rcarrillocruz mordred , Shrews : out of curiosity, how you filter the jobs for ansible shade ? i.e. i don't see a 'files' attribute on the jobs def, curious how you trigger them on just-openstack-modules PRs
14:20:46 mordred rcarrillocruz: it's in project pipeline definition
14:21:04 mordred rcarrillocruz: because we only want to skip things on ansible prs ... one sec
14:21:26 rcarrillocruz ah ok...
14:21:47 mordred rcarrillocruz: https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L4-L16
14:23:57 rcarrillocruz i'm helping out gundalow to put jobs for ansible/ansible network modules
14:24:13 rcarrillocruz and wanted to link him the 'files' thingy in a reall world example
15:40:33 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class https://review.openstack.org/544049
15:42:49 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added few image properties to Image class https://review.openstack.org/544049
15:45:12 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class https://review.openstack.org/544544
15:46:32 dasp mordred: sorry about the spam above, https://review.openstack.org/#/c/544049/ that you previously CR+2'ed now passes testing
15:49:55 dasp I'm also unsure what's the best way to implement arbitrary properties on the Image object, I've updated https://review.openstack.org/#/c/544544/ about that. It uses Image.properties as a bag for those unexpected properties but is it worth packing/unpacking them from the API object?
16:19:47 mordred dasp: I think it is - on the shade side we put known/official properties on the main Image and the others into a properties - I'd eventually like for both the shade and sdk sides of openstacksdk to be working with the same objects... so I think that's a step in the right direction - I've got thatpatch queued up for review here in just a little bit
16:21:16 dasp mordred: okay, I think my latest iteration correctly gathers those unexpected properties and allows for updating them, had to modify some tests. I'm looking forward to your review and comments if I can make it better.
17:32:10 mnaser it would be nice if 'openstack image create' ported over the '--progress' option that exists in glance
17:41:12 mordred mnaser: we've got a todo-list item for that sdk-side
17:41:28 mnaser mordred: cool, i try to mention things i see missing when i do :)
17:41:31 mordred mnaser: ianw started poking at some generalized callback mechanisms for tracking progress of long-running calls
17:41:52 mnaser i'd push up a patch but i figured it was something a bit more complicated in regards to a standarized progress tracking method
17:58:56 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class https://review.openstack.org/544544
18:17:53 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Resolve images and flavors one by one in server list https://review.openstack.org/568345
18:17:53 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Skip calls to glance and nova when got no servers https://review.openstack.org/568344
19:13:20 mordred mnaser: yah - the tricky part is that v1 PUT and v2 PUT are both just single realy long HTTP PUT calls - so we'll likely need a virtual file wrapper object that can fire callbacks ever X bytes read/transferred or something insane like that
19:13:40 mordred BUT - once we do it once, since we'll do it at the low-level adapter layer, we should actually be able to apply it to all calls
19:52:52 dasp is openstackclient.tests.functional.compute.v2.test_aggregate.AggregateTests known to fail or is it a random error?
19:57:34 mordred dasp: I don't know that I've noticed it a bunch - I see floating ip and volume tests most frequently with random errors - but looking at that one I'd say that's pretty fair for a recheck
20:00:07 mordred dasp: found one thing I think you probably want to change, but otherwise I thnk it looks good
20:00:53 mordred adriant: ^^ if you have a sec, https://review.openstack.org/544544 has a behavior change in it and would be nice to have you chime in on
20:07:56 openstackgerrit Daniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class https://review.openstack.org/544544
20:25:13 openstackgerrit Brian Rosmaita proposed openstack/keystoneauth master: WIP - fix logging of encoded headers https://review.openstack.org/568365
20:35:17 openstackgerrit Brian Rosmaita proposed openstack/keystoneauth master: WIP - fix logging of encoded headers https://review.openstack.org/568365
22:53:13 adriant mordred: will look
23:48:50 adriant mordred: Oh I see, so glance kind of does something similar with extra properties like Keystone.
23:53:07 adriant actually that's reminds me... I should test the Keystone extra properties stuff. I know we sort of have a few like 'email' (which isn't a real field in Keystone), but Keystone's extra json blob lets you add arbitrary values.
#openstack-sdks - 2018-05-15
00:15:48 adriant mordred: left a review on the patch. It works, but also doesn't when getting back the values.

Earlier   Later