| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-04-26 | |||
| 17:00:55 | elmiko | looks good to me, thanks for the clarity edleafe =) | |
| 17:01:44 | elmiko | sent! | |
| 17:06:38 | cdent | I thought that lack of clarity was just elmiko's inimitable style | |
| 17:06:45 | cdent | which I took as artistry | |
| 17:10:48 | elmiko | cdent: pretty much XD | |
| 18:53:46 | JPL | Hi. I just started using shade to connect to our private cloud instances, and am having some issues switching projects (`connect_as_project`).Ref: https://docs.openstack.org/shade/latest/user/usage.html | |
| 18:53:53 | JPL | https://gist.github.com/jplindquist/acb4ddfb00f9e412563fb26343b138a2 | |
| 18:55:10 | harlowja | ya, i've been trying that same thing with JPL | |
| 18:55:13 | JPL | I can connect to my user-project, list servers, etc, all without issue, but if I attempt to connect_as_project to another project, I receive an error: `os_client_config.exceptions.OpenStackConfigException: Cloud defaults was not found.` | |
| 18:55:40 | harlowja | JPL u also put in a 'defaults:{}' and 'default:{}' in your clouds.yaml right | |
| 18:55:46 | harlowja | with no luck with those right? | |
| 18:56:01 | JPL | Correct | |
| 18:57:02 | JPL | Looks like it's trying to combine defaults here when it does connect_as: https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L366-L369 | |
| 19:19:05 | Shrews | that code is *really* new. a bug there does not surprise me | |
| 19:23:36 | JPL | Yeah, I wouldn't be surprised, wasn't sure if anybody else had used it successfully or not :/ | |
| 19:26:20 | Shrews | so it looks like OCC is supposed to give you a 'defaults' cloud if you have none defined. If you do have some defined, you don't get that. | |
| 19:26:28 | Shrews | so yeah, i think that's a bug | |
| 19:26:39 | Shrews | may need to confer with mordred on how to handle that | |
| 19:27:31 | Shrews | i wonder why our tests didn't catch it though | |
| 19:36:10 | Shrews | JPL: out of curiosity, what is your OCC version? | |
| 19:36:26 | JPL | os-client-config (1.29.0) | |
| 19:37:41 | mordred | Shrews, JPL: I believe that's fixed in master - but I need to check | |
| 19:37:43 | mordred | (and sorry) | |
| 19:38:20 | JPL | All good, thanks for checking, I appreciate your help | |
| 19:38:38 | Shrews | i do not see a fix in master | |
| 19:38:50 | mordred | Shrews: maybe you're not squinting hard enough? | |
| 19:38:59 | Shrews | entirely possible | |
| 19:39:00 | JPL | rofl | |
| 19:39:51 | Shrews | it also might help if i were not looking at the occ git log | |
| 19:40:02 | mordred | well | |
| 19:40:28 | mordred | so - it's fixed in sdk master and I'm a bad person and didn't cherry-pick it back into shade master | |
| 19:42:15 | Shrews | lol | |
| 19:42:39 | JPL | aaah | |
| 19:43:38 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Backport connect_as fix from openstacksdk https://review.openstack.org/564604 | |
| 19:44:15 | mordred | Shrews, JPL I'm pretty sure that will fix it - and it's no wonder it didn't get backported, it was hidden inside of a patch for using oslotest's base class | |
| 19:44:16 | mordred | sigh | |
| 19:45:26 | JPL | * highfive | |
| 19:45:26 | mordred | Shrews: with the release of sdk I put in apatch for today, we should be able to land the patch to make occ a shim and at least remove that layer of confusion - and then I think it'll be time to do the same thing with shade - the two-parallel-codebases thing is too much for my brain | |
| 19:46:10 | Shrews | too much for anyone's brain | |
| 19:54:23 | harlowja | mordred so how much of openstacksdk vs shade going forward? | |
| 19:54:29 | harlowja | merging? maybe/ | |
| 19:54:30 | harlowja | ? | |
| 19:54:49 | harlowja | someday?, soon? never? | |
| 19:54:50 | JPL | I tried updating my local copy with that diff, got this nwo:AttributeError: 'OpenStackCloud' object has no attribute 'config' | |
| 19:55:55 | mordred | JPL: ok. darn. I'll have to work slighly harder :) | |
| 19:56:32 | JPL | Traceback (most recent call last): File "shade-test.py", line 22, in <module> project_cloud = default_cloud.connect_as_project(project=project_name) File "/usr/local/lib/python2.7/site-packages/shade/openstackcloud.py", line 411, in connect_as_project return self.connect_as(**auth) File "/usr/local/lib/python2.7/site-packages/shade/openstackcloud.py", line 328, in connect_as if self.config._openstack_config: Att | |
| 19:56:48 | JPL | That's really ugly copy/paste, womp | |
| 19:57:25 | mordred | harlowja: the shade and os-client-config code is already merged into sdk - the next step (which is the really tricky one) is to remove the shade code from shade and make it a very thin compat layer on top of the equiv code in sdk | |
| 19:57:34 | harlowja | mordred gotcha | |
| 19:57:39 | harlowja | TIL, lol | |
| 19:57:50 | mordred | harlowja: right now we're playing the 'keep both in sync with each other while we get that all done so that it doesn't break anybody' - which sucks | |
| 19:57:59 | harlowja | agreed | |
| 20:00:39 | mordred | JPL: change config = self.config._openstack_config to config = self.cloud_config._openstack_config | |
| 20:00:47 | mordred | JPL: copy-pasta error :) | |
| 20:01:18 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Backport connect_as fix from openstacksdk https://review.openstack.org/564604 | |
| 20:02:50 | mordred | Shrews: ^ had to update because I'm a terrible person | |
| 20:02:52 | JPL | Also if self.config._openstack_config: ? | |
| 20:03:07 | JPL | same thing, otherwise I think this will do the trick | |
| 20:03:50 | JPL | Yay, working | |
| 20:03:52 | JPL | if self.cloud_config._openstack_config: config = self.cloud_config._openstack_config | |
| 20:05:16 | mordred | \o/ | |
| 20:05:35 | melwitt | amotoki: hi, your review would be appreciated on this change we're trying to get in to make stable/queens novaclient work together with stable/queens openstackclient so that we may update the queens novaclient constraint to 10.x https://review.openstack.org/538070 so that users can use the multi-attach feature with queens out-of-the-box | |
| 20:05:45 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Backport connect_as fix from openstacksdk https://review.openstack.org/564604 | |
| 20:06:05 | melwitt | amotoki: forgot to link the change, of course https://review.openstack.org/562840 | |
| 20:06:16 | JPL | Thank you all for your help | |
| 20:06:33 | mordred | JPL: thanks for trying out the fixes! that first one really didn't fix anything did it? :) | |
| 20:06:54 | JPL | lol, any time | |
| 20:07:47 | JPL | Last question, assuming everything passes and makes it in, how long usually before a new release with that? | |
| 20:10:17 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Infer version from old versioned service type aliases https://review.openstack.org/564299 | |
| 20:11:22 | mordred | JPL: should have one today or tomorrow - assuming I can get TheJulia to land https://review.openstack.org/#/c/564279/ :) | |
| 20:12:05 | mordred | (basically, as soon as that patch lands, we can land the fix for your issue and a patch pabelanger needs and cut a release | |
| 20:12:46 | JPL | awesomesauce | |
| 21:01:29 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Infer version from old versioned service type aliases https://review.openstack.org/564299 | |
| 22:11:53 | adriant | mordred: Putting the code in the SDK layer was my first thought too. I think moving the advanced logic into the SDK layer makes sense if it's still part of that service, and shade just uses it as passthrough, but multi-project workflow type stuff should always stay in shade | |
| 22:11:58 | adriant | if that makes sense | |
| 22:12:12 | adriant | at least then we have some sort of consistency for where to put stuff | |
| #openstack-sdks - 2018-04-27 | |||
| 03:53:25 | openstackgerrit | Mark Kirkwood proposed openstack/python-openstackclient master: Add an option to container create for storage policy. Also display some policy data for container show and object store account show commands. https://review.openstack.org/564665 | |
| 05:12:00 | openstackgerrit | Mark Kirkwood proposed openstack/python-openstackclient master: Add an option to container create for storage policy. Also display some policy data for container show and object store account show commands. https://review.openstack.org/564665 | |
| 10:45:06 | mordred | adriant: agree | |
| 10:49:42 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove DataCentred from list of vendors https://review.openstack.org/564727 | |
| 10:49:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: pypy is not checked at gate https://review.openstack.org/564729 | |
| 10:49:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add Limestone Networks vendor info https://review.openstack.org/564728 | |
| 11:04:29 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Replace guts with openstack.config https://review.openstack.org/549307 | |
| 11:13:17 | mordred | Shrews: ^^ assuming that passes, that should take care of occ | |
| 11:50:54 | ttsiouts | Hello! I have two patches up https://review.openstack.org/#/c/551811/ and https://review.openstack.org/#/c/562300/. I would really appreciate it if someone could help with reviewing. Thanks in advance!! | |
| 12:08:45 | openstackgerrit | Merged openstack-infra/shade master: Add get_volume_limits() support https://review.openstack.org/564247 | |
| 12:54:28 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Adds Senlin support to shade https://review.openstack.org/542537 | |
| 12:56:12 | openstackgerrit | Merged openstack-infra/shade master: Backport connect_as fix from openstacksdk https://review.openstack.org/564604 | |
| 13:02:00 | mordred | Shrews: ^^ those two landed, I think it's time to cut a shade release | |
| 13:02:49 | Shrews | mordred: go for it | |
| 13:03:34 | mordred | Shrews: https://review.openstack.org/564752 Release shade 1.28.0 | |
| 13:06:40 | Shrews | mordred: 1.28.0? I don't see a 1.27.0 tag | |
| 13:11:35 | mordred | Shrews: I believe 1.27.0. and 1.27.1 both got cut on stable/queens | |
| 13:12:58 | Shrews | mordred: oh, yeah. not used to this new release process | |
| 13:14:04 | openstackgerrit | Merged openstack-infra/shade master: add lower-constraints job https://review.openstack.org/555299 | |
| 13:14:38 | mordred | Shrews: me either - I kind of failed at paying attention to freeze dates, thus why we woundup with queens releases :) | |
| 13:35:10 | amotoki | melwitt: sorry for late. I will take a look at the backport patch during this weekend at the latest. I need to refresh my memory on compute/network hybrid commands. | |
| 13:44:50 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Replace guts with openstack.config https://review.openstack.org/549307 | |
| 13:53:44 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add Limestone Networks vendor info https://review.openstack.org/564728 | |
| 13:56:49 | melwitt | thanks amotoki | |