| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-04-17 | |||
| 09:45:07 | jpich | I'm not super familiar with it yet either and was pointed to https://docs.openstack.org/infra/storyboard/gui/manual.html as a good starting point, if that helps! | |
| 09:45:26 | ttsiouts | jpich: oh! thanks a lot!! | |
| 09:45:36 | ttsiouts | I'll try! | |
| 09:46:11 | jpich | Thank you! | |
| 15:16:44 | openstackgerrit | Merged openstack/cliff master: add lower-constraints job https://review.openstack.org/555405 | |
| 15:19:22 | openstackgerrit | Merged openstack/python-openstackclient master: Clean up W503 and E402 pep8 errors https://review.openstack.org/560132 | |
| 15:53:00 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Network: Add tag support for floating ip https://review.openstack.org/547316 | |
| 20:12:26 | frickler | general question: should we update bug references to stories in currently in-flight patches? | |
| 20:58:31 | openstackgerrit | Doug Hellmann proposed openstack/keystoneauth master: add lower-constraints job https://review.openstack.org/555625 | |
| 20:58:32 | openstackgerrit | Doug Hellmann proposed openstack/keystoneauth master: fix pep8 errors caused by pycodestyle>=2.4.0 https://review.openstack.org/562052 | |
| 21:24:49 | openstackgerrit | Doug Hellmann proposed openstack/cliff master: exclude cmd2 0.8.3 and update to 0.8.4 https://review.openstack.org/560121 | |
| #openstack-sdks - 2018-04-18 | |||
| 14:46:32 | openstackgerrit | Theodoros Tsioutsias proposed openstack/python-openstackclient master: Add project info to server list from all projects https://review.openstack.org/562300 | |
| 15:00:38 | openstackgerrit | Theodoros Tsioutsias proposed openstack/python-openstackclient master: Add project info to server list from all projects https://review.openstack.org/562300 | |
| 15:20:57 | gtmanfred | mordred: you around today? | |
| 16:53:16 | openstackgerrit | Dongcan Ye proposed openstack/python-openstackclient master: DEBUG: Fix functional job failed https://review.openstack.org/562345 | |
| 20:42:19 | openstackgerrit | Merged openstack/keystoneauth master: Fix W503 line-break-before-binary-operator https://review.openstack.org/561259 | |
| 21:59:25 | openstackgerrit | Hongbin Lu proposed openstack/python-openstackclient master: Support filtering port with IP address substring https://review.openstack.org/532324 | |
| #openstack-sdks - 2018-04-19 | |||
| 07:55:59 | openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: add lower-constraints job https://review.openstack.org/555625 | |
| 09:23:05 | openstackgerrit | Merged openstack/keystoneauth master: add lower-constraints job https://review.openstack.org/555625 | |
| 12:45:26 | elmiko | cdent edleafe just wanted to make sure you saw my email, i won't be able to make the meeting today. sorry | |
| 12:56:21 | edleafe | elmiko: Guess who's getting all new work assigned to him? | |
| 12:57:27 | elmiko | haha, dmitry? | |
| 12:57:30 | elmiko | XD | |
| 12:58:25 | cdent | Ed and I will just there and scowl. | |
| 13:10:13 | elmiko | ha! | |
| 13:12:09 | cdent | grumbly old men farting | |
| 13:14:46 | elmiko | hmm, ya know, i can hold off going to the airport for at _least_ an hour XD | |
| 15:40:24 | openstackgerrit | Dongcan Ye proposed openstack/python-openstackclient master: Fix functional job failed https://review.openstack.org/562345 | |
| 16:16:33 | cdent | edleafe: https://etherpad.openstack.org/p/api-sig-newsletter (indeed very short) | |
| 16:19:02 | openstackgerrit | Merged openstack/api-wg master: Update the errors guidance to use service-type for code https://review.openstack.org/554921 | |
| 16:20:05 | edleafe | cdent: let 'er rip! | |
| 16:20:21 | cdent | thanks | |
| #openstack-sdks - 2018-04-20 | |||
| 01:49:59 | openstackgerrit | Dongcan Ye proposed openstack/python-openstackclient master: Fix functional job failed https://review.openstack.org/562345 | |
| 03:06:38 | openstackgerrit | Kiseok Kim proposed openstack/openstacksdk master: Fix typo in README.rst https://review.openstack.org/562916 | |
| 03:20:15 | adriant | mordred, dtroyer_zz: Are we moving the openstackclient to only use the SDK? I heard murmurings about that, but was curious how far along it got. | |
| 03:21:05 | adriant | I ask because I know the openstackclient uses some weird Swift layer that is unique to itself and part of me is very very tempted to replace that with the SDK because the openstackclient still lacks features that the swift-cli has. | |
| 03:21:21 | adriant | and I really want to stop telling people they have to use the swift client... | |
| 03:21:39 | adriant | lets be honest, I want to stop using the swift client :P | |
| 06:42:23 | openstackgerrit | Lingxian Kong proposed openstack/openstackclient master: Add python-qinlingclient to zuul job https://review.openstack.org/562949 | |
| 10:04:50 | openstackgerrit | Tovin Seven proposed openstack/openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563032 | |
| 10:05:46 | openstackgerrit | Tovin Seven proposed openstack/osc-lib master: Trivial: Update pypi url to new url https://review.openstack.org/563033 | |
| 10:08:01 | openstackgerrit | Sergey Skripnick proposed openstack/openstacksdk master: Heat files parameter https://review.openstack.org/563035 | |
| 10:23:52 | openstackgerrit | Tovin Seven proposed openstack/python-openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563062 | |
| 11:39:55 | cdent | edleafe, elmiko, dtantsur|pto : I've asked for a single day at the PTG (again). Seemed to work well last time. | |
| 12:53:14 | pooja_jadhav | cdent: Hi | |
| 13:39:26 | openstackgerrit | Merged openstack/osc-lib master: Trivial: Update pypi url to new url https://review.openstack.org/563033 | |
| 13:40:18 | pooja_jadhav | cdent : Hi | |
| 13:40:42 | cdent | hi pooja_jadhav | |
| 13:41:04 | pooja_jadhav | cdent: Want to dicuss about split logger | |
| 13:41:34 | openstackgerrit | Merged openstack/openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563032 | |
| 13:43:26 | pooja_jadhav | cdent: Actually, for testing purpose of split logger, I want to test nova cinder interaction. So put _SESSION._split_loggers = True after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L86 | |
| 13:43:48 | cdent | pooja_jadhav: sorry, I'm not sure I know what you're talking about. I don't have a memory of talking about split logger. | |
| 13:43:53 | openstackgerrit | Merged openstack/python-openstackclient master: Trivial: Update pypi url to new url https://review.openstack.org/563062 | |
| 13:45:58 | pooja_jadhav | cdent: https://review.openstack.org/#/c/505764 | |
| 13:46:43 | pooja_jadhav | cdent: want to dicuss about this above patch Monty has proposed and merged into master branch | |
| 13:46:53 | cdent | pooja_jadhav: oh that, yeah, I don't really know much about that. mordred might but he's at a conference right now | |
| 13:47:46 | pooja_jadhav | cdent: Ohk... I have ping him several times, but haven't got rly :( | |
| 13:48:09 | pooja_jadhav | cdent: Who else can help me in this | |
| 13:48:10 | pooja_jadhav | ?? | |
| 13:49:05 | cdent | I can talking with you about it, but it will mostly be you explaining what you're trying to do to me, and maybe as part of that things will be more clear | |
| 13:49:48 | pooja_jadhav | cdent: Actually, I am facing issue while using split logger parameter in nova-cinder interaction. | |
| 13:50:07 | pooja_jadhav | cdent: i will tell you what i am trying to do. | |
| 13:50:59 | pooja_jadhav | cdent: after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L86.. i am setting _SESSION._split_loggers = True just for time being testing. | |
| 13:51:45 | pooja_jadhav | so when request goes from nova to cinder ( i should request into see split logging) as passed split_logger = True | |
| 13:53:25 | cdent | I think instead of doing _SESSION._split_loggers = True after that call you instead need to pass split_loggers=True in the call to load_session_from_conf_options | |
| 13:53:25 | pooja_jadhav | cdent: But the code in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617 is making split_logger = False if logger is already passed. and because of this request-ids are not getting logged | |
| 13:53:33 | cdent | does that make any difference | |
| 13:54:13 | pooja_jadhav | but this load_session_from_conf_options method dont have this parameter | |
| 13:55:00 | pooja_jadhav | how can I pass that split_logger to load_session_from_conf_options | |
| 13:56:27 | cdent | pooja_jadhav: from what I can tell load_session_from_conf_options takes kwargs: | |
| 13:57:25 | cdent | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py#L246 | |
| 13:57:53 | pooja_jadhav | ok | |
| 14:00:13 | pooja_jadhav | but the issue is, logger is getting passed from some where | |
| 14:00:47 | pooja_jadhav | and that if condition in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617 making split_logger to False | |
| 14:02:23 | pooja_jadhav | so it only logs (request, response and response body) except request-id | |
| 14:05:38 | openstackgerrit | Mário Santos proposed openstack-infra/shade master: Adds kwargs support when creating a Neutron subnet https://review.openstack.org/563134 | |
| 14:09:25 | cdent | sorry pooja_jadhav got distracted for a moment, re-reading | |
| 14:09:36 | pooja_jadhav | no issue | |
| 14:10:26 | cdent | Based on what you are saying I think you've found a bug. | |
| 14:12:23 | cdent | if you can't find mordred, you might try speaking with cmurphy or lbragstad ? | |
| 14:12:51 | cdent | If you're able to come up with a minimal test case that demostrates the problem, that would probably be useful too | |
| 14:14:24 | cmurphy | kmalloc might also be able to help with that | |
| 14:14:35 | cmurphy | I can try but would have to refresh my memory a bit | |
| 14:16:33 | pooja_jadhav | ok | |
| 14:17:39 | pooja_jadhav | in keystonenauth, in def request()- if logger is passed then split_logger sets to False, and because of this request-ids are not getting logged | |
| 14:17:50 | pooja_jadhav | In my opion also, it a bug | |
| 14:18:47 | pooja_jadhav | My aim is to use split_logger functionality wherever keystoneauth session is getting used. | |
| 14:19:51 | pooja_jadhav | I already had discussion with kmalloc | |
| 14:20:50 | cmurphy | pooja_jadhav: I think if a logger is passed then that indicates you only want to use one logger, ie the one that you passed, and so splitting loggers wouldn't make sense | |
| 14:22:40 | pooja_jadhav | cmurphy: ohk, But I am able to see (3 parts of request in splits like(keystoneauth.session.request, keystoneauth.session.response, keystoneauth.session.body) | |
| 14:23:16 | pooja_jadhav | cmurphy: Only the part I am not able to see is keystoneauth.session.request-id | |
| 14:26:18 | cmurphy | pooja_jadhav: so you think something around here is going wrong? https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L772-L775 | |
| 14:26:52 | pooja_jadhav | cmurphy: yes | |
| 14:27:35 | pooja_jadhav | cmurphy: Split_logger is getting as False and because of that request-is is not get logged. | |
| 14:28:42 | dtroyer_zz | adriant: it has been the plan for OSC to use the SDK once it has a 1.0 release since the SDK was started. We relented on the 1.0 for Network in order to not add the neutronclient dependency and other reasons, and it has been painful as the SDK has made at least two changes we have been required to work around and handle multiple SDK versions for. | |
| 14:29:01 | cmurphy | pooja_jadhav: you said you're passing in a logger and that's why it's getting set to false, can you not pass in a logger? | |
| 14:30:16 | dtroyer_zz | The api.object layer in OSC was largely lifted from swiftclient since swiftclient was still only available in the swift repo at the time. I put it into the form I was proposing for a low-level SDK that was subsequently not merged. and it has sat there ever since waiting for the SDK 1.0 as explained above | |
| 14:31:45 | dtroyer_zz | so yes, once we have an SDK 1.0 folks can go nuts converting commands to use it, with adequate compatibility testing in place | |
| 14:32:22 | pooja_jadhav | pooja_jadhav: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client. | |
| 14:32:36 | pooja_jadhav | cmurphy: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client. | |