| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-22 | |||
| 12:13:34 | adriant | I'm just about to run it locally and check again | |
| 12:13:40 | mordred | adriant: have I mentioned recently that I really miss strong typing? | |
| 12:14:14 | adriant | yeah... normally I don't hit these issues, but every now and again you wish we had it | |
| 12:14:23 | mordred | adriant: cool - I'd love to find/fix the calling location if we can - but yeah, I can see maybe needing to do isinstance(type, Response) ... but that just seems so sad | |
| 12:15:11 | adriant | isinstance! of course, silly me I use that one but always forget it | |
| 12:15:19 | mordred | :) | |
| 12:15:24 | mordred | I have to remind myself of it all the time | |
| 12:15:38 | adriant | is this and instance to use it? ;) | |
| 12:15:43 | adriant | an* | |
| 12:18:14 | adriant | b"AttributeError: 'dict' object has no attribute 'headers'" | |
| 12:18:14 | adriant | mordred: self.request_id = response.headers.get('x-openstack-request-id')" | |
| 12:18:25 | adriant | yeah, somewhere it's a dict | |
| 12:23:07 | openstackgerrit | Merged openstack/os-client-config master: pypy is not checked at gate https://review.openstack.org/554955 | |
| 12:23:16 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 12:25:13 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 12:28:46 | adriant | mordred: a better fix was found so (to try that pun again), this isn't an instance where we type check. :P | |
| 12:33:01 | mordred | adriant: \o/ | |
| 13:07:23 | openstackgerrit | Doug Hellmann proposed openstack-infra/requestsexceptions master: add lower-constraints job https://review.openstack.org/555298 | |
| 13:07:30 | openstackgerrit | Doug Hellmann proposed openstack-infra/shade master: add lower-constraints job https://review.openstack.org/555299 | |
| 13:18:43 | openstackgerrit | Merged openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142 | |
| 13:26:55 | amotoki | dtroyer: regarding storyboard migration along with SDK in the dev list, do you have any specific concern? In general, I can take care of the migration if it happens. | |
| 13:27:02 | dhellmann | mordred : what's up with requestsexceptions? I don't see any of the unit test jobs running against https://review.openstack.org/#/c/555298/ | |
| 13:28:05 | dtroyer | amotoki: the only thing I thought we should do would be a pass through the bugs and clean up obsolete ones, but IIRc all get migrated anyway so I'm not sure that is important | |
| 13:28:37 | dtroyer | amotoki: if you want to handle the migration, that would be awesome, thanks! | |
| 13:32:20 | amotoki | dtroyer: honestly I don't know what kind of tools we actually have. On obsolete bugs, I think we can look thru them even after the migration. | |
| 13:33:24 | amotoki | dtroyer: tags in storyboard looks like global (from my limited experience), but it needs to be clarified. | |
| 13:34:13 | amotoki | I only have experiences on storyboard around octavia migration. | |
| 13:34:47 | dtroyer | amotoki: sure, that is more than I have with Storyboard :) | |
| 13:40:27 | amotoki | dtroyer: from my impressions so far, it seems we have no big concern on osc migration to storyboard. | |
| 13:40:30 | amotoki | dtroyer: I can care things during migrations and discuss broader topics with mordred and/or infra team. | |
| 13:40:46 | amotoki | dtroyer: i will send a follow-up mail to the list | |
| 13:42:25 | dtroyer | amotoki: sounds good, thanks | |
| 13:42:39 | mnaser | i think the openstackclient gate is broken? | |
| 13:42:52 | mnaser | osc-functional-devstack seems to always fail | |
| 13:43:47 | amotoki | mordred: in my understanding so far, we have a tool to support migration from launchpad to storyboard, right? | |
| 13:44:25 | mnaser | it looks like creating a network segment now does not have a description of 'None' but an empty string | |
| 13:45:25 | amotoki | mordred: based on chats with dtroyer here, there is no big blocking issue to block OSC storyboard migration. the remaining thing is how we can automate it. | |
| 13:45:41 | dtroyer | mnaser: frickler chased that down yesterday to a neutron commit that is being reverted | |
| 13:47:19 | frickler | dtroyer: mnaser: yes and the revert is failing due to some stackviz issue, see current discussion in -qa | |
| 13:47:30 | dtroyer | mnaser: revert: https://review.openstack.org/#/c/555016/ | |
| 13:49:02 | mnaser | okay, awesome, thanks frickler and dtroyer :) | |
| 13:49:59 | amotoki | slaweq and me need to understand how we can prevent this kind of breakage outside of neutron. I haven't figured out the whole picture | |
| 13:50:29 | amotoki | slaweq: sorry for pinging you :( | |
| 13:50:42 | slaweq | amotoki: no problem :) | |
| 13:50:52 | amotoki | hehe | |
| 13:52:01 | mnaser | amotoki: have neutron run that devstack osc job in gate? | |
| 13:52:11 | mnaser | assuming that job is fairly stable | |
| 13:54:47 | amotoki | mnaser: no, it is not part of neutron gate jobs. | |
| 13:55:13 | amotoki | mnaser: I am checking the relationship of osc-functional-devstack and neutron repo | |
| 13:55:54 | amotoki | basically they are not related directly | |
| 13:56:45 | mnaser | this type of thing can help catch things .. aka "hi im neutron and is my change breaking osc" seems like a reasonable thing | |
| 13:57:57 | dtroyer | for a Neutron change like that to break OSC means it is an API breakage, Using osc's functional tests as API tests is one way to catch that, it could also be done with stronger API testing in Neutron | |
| 13:58:50 | dtroyer | osc's functional tests do not exercise the APIs as thoroughly as I would hope dedicated API tests would do. | |
| 14:06:25 | amotoki | as my neutron hat, I believe neutron and tempest teams expect this should be caught in tempest/neutron-tempest-plugin should catch it. | |
| 14:06:41 | amotoki | i will investigate more tomorrow | |
| 14:14:03 | SamYaple | mordred: would a "think about using openstacksdk" warning be a good thing for shade? | |
| 14:14:37 | SamYaple | ran into someone who thought the shade/openstacksdk merger was going into shade instead of openstacksdk being the place for future dev | |
| 14:16:42 | mordred | amotoki, dtroyer: oh, yes - migration to storyboard basically involves just deciding to migrate - then infra can arrange actually doing the migration | |
| 14:17:18 | mordred | amotoki, dtroyer: so if we want to migrate python-openstackclient, we can just add it to the list of repos to migrate when we migrate openstacksdk | |
| 14:17:25 | amotoki | mordred: sounds nice. | |
| 14:17:40 | mordred | SamYaple: it might not be a bad idea | |
| 14:17:53 | amotoki | mordred: as osc team, I can follow up minor things on migration of OSC | |
| 14:18:28 | mordred | amotoki: sweet! | |
| 14:20:07 | mordred | dhellmann: requestsexceptions doesn't actually have any tests (it's a very small librar that just squelches 4 useless warnings) | |
| 14:20:25 | dhellmann | mordred : ok, so we don't need a lower-constraints job for it? | |
| 14:20:26 | mordred | dhellmann: that said - looking at that patch to see what's up | |
| 14:20:36 | dhellmann | it has requirements, so... | |
| 14:20:54 | mordred | dhellmann: it only has test-requirements - and that only includes hacking | |
| 14:21:02 | dhellmann | ok. I'll abandon that patch | |
| 14:21:23 | mordred | dhellmann: cool. I love it when problems are solved by abandoning patches | |
| 14:21:40 | mordred | dhellmann: I should remove the py35,py27 envs from tox.ini ... | |
| 14:22:05 | dhellmann | my script isn't fancy enough to figure out whether tests are needed; it just makes the change to the repo | |
| 14:22:34 | mordred | dhellmann: well - I think that's the right choice for your script - things should in general have tests | |
| 14:22:45 | dhellmann | hmm, pbr is failing the py27 tests | |
| 14:22:49 | mordred | \o/ | |
| 14:22:49 | dhellmann | http://logs.openstack.org/97/555297/1/check/openstack-tox-py27/d977be1/ara/ | |
| 14:23:37 | dhellmann | and shade is failing the new lower-constraints job, so that's fun https://review.openstack.org/#/c/555299/ | |
| 14:23:52 | mordred | dhellmann: you're giving me all sorts of fun and joy today | |
| 14:24:06 | dhellmann | whee | |
| 14:24:32 | mordred | dhellmann: those are fun failures | |
| 14:24:34 | dhellmann | NoMockAddress exceptions | |
| 14:25:05 | dhellmann | does shade use a special test library for some of that? something that is maybe set too low? | |
| 14:25:15 | dhellmann | oh, those run under python 3, fwiw | |
| 14:25:24 | mordred | dhellmann: it uses requests_mock - and python3 should be fine | |
| 14:25:38 | mordred | dhellmann: I'll pull locally and see if I can figure out which thing is breaking it | |
| 14:25:43 | dhellmann | thank you | |
| 14:25:49 | mordred | dhellmann: the lower-constraints.txt is intended to be managed locally, yeah? | |
| 14:25:52 | dhellmann | yes | |
| 14:26:15 | dhellmann | there is not currently a test to verify that the values there are not higher than what is listed in requirements txt | |
| 14:26:57 | mordred | dhellmann: btw - your how-many-summits-have-I-been-to plugin is awesome | |
| 14:27:06 | dhellmann | haha | |
| 14:27:15 | dhellmann | I'm waiting for someone to notice the off-by-one error in the math | |
| 14:27:51 | mordred | dhellmann: I didn't look deeply enough to know if it allows expressing missed summits somewhere | |
| 14:28:06 | dhellmann | feature requests will be answered with commit privileges | |
| 14:28:11 | mordred | dhellmann: :) | |
| 14:28:28 | dhellmann | in fact I need to give cmurphy commit rights, since she sent a patch | |
| 14:28:47 | cmurphy | heh | |
| 14:31:04 | dhellmann | I'm trying this new thing where I instigate something and let other people finish it | |
| 14:32:10 | mordred | dhellmann: that strategy has worked pretty well for me over the years | |
| 14:32:54 | mordred | dhellmann: in fact, this last cycle I accomplished it by _saying_ I was going to do something and then doing no work on it so that cmurphy 'fixed' my buggy code - where the bug was "there is no code" | |