| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-07 | |||
| 02:44:43 | Qiming | mordred, previously, we did that in SDK using the Profile, client can do profile.set_api_version to specify a microversion for a service individually ... when the request is later sent to to keystoneauth1, we compile the microversion request into a single header by following the api-wg guideline so the server side can know better which api version is requested | |
| 02:46:47 | Qiming | mordred, these code looked to me have been changed quite a lot ... :) I don't recognize them now ... would love to hear your opinion on the way we support API microversioning. | |
| 02:49:27 | Qiming | mordred, imho, we have several things to do wrt API microversioning: 1) re-enable sdk to forward API microversion request to server; 2) better parsing of the API microversion returned (assuming the service is playing a good citizen); 3) negotiation of API microversion to send based on (explicitly) specified version request and the range returned by the server | |
| 13:11:04 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Add guidance on needing cache-control headers https://review.openstack.org/550468 | |
| 14:51:43 | olivierbourdon38 | hello everyone, any potential reviewers for some shade fixes: https://review.openstack.org/549981 https://review.openstack.org/550107 ? thx | |
| 14:57:17 | olivierbourdon38 | yes I think it should be solved now by https://review.openstack.org/550484 | |
| 14:57:24 | TheJulia | yeah | |
| 14:57:43 | olivierbourdon38 | at least from what I digged out so far | |
| 14:58:06 | TheJulia | yeah, that should be it I think | |
| 14:58:28 | TheJulia | olivierbourdon38: reviewed both patches, One I guess just needs a docstring, the other I think needs some testing | |
| 15:00:50 | olivierbourdon38 | TheJulia many thx will update accordingly | |
| 15:41:26 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981 | |
| 16:35:34 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981 | |
| 16:58:08 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Re-implement more removed novaclient bits https://review.openstack.org/550176 | |
| 16:58:08 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Convert add floating IP command to nova-net/neutron split https://review.openstack.org/550105 | |
| 18:21:59 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981 | |
| 18:24:03 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981 | |
| 18:31:30 | openstackgerrit | James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558 | |
| 19:09:58 | openstackgerrit | James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558 | |
| 19:27:50 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981 | |
| 19:55:00 | olivierbourdon38 | TheJulia fixed https://review.openstack.org/#/c/549981 adding proper testing ;-) | |
| 21:11:36 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606 | |
| 21:18:51 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Re-implement novaclient bits removed in 10.0 https://review.openstack.org/550105 | |
| 21:21:40 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606 | |
| 21:37:36 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606 | |
| 21:39:09 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107 | |
| 23:43:07 | openstackgerrit | rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646 | |
| #openstack-sdks - 2018-03-08 | |||
| 00:18:57 | openstackgerrit | rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646 | |
| 01:42:07 | openstackgerrit | James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558 | |
| 03:41:29 | openstackgerrit | rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646 | |
| 03:49:13 | openstackgerrit | James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558 | |
| 04:38:09 | openstackgerrit | shogoadachi proposed openstack/python-openstackclient master: Remove --volume and its relating options from image set command https://review.openstack.org/548212 | |
| 05:04:09 | openstackgerrit | Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107 | |
| 05:06:24 | adriant | mordred: I've found more bugs! | |
| 05:07:04 | adriant | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/role_assignments.py#L101-L122 | |
| 05:07:05 | adriant | vs | |
| 05:07:06 | adriant | https://github.com/openstack/python-openstacksdk/blob/master/openstack/identity/v3/role_assignment.py#L26-L29 | |
| 05:07:12 | adriant | We need to stick in some renames | |
| 05:07:16 | adriant | well | |
| 05:07:17 | adriant | mappings | |
| 05:08:22 | adriant | although how we can do user.id=user_id I have no clue | |
| 05:08:52 | eandersson | What is the general idea for using the openstacksdk and horizon dashboards (e.g. senlin-dashboard). Should I be using occ.OpenStackConfig? | |
| 05:09:32 | adriant | in the mean time... I'll just use the keystoneclient | |
| 05:11:04 | eandersson | I managed to get it working with something like this, but no clue if this is the path that we are meant to take http://paste.openstack.org/show/694520/ | |
| 05:15:06 | adriant | eandersson: you should be able to just do: https://github.com/openstack/python-openstacksdk/blob/master/openstack/connection.py#L78-L89 | |
| 05:15:11 | adriant | or something close | |
| 05:15:20 | eandersson | Ah nice | |
| 05:15:29 | adriant | and look at: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L271-L294 | |
| 05:15:31 | eandersson | man clustering_api_version was confusing as heck | |
| 05:16:22 | eandersson | I would have expected that to have a sane default :D | |
| 05:17:02 | adriant | eandersson: oh nvm, you're already in your example correctly pulling the data out of the request | |
| 05:17:09 | adriant | ignore my nova link :P | |
| 05:21:46 | adriant | mordred: GAH! **{'user_id': 'user.id' ...} works! | |
| 05:21:59 | adriant | it's so awful, but whatever. | |
| 05:22:19 | eandersson | I think I need to make some changes to the senlinclient to get this to work properly | |
| 05:22:31 | eandersson | https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/client.py#L21 | |
| 05:23:00 | eandersson | https://github.com/openstack/python-senlinclient/blob/master/senlinclient/plugin.py#L43 | |
| 05:23:13 | adriant | eandersson: oh, yeah the SDK has changed a ton since, you now really want to register it as a service type or something | |
| 05:23:21 | adriant | I've not yet dug into that code enough yet | |
| 05:23:40 | eandersson | It's difficult to keep things compatible | |
| 05:23:50 | eandersson | the new openstacksdk seems to break a lot for senlin | |
| 05:24:37 | adriant | I think the choice was made to break things before v1.0 in an effort to then never have to break anything as badly afterwards | |
| 05:25:00 | adriant | which, is a pain, but it makes prefect sense | |
| 05:25:01 | eandersson | v1.0 was that part of queens? | |
| 05:25:10 | adriant | not yet I don't believe | |
| 05:25:24 | adriant | we just hit 0.12.0 | |
| 05:25:58 | eandersson | I see running 0.11.3 in my devstack at the moment | |
| 05:26:38 | adriant | https://github.com/openstack/python-openstacksdk/releases | |
| 05:26:52 | adriant | 0.11.3 was the last one | |
| 05:27:07 | adriant | 0.12.0 is 2 days old :P | |
| 05:27:16 | eandersson | Keep hitting obscure incompatibility errors that get eaten up | |
| 05:27:30 | eandersson | > name = urllib.parse.urlparse(authenticator.auth_url).hostname | |
| 05:27:30 | eandersson | The worst one is from this line | |
| 05:28:12 | eandersson | Many code paths lead here with authenticator being set to None | |
| 05:29:56 | eandersson | Since before 0.10, authenticator was set automatically | |
| 05:31:50 | eandersson | Actually, think I will just pass on the authenticator for now | |
| 05:32:17 | eandersson | Since I feel like the senlinclient needs to be fixed (or cleaned up) before the new route makes snese | |
| 05:32:53 | eandersson | I assume I can just pass on a keystoneauth1 Token right? | |
| 05:43:01 | adriant | mordred: nvm... I'm silly. I can just do: role_id="role.id" for some reason I suddenly thought it was the other way around... | |
| 05:48:54 | eandersson | This works with both openstacksdk 0.9.x and 0.10.x http://paste.openstack.org/show/694585/ | |
| 05:49:11 | eandersson | adriant, does this make sense? ^ | |
| 05:53:25 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Redo role assignment list query filters https://review.openstack.org/550700 | |
| 05:53:38 | adriant | eandersson: and fails with 0.11.3+ ? | |
| 05:54:52 | eandersson | Sorry I meant that it works with 0.9.x and 0.10.x and 0.11.x | |
| 05:55:04 | eandersson | The previous code did not, as there was no authenticator passed on | |
| 05:55:41 | adriant | eandersson: what module is senlin_client exactly? | |
| 05:55:48 | adriant | trying to find it in the senlinclient code | |
| 05:56:15 | adriant | eandersson" https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/client.py#L18 ? | |
| 05:56:22 | eandersson | Yep | |
| 05:56:31 | eandersson | https://github.com/openstack/python-senlinclient/blob/master/senlinclient/plugin.py#L29 | |
| 05:56:46 | eandersson | Basically it still uses the deprecated profile | |
| 05:56:59 | eandersson | the problem with profile after 0.10 and newer is that you now need to pass an authenticator | |
| 05:57:19 | adriant | oh, but if you pass through the authenticator as a kwarg it works | |
| 05:57:25 | adriant | yeah, that makes sense | |
| 05:57:45 | eandersson | I feel like the authenticator should still be passed on until profile has been removed :p | |
| 05:57:56 | eandersson | I mean for the openstacksdk | |
| 05:59:12 | adriant | eandersson: so wait... the senlin client uses the cluster service in the sdk? | |
| 05:59:21 | adriant | why not just use the SDK directly? | |
| 05:59:33 | eandersson | good question | |
| 05:59:40 | eandersson | probably legacy code :D | |