Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-03-05
15:33:40 TheJulia The consensus with nova -> ironic was to just migrate to rest calls where we are not using the client library for ironic, so we’re better able to navigate api version issues. Explicitly not use the SDK, fwiw.
15:34:07 TheJulia As the behaviors/needs are different
15:37:29 dtroyer TheJulia: exactly and thank you.
15:37:50 dtroyer I wish I could remember who it was talking about that...
15:39:52 TheJulia There was some other chatter, but I realize my preference to just do rest calls is heavily influenced by experience of pain.
16:18:46 openstackgerrit Tobias Brox proposed openstack-infra/shade master: Allow grant_role to select users in a different domain https://review.openstack.org/549744
16:39:12 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Re-implement more removed novaclient bits https://review.openstack.org/549813
16:40:00 dtroyer mordred: ^^^ is the os-hosts bit, it still needs tests for the zpi.compute_v2 methods but I'm landing and wanted to see if functional tests pass
16:54:36 openstackgerrit Andrey Kurilin proposed openstack/python-openstackclient master: Rework "openstack server add floating ip" cmd https://review.openstack.org/549820
20:19:13 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: WIP: Example of converting floating IP command to nova-net/neutron split https://review.openstack.org/549864
20:21:25 dtroyer mordred: ^^^^ is an example that leverages the bits we already have done for switching between nova-net and neutron implementations
22:10:22 jamielennox dtroyer: i miss our pow-wows as well, sad i missed it
#openstack-sdks - 2018-03-06
05:30:32 Qiming mordred, the API microversioning is broken in SDK? We were passing OpenStack-API-Version headers properly before, but in recent versions, the header is gone ...
06:54:42 openstackgerrit Kairat Kushaev proposed openstack/keystoneauth master: use defusedxml for XML parsing https://review.openstack.org/536761
09:03:35 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
14:32:33 openstackgerrit Corey Bryant proposed openstack/cliff master: Align parsed() call with cmd2 versions >= 0.7.3 https://review.openstack.org/548625
14:39:16 mordred Qiming: keystoneauth should be passing the version headers for any place where we've requested a microversion ... but to my knowledge we're not currently negotiating any microversions ... can you tell me more about a place where we should be sending a microversion?
14:40:54 slaweq mordred: hi
14:41:47 slaweq mordred: do You know maybe why I don't have possibility to give +2/-2 and W+1 in python-openstacksdk anymore?
14:42:03 slaweq mordred: did You remove me maybe from core group for this project?
14:42:58 slaweq mordred: for example here: https://review.openstack.org/#/c/549474/ I can give only +1 and -1
14:44:10 mordred slaweq: ah! I put up a project-config change to make an openstacksdk team that was applied to all the correct repos - I'm guessing it landed - I need to go add people to it ... one sec
14:44:38 slaweq mordred: sure, I just though that I wasn't good enough and You removed me :)
14:45:01 slaweq and I was little bit sad because of that :(
14:47:23 mordred slaweq: done!
14:47:36 mordred slaweq: no - defintely not :)
14:47:46 slaweq mordred: thx, now I have +2 again :)
14:47:50 mordred \o/
15:01:04 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: WIP: Example of converting floating IP command to nova-net/neutron split https://review.openstack.org/550105
15:01:57 dtroyer mordred: ^^^ what 12 hours of travel without $DAY_JOB email gets
15:07:14 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107
15:23:05 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Default --nic to 'auto' if creating a server with >= 2.37 https://review.openstack.org/545946
15:33:40 openstackgerrit Corey Bryant proposed openstack/cliff master: Align parsed() call with cmd2 versions >= 0.7.3 https://review.openstack.org/548625
16:39:50 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107
16:59:47 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Provide a helper method to get headers from environ https://review.openstack.org/495356
16:59:48 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Import functions from placement https://review.openstack.org/496212
17:28:07 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Re-implement more removed novaclient bits https://review.openstack.org/550176
17:28:07 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Convert add floating IP command to nova-net/neutron split https://review.openstack.org/550105
20:49:09 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252
20:49:09 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251
21:22:40 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263
21:22:41 openstackgerrit Chris Dent proposed openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264
#openstack-sdks - 2018-03-07
02:44:43 Qiming mordred, previously, we did that in SDK using the Profile, client can do profile.set_api_version to specify a microversion for a service individually ... when the request is later sent to to keystoneauth1, we compile the microversion request into a single header by following the api-wg guideline so the server side can know better which api version is requested
02:46:47 Qiming mordred, these code looked to me have been changed quite a lot ... :) I don't recognize them now ... would love to hear your opinion on the way we support API microversioning.
02:49:27 Qiming mordred, imho, we have several things to do wrt API microversioning: 1) re-enable sdk to forward API microversion request to server; 2) better parsing of the API microversion returned (assuming the service is playing a good citizen); 3) negotiation of API microversion to send based on (explicitly) specified version request and the range returned by the server
13:11:04 openstackgerrit Chris Dent proposed openstack/api-wg master: Add guidance on needing cache-control headers https://review.openstack.org/550468
14:51:43 olivierbourdon38 hello everyone, any potential reviewers for some shade fixes: https://review.openstack.org/549981 https://review.openstack.org/550107 ? thx
14:57:17 olivierbourdon38 yes I think it should be solved now by https://review.openstack.org/550484
14:57:24 TheJulia yeah
14:57:43 olivierbourdon38 at least from what I digged out so far
14:58:06 TheJulia yeah, that should be it I think
14:58:28 TheJulia olivierbourdon38: reviewed both patches, One I guess just needs a docstring, the other I think needs some testing
15:00:50 olivierbourdon38 TheJulia many thx will update accordingly
15:41:26 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
16:35:34 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
16:58:08 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Re-implement more removed novaclient bits https://review.openstack.org/550176
16:58:08 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Convert add floating IP command to nova-net/neutron split https://review.openstack.org/550105
18:21:59 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
18:24:03 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
18:31:30 openstackgerrit James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558
19:09:58 openstackgerrit James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558
19:27:50 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add proper return value for validate_node https://review.openstack.org/549981
19:55:00 olivierbourdon38 TheJulia fixed https://review.openstack.org/#/c/549981 adding proper testing ;-)
21:11:36 openstackgerrit Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606
21:18:51 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Re-implement novaclient bits removed in 10.0 https://review.openstack.org/550105
21:21:40 openstackgerrit Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606
21:37:36 openstackgerrit Monty Taylor proposed openstack-infra/shade master: DNM testing building some things on some nodes https://review.openstack.org/550606
21:39:09 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107
23:43:07 openstackgerrit rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646
#openstack-sdks - 2018-03-08
00:18:57 openstackgerrit rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646
01:42:07 openstackgerrit James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558
03:41:29 openstackgerrit rarm nagalingam proposed openstack-infra/shade master: Adds toggle port security on network create https://review.openstack.org/550646
03:49:13 openstackgerrit James Denton proposed openstack/python-openstacksdk master: Adds prefixlen to the request body when creating subnets https://review.openstack.org/550558
04:38:09 openstackgerrit shogoadachi proposed openstack/python-openstackclient master: Remove --volume and its relating options from image set command https://review.openstack.org/548212
05:04:09 openstackgerrit Olivier Bourdon proposed openstack-infra/shade master: Add extra failure codes to bad request exception https://review.openstack.org/550107
05:06:24 adriant mordred: I've found more bugs!
05:07:04 adriant https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/role_assignments.py#L101-L122
05:07:05 adriant vs
05:07:06 adriant https://github.com/openstack/python-openstacksdk/blob/master/openstack/identity/v3/role_assignment.py#L26-L29
05:07:12 adriant We need to stick in some renames
05:07:16 adriant well
05:07:17 adriant mappings
05:08:22 adriant although how we can do user.id=user_id I have no clue
05:08:52 eandersson What is the general idea for using the openstacksdk and horizon dashboards (e.g. senlin-dashboard). Should I be using occ.OpenStackConfig?
05:09:32 adriant in the mean time... I'll just use the keystoneclient
05:11:04 eandersson I managed to get it working with something like this, but no clue if this is the path that we are meant to take http://paste.openstack.org/show/694520/
05:15:06 adriant eandersson: you should be able to just do: https://github.com/openstack/python-openstacksdk/blob/master/openstack/connection.py#L78-L89
05:15:11 adriant or something close
05:15:20 eandersson Ah nice
05:15:29 adriant and look at: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L271-L294
05:15:31 eandersson man clustering_api_version was confusing as heck
05:16:22 eandersson I would have expected that to have a sane default :D
05:17:02 adriant eandersson: oh nvm, you're already in your example correctly pulling the data out of the request
05:17:09 adriant ignore my nova link :P
05:21:46 adriant mordred: GAH! **{'user_id': 'user.id' ...} works!
05:21:59 adriant it's so awful, but whatever.
05:22:19 eandersson I think I need to make some changes to the senlinclient to get this to work properly
05:22:31 eandersson https://github.com/openstack/python-senlinclient/blob/master/senlinclient/v1/client.py#L21
05:23:00 eandersson https://github.com/openstack/python-senlinclient/blob/master/senlinclient/plugin.py#L43
05:23:13 adriant eandersson: oh, yeah the SDK has changed a ton since, you now really want to register it as a service type or something

Earlier   Later