Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-02-23
14:00:44 mardim I will +1
14:01:26 Shrews i still need a release note for it
14:01:46 mardim Shrews, I agree yes
14:11:05 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
14:37:01 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
14:37:19 Shrews seems there is no heat equivalent to "no timeout"
14:37:32 Shrews None just uses the heat default value
14:49:11 mordred Shrews: that patch lgtm
14:49:48 Shrews w00t
15:36:41 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run normalize_keys on config for session codepath https://review.openstack.org/547159
15:55:06 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove the need for OpenStackConfig in CloudRegion https://review.openstack.org/547488
15:59:10 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
16:01:37 mordred slaweq, Qiming_, Shrews : ^^ that patch is inspired by https://review.openstack.org/#/c/547372 ... what do you think?
16:02:32 mordred slaweq, rods_: also, https://review.openstack.org/#/c/547430/ from Shrews is an easy +A
16:05:16 Shrews mordred: ++ to any code de-dupe
18:21:19 openstackgerrit OpenStack Release Bot proposed openstack/keystoneauth master: Update reno for stable/newton https://review.openstack.org/547595
18:24:59 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
18:26:00 mordred Shrews, slaweq, rods_, SamYaple: if you get a sec, https://review.openstack.org/#/c/547159 fixes an issue that adriant uncovered
18:39:23 slaweq_ mordred: done
18:39:35 mordred slaweq_: thanks!
18:40:53 mordred slaweq_: oh - good catch
18:43:05 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run normalize_keys on config for session codepath https://review.openstack.org/547159
18:43:11 mordred slaweq_: fixed
18:44:42 slaweq_ mordred: no problem, +2 already, thx
19:21:29 Shrews mordred: left a question
19:22:41 mordred Shrews: good question - left response (tl;dr yes, intentional. normalize gets run on the config parameter in the CloudRegion constructor now)
20:27:23 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add project tags functionality https://review.openstack.org/481284
20:30:54 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add support for "--dns-domain" argument https://review.openstack.org/500450
20:37:01 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add support for endpoint group commands https://review.openstack.org/520627
21:29:38 openstackgerrit Brianna Poulos proposed openstack/python-openstackclient master: Update help text for encryption provider https://review.openstack.org/545459
22:21:22 adriant mordred: not a bug, but something we should do a sweep for at some stage, a bunch of resources are missing query options. I know I just got hit by some of that with Nova servers.
22:22:05 adriant as painful as it sounds, we should go through the API refs.... and then update he resources based on the serverside query options
22:22:10 adriant the*
22:23:54 adriant and we're missing stuff like https://developer.openstack.org/api-ref/compute/#list-hypervisor-servers
22:27:41 adriant although that latter one I can't even seem to find in the novaclient
22:31:44 adriant for context, i'm trying to list servers on a given hypervisor. filter by host with sdk doesn't work, nor with novaclient, but I can filter by 'node' with nova client, which the sdk doesn't have as a valid filter. Chances are the old version of nova I'm testing against is missing queries, but it's still odd.
22:41:43 adriant yeah, if I add 'node' as a query option to the server model it works
22:46:37 adriant mordred: I feel like I'm always coming to you with problems :P
22:48:42 adriant i'll submit some patches for the missing nova query params at least hopefully in the next day or two, and depending on my time I may start comparing our query params to the api refs and see what we've missed.
23:52:18 adriant oh, ok, so yes those servers and search paths for hypervisors are deprecated, and now you can do that with extra query values on list and get. which we don't have in the SDK yet.
#openstack-sdks - 2018-02-24
02:08:21 openstackgerrit Merged openstack/python-openstacksdk master: Add support for dns-domain https://review.openstack.org/500660
02:50:33 openstackgerrit Merged openstack/keystoneauth master: Override support message in AuthorizationFailure class https://review.openstack.org/539166
03:55:49 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Remove duplicated network attributes https://review.openstack.org/547703
08:16:08 frickler mordred: dtroyer: thx for the fast reviews, https://review.openstack.org/500450 needs another +w after dependency got merged it seems
08:18:43 frickler hmm, maybe it was because of the zuul restart, will try a recheck
09:11:53 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add dns-domain support to Network object https://review.openstack.org/516701
09:15:27 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
10:59:42 openstackgerrit Merged openstack/python-openstackclient master: Add support for "--dns-domain" argument https://review.openstack.org/500450
14:59:03 openstackgerrit Merged openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
15:45:43 openstackgerrit Andreas Jaeger proposed openstack/python-openstacksdk master: Fix coverage running https://review.openstack.org/547761
15:51:28 openstackgerrit Andreas Jaeger proposed openstack/python-openstacksdk master: Fix coverage running https://review.openstack.org/547761
#openstack-sdks - 2018-02-25
01:05:17 openstackgerrit Merged openstack/python-openstackclient master: Add project tags functionality https://review.openstack.org/481284
01:05:20 openstackgerrit Merged openstack/python-openstackclient master: Add support for endpoint group commands https://review.openstack.org/520627
01:34:11 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for QoS policy https://review.openstack.org/547372
01:38:46 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for security group https://review.openstack.org/547369
01:43:01 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for floating ip https://review.openstack.org/547366
01:55:30 openstackgerrit Merged openstack/python-openstacksdk master: Fix coverage running https://review.openstack.org/547761
03:33:46 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Network: Add tag support for security group https://review.openstack.org/547369
06:31:44 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
10:03:46 openstackgerrit Merged openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
11:36:55 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: [WIP] Network: Add tag support for QoS policy https://review.openstack.org/547810
17:13:35 SamYaple adriant: painful or not, going through the api-ref is a good idea. its how i added a chunk of the keystone stuff in shade. would love to see all apis options implemented and validated in the sdk
21:29:47 adriant SamYaple: Yeah, I think it needs to be done. I'd put my hand up to do it, but I doubt I'd get the time to do it any time soon :(
21:43:26 SamYaple i definetely cant lead the work at this time, but someone could put me down to do some of it if we wanted to split it up
22:25:45 adriant SamYaple: I'm at least going to try and do Nova in the next week or two.
#openstack-sdks - 2018-02-26
08:58:13 mordred adriant: heya - sorry, was travelling - reading scrollback now
08:58:30 adriant mordred: you didn't miss much
09:00:45 mordred ah - yes - *definitely* need more query params from api-ref
09:01:00 mordred the ruby folks have been actually parsing the api-ref and generating code from it ...
09:01:19 mordred perhaps we should write a script or something to do a similar thing and update all of the resources ...
09:01:45 mordred adriant: "extra query values on list and get" - what's what?
09:04:10 adriant mordred: could do, just a tool to parse and compare what we have an what is expected.
09:04:28 adriant mordred: also, not quite parsing your last comment there :P What do you mean?
09:10:04 mordred adriant: oh, you said "oh, ok, so yes those servers and search paths for hypervisors are deprecated, and now you can do that with extra query values on list and get. which we don't have in the SDK yet."
09:10:44 adriant oh, shit ok let me now parse what the hell I was saying with that
09:10:53 mordred adriant: OH! - wait
09:10:55 mordred I think I get it
09:11:49 adriant me too... yeah, if you do /hypervisors?servers=true you get the servers on each hypervisor
09:11:52 mordred there was /os-hypervisors/{hypervisor}/servers is deprecated and
09:11:54 mordred yah
09:12:12 mordred this is actually a good example of a microversion difference
09:12:17 adriant rather than /hypervisor/<id>/servers or whatever
09:12:37 mordred for us to figure out how to express in a way that isn't *super* crazy
09:14:58 adriant does the sdk do any microversion stuff?
09:15:05 adriant I didn't think it did yet
09:15:17 adriant I think the nova client kind of does
09:20:50 mordred oh - novaclient definitely does - it defaults to latest microversion when you use nova cli
09:21:32 mordred sdk doesn't do them yet on any proxy calls - but the underlying Proxy/Adapter class supports them, so we can pass them in impl code when we need to
09:25:44 mordred this thing seems like a good first candidate to add - that and I wanna add 'get-me-a-network' support (in get-me-a-network I think sdk should emulate it for older clouds that donm' thave that microversion
09:37:31 mordred adriant: can you pass ?hypervisor_hostname_pattern and ?with_servers before 2.53 and 2.53 just deprecates the /hypervisor/<id>/servers ? or it's two different ways to do the same thing I'm guessing
09:39:27 adriant mordred: I'm not really sure, I know dug into that because some code I had to rewrite was doing the older calls (against an old version of nova) and I had to make it marginally less awful
09:39:46 adriant I now* dug into
09:40:03 adriant it looks like different ways of doing the same thing
09:40:52 mordred nod
09:45:19 mordred adriant: maybe we should add a list_hypervisors_by_server or something, so we can do "if microversion_2.53_available: return self.get('/os-hypervisors/foo/servers') else: return self.hypervisors(with_servers=foo)
09:45:39 adriant mordred: that would work
09:46:12 mordred adriant: alternately, we could just look to see if hypervisor_hostname_pattern and with_servers have been given to hypervisors() and do the logic there
09:46:59 adriant mordred: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/hypervisors.py#L86
09:47:28 adriant ^ your first suggestion is pretty much how novaclient does it
09:47:41 mordred that might be better ... since that would be more in keeping with the shape of the 'modern' version of the API - with calling the

Earlier   Later