Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-02-22
23:01:53 adriant that's amusing
23:05:42 adriant mordred: clean venv, both py2 and py3 cause me the same issue :(
23:07:02 adriant its a minor enough thing though that it probably isn't worth chasing
23:07:26 adriant although I'll admit I'm curious what's the cause
23:08:06 mordred yah. I worry something is wrong at a deeper level - I'm going to try with oi this time
#openstack-sdks - 2018-02-23
00:21:10 mordred adriant: WOOT - found it
00:22:02 adriant mordred: what was it? :P
00:23:19 mordred adriant: the code in oi is passing in an authenticated session, which is a different codepath than I was using in that test. (that's why I didn't get a failure) the underlying issue is that in session codepath the normalize_keys function is not getting called - which is where the stringificatoin of the values happens
00:24:13 adriant ah! that makes sense, and further useful fixes to the session codepath (which I do care about ;))
00:29:31 mordred ++
00:39:58 mordred adriant: https://review.openstack.org/547225 Run normalize_keys on config for session codepath <-- that should fix it
00:42:49 adriant woo!
08:04:38 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for floating ip https://review.openstack.org/547316
09:01:36 openstackgerrit Jose Castro Leon proposed openstack/python-openstackclient master: Add support for endpoint group commands https://review.openstack.org/520627
09:33:38 spredzy .close
10:37:45 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for floating ip https://review.openstack.org/547366
10:48:57 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for security group https://review.openstack.org/547369
10:52:35 mardim hello
10:52:46 mardim is this the channel of openstack shade project
10:52:47 mardim ?
10:57:53 openstackgerrit Dongcan Ye proposed openstack/python-openstacksdk master: Network: Add tag support for QoS policy https://review.openstack.org/547372
10:58:50 mardim mordred, Hello I think I am hitting a bug here what do you think : https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L1317
10:59:19 mardim mordred, the error is TypeError: unsupported operand type(s) for //: 'NoneType' and 'int'
11:39:18 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstacksdk master: Add support for dns-domain https://review.openstack.org/500660
11:52:43 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add support for "--dns-domain" argument https://review.openstack.org/500450
12:18:38 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add dns-domain support to Network object https://review.openstack.org/516701
12:22:51 frickler mardim: are you explicitly setting "timeout=None" in your call? otherwise I don't see how this could happen
12:28:16 openstack Launchpad bug 1751251 in OpenStack SDK "Openstack-infra Shade project TypeError" [Undecided,New]
12:28:16 mardim frickler, hello I think is typo I opened a bug : https://bugs.launchpad.net/python-openstacksdk/+bug/1751251
12:28:35 mardim frickler, Maybe this helps you to understand what I mean ^
12:44:55 frickler mardim: can you please add detailed steps how to reproduce the exception?
13:16:29 mardim frickler, To be honest I am not sure how to reproduce the error because I am meeting this bug when I execute some yardstick testcases and that's because OPNFV yardstick
13:16:56 mardim project uses the Shade to create heat Stacks
13:18:05 mardim But I think in general if you find a way yo call the create_stack function the you will hit the error
13:18:33 mardim because when I deleted the '// 60 ' by hand in the code evreything worked
13:18:39 mardim so I think this is the problem
13:26:33 frickler mardim: well, changing the code masks the issue but changes the effect of the timeout parameter in an incompatible way. the "//" is a valid operator on integers and the timeout parameter is explicitly specified as being an int, so the exception you are showing very likely is caused by an illegal caller
13:27:06 frickler mardim: the default value for timeout is 3600, too
13:28:00 mardim frickler, hmm ok let me check something
13:32:49 Shrews well, yes, the error seems to be with the caller, but in other API calls, we let timeout=None mean forever, so i think mardim has found a valid issue we should fix
13:57:34 mardim frickler, Shrews Guys you were right the problem is on the caller
13:57:44 mardim you can delete the bug report if you want
13:58:06 Shrews mardim: i think we should still allow for None values
13:58:19 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
13:58:30 Shrews see ^^^
13:58:38 Shrews just trying to confirm that None means "no timeout"
13:58:46 Shrews in heat
13:59:51 Shrews i don't know heat at all, so waiting for a response from one of the devs
14:00:39 mardim Shrews, I am not expert of Heat either but nevertheless I agree with your patch
14:00:44 mardim I will +1
14:01:26 Shrews i still need a release note for it
14:01:46 mardim Shrews, I agree yes
14:11:05 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
14:37:01 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for timeout=None in orchestration API calls https://review.openstack.org/547430
14:37:19 Shrews seems there is no heat equivalent to "no timeout"
14:37:32 Shrews None just uses the heat default value
14:49:11 mordred Shrews: that patch lgtm
14:49:48 Shrews w00t
15:36:41 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run normalize_keys on config for session codepath https://review.openstack.org/547159
15:55:06 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove the need for OpenStackConfig in CloudRegion https://review.openstack.org/547488
15:59:10 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
16:01:37 mordred slaweq, Qiming_, Shrews : ^^ that patch is inspired by https://review.openstack.org/#/c/547372 ... what do you think?
16:02:32 mordred slaweq, rods_: also, https://review.openstack.org/#/c/547430/ from Shrews is an easy +A
16:05:16 Shrews mordred: ++ to any code de-dupe
18:21:19 openstackgerrit OpenStack Release Bot proposed openstack/keystoneauth master: Update reno for stable/newton https://review.openstack.org/547595
18:24:59 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
18:26:00 mordred Shrews, slaweq, rods_, SamYaple: if you get a sec, https://review.openstack.org/#/c/547159 fixes an issue that adriant uncovered
18:39:23 slaweq_ mordred: done
18:39:35 mordred slaweq_: thanks!
18:40:53 mordred slaweq_: oh - good catch
18:43:05 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run normalize_keys on config for session codepath https://review.openstack.org/547159
18:43:11 mordred slaweq_: fixed
18:44:42 slaweq_ mordred: no problem, +2 already, thx
19:21:29 Shrews mordred: left a question
19:22:41 mordred Shrews: good question - left response (tl;dr yes, intentional. normalize gets run on the config parameter in the CloudRegion constructor now)
20:27:23 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add project tags functionality https://review.openstack.org/481284
20:30:54 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add support for "--dns-domain" argument https://review.openstack.org/500450
20:37:01 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add support for endpoint group commands https://review.openstack.org/520627
21:29:38 openstackgerrit Brianna Poulos proposed openstack/python-openstackclient master: Update help text for encryption provider https://review.openstack.org/545459
22:21:22 adriant mordred: not a bug, but something we should do a sweep for at some stage, a bunch of resources are missing query options. I know I just got hit by some of that with Nova servers.
22:22:05 adriant as painful as it sounds, we should go through the API refs.... and then update he resources based on the serverside query options
22:22:10 adriant the*
22:23:54 adriant and we're missing stuff like https://developer.openstack.org/api-ref/compute/#list-hypervisor-servers
22:27:41 adriant although that latter one I can't even seem to find in the novaclient
22:31:44 adriant for context, i'm trying to list servers on a given hypervisor. filter by host with sdk doesn't work, nor with novaclient, but I can filter by 'node' with nova client, which the sdk doesn't have as a valid filter. Chances are the old version of nova I'm testing against is missing queries, but it's still odd.
22:41:43 adriant yeah, if I add 'node' as a query option to the server model it works
22:46:37 adriant mordred: I feel like I'm always coming to you with problems :P
22:48:42 adriant i'll submit some patches for the missing nova query params at least hopefully in the next day or two, and depending on my time I may start comparing our query params to the api refs and see what we've missed.
23:52:18 adriant oh, ok, so yes those servers and search paths for hypervisors are deprecated, and now you can do that with extra query values on list and get. which we don't have in the SDK yet.
#openstack-sdks - 2018-02-24
02:08:21 openstackgerrit Merged openstack/python-openstacksdk master: Add support for dns-domain https://review.openstack.org/500660
02:50:33 openstackgerrit Merged openstack/keystoneauth master: Override support message in AuthorizationFailure class https://review.openstack.org/539166
03:55:49 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Remove duplicated network attributes https://review.openstack.org/547703
08:16:08 frickler mordred: dtroyer: thx for the fast reviews, https://review.openstack.org/500450 needs another +w after dependency got merged it seems
08:18:43 frickler hmm, maybe it was because of the zuul restart, will try a recheck
09:11:53 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add dns-domain support to Network object https://review.openstack.org/516701
09:15:27 openstackgerrit Dongcan Ye proposed openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
10:59:42 openstackgerrit Merged openstack/python-openstackclient master: Add support for "--dns-domain" argument https://review.openstack.org/500450
14:59:03 openstackgerrit Merged openstack/python-openstacksdk master: Shift tag resource definition to TagMixin https://review.openstack.org/547489
15:45:43 openstackgerrit Andreas Jaeger proposed openstack/python-openstacksdk master: Fix coverage running https://review.openstack.org/547761
15:51:28 openstackgerrit Andreas Jaeger proposed openstack/python-openstacksdk master: Fix coverage running https://review.openstack.org/547761

Earlier   Later