| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-01-22 | |||
| 17:56:31 | openstackgerrit | Merged openstack/python-openstackclient master: Check that Glance returns image data before processing it https://review.openstack.org/531201 | |
| 17:56:32 | openstackgerrit | Merged openstack/python-openstackclient master: Replace assert with condition https://review.openstack.org/536300 | |
| 17:56:59 | mordred | old saharaclient should work since it's got v1/project-id in the catalog like it expects, and old client will still send project-id in urls to saraha which will continue to work | |
| 17:57:09 | openstackgerrit | Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/535769 | |
| 17:57:51 | jeremyfreudberg | mordred, alright, i guess i'm convinced | |
| 17:57:55 | mordred | I think what can be gained by making project-id in the url optional is that a user with an updated saharaclient could use v1 on a catalog with unversioned endpoint as well | |
| 17:58:41 | mordred | NOW - other options would be to update saharaclient to pre-pend project-ids for v1 if it does't have them already - your API docs already indicate project-id is a required part of the API call | |
| 17:59:21 | mordred | that would also get you people being able to use unversioned catalog endpoints with newer saharaclient | |
| 17:59:48 | mordred | and non-python things are going to need to deal with unversioned endpoints to be ableto consume those *anyway* | |
| 18:01:05 | mordred | so the biggest issue with doing appending in saharaclient itself would be, amusingly enough, python consumers who are using ksa but not python-saharaclient | |
| 18:01:20 | mordred | (like openstacksdk) | |
| 18:01:26 | jeremyfreudberg | mordred: right | |
| 18:01:45 | jeremyfreudberg | ok, so i guess making project-id optional on the server-side is the best way forward | |
| 18:02:06 | mordred | yah- I think it enables the largest number of people | |
| 18:02:46 | mordred | we could also talk to cdent and edleafe and elmiko about adding an optional field to the version discovery document specification | |
| 18:03:21 | mordred | so that a discovery doc with an endpoint could have an optional field 'requires-project-id' | |
| 18:03:34 | jeremyfreudberg | mordred: yes, i was thinking of that too, to extend version discovery (and have keystoneauth understand those new extensions), but i'm also assuming that situations like Sahara's are only getting rarer as time goes on | |
| 18:03:40 | jeremyfreudberg | so it might be a lot of work for nothing | |
| 18:03:49 | mordred | and we could update the consumption docs and ksa to look for that field and know to append a project id to any endpoint it finds that has that field | |
| 18:04:29 | mordred | jeremyfreudberg: yah. it might be - otoh, I haven't looked to see how many services we have in a similar place to where sahara is now ... | |
| 18:05:21 | mordred | and if we made it a systemic flag like that, we could update things at a base layer in ksa, gophercloud, fog, etc and then people wouldn't necessarily need sahara-specific logic in base clients | |
| 18:05:33 | mordred | like - maybe it's a one-two punch | |
| 18:06:19 | mordred | do 'make project-id optional for sahara v1' and also look in to adding an optional field to version docs and getting base clients updated to understand it | |
| 18:06:42 | jeremyfreudberg | indeed | |
| 18:06:50 | mordred | it wouldn't be much work to add to ksa or to add to the version spec (other than bikshedding of course) | |
| 18:07:32 | mordred | cdent, elmiko, edleafe: ^^ any thoughts on that? | |
| 18:08:15 | edleafe | mordred: current heads-down on placement, with feature freeze this week | |
| 18:08:49 | mordred | edleafe: kk. I guess that's important :) | |
| 18:09:43 | edleafe | :) | |
| 18:09:48 | jeremyfreudberg | mordred: i agree it's not too much work. and happy to have contributed to circumstances that lead to its inspiration | |
| 18:09:53 | jeremyfreudberg | should be interesting to see if it goes somewhere | |
| 18:17:00 | elmiko | mordred: about to leave for the airport, but i'll catch up on the plane | |
| 18:19:04 | cdent | mordred, jeremyfreudberg : nova made it optional but I don't recall the details on how that was managed service catalog or version-wise. sdague will probably know | |
| 18:19:18 | cdent | my preference would be to _not_ add something to version discovery | |
| 18:19:53 | cdent | but then I have a pathalogical problem with project id in uris | |
| 18:20:05 | cdent | (except where they actually mean something) | |
| 18:23:39 | mordred | cdent: yah - I think we're all in strong agreement about them going away (except where they mean something) | |
| 18:24:22 | mordred | cdent: I *think* nova just made them optional, and then over a period of time convinced people to stop putting them into catalog entries | |
| 18:26:15 | cdent | mordred: I would fear that if we make it easy and non-painful to keep them around, then they'll stay around. Which is unfriendly of me, but I can't. be friendly _all_ the time. | |
| 18:27:54 | mordred | cdent: I reject that premise. you're always friendly :) | |
| 18:31:09 | jeremyfreudberg | mordred: thanks again. i'll ping you again if needed (but it looks like we're good) | |
| 19:15:26 | sdague | it was made optional but deprecated. There is a microversion used for signaling that the code can support it | |
| 19:27:24 | openstackgerrit | Merged openstack/os-api-ref master: Remove name from project stanza https://review.openstack.org/536126 | |
| 20:05:18 | openstackgerrit | Slawek Kaplonski proposed openstack/python-openstacksdk master: Make floating IP to be prefered over fixed when looking for IP https://review.openstack.org/536548 | |
| 20:11:54 | openstackgerrit | Slawek Kaplonski proposed openstack/python-openstacksdk master: Make meta.find_best_address() more generic https://review.openstack.org/536553 | |
| 20:14:58 | slaweq | mordred: hi, ^^ two cherry-picks from shade to openstacksdk | |
| 20:15:13 | slaweq | mordred: it was as easy as You said me earlier :) thx | |
| 20:16:06 | mordred | slaweq: woot! | |
| 20:16:38 | mordred | slaweq: there's also a topic i've been using 'merge-shade' - and a few outstanding patches we should make sure get in | |
| 20:17:15 | slaweq | ok, I will change topic then | |
| 20:49:31 | openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Add system role functionality https://review.openstack.org/524416 | |
| 20:54:07 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Raise error when supplying invalid query params https://review.openstack.org/532723 | |
| 22:51:39 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Rework Network client config for new SDK Connection https://review.openstack.org/524715 | |
| 22:52:34 | mordred | dtroyer: could I impose upon you to +A https://review.openstack.org/#/c/524991/ ? | |
| 22:52:59 | mordred | dtroyer: I'm trying to get the osc-tips jobs added to openstacksdk which kind of fell off the radar a bit | |
| 22:56:30 | mordred | amotoki, dhellmann: also, if either of you have a sec to +A a patch from dtroyer ... https://review.openstack.org/#/c/524715 | |
| 22:56:30 | openstackgerrit | Ihar Hrachyshka proposed openstack/python-openstacksdk master: DNM testing whether lib/neutron switch breaks this repo https://review.openstack.org/535943 | |
| 23:00:25 | mordred | RuiChen: you too re: 524715 | |
| 23:07:33 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Add CRUD support for application credentials https://review.openstack.org/536163 | |
| 23:13:03 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Add CRUD support for application credentials https://review.openstack.org/536163 | |
| 23:14:44 | mordred | adriant: fyi - the test failure you're seeing on your patch is not related to your patch | |
| 23:16:08 | adriant | mordred: I gathered. I'm just keeping it rebased out of habit. | |
| 23:16:12 | mordred | adriant: it should be fixed by https://review.openstack.org/#/c/533823 - although now that one has a super-fun error about invalid gateways | |
| 23:16:16 | mordred | adriant: ++ | |
| 23:29:06 | openstackgerrit | Merged openstack/python-openstacksdk master: Fix releasenotes builds https://review.openstack.org/536056 | |
| #openstack-sdks - 2018-01-23 | |||
| 01:36:08 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove inner_exceptions plumbing https://review.openstack.org/536640 | |
| 01:59:39 | mordred | SamYaple, Shrews, adriant, briancurtin: the stuff in https://review.openstack.org/#/q/topic:swift-resource2+status:open should be ready to go - the RETRY_LIMIT errors were actually a zuul bug that we helped track down (go us) | |
| 02:00:12 | mordred | amotoki: ^^ you too, if you have any time | |
| 02:03:33 | mordred | amotoki, briancurtin: there's a weird thing in https://review.openstack.org/#/c/533823/ - basically the override of _consume_attrs - that would be better if it wasn't there, but my brain hasn't been able to unlock the actual issue and figure your eyes might spot something | |
| 02:05:39 | mordred | essentially, what happens without that keypair override method is that **SOMETIMES** the incoming/remote name parameter gets applied to both id and name of keypair, and **SOMETIMES** the remote id parameter does. it's non-determinitstic - if I run a 4-line script in a loop it'll do it one way sometimes and one way the other times | |
| 02:13:49 | mordred | the keypair patch 'fixes' it and it's always consistent now - but there's obviously something deeper that I'm guessing I broke ... my hunch is something with the MRO lookups | |
| 02:14:40 | mordred | amotoki, briancurtin: ANYWAY - no worries if you don't have time/space for it, but if you do, it would be neat | |
| 05:06:36 | openstackgerrit | Merged openstack/python-openstackclient master: Rework Network client config for new SDK Connection https://review.openstack.org/524715 | |
| 06:00:08 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix compute keypair functional test error https://review.openstack.org/536206 | |
| 07:03:58 | adriant | mordred: since the VPNasS is once again supported and maintained, we probably do need to do some work in the SDK and shade to make it a little more sensible and ensure it works as expected. | |
| 07:04:32 | adriant | ^ is lying | |
| 07:04:32 | adriant | https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/vpn_service.py#L17 | |
| 07:05:57 | adriant | I'm bringing it up because we have people using the service, and someone today actually was talking about wanting to automate elements of it, and how neutronclient didn't really do anything useful with it and is itself kind of crappy. | |
| 07:06:55 | adriant | plus there are many things with VPNaaS that you can shoot yourself with, so some sensible logic in Shade to help people not shoot themselves in the foot would be nice, parts of which we can also expose in the SDK. | |
| 07:08:40 | chenyb4 | Hi, Qiming . Please help review this patch. https://review.openstack.org/#/c/536206/ | |
| 07:12:57 | chenyb4 | Qiming, this patch fix gerrit review functional test faild. | |
| 07:56:14 | tovin07 | HI dtroyer, RuiChen | |
| 07:57:00 | tovin07 | Please take a look at this https://review.openstack.org/#/c/524715/2/openstackclient/network/client.py@70 | |
| 07:57:25 | tovin07 | This is dtroyer's patch | |
| 07:57:46 | tovin07 | it failed in my case | |
| 08:11:34 | openstackgerrit | Slawek Kaplonski proposed openstack/python-openstacksdk master: Make floating IP to be prefered over fixed when looking for IP https://review.openstack.org/536548 | |
| 08:58:49 | RuiChen | tovin07: yes, you are right, please commit a patch to resolve it, we can merge your patch quickly. | |
| 09:31:30 | openstackgerrit | Qi Peng proposed openstack/openstackclient master: Update homepage url https://review.openstack.org/536732 | |
| 10:55:28 | openstackgerrit | Kairat Kushaev proposed openstack/keystoneauth master: replace lxml with defusedxml https://review.openstack.org/536761 | |
| 13:44:34 | openstackgerrit | Hunt Xu proposed openstack/python-openstacksdk master: Fix an error about listing projects in connection doc https://review.openstack.org/536825 | |
| 14:01:43 | mordred | adriant: ++ | |
| 14:02:29 | mordred | Qiming, chenyb4: those failures should be fixed by https://review.openstack.org/#/c/533823 | |
| 14:03:58 | chenyb4 | ok, thanks Qiming | |
| 14:09:05 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Fix use of new openstacksdk connection https://review.openstack.org/536839 | |
| 14:10:08 | mordred | RuiChen, dtroyer, tovin07: ^^ that fixes tovin07's issue | |
| 14:31:36 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Add clustering guides node file, examples node code https://review.openstack.org/536847 | |
| 14:37:59 | openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Add masakari and service-type instance-ha https://review.openstack.org/534875 | |
| 14:39:35 | openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Add historical aliases for openstacksdk names https://review.openstack.org/536848 | |
| 14:42:31 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove inner_exceptions plumbing https://review.openstack.org/536640 | |
| 15:14:05 | dtroyer | mordred: thanks for getting that | |