| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-01-10 | |||
| 02:52:48 | openstackgerrit | Merged openstack/keystoneauth master: Fix masked variable name https://review.openstack.org/484340 | |
| 07:34:32 | openstackgerrit | Xi Yang proposed openstack/python-openstackclient master: Change 'Volume' to 'Block Storage' https://review.openstack.org/532439 | |
| 12:01:10 | amotoki | slaweq: could you review https://review.openstack.org/#/c/529951/ ? osc-lib depends on it and we would like to land it in queens | |
| 12:03:04 | Mr_Broken | Any chance that shade will be supporting SubnetPool functionality ? ( create, delete , manage ? ) | |
| 12:03:04 | Mr_Broken | Hey Guys | |
| 12:58:23 | slaweq | amotoki: hi, I will check it soon | |
| 12:58:36 | amotoki | slaweq: thanks | |
| 13:27:05 | slaweq | amotoki: done | |
| 13:27:50 | amotoki | slaweq: thanks. do you know who releases SDKs recently? | |
| 13:29:50 | slaweq | I don't know who did it recently but AFAIR some time ago I was asking briancurtin for that | |
| 13:30:59 | amotoki | I see. I think openstacksdk is now an official project "OpenStackSDK" and mordred is PTL, so it is clear to me | |
| 13:31:46 | briancurtin | amotoki: yeah i still release, but i would check with mordred on where things are at because there’s a lot of stuff going on right now | |
| 13:32:27 | amotoki | briancurtin: thanks. the reason I am checking this is the next week is non-client lib release, so I think openstacksdk and osc-lib are both affected | |
| 13:33:40 | amotoki | wait... I thought openstacksdk and osc-lib are not catagorized into client lib... i might be wrong | |
| 13:33:41 | briancurtin | yeah that’s something i don’t know anything about, as sdk has never been “official”, so traditionally if we needed to release something we release it | |
| 13:34:36 | amotoki | yeah. it is good time to clarify :) | |
| 14:04:01 | mordred | amotoki, slaweq: the process now will involve submitting a patch to the openstack/releases repo requesting a release be cut ... | |
| 14:04:17 | mordred | I'll check and see whether we fall in to client lib or non-client lib .. | |
| 14:06:31 | slaweq | thx mordred | |
| 14:19:21 | mordred | slaweq: if you happen to have some free time ... https://review.openstack.org/#/c/532347 and the ones before it are ready for review | |
| 14:19:49 | slaweq | mordred: sure, I will look today | |
| 14:23:01 | mordred | slaweq: thanks! | |
| 14:25:32 | Shrews | mordred: https://review.openstack.org/#/c/531611/4/doc/source/user/config/using.rst changes get_one_cloud() to get_one(). Same with get_all_clouds(). I don't see those defined in OCC | |
| 14:26:10 | Shrews | oh, duh. | |
| 14:27:32 | Shrews | silly code merging. ignore me | |
| 14:51:50 | mordred | Shrews: yah. I'm trying to make that as confusing for you as possible | |
| 14:52:57 | mordred | Shrews: that said - I think we're really close on the OCC import being in good shape, so when we cut the next sdk release we should be able to get the code ripped out from occ and have it depend on the sdk version of the code and be pretty much done with that side of the merge | |
| 15:53:20 | openstackgerrit | Merged openstack/python-openstacksdk master: Rename CloudConfig to CloudRegion https://review.openstack.org/531611 | |
| 17:10:34 | jpena | hi, I have a question about cliff 2.10.0. I think it's breaking the magnum gate, but I need some guidance on what the best fix would be | |
| 17:21:09 | jpich | jpena: Is there a bug to see more about the issue? | |
| 17:22:23 | jpena | jpich: I saw the issue when the package failed to build for RDO Trunk ()https://review.rdoproject.org/r/11275 , then started following the thread | |
| 17:23:07 | jpich | Oh, the legacy command name translation | |
| 17:23:21 | jpena | the TL;DR is that magnum calls the CommandManager constructor using None as a namespace, which causes commands not to be loaded in https://github.com/openstack/cliff/blob/2.10.0/cliff/commandmanager.py#L55-L56 | |
| 17:23:46 | jpena | I'm not familiar with cliff, so I wonder if this should be a bug in Magnum or cliff | |
| 17:26:33 | jpena | brb | |
| 17:27:40 | jpich | jpena: I'm not very familiar yet with cliff either, but since one of the patches I was involved with got included in 2.10 I thought I would ask in case I could help... I'm afraid I don't know the answer to your question, though perhaps dhellmann would have an idea? | |
| 17:28:16 | jpena | ok, thanks :) | |
| 17:28:18 | jpich | jpena: I think in that case I'd be tempted to file the bug with both magnum and cliff as components for now, so the experts on both sides can find the best solution | |
| 17:28:30 | jpena | btw, this seems to be the same as https://bugs.launchpad.net/python-cliff/+bug/1741911 | |
| 17:28:31 | openstack | Launchpad bug 1741911 in cliff "Regression with cliff 2.10.0" [Undecided,New] | |
| 17:28:38 | jpich | I mean, know which is more likely to break things or not | |
| 17:28:39 | jpich | ah! | |
| 17:28:40 | jpena | I'll add info to that bug | |
| 17:29:50 | jpich | Thanks! Good luck | |
| 17:44:23 | mordred | jpena, jpena: hah. my nick highlighting for both of you wound up being the same color and so for a minute I thought one of you just had a very long conversation with yourself | |
| 17:45:20 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate https://review.openstack.org/531514 | |
| 19:46:35 | openstackgerrit | Samuel Pilla proposed openstack/python-openstackclient master: Add project tags functionality https://review.openstack.org/481284 | |
| 20:51:54 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rationalize logging helpers and docs https://review.openstack.org/532634 | |
| 20:51:54 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Merge user and users sections of the docs https://review.openstack.org/532633 | |
| 21:54:09 | openstackgerrit | Merged openstack/python-openstacksdk master: Add function to make CloudRegion from session https://review.openstack.org/531612 | |
| 21:56:56 | openstackgerrit | Merged openstack/python-openstacksdk master: Port wait_for_ methods to use iterate_timeout https://review.openstack.org/531268 | |
| 22:58:39 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Add an octavia functional test gate https://review.openstack.org/531514 | |
| 23:58:38 | openstackgerrit | Merged openstack/python-openstacksdk master: Allow to pass filters like domain to find_project/user https://review.openstack.org/529951 | |
| 23:58:39 | openstackgerrit | Merged openstack/python-openstacksdk master: Add _query_mapping to identity resources https://review.openstack.org/529952 | |
| 23:58:40 | openstackgerrit | Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/531974 | |
| 23:59:20 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove metric service https://review.openstack.org/532697 | |
| #openstack-sdks - 2018-01-11 | |||
| 00:12:04 | mordred | ignore that ^^ | |
| 00:14:50 | mordred | Qiming: if you have a sec, feel like reviewing https://review.openstack.org/#/c/530769/ ? I think it should be ok from your earlier comments | |
| 00:16:45 | mordred | Qiming: also, I pushed up a patch to heat to shift it from using senlinclient to using SDK https://review.openstack.org/#/c/532680/ and a senlin patch https://review.openstack.org/#/c/532641/ that I'd love your feedback on | |
| 02:58:50 | adriant | is it just me, or query params/filters are busted for the openstackSDK? | |
| 02:59:52 | adriant | I'm trying to list stuff via the SDK and the list commands appear to just take key/values as kwargs, but those aren't actually being used since QueryParameters._transpose() appears to gobble them up... | |
| 03:06:43 | adriant | from what I can tell, this is because 'somewhere' on the resource we need to define what they acceptable query params are... or something? but this isn't actually happening anywhere. | |
| 03:07:52 | adriant | no wait... they are actually being used | |
| 03:07:59 | adriant | just not at all for any of the identity | |
| 03:08:26 | adriant | but then the terrifying thing is that after mangling the query, i get returned EVERYTHING | |
| 03:09:26 | adriant | so if I do: sdk.identity.projects(name="some project") | |
| 03:09:43 | adriant | a list with projects of that name, OR nothing | |
| 03:09:47 | adriant | yet I get everything... | |
| 03:10:13 | adriant | because my query is being mangled and the API then does a call for everything | |
| 03:10:34 | adriant | I think it would be much much safer to no mangle the query, just throw a damn error | |
| 03:10:42 | adriant | not* | |
| 03:11:25 | adriant | if you attempt to query with a key that isn't setup to be queried with, throw an error rather than return to me a list of data that I may act upon thinking it matched my query... | |
| 03:11:27 | adriant | when it didn't. | |
| 04:04:57 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Raise error when supplying invalid query params https://review.openstack.org/532723 | |
| 04:05:49 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Raise error when supplying invalid query params https://review.openstack.org/532723 | |
| 04:08:58 | adriant | mordred, briancurtin: : ^ this technically break functionality, but because you're now requiring explicit definition of valid queries in the Resource2 class, rather than just passing them through without checking like Resource did, you can confirm people are being sensible. | |
| 04:10:24 | adriant | Identity has been moved to Resource2, but no one setup any valid queries for it... so trying to list projects and filtering by name returns all projects... which is an unsafe query because you're mangling the query I supplied since no one configured it as valid in the code. | |
| 04:10:55 | adriant | But... since we are configuring valid queries in the code (a good thing), we can stop people from making stupid mistakes by throwing this kind of error. | |
| 04:11:40 | adriant | Which means we actually need to define the queries. I'll dig through and see if there is a patch for adding filters to identityv3, if not, I'll submit that. | |
| 04:14:52 | adriant | hah, fuck, nvm, my bad. the version of the sdk I was using to test doesn't have it... master does... ignore me | |
| 04:18:14 | adriant | Still worth throwing errors for invalid queries because it's safer, since we know what a valid query is | |
| 08:34:28 | openstackgerrit | Zhaokun Fu proposed openstack/python-openstackclient master: add --password option for openstack server create https://review.openstack.org/490718 | |
| 08:48:58 | Mr_Broken | Hey guys, | |
| 08:48:59 | Mr_Broken | Any chance that shade will be supporting SubnetPool functionality ? ( create, delete , manage ? ) | |
| 11:02:43 | openstackgerrit | Merged openstack/python-openstacksdk master: Add query filters for find_network https://review.openstack.org/476410 | |
| 13:31:37 | openstackgerrit | Dmitry Tantsur proposed openstack/api-wg master: [WIP] Add guideline on exposing microversions in SDKs https://review.openstack.org/532814 | |
| 13:47:21 | openstackgerrit | Stephen Finucane proposed openstack/cliff master: sphinxext: Warn if namespace or command pattern invalid https://review.openstack.org/510913 | |
| 14:02:53 | openstackgerrit | Dmitry Tantsur proposed openstack/api-wg master: Add guideline on exposing microversions in SDKs https://review.openstack.org/532814 | |
| 14:03:02 | dtantsur | cdent, mordred, TheJulia, thought dump complete ^^^ :) | |
| 14:18:49 | mordred | dtantsur: ooh, fun reading for this morning | |
| 14:19:07 | dtantsur | haha, I hope you enjoy it :) I did steal a few things from Shade docs ;) | |
| 14:20:12 | mordred | dtantsur: it's good - and it's a hard topic. I think that's an excellent write up | |
| 14:21:09 | dtantsur | cool! | |
| 14:22:20 | mordred | adriant: in shade we do a hybrid approach, which is that we send query parameters to the service if we know about them, but then also filter results client-side before returning them, in case someone wants to filter by something that's not possible as a server-side filter | |
| 14:24:37 | mordred | adriant: I was actually just thinking the other day about adding that post-filtering to Resource2 ... but I think we'd also want to add a flag to control pushdown behavior | |
| 14:25:59 | mordred | because there are three general things people tend to want "pushdown as many filters to the server as possible and apply any remaining filters client-side" "pushdown everything and error if some filters can't be handled server-side" "pushdown nothing and do all filtering client-side" | |
| 17:22:30 | cdent | elmiko, edleafe, dtantsur|afk : https://etherpad.openstack.org/p/api-sig-newsletter please and thank you | |
| 17:24:25 | edleafe | looking... | |
| 17:25:36 | edleafe | looks like cdent has his thesaurus at the ready :) | |
| 17:26:18 | cdent | I am a thesaurus | |