Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-08-14
13:43:44 efried mordred Yeah, thought that might be the case.
13:43:47 mordred efried: when we do, I believe the case you raised is an important one for us to handle
13:43:55 mordred efried: and I had not considered it - so yay!
13:43:58 efried hadn't followed the thought all the way through.
13:44:32 mordred efried: I had just written the patch to fix it and was writing an exception message when I realized it was going to be "the data at https://service-types.openstack.org/service-types.json is stale" :)
13:47:05 efried mordred So here's a weird thing that happened with https://review.openstack.org/#/c/493361
13:49:25 mordred efried: https://review.openstack.org/#/c/462140/ is a dependency loop I made, which is why t's not testing
13:50:47 mordred efried: (also, what's the weird thing?)
13:51:06 mordred efried: or just that that happened?
13:51:26 efried Sorry, got an interrupt
13:51:41 efried mordred The published output is identical except for the version string (expected, cause it's a time stamp)... and the sha.
13:51:47 efried The sha should be identical
13:51:54 efried Cause it doesn't use the version.
13:52:21 efried So I guess it's calculating the sha pre-decode, eh?
13:52:48 efried or rather, it was; and now it's not.
13:55:11 efried mordred Oh.
13:55:18 efried It has nothing to do with the content.
13:55:24 efried It's the commit hash.
13:55:28 efried <sheepish>
13:55:50 efried Hm, I'm not sure I love that idea, tbh.
13:56:02 efried I mean, we could very well commit a change that doesn't affect the JSON itself.
13:56:05 efried Like this one :)
14:01:46 mordred efried: it's purely a utf-8 encoding json reading change
14:02:16 efried mordred Not even json related.
14:02:18 mordred efried: the commit hash isn't strictly important - but the logic is there to prevent us publishing a new json file when we make changes like this one
14:02:20 efried Swhat confused me at first.
14:02:40 efried mordred Right - which doesn't work.
14:02:41 mordred efried: yah - sorry, that's what I mean. it's really a "we thought we were using python3 but weren't actually"
14:03:23 efried mordred But it won't prevent us from republishing when we make changes like this one. Because the git commit hash will always change. And that's what we're stuffing into the 'sha'.
14:03:23 mordred efried: it doesn't? why not? ... oh, sorry, there's another piece to this puzzle (I should write a better commit message)
14:03:45 mordred right. we always put sha into the json - the "is the data different" check is elsewhere and it ignores sha
14:04:14 efried mordred Oh. Ignores the sha, rather than using the sha to tell whether we've changed :)
14:04:17 mordred efried: the problem here surfaced because my tox installation is a python3 installation, which means I got a python3 virtualenv even though our config was broken
14:04:33 mordred so when I ran "tox -epublish" locally to validate, it broke
14:04:40 efried mordred Yeah, I get it. It just led me down this (apparently unrelated) rathole.
14:04:43 mordred yah. :)
14:04:51 mordred it's a good rathole - welcome to the rats!
14:07:57 efried mordred You gonna update the commit message anyway? So may be jenkins will pick it up??
14:12:43 openstackgerrit Eric Fried proposed openstack/os-service-types master: Support secondary services https://review.openstack.org/493325
14:34:25 mordred efried: sorry - morning juggling of the things - I shall update the depend cycle in just a sec
14:34:37 efried mordred I did that ^^
14:35:24 efried The commit message was on the tox one - I think you were wanting to mention that it was missed because your env was running py3 by default.
14:35:25 efried or something.
16:20:22 openstackgerrit Merged openstack/python-openstackclient master: Convert network segment functional tests to JSON https://review.openstack.org/491612
17:57:08 openstackgerrit Rajath Agasthya proposed openstack/python-openstackclient master: Add flavor value options https://review.openstack.org/302795
18:08:58 openstackgerrit Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/491294
18:52:18 efried mordred https://review.openstack.org/#/c/490750/ is not reflected in https://service-types.openstack.org/service-types.json - don't we have a bot that's supposed to republish?
19:02:10 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Ensure git rev-parse output works in python3 https://review.openstack.org/493361
19:02:38 efried mordred docs build appears to need to run under py2 ^^
19:02:52 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Use consistent url schemes https://review.openstack.org/493362
19:03:08 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
19:03:24 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
19:03:34 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Only run json.dump once https://review.openstack.org/493363
19:03:41 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Add three more transformations https://review.openstack.org/493364
19:12:35 openstackgerrit Merged openstack/cliff master: Updated from global requirements https://review.openstack.org/493298
23:11:48 efried mordred Well, it worked locally, but jenkins still hates it.
23:13:50 mordred efried: docs jobs don't use docs environment - they use the venv env (sorry for the delay)
23:14:23 efried mordred oh, so the fact that tox -e docs worked for me locally was irrelevant.
23:14:58 efried mordred And what actually needs to happen is we need to put python2 into [testenv] and then spray python3 into all the specific testenvs that ain't docs.
23:15:01 efried or... something.
23:19:53 mordred efried: just put it in the venv env section
23:21:08 efried mordred I'm about to head out for the evening. I'll restack it in the morning, unless you want to handle it.
23:21:25 mordred efried: kk
23:35:09 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Only run json.dump once https://review.openstack.org/493363
23:35:09 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Use consistent url schemes https://review.openstack.org/493362
23:35:10 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Ensure git rev-parse output works in python3 https://review.openstack.org/493361
23:35:10 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
23:35:11 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
23:35:11 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add three more transformations https://review.openstack.org/493364
23:35:22 mordred efried: ^^ that should do it (just fixed the conf.py error)
23:36:18 efried mordred Cool.
#openstack-sdks - 2017-08-15
01:36:46 openstackgerrit Qearl proposed openstack/python-openstacksdk master: fix the bug that cannot create a listener by openstacksdk https://review.openstack.org/493449
02:01:54 reedip_ stevemar : hi
02:57:54 openstackgerrit Qearl proposed openstack/python-openstacksdk master: fix the bug that cannot create a listener by openstacksdk https://review.openstack.org/493449
08:37:21 openstackgerrit liyi proposed openstack/python-openstacksdk master: Fix stack_file function return body https://review.openstack.org/493786
09:55:35 openstackgerrit Rui Chen proposed openstack/python-openstackclient feature/osc4: [Compute]Make column content readable for both human and machine https://review.openstack.org/493814
12:39:38 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Only run json.dump once https://review.openstack.org/493363
12:39:39 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add three more transformations https://review.openstack.org/493364
12:39:39 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
12:39:40 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
13:10:58 openstackgerrit Vitalii Kulanov proposed openstack/cliff master: Update doc on Sphinx integration process https://review.openstack.org/493869
13:18:22 openstackgerrit Merged openstack/service-types-authority master: Ensure git rev-parse output works in python3 https://review.openstack.org/493361
13:18:29 openstackgerrit Merged openstack/service-types-authority master: Use consistent url schemes https://review.openstack.org/493362
14:28:36 openstackgerrit Merged openstack/python-openstacksdk master: Support node-adopt/preview CLI https://review.openstack.org/493542
14:35:54 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574
15:30:48 openstackgerrit Merged openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574
15:38:56 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Introduce Pool for Octavia (load balancing) https://review.openstack.org/449264
16:17:52 openstackgerrit Merged openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
16:45:22 efried cdent mordred What's the protocol for overriding a -1 whose issue has been resolved? (AJaeger in https://review.openstack.org/#/c/462140/)
16:45:55 cdent efried: i believe you can +2 +W and ignore it
16:46:10 cdent or if you don’t like that you can go find the culprit
16:46:14 efried k, didn't want to break some rule. Doing it now.
16:46:22 efried I tried to find the culprit - both via comment and in IRC.
16:46:44 efried I think 24h is enough, don't you?
16:47:38 efried +Aed, get that stack movin
16:51:08 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Change default swift name to object-storage https://review.openstack.org/462138
16:53:43 openstackgerrit Eric Fried proposed openstack/service-types-authority master: It's better to use 'cluster' as senlin's service_type https://review.openstack.org/484011
16:55:49 mordred efried, cdent: the more I think about it I actually think we should give up on the swift->object-storage and just move their docs - their service-type has been object-store for WAY too long and I think maybe changing it for consistency sake at this point is maybe a step too far?
16:56:25 efried mordred As you wish. I sees a merge conflict, I resolves a merge conflict.
16:56:46 cdent mordred: I’m good with that. I’ve not been keen on the changes for the sake of consistency (when there’s history).

Earlier   Later