Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-05-02
00:44:36 efried jamielennox I'm missing this line: https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/session.py@159
00:45:08 efried jamielennox Yeah, not providing CLI options right now, but that doesn't mean we never will. And I should do it consistently with how loading.session is.
00:45:23 jamielennox efried: so session is not necessarily the best one to copy
00:45:37 jamielennox or maybe it is :)
00:46:05 efried Waidaminute - I am already doing cfg = _utils.get_oslo_config()
00:46:22 efried jamielennox https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/adapter.py@51
00:46:50 efried So okay, you're saying I should *not* do that the same way as session does? /me confused.
00:47:01 jamielennox efried: so the idea with all of this loading as mentioned is that there are a number of ways you can do it, one of which is oslo.config
00:47:40 jamielennox if you look at the most simple plugin you see it returns keystoneauth opts from get_options: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/_plugins/admin_token.py#L33
00:49:09 jamielennox then when dealing with oslo.config specifically it converts the ksa opt to an oslo opt: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/conf.py#L128
00:49:29 jamielennox this means that os-c-c can use ksa loading without worrying about oslo.config
00:50:39 jamielennox now there are times where you want oslo.config to behave differently to just the standard ksa opts, and you can override it with the oslo_config_opts that you're doing - and that's fine, that's what session does because we matched old variables names to new variable names
00:51:28 jamielennox just in this case it looks like a really simple pass through (you're not manipulating variables), so you could probably just do it as ksa opts
00:51:48 jamielennox so i'm just wondering if that's planned or just the result of looking at session
00:52:05 efried jamielennox Result of looking at session, for sure.
00:52:59 efried jamielennox Though looking at loading.conf, it appears to be kinda auth-specific.
00:53:24 jamielennox efried: yea, i'm just having another look through that as well
00:53:35 jamielennox it was definitely designed around auth
00:54:27 jamielennox i never considered non-auth loading at the time
00:55:26 efried Okay.
00:55:52 efried jamielennox I do have to bail before my wife gets steamed. If you want to leave comments in the review, or email me, or something, we can hash it out.
00:56:13 jamielennox efried: yea, i'll try and have a closer look, just thought i'd see if you were here
00:56:21 jamielennox thanks
04:27:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Funcional tests: quota list https://review.openstack.org/461618
05:08:59 openstackgerrit Robert van Leeuwen proposed openstack/python-openstackclient master: Fixes osc port set allowed-address for ports without previous set allowed address https://review.openstack.org/461364
12:34:49 efried jamielennox You still around?
13:26:46 mordred efried: he's in australia - so usually will only overlap early in the US morning or at the end of the day
13:27:07 efried mordred Yeah, figured as much, but was worth a shot ;-)
13:27:26 efried mordred If you have the cycles today, wanna take a look at those two changes?
13:27:45 efried ksa [https://review.openstack.org/460337] and nova [https://review.openstack.org/458257]
13:29:05 mordred efried: yes! I have a panel session in 45 minutes, but after that I totally will
13:29:20 efried mordred Thanks!
15:10:32 openstackgerrit Merged openstack/keystoneauth master: Introduce keystoneauth1.loading.adapter https://review.openstack.org/460337
15:32:55 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Functional tests: Identity v2 and DevStack https://review.openstack.org/461826
16:57:50 openstackgerrit Ed Leafe proposed openstack/api-wg master: Microversions: add next_min_version field in version body https://review.openstack.org/446138
17:02:27 openstackgerrit Ed Leafe proposed openstack/api-wg master: Microversions: add signal when raising minimum version https://review.openstack.org/446138
19:09:26 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Nova-net functional tests: aggregates https://review.openstack.org/461491
19:09:26 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Funcional tests: quota list https://review.openstack.org/461618
20:17:53 openstackgerrit Merged openstack/python-openstackclient master: Functional tests: Identity v2 and DevStack https://review.openstack.org/461826
22:08:41 openstackgerrit Ed Leafe proposed openstack/api-wg master: Microversions: add next_min_version field in version body https://review.openstack.org/446138
#openstack-sdks - 2017-05-03
00:46:50 EmilienM dtroyer: I found a new issue, this time I'm not sure it's in tripleo
00:46:55 EmilienM http://logs.openstack.org/37/457037/7/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/5f1ec27/console.html#_2017-05-02_22_26_46_061856
00:47:15 EmilienM I'm investigating it but if you know :)
00:50:11 EmilienM I'm not sure but I think about https://github.com/openstack/os-client-config/commit/e6755872ada4978f585bdf15edf623dbcf72c4ee
00:57:20 openstackgerrit Emilien Macchi proposed openstack/os-client-config master: DO NOT MERGE - Revert "Remove the keystoneclient auth fallback" https://review.openstack.org/461945
00:59:41 umbSublime Hi quick question, when using the python openstacksdk, what is equivalent to being an admin and running "nova list --all-tenants". When I use conn.compute.servers(), I get only the instances from my admin tenant_id
01:01:37 umbSublime same goes for conn.compute.find_server(name_or_id), it works fine no matter the tenant if I use a uuid for name_or_id param, but if I use name it can only find the instances from my own tenant_id
01:39:58 openstackgerrit Merged openstack/python-openstackclient master: Nova-net functional tests: aggregates https://review.openstack.org/461491
01:50:36 openstackgerrit Merged openstack/python-openstackclient master: Funcional tests: quota list https://review.openstack.org/461618
05:09:37 openstackgerrit Merged openstack/python-openstackclient master: Explicitly set 'builders' option https://review.openstack.org/457960
08:28:53 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstacksdk master: Add direction field to QoS bandwidth limit. https://review.openstack.org/356512
09:31:36 ralonsoh briancurtin: hi, can you review again https://review.openstack.org/#/c/356512/?
09:31:47 ralonsoh briancurtin: thank you in advance
09:43:22 ralonsoh dtroyer: hi
09:44:06 ralonsoh dtroyer: https://review.openstack.org/#/c/356512/ depending patch is merged. And https://review.openstack.org/#/c/458056/ is also waiting for this one
09:44:21 ralonsoh dtroyer: can you take a look?
09:44:29 ralonsoh dtroyer: thank you in advance
11:01:47 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add direction field to QoS bandwidth limit. https://review.openstack.org/458056
11:04:01 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Create server with security group ID and name https://review.openstack.org/462076
11:26:42 briancurtin umbSublime: probably servers(all_tenants=True)
11:39:46 openstackgerrit Merged openstack/python-openstacksdk master: Add direction field to QoS bandwidth limit. https://review.openstack.org/356512
12:06:40 openstackgerrit Monty Taylor proposed openstack/os-client-config master: WIP Braindump thoughts and a tenantive plan for v2 https://review.openstack.org/462092
12:21:19 openstackgerrit OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/462114
12:23:15 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/462125
12:23:18 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/462126
12:34:24 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add the rest of the services we know about https://review.openstack.org/461221
12:34:25 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Changes types of the three services that manage systems https://review.openstack.org/462137
12:36:17 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Change default swift name to object-storage https://review.openstack.org/462138
12:38:29 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Change rating to usage-report https://review.openstack.org/462139
12:41:37 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
12:53:16 openstackgerrit Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/462126
13:11:11 openstackgerrit Jordan Pittier proposed openstack/os-client-config master: Revert "Use interface not endpoint_type for keystoneclient" https://review.openstack.org/462144
13:11:37 openstackgerrit Jordan Pittier proposed openstack/os-client-config master: Revert "Use interface not endpoint_type for keystoneclient" https://review.openstack.org/462144
13:16:05 openstackgerrit Jordan Pittier proposed openstack/os-client-config master: Revert "Use interface not endpoint_type for keystoneclient" https://review.openstack.org/462144
13:21:56 stevemar dtroyer: yay for osc releases
13:21:59 stevemar that as a huge release
13:22:54 stevemar 150 commits according to github :)
13:31:53 openstackgerrit Akihiro Motoki proposed openstack/osc-lib master: Support cliff FormattableColumn https://review.openstack.org/462150
14:11:33 dtroyer ralonsoh: that sdk review needs to be in a release and that release needs to be the minimum version in global-requirements before OSC can unconditionally rely on that support.
14:12:14 dtroyer The functional test failure is real and shows what happens without the proper SDK in place. The functional-tips job failure is unrelated and your test works there
14:12:46 dtroyer stevemar: this one really got away from me, the rabbit hole of nova-net + functional tests turned out to be a rhino hole
14:13:28 dtroyer I have to get over that "just one more thing first" mentality
14:22:09 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Use cliff formattable columns https://review.openstack.org/462170
14:27:33 stevemar dtroyer: yeah, burden of being on the client and all that
15:30:36 openstackgerrit Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/462125
16:54:34 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
17:23:23 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Make it possible to depend on the data https://review.openstack.org/462233
18:03:23 openstackgerrit Akihiro Motoki proposed openstack/service-types-authority master: Add networking service (neutron) https://review.openstack.org/462241
18:40:44 openstackgerrit Akihiro Motoki proposed openstack/service-types-authority master: Add gnocchi https://review.openstack.org/462262
19:35:34 openstackgerrit Akihiro Motoki proposed openstack/osc-lib master: Support cliff FormattableColumn https://review.openstack.org/462150
19:44:02 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Skip floating ip attach functional test on nova-net https://review.openstack.org/462277
20:10:02 umbSublime briancurtin, that worked !!, I'm just curious as to why this isn't documented. Did you find that param reading the SC ?
20:10:48 briancurtin i wrote it
20:10:58 briancurtin we should probably redo the servers() docstring
20:10:58 umbSublime that explains it :)
20:11:25 briancurtin that includes an explicit list of query params (that got out of date) rather than linking off to the ones that are accepted
20:16:11 umbSublime I'm assuming find_server() also has a all_tenants param ?
20:39:05 umbSublime well it doesn't, but servers(name=<name>, all_tenants=True), returns what I would expect, but in a generator object instead of a server object
21:04:03 openstackgerrit Merged openstack/osc-lib master: Updated from global requirements https://review.openstack.org/462114
21:20:18 openstackgerrit Dean Troyer proposed openstack/osc-lib master: Follow-up to headers handler to fix find_bulk() https://review.openstack.org/462294

Earlier   Later