Posted	Nick	Remark
#openstack-sdks - 2017-04-28
17:53:55	dtroyer	if its a bug lets fix it
17:53:56	mordred	but the actual fix in occ is super easy (and honestly less work than working around it)
18:08:38	mordred	dtroyer: oh - I may not have put the right little carets in my earlier sentence... https://review.openstack.org/#/c/461114/ fixes the issue :)
18:13:28	dtroyer	cool, thanks. will you need a 1.27.1 release for just that or can it wait a bit?
18:25:34	mordred	dtroyer: I don't think it's super urgen - I've got a red non-voting job in shade - but I honestly don't think anyone else is going to hit this one
18:26:40	dtroyer	ok, I'll hold off then in case something from bumping g-r shows up next week
19:18:03	openstackgerrit	Merged openstack/python-openstackclient master: Fix Nova-net netowrk commands https://review.openstack.org/460679
19:40:58	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Nova net functional tests round 3 https://review.openstack.org/461113
19:43:21	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: DNM: Enable debug in functional tests https://review.openstack.org/458579
20:07:15	mordred	dtroyer: this time with tests working :)
20:07:41	mordred	Shrews: ^^ so - legacy-functional-tips is definitely not doing what we think it's doing
20:07:59	mordred	Shrews: but I do not yet have an answer as to wh
21:02:50	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add explicit mention of versions https://review.openstack.org/460540
21:02:51	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Point keystone at overall API docs https://review.openstack.org/461152
21:02:51	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add an attribute for aliases https://review.openstack.org/460539
21:11:30	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Fix volume qos spec list https://review.openstack.org/461153
21:35:46	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Fix interactions with keystoneauth from newton https://review.openstack.org/461114
23:12:36	mordred	dtroyer: ^^ yay passes tests this time. (the red test for shade legacy libs nv is expected - tracking that down separately
#openstack-sdks - 2017-04-29
03:25:55	openstackgerrit	Merged openstack/python-openstackclient master: Fix volume qos spec list https://review.openstack.org/461153
03:44:49	openstackgerrit	Merged openstack/python-openstackclient master: Nova net functional tests round 3 https://review.openstack.org/461113
08:19:41	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
08:26:51	openstackgerrit	Akihiro Motoki proposed openstack/python-openstackclient master: Network tag support https://review.openstack.org/461195
10:28:30	openstackgerrit	Akihiro Motoki proposed openstack/python-openstackclient master: Network tag support https://review.openstack.org/461195
11:20:03	openstackgerrit	Merged openstack/service-types-authority master: Add load-balancer service type https://review.openstack.org/434999
14:05:19	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add validation and publication infrastructure https://review.openstack.org/461209
14:08:21	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Point keystone at overall API docs https://review.openstack.org/461152
14:08:22	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add explicit mention of versions https://review.openstack.org/460540
14:08:22	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add validation and publication infrastructure https://review.openstack.org/461209
14:08:23	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add an attribute for aliases https://review.openstack.org/460539
14:40:07	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: DNM: test functional test using OS_CLOUD=devstack-admin https://review.openstack.org/461211
15:42:15	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: functional tests: minor cleanup https://review.openstack.org/461211
15:45:04	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add the rest of the services we know about https://review.openstack.org/461221
15:45:04	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add validation and publication infrastructure https://review.openstack.org/461209
15:52:28	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add the rest of the services we know about https://review.openstack.org/461221
16:05:25	openstackgerrit	Monty Taylor proposed openstack/service-types-authority master: Add the rest of the services we know about https://review.openstack.org/461221
16:28:23	openstackgerrit	Akihiro Motoki proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729
16:29:18	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Use constraints environment for testing https://review.openstack.org/461225
17:00:50	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
17:09:13	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
17:17:24	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
17:33:06	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Fix document warnings https://review.openstack.org/461228
17:35:01	openstackgerrit	Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
18:47:16	EmilienM	dtroyer: I was afk yesterday afternoon - I have more logs now: http://logs.openstack.org/37/457037/4/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/5bf6daf/console.html#_2017-04-28_17_01_45_634230
18:47:20	EmilienM	it's in tripleoclient, i'm investigating
#openstack-sdks - 2017-05-01
09:23:58	openstackgerrit	Robert van Leeuwen proposed openstack/python-openstackclient master: Fixes osc port set allowed-address for ports without previous set allowed address https://review.openstack.org/461354
09:58:09	leeuwenrjj	Hi, I just hit a bug and created a fix but I have a short question on the unit test since that did not catch the issue
09:59:05	leeuwenrjj	The unit test for the network/v2/fakes.py for the port creates empty dictionaries e.g. for allowed_address_pairs
10:00:10	leeuwenrjj	Because those empty values are not created in the real world some of the unit tests will work but in the real world they will break. See my change: https://review.openstack.org/#/c/461354/
10:00:51	leeuwenrjj	So my question: should those unit tests be modified to not include empty dictionaries?
11:32:31	openstackgerrit	Robert van Leeuwen proposed openstack/python-openstackclient master: Fixes osc port set allowed-address for ports without previous set allowed address https://review.openstack.org/461364
12:08:01	EmilienM	dtroyer: hey, just fyi about the issue we had last week: https://review.openstack.org/#/c/461336
12:37:21	openstackgerrit	Merged openstack/python-openstacksdk master: Fix document warnings https://review.openstack.org/461228
13:30:27	cdent	mordred: you must be very proud of your giant bikeshed. so big and in need of so many different colors
13:39:07	openstackgerrit	OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/460257
13:40:54	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/461387
13:40:57	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/461388
13:52:23	openstackgerrit	OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/460257
14:05:40	openstackgerrit	OpenStack Proposal Bot proposed openstack/openstackclient master: Updated from global requirements https://review.openstack.org/440080
14:06:03	openstackgerrit	OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/460257
14:07:50	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/461387
14:23:45	mordred	cdent: I lke to flummox the color-blind
14:24:14	cdent	sometimes you have to be cruel to be kind
14:24:45	mordred	dtroyer: I believe I just figured out an end-to-end design and plan for the occ 2.0 stuff we chatted about in atlanta and how to do it without breaking anyone - I'm going to write it all down in narrative form for a sanity check - but I think it actually won't be bad to implement
14:50:52	EmilienM	dtroyer: fyi https://review.openstack.org/#/c/461069/1/osc_lib/shell.py@a440
15:03:16	openstackgerrit	Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/461388
15:04:46	openstackgerrit	Merged openstack/python-openstacksdk master: Port metric v1 to resource2 https://review.openstack.org/460673
15:05:16	openstackgerrit	Merged openstack/python-openstacksdk master: Port unversioned Version resources to resource2 https://review.openstack.org/460735
15:27:28	dtroyer	EmilienM: thanks, commented
15:28:32	EmilienM	dtroyer: ok thanks, have you seen https://review.openstack.org/#/c/461336/ ?
15:38:36	dtroyer	commented there too. there's a bit of unnecessary stuff going on in there
15:57:58	EmilienM	dtroyer: thx
16:10:29	openstackgerrit	Robert van Leeuwen proposed openstack/python-openstackclient master: Fixes osc port set allowed-address for ports without previous set allowed address https://review.openstack.org/461364
16:23:49	openstackgerrit	Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/461387
19:39:04	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Nova-net functional tests: aggregates https://review.openstack.org/461491
22:21:24	openstackgerrit	Eric Fried proposed openstack/keystoneauth master: Introduce keystoneauth1.loading.adapter https://review.openstack.org/460337
23:11:24	openstackgerrit	Merged openstack/os-client-config master: Fix interactions with keystoneauth from newton https://review.openstack.org/461114
#openstack-sdks - 2017-05-02
00:41:32	jamielennox	efried: assume you've left, why use the oslo conf options instead of the keystoneauth options in https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/adapter.py ?
00:42:07	efried	jamielennox Is that not what I'm doing?
00:43:01	jamielennox	efried: so in keystoneauth we define our own option type: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/opts.py
00:43:28	jamielennox	the idea being that these things can be available on CLI, oslo.config, and in the weird ways glance does things
00:44:01	efried	jamielennox Ohh, I see now.
00:44:17	jamielennox	i mean there might be no reason to provide adapter options via CLI
00:44:36	efried	jamielennox I'm missing this line: https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/session.py@159
00:45:08	efried	jamielennox Yeah, not providing CLI options right now, but that doesn't mean we never will. And I should do it consistently with how loading.session is.
00:45:23	jamielennox	efried: so session is not necessarily the best one to copy
00:45:37	jamielennox	or maybe it is :)
00:46:05	efried	Waidaminute - I am already doing cfg = _utils.get_oslo_config()
00:46:22	efried	jamielennox https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/adapter.py@51
00:46:50	efried	So okay, you're saying I should *not* do that the same way as session does? /me confused.
00:47:01	jamielennox	efried: so the idea with all of this loading as mentioned is that there are a number of ways you can do it, one of which is oslo.config
00:47:40	jamielennox	if you look at the most simple plugin you see it returns keystoneauth opts from get_options: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/_plugins/admin_token.py#L33
00:49:09	jamielennox	then when dealing with oslo.config specifically it converts the ksa opt to an oslo opt: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/conf.py#L128
00:49:29	jamielennox	this means that os-c-c can use ksa loading without worrying about oslo.config
00:50:39	jamielennox	now there are times where you want oslo.config to behave differently to just the standard ksa opts, and you can override it with the oslo_config_opts that you're doing - and that's fine, that's what session does because we matched old variables names to new variable names
00:51:28	jamielennox	just in this case it looks like a really simple pass through (you're not manipulating variables), so you could probably just do it as ksa opts
00:51:48	jamielennox	so i'm just wondering if that's planned or just the result of looking at session
00:52:05	efried	jamielennox Result of looking at session, for sure.
00:52:59	efried	jamielennox Though looking at loading.conf, it appears to be kinda auth-specific.
00:53:24	jamielennox	efried: yea, i'm just having another look through that as well
00:53:35	jamielennox	it was definitely designed around auth

Earlier   Later