Posted	Nick	Remark
#openstack-sdks - 2017-04-21
13:39:27	openstackgerrit	Carlos Goncalves proposed openstack/python-openstackclient master: Add 'data_plane_status' option to Port classes https://review.openstack.org/458626
13:49:59	stevemar	dtroyer_zz: about https://review.openstack.org/#/c/444924/15/openstackclient/compute/v2/server.py
13:50:06	stevemar	where are the new args being used?
13:50:13	stevemar	did i miss something?
13:52:33	dtroyer_zz	stevemar: new args? do you mean the two new options?
13:58:48	stevemar	yes
14:16:49	dtroyer_zz	they are just convenience options, I'm not sure what motivated the change. Similar to what I did in https://review.openstack.org/302795 to make users' lives simpler
14:17:53	cgoncalves	dtroyer_zz: re https://review.openstack.org/#/c/458626/ is there any PUT-only argument in osc where osc does a POST+PUT (in a class Create)?
14:18:40	dtroyer_zz	There are places where we do multiple calls to achieve the desired result, I'd have to look for some specific examples
14:19:12	dtroyer_zz	remember, we're first providing a consistent user interface, and doing what is necessary on the backside to make up for the REST APIs
14:19:48	cgoncalves	dtroyer_zz: don't bother if you don't remember by heart. I'll look up
14:21:05	cgoncalves	understood. it will feel weird to me having multiple calls for this case in particular but okay
14:21:37	dtroyer_zz	once you get past the 1-to-1 mapping of commands to REST APIs it gets easier :)
14:22:45	dtroyer_zz	volume create does this
14:23:15	cgoncalves	yeah, but in this case it doesn't make much since IMO because data_plane_status represents the status of the underlying data plane and when one creates a new port it doesn't know the status beforehand
14:23:17	dtroyer_zz	v1 has 1 extra, v2 has 2 extra calls depending on options
14:24:06	cgoncalves	ok, I'll have a look. it's not much of a technical matter but rather if it makes sense allowing setting it on port creation
14:24:16	dtroyer_zz	ok, that's what I mean about the use case, if it really is never going to be used we don't need it.
14:24:37	dtroyer_zz	but I don't know exactly how it is used…
14:25:22	dtroyer_zz	it felt like an enable/disable flag to create and set the desired status in one call
14:34:37	cgoncalves	dtroyer_zz: un/setting the attr doesn't change the underlying status. the attr is used just to signal to users the current status, nothing else
14:35:48	cgoncalves	I don't see an use case for the multi call, but nevertheless I'll double-check and leave my comment on the review
14:37:51	cgoncalves	and only admins and users with a special role can un/set this attribute
15:12:58	stevemar	dtroyer_zz: ohhhh duh... "dest=nic"
15:13:01	stevemar	that tripped me up
15:13:18	stevemar	type=_prefix_checked_value('net-id='),
15:13:21	stevemar	weird
15:19:25	dtroyer_zz	ya, I stared at that for a bit, argparse is majikal
16:51:17	openstackgerrit	Dean Troyer proposed openstack/osc-lib master: Add endpoint hook to BaseAPI https://review.openstack.org/458916
#openstack-sdks - 2017-04-22
04:41:44	openstackgerrit	Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263
08:56:25	openstackgerrit	Merged openstack/python-openstacksdk master: Allow router related functions to receive an ID https://review.openstack.org/457647
#openstack-sdks - 2017-04-23
14:17:37	openstackgerrit	Doug Hellmann proposed openstack/cliff master: covert test suite to use testrepository https://review.openstack.org/459112
15:47:59	openstackgerrit	Jordan Pittier proposed openstack/os-client-config master: Make _fix_argv() somewhat compatible with Argparse action='append' https://review.openstack.org/459115
18:23:43	openstackgerrit	Merged openstack/keystoneauth master: Updated inconsistent value of scope parameter https://review.openstack.org/452652
#openstack-sdks - 2017-04-24
07:12:37	openstackgerrit	Rui Chen proposed openstack/python-openstackclient master: Remove ipdb installation in tox debug section https://review.openstack.org/459180
09:21:28	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: DNM For the love of FSM https://review.openstack.org/458819
11:04:40	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: DNM For the love of FSM https://review.openstack.org/458819
13:55:24	dhellmann	dtroyer, stevemar: it's not the most important cliff patch, but it would be good to have before starting some of the other work this cycle to avoid rewriting tests later: https://review.openstack.org/#/c/459112/
16:39:41	openstackgerrit	Monty Taylor proposed openstack/api-wg master: WIP Add document describing consuming discovery https://review.openstack.org/459405
16:50:31	mordred	dtroyer, edleafe, cdent:^^there's the shade patch ported over (and slightly re-organized) - I've still got a few bigger edits though that need to be made before it's ready for _Real_ review
16:51:18	cdent	✔
16:53:05	edleafe	mordred: cool. Added to the queue
19:53:49	mordred	edleafe: dude. examples for this suck :)
19:58:39	mordred	I mean, they're a great idea
19:58:42	mordred	they just suck
20:13:40	edleafe	mordred: I like torturing you
20:14:47	mordred	edleafe: you're doing a good job of it
20:15:10	mordred	otoh - the doc is now 1072 lines long - so I may be torturing YOU too
20:15:38	openstackgerrit	Monty Taylor proposed openstack/api-wg master: WIP Add document describing consuming discovery https://review.openstack.org/459405
20:16:10	mordred	edleafe: okie. I restructured a few thigns to make the main algortihm section a bit less mind-numbing and added specific examples to most of the little "go follow this process" sections
20:17:02	mordred	edleafe: let me know if that's better or worse - no rush or anything
20:29:58	edleafe	mordred: thx
21:44:45	stevemar	nice one dhellmann
23:06:56	mordred	stevemar: you might also find that api-wg patch (https://review.openstack.org/459405) interesting too
23:59:51	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Improve no-auth path https://review.openstack.org/459471
#openstack-sdks - 2017-04-25
06:02:23	openstackgerrit	Merged openstack/python-openstackclient master: Improve no-auth path https://review.openstack.org/459471
07:48:36	openstackgerrit	Takashi NATSUME proposed openstack/python-openstackclient master: Add '--no-live' and '--force' option in 'server migrate' https://review.openstack.org/427565
08:47:57	openstackgerrit	Wang Hui proposed openstack/golang-client master: Add Keystone v3 https://review.openstack.org/450016
09:18:10	openstackgerrit	Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119
10:14:32	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: DNM: Start using 'cliff.sphinxext' https://review.openstack.org/452861
10:15:27	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: DNM: Start using 'cliff.sphinxext' https://review.openstack.org/452861
12:31:19	openstackgerrit	Dean Troyer proposed openstack/osc-lib master: Tell ClientManager when auth is required https://review.openstack.org/459660
12:47:59	openstackgerrit	Rui Chen proposed openstack/python-openstackclient master: Live migration to choose host automatically https://review.openstack.org/459667
12:48:15	sfinucan	stevemar: Think I've got that Sphinx extension working. Turns out getattr works
12:48:36	sfinucan	Pushing a locally modified version now until the patch makes it into cliff itself
12:49:06	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Convert 'server' commands to use autoprogram https://review.openstack.org/458452
12:49:06	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Start using 'cliff.sphinxext' https://review.openstack.org/452861
12:54:56	openstackgerrit	Stephen Finucane proposed openstack/cliff master: Use getattr for Sphinx extension https://review.openstack.org/459671
12:57:38	openstackgerrit	Merged openstack/cliff master: covert test suite to use testrepository https://review.openstack.org/459112
13:02:20	openstackgerrit	Gage Hugo proposed openstack/keystoneauth master: Uncomment warning-is-error for doc building https://review.openstack.org/459673
13:54:46	openstackgerrit	Merged openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924
14:02:11	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: DNM: Enable debug in functional tests https://review.openstack.org/458579
14:11:42	openstackgerrit	Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
14:11:42	openstackgerrit	Monty Taylor proposed openstack/api-wg master: Add document describing consuming discovery https://review.openstack.org/459405
14:11:55	mordred	dtroyer, cdent, edleafe: ^^ merry christmas
14:12:13	mordred	2 more coming just as soon as I can write them
14:12:34	dtroyer	mordred: thanks :) I'm just now looking at stuffs you wrote on 4/11
14:12:42	cdent	mordred: you keep creating things for me to read. I can't decide if I should thank you or hit you
14:13:07	mordred	cdent: both are probably the right call
14:13:18	mordred	dtroyer: the global profile thing in occ?
14:13:31	dtroyer	no, the vendor doc in o-c-c
14:13:42	mordred	yah. sorry, that's what I meant
14:13:54	dtroyer	I think OSC is finally in a place to withstand an o-c-c release so I'm going through that queue
14:13:56	mordred	dtroyer: that's the next thign I want to write up here - and will likely need a spec *somewhere*
14:20:00	edleafe	mordred: in meeting hell this morning. Will get to it later today.
14:20:17	edleafe	And I agree with the choice to both thank and hit
14:20:48	mordred	edleafe: :)
14:20:59	mordred	edleafe: tuesdays is meeting hell day
14:25:32	mordred	edleafe, cdent: at least with this new one, I included specific examples and even json schema documents!
14:27:16	cdent	willikers
14:33:01	edleafe	:-O
14:35:32	openstackgerrit	Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
15:07:20	openstackgerrit	Merged openstack/os-client-config master: Add designateclient to constructors list https://review.openstack.org/448100
15:10:03	dtroyer	stevemar: if you have another free minute, https://review.openstack.org/#/c/459660/ is the osc-lib version of yesterday's OSC auth fix that unblocked the gate
15:24:07	openstackgerrit	Merged openstack/python-openstackclient master: Make test_server.py more elegant and simple https://review.openstack.org/458785
16:21:03	annegentle	hey, cdent around?
16:21:10	cdent	hi annegentle
16:21:16	annegentle	hiya!
16:22:25	annegentle	cdent any reason not to link to the docs guideines in https://review.openstack.org/#/c/421846? I might have missed the discussion
16:23:36	cdent	annegentle:I did in one place (line 227) was there somewhere else that seems better?

Earlier   Later