| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-04-21 | |||
| 12:07:02 | cdent | thanks dtroyer_zz | |
| 12:12:03 | mordred | cdent: you should always sit on livestock! | |
| 12:12:12 | mordred | cdent: and yes, also, congrats! | |
| 12:12:34 | cdent | "A chicken in every pot, a bull under every butt." | |
| 12:12:49 | mordred | cdent: if you can't get to it today, no worries. edleafe has suggested that he thinks it actually is appropriate to submit to the api-wg repo (with a little bit of genericizing) | |
| 12:13:09 | mordred | so I may just work on that a little bit before you get to it anyway | |
| 12:13:46 | cdent | ah, well, cool | |
| 12:14:05 | cdent | the api-wg shall grow to consume all guidelines on how be midly sane | |
| 12:14:12 | mordred | (I replied ot him that I think there are maybe three documents a) how discoverability _should_ work at a perfect point in the future b) how clients can properly consume discoverability today c) any additional things shade does on top of b | |
| 12:15:11 | mordred | and if we have b, we can highlight with a the value of services implementing the guidelines "look at the fewer calls / less work in the client algorithm if you do discoverability corectly" | |
| 12:15:56 | mordred | anywho - I'll work on an edit nad send it to your repo - also, de-shadifying it a little might help dtroyer_zz to tell me what's broken in it from his pov too | |
| 12:16:21 | dtroyer_zz | mordred: I'm about 3/4 through it, fwiw, and only two comments so far | |
| 12:16:59 | cdent | mordred: a and b sound very api-wg useful | |
| 12:22:45 | cgoncalves | can we get a new release of osc-lib (>1.4.0) so that we can get https://review.openstack.org/#/c/458586/ ? all patch sets are failing to verify with osc-lib==1.4.0 | |
| 12:24:33 | dtroyer_zz | cgoncalves: I submitted it last night: https://review.openstack.org/458652 will ping release team again | |
| 12:25:10 | mordred | dtroyer_zz: woot! | |
| 12:25:33 | mordred | dtroyer_zz: oh, also, since you're making a release I'm guessing you're aware, but I also pinged you in response to a user human on the twitters | |
| 12:25:46 | cgoncalves | dtroyer_zz: ah, thanks! | |
| 12:25:56 | dtroyer_zz | ah, twitter… I should pay more attention to that | |
| 12:26:18 | dtroyer_zz | and yes, that's what osc-lib 1.5.0 fixes | |
| 12:27:10 | mordred | I figured | |
| 12:27:20 | dtroyer_zz | it also makes me want to focus purely on a static-linked client | |
| 12:27:20 | mordred | dtroyer_zz: did you get bit by transitive dependency hell? | |
| 12:27:38 | mordred | yah | |
| 12:27:50 | dtroyer_zz | no actually, it was an 'optimization' for auth that I didn't have a complete test for tokens | |
| 12:28:00 | mordred | oh. gross | |
| 12:28:10 | dtroyer_zz | I think I know why it passed the other tests and am working on that now | |
| 12:28:28 | mordred | I actually had a dream last night that yesterday's shade release had missed testing something and that I woke up to a ton of people being angry that I'd broken them | |
| 12:29:25 | dtroyer_zz | I have those with every 'git review' of the releases repo | |
| 12:29:45 | dtroyer_zz | and don't release o-c-c yet, that's also on my short list to fix | |
| 12:31:01 | dtroyer_zz | summary: osc-s -tips job is broken in unusual and mysterious ways that are not easily duplicated in my local environment | |
| 12:32:17 | cgoncalves | dtroyer_zz: +workflow! 1.5.0 is on the way :-) | |
| 12:33:12 | mordred | dtroyer_zz: yah - I looked at the job fail and couldn't figure out why | |
| 12:33:19 | dtroyer_zz | cgoncalves: \o/ it'll take the u-c update to merge to unblock the OSC gate, everything else should be happy with the release | |
| 12:33:21 | mordred | dtroyer_zz: but have I mentioned how happy I am we added that job? | |
| 12:34:15 | dtroyer_zz | I set that job to run OSC in debug mode finally and it's a wealth of failures, and for different reasons, mostly due to removing the ksc auth thing from o-c-c (that needed to go) but that exposed a totally different problem that we'd been masking | |
| 12:35:06 | dtroyer_zz | the osc-lib 1.4.0 just totally confused things yesterday | |
| 12:39:45 | mordred | _awesome_ | |
| 12:48:38 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: DNM For the love of FSM https://review.openstack.org/458819 | |
| 13:39:27 | openstackgerrit | Carlos Goncalves proposed openstack/python-openstackclient master: Add 'data_plane_status' option to Port classes https://review.openstack.org/458626 | |
| 13:49:59 | stevemar | dtroyer_zz: about https://review.openstack.org/#/c/444924/15/openstackclient/compute/v2/server.py | |
| 13:50:06 | stevemar | where are the new args being used? | |
| 13:50:13 | stevemar | did i miss something? | |
| 13:52:33 | dtroyer_zz | stevemar: new args? do you mean the two new options? | |
| 13:58:48 | stevemar | yes | |
| 14:16:49 | dtroyer_zz | they are just convenience options, I'm not sure what motivated the change. Similar to what I did in https://review.openstack.org/302795 to make users' lives simpler | |
| 14:17:53 | cgoncalves | dtroyer_zz: re https://review.openstack.org/#/c/458626/ is there any PUT-only argument in osc where osc does a POST+PUT (in a class Create |
|
| 14:18:40 | dtroyer_zz | There are places where we do multiple calls to achieve the desired result, I'd have to look for some specific examples | |
| 14:19:12 | dtroyer_zz | remember, we're first providing a consistent user interface, and doing what is necessary on the backside to make up for the REST APIs | |
| 14:19:48 | cgoncalves | dtroyer_zz: don't bother if you don't remember by heart. I'll look up | |
| 14:21:05 | cgoncalves | understood. it will feel weird to me having multiple calls for this case in particular but okay | |
| 14:21:37 | dtroyer_zz | once you get past the 1-to-1 mapping of commands to REST APIs it gets easier :) | |
| 14:22:45 | dtroyer_zz | volume create does this | |
| 14:23:15 | cgoncalves | yeah, but in this case it doesn't make much since IMO because data_plane_status represents the status of the underlying data plane and when one creates a new port it doesn't know the status beforehand | |
| 14:23:17 | dtroyer_zz | v1 has 1 extra, v2 has 2 extra calls depending on options | |
| 14:24:06 | cgoncalves | ok, I'll have a look. it's not much of a technical matter but rather if it makes sense allowing setting it on port creation | |
| 14:24:16 | dtroyer_zz | ok, that's what I mean about the use case, if it really is never going to be used we don't need it. | |
| 14:24:37 | dtroyer_zz | but I don't know exactly how it is used… | |
| 14:25:22 | dtroyer_zz | it felt like an enable/disable flag to create and set the desired status in one call | |
| 14:34:37 | cgoncalves | dtroyer_zz: un/setting the attr doesn't change the underlying status. the attr is used just to signal to users the current status, nothing else | |
| 14:35:48 | cgoncalves | I don't see an use case for the multi call, but nevertheless I'll double-check and leave my comment on the review | |
| 14:37:51 | cgoncalves | and only admins and users with a special role can un/set this attribute | |
| 15:12:58 | stevemar | dtroyer_zz: ohhhh duh... "dest=nic" | |
| 15:13:01 | stevemar | that tripped me up | |
| 15:13:18 | stevemar | type=_prefix_checked_value('net-id='), | |
| 15:13:21 | stevemar | weird | |
| 15:19:25 | dtroyer_zz | ya, I stared at that for a bit, argparse is majikal | |
| 16:51:17 | openstackgerrit | Dean Troyer proposed openstack/osc-lib master: Add endpoint hook to BaseAPI https://review.openstack.org/458916 | |
| #openstack-sdks - 2017-04-22 | |||
| 04:41:44 | openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263 | |
| 08:56:25 | openstackgerrit | Merged openstack/python-openstacksdk master: Allow router related functions to receive an ID https://review.openstack.org/457647 | |
| #openstack-sdks - 2017-04-23 | |||
| 14:17:37 | openstackgerrit | Doug Hellmann proposed openstack/cliff master: covert test suite to use testrepository https://review.openstack.org/459112 | |
| 15:47:59 | openstackgerrit | Jordan Pittier proposed openstack/os-client-config master: Make _fix_argv() somewhat compatible with Argparse action='append' https://review.openstack.org/459115 | |
| 18:23:43 | openstackgerrit | Merged openstack/keystoneauth master: Updated inconsistent value of scope parameter https://review.openstack.org/452652 | |
| #openstack-sdks - 2017-04-24 | |||
| 07:12:37 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Remove ipdb installation in tox debug section https://review.openstack.org/459180 | |
| 09:21:28 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: DNM For the love of FSM https://review.openstack.org/458819 | |
| 11:04:40 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: DNM For the love of FSM https://review.openstack.org/458819 | |
| 13:55:24 | dhellmann | dtroyer, stevemar: it's not the most important cliff patch, but it would be good to have before starting some of the other work this cycle to avoid rewriting tests later: https://review.openstack.org/#/c/459112/ | |
| 16:39:41 | openstackgerrit | Monty Taylor proposed openstack/api-wg master: WIP Add document describing consuming discovery https://review.openstack.org/459405 | |
| 16:50:31 | mordred | dtroyer, edleafe, cdent:^^there's the shade patch ported over (and slightly re-organized) - I've still got a few bigger edits though that need to be made before it's ready for _Real_ review | |
| 16:51:18 | cdent | ✔ | |
| 16:53:05 | edleafe | mordred: cool. Added to the queue | |
| 19:53:49 | mordred | edleafe: dude. examples for this suck :) | |
| 19:58:39 | mordred | I mean, they're a great idea | |
| 19:58:42 | mordred | they just suck | |
| 20:13:40 | edleafe | mordred: I like torturing you | |
| 20:14:47 | mordred | edleafe: you're doing a good job of it | |
| 20:15:10 | mordred | otoh - the doc is now 1072 lines long - so I may be torturing YOU too | |
| 20:15:38 | openstackgerrit | Monty Taylor proposed openstack/api-wg master: WIP Add document describing consuming discovery https://review.openstack.org/459405 | |
| 20:16:10 | mordred | edleafe: okie. I restructured a few thigns to make the main algortihm section a bit less mind-numbing and added specific examples to most of the little "go follow this process" sections | |
| 20:17:02 | mordred | edleafe: let me know if that's better or worse - no rush or anything | |
| 20:29:58 | edleafe | mordred: thx | |
| 21:44:45 | stevemar | nice one dhellmann | |
| 23:06:56 | mordred | stevemar: you might also find that api-wg patch (https://review.openstack.org/459405) interesting too | |
| 23:59:51 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Improve no-auth path https://review.openstack.org/459471 | |
| #openstack-sdks - 2017-04-25 | |||
| 06:02:23 | openstackgerrit | Merged openstack/python-openstackclient master: Improve no-auth path https://review.openstack.org/459471 | |
| 07:48:36 | openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: Add '--no-live' and '--force' option in 'server migrate' https://review.openstack.org/427565 | |
| 08:47:57 | openstackgerrit | Wang Hui proposed openstack/golang-client master: Add Keystone v3 https://review.openstack.org/450016 | |
| 09:18:10 | openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119 | |
| 10:14:32 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: DNM: Start using 'cliff.sphinxext' https://review.openstack.org/452861 | |
| 10:15:27 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: DNM: Start using 'cliff.sphinxext' https://review.openstack.org/452861 | |