Posted	Nick	Remark
#openstack-sdks - 2017-03-20
16:37:18	lbragstad	edleafe so what i'm hearing is that it should be possible to exceed the total number of tags limited in a PUT request with individual tag management
16:38:00	edleafe	lbragstad: unless you do server-side checking, yes
16:38:17	lbragstad	edleafe is there any reason to *not* do server-side checking?
16:38:46	lbragstad	(outside of extra validation)
16:39:02	edleafe	that would require that the server do a GET to determine the number of current tags with each PUT request
16:39:27	lbragstad	yeah - it would have to inspect what's already tagged
16:44:23	lbragstad	edleafe thanks for answering my questions - i think i have enough to go do another review of the spec
16:51:08	edleafe	lbragstad: yw
16:54:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Use Sphinx 1.5 warning-is-error https://review.openstack.org/446629
16:54:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Fix option-describe typos https://review.openstack.org/447590
16:54:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Remove local fork of apidoc https://review.openstack.org/447589
16:54:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: docs: Don't include ChangeLog https://review.openstack.org/447588
16:54:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Don't duplicate commands https://review.openstack.org/447592
16:54:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Correct option, envvar markup https://review.openstack.org/447591
16:54:45	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Correct docstrings https://review.openstack.org/447594
16:54:45	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Option arguments are not options https://review.openstack.org/447593
16:54:46	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Don't use murano plugin https://review.openstack.org/447596
16:54:46	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Correct invalid indentation https://review.openstack.org/447595
16:54:47	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Include API modules in docs https://review.openstack.org/447598
16:54:47	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Correct issues with network-topology spec https://review.openstack.org/447597
16:56:45	dtroyer	so Stephen, ^^^^ could have been done as a couple of reviews that batch together similar things
17:08:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Remove local fork of apidoc https://review.openstack.org/447589
17:08:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Fix option-describe typos https://review.openstack.org/447590
17:08:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: doc: Correct option, envvar markup https://review.openstack.org/447591
17:08:44	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Don't duplicate commands https://review.openstack.org/447592
17:57:38	openstackgerrit	Merged openstack/python-openstackclient master: Adds missing flavor information in the server list long command https://review.openstack.org/444934
17:58:32	openstackgerrit	Merged openstack/python-openstackclient master: Add extra filtering options to qos policy list https://review.openstack.org/401131
17:58:38	openstackgerrit	Merged openstack/python-openstackclient master: Non-Admin can't list own projects https://review.openstack.org/376056
18:51:41	stevemar	dtroyer: i have questions on https://review.openstack.org/#/c/387611/55 -- you +2'ed, can you answer them in the authors absence ?
18:53:29	ankur-gupta-f4	stevemar: it is laying down a common command in case there are more agent commands down the line which add the network to an agent.
18:53:34	ankur-gupta-f4	hence the --dhcp flag
18:54:00	stevemar	ankur-gupta-f4: oh okay
18:54:04	ankur-gupta-f4	Your comments about the help text needs to be addressed though
18:54:26	stevemar	ankur-gupta-f4: fix them up and i'll approve it ;)
18:54:26	ankur-gupta-f4	I thought it had already been addressed
18:55:36	ankur-gupta-f4	k gimme a sec
19:02:09	openstackgerrit	Ankur proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC https://review.openstack.org/387611
19:03:16	ankur-gupta-f4	stevemar: done. Double check my work though. It was hurried sitting at airport gate
19:05:28	sshank	stevemar, The dhcp flag check was added to support any future agents needs to be extended.
19:45:19	stevemar	sshank: gotcha
20:08:25	reedip	sshank : checking
20:08:31	reedip	o/
20:11:47	reedip	stevemar , ankur-gupta-f4, sshank : there is an issue with https://review.openstack.org/#/c/387611/55
20:12:23	reedip	not a big one though\
20:12:31	sshank	reedip, Whats it about?
20:12:55	reedip	sshank : change the commit message plz
20:13:33	reedip	sshank : if you are moving the DHCP commands to OSC, please add the DHCP flag to network agent add/list etc
20:13:48	reedip	as mentioned in the https://review.openstack.org/#/c/387611/56/doc/source/command-objects/network-agent.rst
20:13:56	ankur-gupta-f4	I think it is a non-issue
20:14:21	ankur-gupta-f4	Since it is introducing a general command for adding agents to network
20:14:48	ankur-gupta-f4	Not just dhcp. Even though currently dhcp is the only agent type supported
20:15:08	reedip	ankur-gupta-f4 : its not a big issue , but it does cause a bit of a misunderstanding in the inital review ... :)
20:15:59	ankur-gupta-f4	Up to cores. Im out till tmw. Adios amigos.
20:16:33	reedip	hehe ... asta la vista !
20:18:55	reedip	sshank: couple of nits are there
20:19:04	reedip	posting them up in another 5 min
20:22:14	reedip	done
20:36:05	sindhu	stevemar: hi, ping?
20:40:18	stevemar	sindhu: pong, whaddup
20:41:06	sindhu	stevemar: hi, needed your review on https://review.openstack.org/#/c/379813/
20:42:58	reedip	stevemar, sindhu : follow up ( related patch ) : https://review.openstack.org/#/c/376311/ :D
20:44:02	sindhu	reedip: yup, looking :)
20:44:39	reedip	stevemar : care to bless https://review.openstack.org/#/c/383025/ as well, if you are there :)
20:45:48	stevemar	reedip sindhu why can't you guys ever give me easy patches :P
20:46:09	reedip	stevemar : Has anyone left any easy patch :P
20:46:29	reedip	besides , its fun to irritate you with the bigger ones :P
20:46:40	sindhu	stevemar: haha :)
20:47:15	ZZelle	dtroyer, hi
20:47:43	stevemar	hehe, give me a day or so to review, we're racing to a deadline internally
20:47:48	stevemar	tomorrow :(
20:47:56	reedip	ok stevemar
20:48:10	sindhu	stevemar: sure, np :)
20:48:32	dtroyer	ZZelle: hey
20:48:41	reedip	sindhu : do you also need a day or can I ping you repeatedly till you doint review ??? :P
20:49:29	sindhu	reedip: hehe ... I will do it today :) soon after the networking meeting
20:49:55	ZZelle	dtroyer, could you relook at https://review.openstack.org/371786 ?
20:53:23	openstackgerrit	Merged openstack/python-openstackclient master: Make MAC address of port updatable https://review.openstack.org/442543
20:53:43	reedip	meeting ??? :O
20:53:56	reedip	you mean the weekly neutron one ?
20:54:01	sindhu	reedip: yup
20:54:12	reedip	thats 12 hours from now ..
20:54:19	reedip	atleast !
20:54:20	reedip	:)
20:54:22	reedip	but ok :D
20:54:36	sindhu	reedip: it's today right in 6min
20:54:45	reedip	What ???????/
20:54:51	sindhu	last week it was on tuesday
20:54:56	reedip	oh ... yeah
20:54:57	sindhu	this week Monday
20:55:01	reedip	thanks for the heads up :D
20:55:07	sindhu	:)
20:55:10	reedip	my calnedar is screwed
21:04:21	reedip	sindhu : hey do you know the VPNaaS patch for OSC ?
21:05:06	reedip	got it sindhu
21:09:04	sindhu	reedip: ok
21:09:25	dtroyer	ZZelle: about the option name, we have been consistent with how we use —fixed-ip, with the kv pairs as you mentioned, but I'd rather not create a new option name for this. We've used —fixed-ip-address in the floating IP commands and it takes only an IP address as an argument. How do you feel about that?
21:11:53	openstackgerrit	Adrian Otto proposed openstack/service-types-authority master: WIP: Add coe-cluster service type https://review.openstack.org/447694
21:12:14	ZZelle	dtroyer, honestly i have no opinion if fixed-ip-address has been somewhere else let's go for it
21:14:47	dtroyer	cool…leaving comments
21:16:23	dtroyer	heh, on huanxuan's other comment about the relnote name, I do find the 'bug-####' naming helpful as I am going through the release notes cleaning things up. no need to change, just thought I'd point out where I do find them meaningful.

Earlier   Later