| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-03-14 | |||
| 02:16:56 | reedip | ankur-gupta-f4 : https://review.openstack.org/#/c/376311/ ???? | |
| 02:20:29 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Functional test for subnet_pool https://review.openstack.org/440150 | |
| 02:44:38 | stevemar | ankur-gupta-f4: probably just skip the tests IMO | |
| 02:45:03 | stevemar | ankur-gupta-f4: it would be nice to check for that exception and skip the test | |
| 02:47:39 | reedip | stevemar : hello :) | |
| 02:47:50 | stevemar | reedip: mr reedip | |
| 02:47:58 | reedip | ?? | |
| 02:50:01 | openstackgerrit | luqitao proposed openstack/osc-lib master: Replace six.iteritems() with .items() https://review.openstack.org/445273 | |
| 02:51:31 | reedip | ankur-gupta-f4, stevemar : How does OpenstackClient search for new Commands | |
| 02:51:45 | reedip | ankur-gupta-f4, stevemar : even if they are registered in tox.ini | |
| 02:57:34 | stevemar | reedip: you mean setup.cfg :) | |
| 02:57:44 | reedip | sorry , yeah stevemar | |
| 02:57:48 | reedip | except setup.cfg | |
| 02:57:59 | stevemar | reedip: you have to add it to setup.cfg and 'install' it | |
| 02:58:14 | stevemar | i normally create a new virtualenv by doing $ virtualenv testcmd | |
| 02:58:26 | stevemar | source it, $ source testcmd/bin/activate | |
| 02:58:34 | stevemar | go to my OSC directory | |
| 02:58:41 | stevemar | edit setup.cfg for the new command | |
| 02:58:52 | stevemar | and 'install' osc locally in my virtualenv | |
| 02:59:02 | stevemar | $ pip install -e . | |
| 02:59:10 | stevemar | ^ from OSC root directory | |
| 02:59:30 | stevemar | when you run $ openstack --version you'll see a .dev version installed | |
| 02:59:40 | stevemar | that should have the new command | |
| 02:59:50 | stevemar | you can run $ which openstack and see where it points also | |
| 03:00:04 | stevemar | when you're done with the virtualenv just run, $ deactivate | |
| 03:00:15 | stevemar | you can then rm -rf the virtualenv directory | |
| 03:01:42 | reedip | stevemar : the command is not in OSC , its in a separate repo , which extends OSC plugins | |
| 03:02:16 | stevemar | reedip: same principals i believe, install OSC in the virtualenv then the other repo | |
| 03:03:28 | reedip | lemme try | |
| 03:06:29 | reedip | stevemar : what if requirements are not met :) | |
| 03:09:37 | reedip | stevemar : getting an error | |
| 03:09:42 | reedip | in requirements | |
| 04:13:23 | ankur-gupta-f4 | reedip: it should work in the same way | |
| 04:13:37 | ankur-gupta-f4 | R u talking about the TaaS commands? | |
| 04:23:47 | rabel__b1 | can someone help me with https://review.openstack.org/#/c/444924/ ? two functional tests in the gate job are failing, but it seems to have nothing to do with the change. one of the test i also saw failing for other changes that seem to be unrelated. | |
| 04:24:31 | ankur-gupta-f4 | rabel__b1: the image tests are temporarily broken. | |
| 04:25:00 | ankur-gupta-f4 | Till its resolved avoid rechecking | |
| 04:36:49 | rabel__b1 | ankur-gupta-f4: ok, thank you. | |
| 04:52:14 | reedip | ankur-gupta-f4 : all working :) dont worry .. I worked around stevemar's solution :D | |
| 04:52:53 | ankur-gupta-f4 | K | |
| 05:04:59 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add extra filtering options to qos policy list https://review.openstack.org/401131 | |
| 08:23:29 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Narrow expected responses for CheckUserInGroup https://review.openstack.org/445257 | |
| 08:29:25 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add status filtering options to port list https://review.openstack.org/444810 | |
| 11:11:17 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add status filtering options to port list https://review.openstack.org/444810 | |
| 11:53:17 | rabel | does anyone know about the status of the broken image functional tests for osc? | |
| 13:07:59 | elmiko | cdent: saw your ping way too late yesterday, isn't that email basically sending us back down the openapi rabbit hole? | |
| 13:08:29 | cdent | elmiko: I think so, but wasn't sure, so wanted to check in. | |
| 13:08:49 | cdent | Thanks for pinging me about it though, as I completely forgot to follow up like I promised I would | |
| 13:09:00 | elmiko | hehe =) | |
| 13:49:22 | openstackgerrit | Bence Romsics proposed openstack/python-openstacksdk master: Add port property: trunk_details https://review.openstack.org/445501 | |
| 14:50:31 | openstackgerrit | Pepijn Oomen proposed openstack/python-openstacksdk master: Expose ha_state property from HA enabled L3 Agents. https://review.openstack.org/445520 | |
| 14:53:34 | reedip | o/ | |
| 15:14:19 | ynirk | I faced a problem with the command `openstack user show 12345 --domain Default` returning the error "get() got an unexpected keyword argument 'domain_id'" | |
| 15:14:19 | ynirk | I am working on an openstack infrastructure where some usernames are only numeric (12345 for example) in a specific domain | |
| 15:14:19 | ynirk | Hi, I hope I am in the right place | |
| 15:14:20 | ynirk | I am more of an ops so I prefer asking for your advice before submitting a bug and a patch. | |
| 15:14:20 | ynirk | Wouldn't it be more coherent with the other try/except to have a 'pass' at https://github.com/openstack/osc-lib/blob/master/osc_lib/utils.py#L124 instead of a 'raise' and let the function raise a NotFound at the end if no resource was found ? | |
| 15:14:20 | openstack | Launchpad bug 1671179 in python-keystoneclient "Unable to retrieve a numeric only username within a domain" [Undecided,In progress] - Assigned to Julien Lavesque (ynirk) | |
| 15:14:20 | ynirk | All get requests (in all openstack components) made with a numeric name and kwargs might return a TypeError if the method's prototype doesn't handle kwargs. | |
| 15:14:20 | ynirk | I first thought of a keystoneclient problem (with the bug https://bugs.launchpad.net/python-keystoneclient/+bug/1671179) but after deeper analysis I think the problem is in find_resource from osc-lib/utils.py | |
| 15:14:21 | ynirk | What do you think ? | |
| 15:16:45 | breton | ynirk: > All get requests (in all openstack components) made with a numeric name and kwargs might return a TypeError if the method's prototype doesn't handle kwargs. | |
| 15:16:51 | breton | ynirk: why is that? | |
| 15:21:50 | dtroyer | ynirk: I think you may be right there | |
| 15:22:22 | dtroyer | I am trying to recall what exceptions I thought should be raised at that point | |
| 15:23:49 | dtroyer | this function is a combination of 3 or 4 of these from individual libs, so working back to that may be fun. Changing it now may also change things in unexpected ways | |
| 15:24:33 | dtroyer | the choices are to add a type(ex) check for TypeError or to remove them altogether | |
| 15:25:31 | ynirk | dtroyer yes exactly but I was not sure of the impact | |
| 15:25:33 | dtroyer | I'm going to have to think on that a bit. if you have time, you may want to try proposing temoving the if in lines 120-124 and just doing a pass there and see what tests/jobs fail. | |
| 15:26:20 | dtroyer | it would be safer to add the TypeError check though | |
| 15:28:15 | ynirk | Ok I also think it is safer and shouldn't break anything | |
| 15:28:28 | ynirk | I was wondering of the reason for the raise (compared to the other try/except) | |
| 15:31:57 | ynirk | I will try to add the TypeError check and see if some tests fail | |
| 15:32:09 | ynirk | Thanks for the feedback | |
| 15:51:11 | josecastroleon | hi | |
| 15:51:35 | josecastroleon | the gate in openstackclient is failing since devstack removed glance v1 | |
| 15:51:58 | ankur-gupta-f4 | yes | |
| 15:53:05 | josecastroleon | shall we remove the glance v1 test? | |
| 15:53:47 | ankur-gupta-f4 | https://www.irccloud.com/pastebin/p3o3Cgo2/ | |
| 15:54:05 | dtroyer | no, we need to continue to support v1 for some time, for now I'd prefer to re-enable Glance v1 in DevStack | |
| 15:54:20 | dtroyer | at least for a time | |
| 15:54:36 | ankur-gupta-f4 | stevemar suggested doing a check first. If exception raised then skip tests | |
| 15:54:45 | josecastroleon | fine, but then we may need to enable glance v1 in the gate | |
| 15:54:48 | josecastroleon | right? | |
| 15:55:14 | dtroyer | yes, that's on my list, I'm fixing cliff's gate ATM | |
| 15:55:23 | josecastroleon | ok thx | |
| 16:04:59 | openstackgerrit | Dean Troyer proposed openstack/cliff master: Update cmd2 fix to still work with 0.6.7 https://review.openstack.org/445552 | |
| 16:06:10 | dtroyer | josecastroleon, ankur-gupta-f1: https://review.openstack.org/#/c/445553/ re-enables Image v1 for OSC functional jobs | |
| 16:18:55 | openstackgerrit | Merged openstack/golang-client master: Update for CTI ps4 https://review.openstack.org/444499 | |
| 16:27:55 | openstackgerrit | Bence Romsics proposed openstack/python-openstacksdk master: Add port property: trunk_details https://review.openstack.org/445501 | |
| 16:30:59 | ynirk | dtroyer tests pass with the two modifications. To be sure I will add the TypeError check | |
| 16:43:36 | reedip | sindhu : hi | |
| 16:44:45 | sindhu | reedip: hey wass up | |
| 16:45:12 | reedip | nothin much sindhu : just wanted to know about the floating ip patch | |
| 16:45:30 | sindhu | reedip: it's all ready right? | |
| 16:45:53 | reedip | no comments from anyone else, I guess | |
| 16:45:56 | reedip | :| | |
| 16:46:53 | sindhu | reedip: yeah! waiting for reviews/getting merged :) | |
| 16:47:47 | reedip | stevemar , can you come to our rescue ???? :D | |
| 18:52:40 | openstackgerrit | Merged openstack/python-openstacksdk master: Add port property: trunk_details https://review.openstack.org/445501 | |