| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-03-13 | |||
| 18:39:12 | openstackgerrit | Dean Troyer proposed openstack/cliff master: Fix broken test with cmd2 0.7.0 https://review.openstack.org/444951 | |
| 18:39:44 | dtroyer | stevemar: ^^^ will unblock cliff's queue if you have a minute | |
| 20:40:08 | openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Add --network and --port to server create https://review.openstack.org/444924 | |
| 20:50:19 | openstackgerrit | Merged openstack/python-openstacksdk master: Add image download example https://review.openstack.org/444940 | |
| 21:05:40 | openstackgerrit | Merged openstack/os-client-config master: OVH supports qcow2 https://review.openstack.org/445042 | |
| 21:06:01 | openstackgerrit | Merged openstack/cliff master: Fix broken test with cmd2 0.7.0 https://review.openstack.org/444951 | |
| 21:08:34 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/432260 | |
| 21:09:38 | openstackgerrit | Steve Martinelli proposed openstack/cliff master: Remove support for py34 https://review.openstack.org/430577 | |
| 23:26:44 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Non-Admin can't list own projects https://review.openstack.org/376056 | |
| 23:39:40 | reedip | o/ | |
| 23:48:30 | openstackgerrit | Merged openstack/cliff master: Remove support for py34 https://review.openstack.org/430577 | |
| #openstack-sdks - 2017-03-14 | |||
| 00:14:41 | openstackgerrit | Merged openstack/cliff master: Updated from global requirements https://review.openstack.org/440033 | |
| 00:41:30 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Narrow expected responses for CheckUserInGroup https://review.openstack.org/445257 | |
| 01:08:58 | stevemar | dtroyer: glance tests are borked | |
| 01:15:21 | stevemar | dtroyer: looks like we're setting IMAGE_API to 1: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/image/v1/test_image.py#L29 | |
| 01:15:31 | stevemar | 21:11 stevemar: HTTPMultipleChoices (HTTP 300) Requested version of OpenStack Images API is not available. | |
| 01:15:31 | stevemar | 21:11 stevemar: Command 'openstack image create 2c10175aea9041aaabd5b2de90285e76 -f value -c name' returned non-zero exit status 1. | |
| 01:15:31 | stevemar | 21:10 stevemar: sample failure: http://logs.openstack.org/20/437320/2/gate/gate-osc-dsvm-functional-ubuntu-xenial/8c6e99b/testr_results.html.gz | |
| 01:16:00 | stevemar | dtroyer: ah its all mriedem's fault | |
| 01:16:02 | stevemar | https://github.com/openstack-dev/devstack/commit/80e82eac4cd127a68fceea37270d09f9cbd71c75 | |
| 01:29:36 | ankur-gupta-f4 | stevemar: Why keep v1 around if deprecated since Newton? | |
| 01:39:42 | stevemar | ankur-gupta-f4: you shouldn't be removing APIs, like ever | |
| 01:40:19 | stevemar | ankur-gupta-f4: the change in devstack made it so image v1 isn't in the pipeline by default (because it is, as you said, deprecated) | |
| 01:40:31 | stevemar | ankur-gupta-f4: our tests assume its there, we'll have to change that | |
| 01:41:43 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add extra filtering options to qos policy list https://review.openstack.org/401131 | |
| 01:43:40 | ankur-gupta-f4 | stevemar: i meant the tests :| | |
| 01:46:06 | ankur-gupta-f4 | Would you change the tests or would you enable glance v1 in the test env? | |
| 02:16:40 | reedip | stevemar : hi , any comments on https://review.openstack.org/#/c/383025/ ? | |
| 02:16:56 | reedip | ankur-gupta-f4 : https://review.openstack.org/#/c/376311/ ???? | |
| 02:20:29 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Functional test for subnet_pool https://review.openstack.org/440150 | |
| 02:44:38 | stevemar | ankur-gupta-f4: probably just skip the tests IMO | |
| 02:45:03 | stevemar | ankur-gupta-f4: it would be nice to check for that exception and skip the test | |
| 02:47:39 | reedip | stevemar : hello :) | |
| 02:47:50 | stevemar | reedip: mr reedip | |
| 02:47:58 | reedip | ?? | |
| 02:50:01 | openstackgerrit | luqitao proposed openstack/osc-lib master: Replace six.iteritems() with .items() https://review.openstack.org/445273 | |
| 02:51:31 | reedip | ankur-gupta-f4, stevemar : How does OpenstackClient search for new Commands | |
| 02:51:45 | reedip | ankur-gupta-f4, stevemar : even if they are registered in tox.ini | |
| 02:57:34 | stevemar | reedip: you mean setup.cfg :) | |
| 02:57:44 | reedip | sorry , yeah stevemar | |
| 02:57:48 | reedip | except setup.cfg | |
| 02:57:59 | stevemar | reedip: you have to add it to setup.cfg and 'install' it | |
| 02:58:14 | stevemar | i normally create a new virtualenv by doing $ virtualenv testcmd | |
| 02:58:26 | stevemar | source it, $ source testcmd/bin/activate | |
| 02:58:34 | stevemar | go to my OSC directory | |
| 02:58:41 | stevemar | edit setup.cfg for the new command | |
| 02:58:52 | stevemar | and 'install' osc locally in my virtualenv | |
| 02:59:02 | stevemar | $ pip install -e . | |
| 02:59:10 | stevemar | ^ from OSC root directory | |
| 02:59:30 | stevemar | when you run $ openstack --version you'll see a .dev version installed | |
| 02:59:40 | stevemar | that should have the new command | |
| 02:59:50 | stevemar | you can run $ which openstack and see where it points also | |
| 03:00:04 | stevemar | when you're done with the virtualenv just run, $ deactivate | |
| 03:00:15 | stevemar | you can then rm -rf the virtualenv directory | |
| 03:01:42 | reedip | stevemar : the command is not in OSC , its in a separate repo , which extends OSC plugins | |
| 03:02:16 | stevemar | reedip: same principals i believe, install OSC in the virtualenv then the other repo | |
| 03:03:28 | reedip | lemme try | |
| 03:06:29 | reedip | stevemar : what if requirements are not met :) | |
| 03:09:37 | reedip | stevemar : getting an error | |
| 03:09:42 | reedip | in requirements | |
| 04:13:23 | ankur-gupta-f4 | reedip: it should work in the same way | |
| 04:13:37 | ankur-gupta-f4 | R u talking about the TaaS commands? | |
| 04:23:47 | rabel__b1 | can someone help me with https://review.openstack.org/#/c/444924/ ? two functional tests in the gate job are failing, but it seems to have nothing to do with the change. one of the test i also saw failing for other changes that seem to be unrelated. | |
| 04:24:31 | ankur-gupta-f4 | rabel__b1: the image tests are temporarily broken. | |
| 04:25:00 | ankur-gupta-f4 | Till its resolved avoid rechecking | |
| 04:36:49 | rabel__b1 | ankur-gupta-f4: ok, thank you. | |
| 04:52:14 | reedip | ankur-gupta-f4 : all working :) dont worry .. I worked around stevemar's solution :D | |
| 04:52:53 | ankur-gupta-f4 | K | |
| 05:04:59 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add extra filtering options to qos policy list https://review.openstack.org/401131 | |
| 08:23:29 | openstackgerrit | Colleen Murphy proposed openstack/python-openstackclient master: Narrow expected responses for CheckUserInGroup https://review.openstack.org/445257 | |
| 08:29:25 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add status filtering options to port list https://review.openstack.org/444810 | |
| 11:11:17 | openstackgerrit | Lv Jiawei proposed openstack/python-openstackclient master: Add status filtering options to port list https://review.openstack.org/444810 | |
| 11:53:17 | rabel | does anyone know about the status of the broken image functional tests for osc? | |
| 13:07:59 | elmiko | cdent: saw your ping way too late yesterday, isn't that email basically sending us back down the openapi rabbit hole? | |
| 13:08:29 | cdent | elmiko: I think so, but wasn't sure, so wanted to check in. | |
| 13:08:49 | cdent | Thanks for pinging me about it though, as I completely forgot to follow up like I promised I would | |
| 13:09:00 | elmiko | hehe =) | |
| 13:49:22 | openstackgerrit | Bence Romsics proposed openstack/python-openstacksdk master: Add port property: trunk_details https://review.openstack.org/445501 | |
| 14:50:31 | openstackgerrit | Pepijn Oomen proposed openstack/python-openstacksdk master: Expose ha_state property from HA enabled L3 Agents. https://review.openstack.org/445520 | |
| 14:53:34 | reedip | o/ | |
| 15:14:19 | ynirk | I faced a problem with the command `openstack user show 12345 --domain Default` returning the error "get() got an unexpected keyword argument 'domain_id'" | |
| 15:14:19 | ynirk | I am working on an openstack infrastructure where some usernames are only numeric (12345 for example) in a specific domain | |
| 15:14:19 | ynirk | Hi, I hope I am in the right place | |
| 15:14:20 | ynirk | I am more of an ops so I prefer asking for your advice before submitting a bug and a patch. | |
| 15:14:20 | ynirk | Wouldn't it be more coherent with the other try/except to have a 'pass' at https://github.com/openstack/osc-lib/blob/master/osc_lib/utils.py#L124 instead of a 'raise' and let the function raise a NotFound at the end if no resource was found ? | |
| 15:14:20 | openstack | Launchpad bug 1671179 in python-keystoneclient "Unable to retrieve a numeric only username within a domain" [Undecided,In progress] - Assigned to Julien Lavesque (ynirk) | |
| 15:14:20 | ynirk | All get requests (in all openstack components) made with a numeric name and kwargs might return a TypeError if the method's prototype doesn't handle kwargs. | |
| 15:14:20 | ynirk | I first thought of a keystoneclient problem (with the bug https://bugs.launchpad.net/python-keystoneclient/+bug/1671179) but after deeper analysis I think the problem is in find_resource from osc-lib/utils.py | |
| 15:14:21 | ynirk | What do you think ? | |
| 15:16:45 | breton | ynirk: > All get requests (in all openstack components) made with a numeric name and kwargs might return a TypeError if the method's prototype doesn't handle kwargs. | |
| 15:16:51 | breton | ynirk: why is that? | |
| 15:21:50 | dtroyer | ynirk: I think you may be right there | |
| 15:22:22 | dtroyer | I am trying to recall what exceptions I thought should be raised at that point | |
| 15:23:49 | dtroyer | this function is a combination of 3 or 4 of these from individual libs, so working back to that may be fun. Changing it now may also change things in unexpected ways | |
| 15:24:33 | dtroyer | the choices are to add a type(ex) check for TypeError or to remove them altogether | |
| 15:25:31 | ynirk | dtroyer yes exactly but I was not sure of the impact | |
| 15:25:33 | dtroyer | I'm going to have to think on that a bit. if you have time, you may want to try proposing temoving the if in lines 120-124 and just doing a pass there and see what tests/jobs fail. | |
| 15:26:20 | dtroyer | it would be safer to add the TypeError check though | |
| 15:28:15 | ynirk | Ok I also think it is safer and shouldn't break anything | |
| 15:28:28 | ynirk | I was wondering of the reason for the raise (compared to the other try/except) | |