Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-03-01
17:41:11 dtroyer without knowing much else, such as the specifics of the error that is returned, I would let Neutron validate the agent id
17:41:32 reedip ankur-gupta-f1 : so your proposal is to have "network agent add router" and "neutron agent add network " as 2 different CLIs ?
17:41:43 dtroyer unless that is something we can easily validate because we already have the information without another trip to the server
17:41:46 reedip dtroyer : yeah, neutron can do that
17:42:04 ankur-gupta-f4 reedip: yes
17:42:17 reedip dtoryer; No , we need to fetch the agent type from its ID from the server, so its better to let Neutron handle it, if possible
17:43:04 reedip ankur-gupta-f4 ( I am confused which ID is on ) : but using "network agent add --XXX" makes handling simpler , isnt it?
17:44:59 ankur-gupta-f4 reedip: how would you implement that.
17:45:37 dtroyer reedip: recall the structure of add/remove commands, with 2 resources
17:45:57 reedip dtroyer: yeah that thought crossed my mind
17:47:14 reedip ankur-gupta-f4 : do we need to keep separate resources for router and network ?
17:47:35 reedip my implementation may be wrong
17:48:05 ankur-gupta-f4 Yea. There should be 2 args when adding
17:49:34 ankur-gupta-f4 No need to overcomplicate
17:50:24 dtroyer network agent add XXX [[—<agent-type-option>] <agent-id> <XXX-name-or-id>
17:51:15 sshank dtroyer: +1
17:52:10 ankur-gupta-f4 Yes. +1
17:54:55 reedip yeah, kinda what I would like.. handling things in one go +1 dtroyer
17:57:48 ankur-gupta-f4 30 min later we finalize the solution we came up with at the beginning 😞
17:58:02 ankur-gupta-f4 Thanks for the feedback everyone
17:58:12 ankur-gupta-f4 sshank: we got work to do
17:58:46 sshank Thanks all. Finally a conclusion. :D \o/
18:02:08 ankur-gupta-f4 sshank: u say that now
18:02:12 reedip ankur-gupta-f4 : HA HA HAAA
18:02:22 reedip :P
18:03:16 ankur-gupta-f4 sshank: expect heavy doses of -1s... mostly from me
18:03:20 openstackgerrit Merged openstack/python-openstackclient master: Auto allocated topology for OSC https://review.openstack.org/391331
18:04:24 reedip ankur-gupta-f4 : can you review the floating ip set/unset
18:04:48 ankur-gupta-f4 Yea
18:04:52 reedip sindhu might just hit me with a broom otherwise :P
18:08:18 sindhu reedip: lol .... naaa i won't :D
18:11:03 ankur-gupta-f4 reedip: i gave a quick glance. Let me get back from lunch and take better look
18:11:42 reedip gn then .... have been sleep deprived since yesterday ! Catch you tomorrow
18:12:01 ankur-gupta-f4 Goodnight man
18:12:15 ankur-gupta-f4 Thx for helping out with the FIP stuff
18:14:37 reedip Now dont say such sweet things, I might just wake up in 2 hours !
18:14:39 reedip :P
19:10:48 openstackgerrit Merged openstack/python-openstackclient master: Add Cinder v3 client support for volumes https://review.openstack.org/412614
19:36:38 openstackgerrit Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797
19:37:33 openstackgerrit Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797
20:09:20 JayF /win 32
20:09:23 JayF whoops :/
20:50:35 openstackgerrit Gage Hugo proposed openstack/keystoneauth master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/439797
20:52:42 openstackgerrit Merged openstack/python-openstacksdk master: Add wait_for_xxx methods to cluster proxy https://review.openstack.org/439490
20:57:02 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Update devstack config to point to a valid image https://review.openstack.org/439847
21:05:02 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC https://review.openstack.org/387611
21:09:10 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce neutron flavor associate, disassociate to OSC https://review.openstack.org/403907
21:20:29 openstackgerrit Nakul Dahiwade proposed openstack/python-openstackclient master: Jsonify meter and meter rule functional tests https://review.openstack.org/439854
21:41:40 openstackgerrit Merged openstack/osc-lib master: Updated from global requirements https://review.openstack.org/439332
#openstack-sdks - 2017-03-02
01:20:42 openstackgerrit Merged openstack/python-openstacksdk master: Update devstack config to point to a valid image https://review.openstack.org/439847
02:18:53 openstackgerrit Rodrigo Duarte proposed openstack/python-openstackclient master: Use *_as_ids instead *_as_list https://review.openstack.org/435972
02:26:11 openstackgerrit Rodrigo Duarte proposed openstack/python-openstackclient master: Use *_as_ids instead *_as_list https://review.openstack.org/435972
03:09:21 openstackgerrit Ankur proposed openstack/python-openstackclient master: Nit: Trivial doc formatting fix for network flavor https://review.openstack.org/439965
04:24:44 reedip_1 ankur-gupta-f1 : 0/
05:06:53 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/440102
05:06:56 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/440103
05:07:30 ankur-gupta-f4 reedip_: hey buddy
05:10:51 openstackgerrit OpenStack Proposal Bot proposed openstack/cliff master: Updated from global requirements https://review.openstack.org/440033
05:13:38 openstackgerrit OpenStack Proposal Bot proposed openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/439317
05:20:08 openstackgerrit OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/440084
05:22:00 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/440102
05:22:03 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/440103
05:25:51 openstackgerrit OpenStack Proposal Bot proposed openstack/cliff master: Updated from global requirements https://review.openstack.org/440033
05:28:17 openstackgerrit OpenStack Proposal Bot proposed openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/439317
05:34:43 openstackgerrit OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/440084
05:36:35 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/440102
05:36:38 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/440103
06:10:21 ankur-gupta-f4 reedip_: ping as per FIP
06:10:58 reedip_ fixed-ip needs to be a string, right ? ankur-gupta-f4
06:11:09 reedip_ the handling is done at the neutron-server end
06:11:48 ankur-gupta-f4 double checking
06:13:34 reedip_ https://github.com/openstack/neutron-lib/blob/485928f654e5daa742ec93fb7845516b4ebe99a1/neutron_lib/api/validators.py#L429
06:16:13 ankur-gupta-f4 k just wondering
06:16:33 ankur-gupta-f4 but the unset is a valid point.
06:17:00 reedip_ That is taken care in the UT
06:17:13 reedip_ assertNone does that, I guess
06:19:45 ankur-gupta-f4 opinion. I will remove the 01
06:19:45 ankur-gupta-f4 given the complexity of removing/deleting resources (as seen with how many times the test has been rewritten order wise). I think it instead of 'floating ip unset port' coming in in the cleanUp, it should be done like the the other commands where it is run, a fip or port show is done and confirmed that the attachment no longer exists. But that is just an
06:19:47 ankur-gupta-f4 -1
06:20:01 ankur-gupta-f4 thanks for the answers
06:22:53 ankur-gupta-f4 reedip_: headed to bed. talk to you in morning
06:23:22 reedip_ ankur-gupta-f4 : thanks :)
06:24:39 openstackgerrit jiahui.qiang proposed openstack/python-openstackclient master: Functional test for subnet_pool https://review.openstack.org/440150
09:13:47 openstackgerrit Rico Lin proposed openstack/keystoneauth master: Update test requirement https://review.openstack.org/440236
09:20:13 openstackgerrit Merged openstack/python-openstackclient master: Nit: Trivial doc formatting fix for network flavor https://review.openstack.org/439965
12:23:08 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient master: Fix NoneType error for volume snapshot create command https://review.openstack.org/440497
13:24:23 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient master: Remove deprecated "ip floating *" commands https://review.openstack.org/440550
13:30:00 openstackgerrit Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/440103
15:01:59 reedip_1 o/
15:05:20 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient master: Remove deprecated "ip floating *" commands https://review.openstack.org/440550
15:45:00 openstackgerrit Nakul Dahiwade proposed openstack/python-openstackclient master: OSC Network Flavor Profile https://review.openstack.org/396783
15:53:31 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC https://review.openstack.org/387611
16:22:23 openstackgerrit Merged openstack/api-wg master: Fix typo in the doc https://review.openstack.org/436865
16:39:08 dims stevemar : dtroyer : does this ring a bell?
16:39:10 dims 2017-03-02 16:31:36.894 | Failed to delete floating_ip with name or ID '0759cfd6-2e42-410b-ab70-7ff81d19562c': 'Proxy' object has no attribute 'session'
16:39:10 dims 2017-03-02 16:31:35.234 | + /opt/stack/new/grenade/projects/70_cinder/resources.sh:destroy:205 : openstack floating ip delete 0759cfd6-2e42-410b-ab70-7ff81d19562c
16:40:12 dims could it be from openstacksdk===0.9.14?
16:44:38 openstackgerrit Nakul Dahiwade proposed openstack/python-openstackclient master: Jsonify meter and meter rule functional tests https://review.openstack.org/439854
16:58:20 reedip_1 dims : this issue was occurring with the older version of devstack
16:58:36 reedip_1 I think there was a new patch which fixed it

Earlier   Later