Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-02-16
19:21:45 dtroyer OSC is based around named resources, many of which are qualified with names that happen to match API service types, but some do not. and
19:21:55 reedip_1 I agree with ankur-gupta-f4 , remove this from common till we do not have more extensions to list :P
19:22:09 dtroyer reedip_: that doesn't make it a good idea or one that should be copied elsewhere. it isn't
19:23:38 reedip_1 dtroyer : I agree , if it has been removed from other projects, neutron can also look in the future to remove the same , if possible . But till it is not, we can use "openstack extension list --network " to list network extensions, couldnt we ?
19:23:41 dtroyer I would also argue that we prefixed some resources with 'network' out of habit that didn't need it, again due to the misconception that "that is the way it should be done" rather than to fully-qualify the resource
19:24:49 dtroyer reedip_: yes, that would work. also, since no other API has extensions (in the OSC repo anyway) —network can be optional. if others appear then no option simply lists them all
19:24:49 ankur-gupta-f4 reedip_1: note the the command is extension show. List is already in place.
19:25:22 dtroyer why does a show command need a type identifier?
19:25:47 dtroyer to show something you have to have a name or ID to begin with?
19:26:04 reedip_1 sorry ankur-gupta-f4 , misread the command
19:26:18 ankur-gupta-f4 because list extensions exists for all core resources. But extension show only is a network command
19:26:39 ankur-gupta-f4 volume and compute APIs don't support the 'show' which returns more details about a specific API extension
19:27:13 dtroyer so either throw an exception for them (not found?) or return an empty or minimal result set
19:27:49 sindhu so i'll still keep in common ?
19:27:55 dtroyer yes
19:28:05 ankur-gupta-f4 but update help text plz
19:28:12 ankur-gupta-f4 as per John Davidge's comments
19:28:33 sindhu okay will do
19:28:45 reedip_1 dtroyer : but is keeping this implementation in common correct ?
19:29:13 reedip_1 I mean that was your query , and I found it right. Wondering what changed your mind :)
19:30:28 dtroyer phase of moon?
19:30:41 reedip_1 wont change till tomorrow :P
19:30:53 dtroyer I don't recall exactly what was the rationaly, but the way I understand it today may be different
19:31:24 reedip_1 so should we take this with a pinch of salt ???
19:32:30 ankur-gupta-f4 moving on though. I want to bring up these updated functional test stuff coming in
19:32:47 dtroyer am I not allowed to change my mind if my understanding changes?
19:33:10 reedip_1 dtroyer : no you are , for sure :)
19:33:25 dtroyer also, given that a number of other commands have dependencies on knowing if extensions are installed/enabled, this is one area I would support putting into a common network lib (network.v2.common)
19:33:36 reedip_1 and I think keeping it in the network section sounds logical
19:33:38 dtroyer excpet that particular module already has command classes in it
19:33:44 reedip_1 ok
19:33:50 dtroyer err, network.common
19:33:59 dtroyer similar to what is in identity.common
19:34:25 dtroyer I'm talking about the actual access methods (calling REST) not the command classes
19:34:41 dtroyer so another command can easily check if an extension is enabled and act appropriately
19:35:34 dtroyer that doesn't need to be done immediately, but I wanted to mention it as an example of places I do think factoring out stuff is beneficial since I rant against that so much in the command classes
19:37:19 ankur-gupta-f4 makes sense.
19:38:26 dtroyer ok, so functional tests?
19:39:15 ankur-gupta-f4 have a patch like that but I want that to be the standard
19:39:15 ankur-gupta-f4 I would like to see more comprehensive tests specifically for some of the set/unset tests. Ive noticed a lot of them just set a description or something similar. I want to see them do a bit more. i.e. port command instead of just setting and unset description. I want them to create another resource like security group and set and unset the security group. I
19:39:51 ankur-gupta-f4 We can catch broken commands/resources faster that way
19:40:18 dtroyer exactly right
19:40:54 ankur-gupta-f4 okay. In that case Im going to start commenting on patches coming in that are still doing the superficial testing and do more thorough functional tests
19:41:11 dtroyer the mechanics of testing the option parsing belongs in unit tests, but especially where things interact with other resources we need to be checking deeper in functional tests
19:41:28 dtroyer good idea
19:41:58 ankur-gupta-f4 Okay. Sounds good.
19:42:18 dtroyer we don't need to duplicate unit tests, but some things also can be affected by changes in the underlying libs and this is the only place we catch those until we add more integration tests
19:43:09 dtroyer to be clear, I think we understand the scope of unit tests, and functional tests work against a running cloud
19:43:44 dtroyer what I'm calling integration tests (maybe the wrong name) test the stack from the command parser down the the requests session emitting HTTP
19:44:04 dtroyer so no actual server required, we mock the HTTP reply and look at the entire client stack
19:44:37 ankur-gupta-f4 hows the run time for something like that?
19:45:41 ankur-gupta-f4 just thinking beyond to bringing it up into voting job
19:45:55 dtroyer similar to unit tests. I have a few defined in tests.unit.integ. so far they are mostly for checking os-client-config behaviour
19:46:10 dtroyer they are run with the unit tests today
19:46:40 dtroyer where unit tests mock out things outside osc, these use the entire stack of dependencies down to the requests lib
19:47:06 dtroyer so osc-lib, python-*client (or SDK), os-client-config, etc
19:47:25 ankur-gupta-f4 neat will take a look
19:48:18 dtroyer hmmm… I'm looking now and it seems like I wrote more than what is there
19:49:58 ankur-gupta-f4 thats all I had for today assuming we are still holding off on networking commands for a while
19:50:55 dtroyer I think we're past where I'd worry about adding functionality, I started looking at some of those larger reviews again yesterday
19:51:23 dtroyer PTG next week will affect the flow, either better or worse, depending on the amount of hacking time we end up with
19:52:05 ankur-gupta-f4 right. PTG :(
19:53:03 ankur-gupta-f4 Flavor Profile and Flavor are two huge ones that could use some eyes
19:53:04 dtroyer ankur-gupta-f1: so just fly home on Sunday and get on the wrong place. oops! Hartsfield? that's not the right airport… oh well…
19:53:10 dtroyer s/place/plane
19:53:38 ankur-gupta-f4 haha. I was thinking of just 'missing' my flight back to Texas and being stuck in Portland forever :|
19:54:31 ankur-gupta-f4 alright. Thanks for the help Dean. Going to go grab some grub
19:54:39 ankur-gupta-f4 thanks reedip_1 : sindhu
19:54:45 ankur-gupta-f4 thanks for the help as well :)
20:41:11 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Implement message docs https://review.openstack.org/435104
20:59:33 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Implement metric docs https://review.openstack.org/435110
21:23:56 openstackgerrit Ankur proposed openstack/python-openstacksdk master: Introduce Base for Octavia (load balancing) https://review.openstack.org/428414
21:48:43 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Reorganize orchestration docs https://review.openstack.org/435132
#openstack-sdks - 2017-02-17
01:32:29 openstackgerrit Merged openstack/python-openstacksdk master: Reorganize orchestration docs https://review.openstack.org/435132
01:32:50 openstackgerrit Merged openstack/python-openstacksdk master: Implement message docs https://review.openstack.org/435104
01:34:05 openstackgerrit Merged openstack/python-openstacksdk master: Reorganize key_manager docs https://review.openstack.org/435069
01:35:11 openstackgerrit Merged openstack/python-openstacksdk master: Reorganize identity docs https://review.openstack.org/434534
14:48:54 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix function test for compute images https://review.openstack.org/435478
15:28:53 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix function test for compute images https://review.openstack.org/435478
16:03:14 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix function test for compute images https://review.openstack.org/435478
17:52:06 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Implement metric docs https://review.openstack.org/435110
18:15:47 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix image selection in server function tests https://review.openstack.org/435559
19:23:10 openstackgerrit Ankur proposed openstack/python-openstackclient master: Port set/unset SecGroup Bug Fix https://review.openstack.org/430087
19:28:58 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Remove quota set workaround for SDK <0.9.13 https://review.openstack.org/435574
19:47:12 openstackgerrit Merged openstack/python-openstacksdk master: Fix function test for compute images https://review.openstack.org/435478
20:15:25 openstackgerrit Dean Troyer proposed openstack/python-openstacksdk master: Revert "Privatize session instance on Proxy subclasses" https://review.openstack.org/435584
20:26:07 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient master: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611
22:52:35 openstackgerrit Merged openstack/python-openstackclient master: Fix image selection in server function tests https://review.openstack.org/435559
#openstack-sdks - 2017-02-18
00:03:58 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Finish converting server functional tests to JSON format https://review.openstack.org/435629
00:54:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Finish converting server functional tests to JSON format https://review.openstack.org/435629
03:36:06 openstackgerrit Merged openstack/python-openstackclient master: Add "encryption-*" options in volume type commands https://review.openstack.org/414197
04:56:51 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Update the image used for functional tests https://review.openstack.org/435656
06:25:10 openstackgerrit Merged openstack/python-openstackclient master: Add "volume host failover" command https://review.openstack.org/411259
06:25:16 openstackgerrit Merged openstack/python-openstackclient master: Functional test for router https://review.openstack.org/434099
06:41:15 openstackgerrit Merged openstack/python-openstackclient master: Fix "server create" command failed when --nic auto or none https://review.openstack.org/432993
15:39:27 openstackgerrit Merged openstack/python-openstacksdk master: Update the image used for functional tests https://review.openstack.org/435656
16:46:18 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix the nextwork agent add remove test https://review.openstack.org/435720
17:50:54 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Finish converting server functional tests to JSON format https://review.openstack.org/435629
18:11:07 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix the agent add remove test https://review.openstack.org/435723
19:21:39 openstackgerrit Terry Howe proposed openstack/python-openstacksdk master: Fix the agent add remove test https://review.openstack.org/435723

Earlier   Later