Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-01-20
13:11:47 sigmavirus err webob 1.7
13:12:24 sigmavirus although the community images work should have merged overnight
13:12:29 sigmavirus so it could be a problem with that
13:27:57 dtroyer yay, let's change defaults!
13:28:14 dtroyer then get ready for a slew of patches with "that's the default now we can remove this we don't need to set it"
13:28:20 dtroyer </ugh>
13:31:23 sigmavirus dtroyer: I'm fairly certain the v1 impact was an unintended consequence
13:32:44 dtroyer ((FWIW, the snark above isn't directed at Glance, it's directed at the seemingly unusual number of patches I've seen recently that want to remove settings because they are defaults, and we know defaults do not change))
13:33:15 dtroyer this just demonstrates why removing those is sometimes a bad idea
13:36:28 dtroyer <back-to-constructive-mode>
13:42:13 dtroyer looking over the community images review, is it possible that https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa#diff-162f814daca94e2b95fa809d7a054eae needs to be specific to v1 and v2 now?
13:45:53 dtroyer working backwards, more wild speculation: https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa#diff-a4e34865d1737c192a19a108ee8f1359
13:46:33 dtroyer there are other places the new is_public kwarg is set to True in v1… that may be why the unit tests didn't see this
13:50:16 sigmavirus dtroyer: yeah I'm trying to get the people who worked on it to look into this
13:50:26 sigmavirus I'm personally digging far into the webob 1.7.0 issues
13:52:04 dtroyer at this point in the cycle, I'm tempted to do what folks always did to devstack and revert it since it is broken, but that would be rude. I will push up a change to the unit tests though to demonstrate why I think it was missed…
13:53:49 openstackgerrit OpenStack Proposal Bot proposed openstack/openstackclient: Updated from global requirements https://review.openstack.org/423275
13:55:44 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/423277
14:07:33 rosmaita dtroyer: reading back through this now
14:07:43 dtroyer stevemar, sigmavirus: I went ahead and posted a revert, I can't (quickly) see why the unit tests didn't get that
14:10:13 rosmaita dtroyer: i thought the problem was happening in an osc test that changes some properties on an already existing image?
14:11:09 dtroyer rosmaita: ah, it is. I equated that to create for an unknown reason
14:11:19 rosmaita ok, np, just trying to narrow this down
14:11:19 dtroyer so it is jsut that update is broken
14:12:10 rosmaita thanks for verifying
14:13:16 dtroyer revised that commit message
14:13:22 rosmaita but, we should probably look at the create tests too to see if they cover creating a public image, creating a private image, creating an image (default)
14:14:29 dtroyer I don't think they get all of the combinations (ours do not either FWIW) but I had the wrong idea in my head while I was looking so I'm heading back there now
14:47:29 openstackgerrit Merged openstack/js-openstack-lib: Created Nova service with flavorList method. https://review.openstack.org/370389
16:47:22 ankur-gupta-f2 dtroyer: stevemar: Any thoughts on Akihiro's latest comments on this patch https://review.openstack.org/#/c/396727/
17:02:24 dtroyer ankur-gupta-f2: commented
17:06:34 ankur-gupta-f2 dtroyer: k thanks will take a look
17:47:33 openstackgerrit Merged openstack/openstackclient: Updated from global requirements https://review.openstack.org/423275
17:48:23 stevemar dtroyer: sigmavirus soo.. was i right? i did a quick diagnosis at the gate before boarding :)
17:48:43 sigmavirus stevemar: right about what?
17:48:44 sigmavirus =P
17:49:08 stevemar sigmavirus: osc func tests, if the glance patch that merged overnight was the issue
17:51:55 sigmavirus I was teasing. You were right. =)
17:57:08 dtroyer stevemar: yes. I pushed up a couple of unit tests to try and duplicate what we saw, modulo pep8 stupidity and an odd py35 failure I think it may be close
17:59:07 sigmavirus dtroyer: looks like you submitted the same patch twice?
17:59:31 dtroyer yes, with and without the revert to check both conditions
18:01:07 dtroyer https://review.openstack.org/#/c/423345/ shows the failed test_update_image_private()
18:01:25 dtroyer that is before the revert
18:02:25 dtroyer https://review.openstack.org/#/c/423344/ shows test_update_image_private() passing after the revert, so the original behaviour
18:02:56 dtroyer and both show that some days I can't pep8 my way out of a paper bag
18:06:30 stevemar dtroyer: and your py35 tests failed :P
18:06:57 sigmavirus I have a functional test for v1 that I'm adding to cover this case too
18:07:06 sigmavirus hoping I can use it to narrow down on what's going on
18:07:42 sigmavirus rosmaita: ^
18:11:14 dtroyer stevemar: no, I was mis-reading what the py35 job was doing, there only seems to be py27 unit test jobs
18:49:44 openstackgerrit Ankur proposed openstack/python-openstackclient: Network L3 Router Commands for OSC https://review.openstack.org/385729
19:24:50 openstackgerrit Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183
19:40:07 rosmaita dtroyer: stevemar: quick question for you in openstack-glance
20:18:11 dtroyer sigmavirus, rosmaita: thanks again for jumping in this so quickly. I know how frustrating it is to have a big pile-o-work get reverted because one little thing, glad to see it is back on track.
20:19:00 sigmavirus dtroyer: my pleasaure
20:19:03 sigmavirus *pleasure even
20:31:35 openstackgerrit Ankur proposed openstack/python-openstacksdk: Modified DHCP/Network Resource https://review.openstack.org/423511
21:13:48 openstackgerrit Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183
23:18:07 openstackgerrit Brian Rosmaita proposed openstack/python-openstackclient: Update container format choices https://review.openstack.org/423551
#openstack-sdks - 2017-01-21
00:29:31 openstackgerrit Anindita Das proposed openstack/python-openstackclient: OSC Network Flavor https://review.openstack.org/382530
00:31:04 openstackgerrit Anindita Das proposed openstack/python-openstackclient: OSC Network Flavor https://review.openstack.org/382530
03:56:31 openstack bug 1658164 in Glance "community images breaks Images v1 API" [Critical,Fix released] https://launchpad.net/bugs/1658164 - Assigned to Ian Cordasco (icordasc)
03:56:31 stevelle https://review.openstack.org/423499 has merged fixing bug 1658164
04:31:50 stevemar thanks stevelle
05:54:23 openstackgerrit Merged openstack/python-openstackclient: Error in the return of command server show, create https://review.openstack.org/422463
06:18:08 openstackgerrit Merged openstack/python-openstackclient: Error in the return of command 'volume qos create' https://review.openstack.org/421065
06:18:15 openstackgerrit Merged openstack/python-openstackclient: Fix port command for SDK >0.9.10 https://review.openstack.org/420420
08:50:23 openstackgerrit Reedip proposed openstack/python-openstackclient: Overwrite/Clear Server property https://review.openstack.org/423600
08:58:57 openstackgerrit Reedip proposed openstack/python-openstackclient: Overwrite/Clear Server property https://review.openstack.org/423600
09:04:15 openstackgerrit Hongbin Li proposed openstack/osc-lib: Remove deprecated option --profile https://review.openstack.org/423603
10:28:18 openstackgerrit Reedip proposed openstack/python-openstackclient: Introduce overwrite/clear functionality in ``osc project set`` https://review.openstack.org/423612
15:03:05 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/423277
15:57:02 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk: Updated from global requirements https://review.openstack.org/423686
18:17:11 openstackgerrit Merged openstack/osc-lib: Updated from global requirements https://review.openstack.org/423673
#openstack-sdks - 2017-01-22
02:32:28 openstackgerrit Hongbin Li proposed openstack/osc-lib: Remove deprecated argument --profile https://review.openstack.org/423603
06:30:09 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Replace "Display Name" by "Name" in volume list https://review.openstack.org/423081
06:30:15 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Functional tests debug support https://review.openstack.org/423154
06:30:31 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Fix OSC networking commands help errors https://review.openstack.org/418221
06:30:35 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Update devref about "--no-property" https://review.openstack.org/421160
#openstack-sdks - 2017-01-23
00:23:20 openstackgerrit Ankur proposed openstack/python-openstackclient: Add meter rule to OSC https://review.openstack.org/378058
00:24:37 openstackgerrit Ankur proposed openstack/python-openstackclient: Add meter rule to OSC https://review.openstack.org/378058
05:58:39 openstackgerrit Reedip proposed openstack/python-openstacksdk: Fix Setting Quotas in Neutron https://review.openstack.org/419911
06:01:57 openstackgerrit Reedip proposed openstack/python-openstacksdk: Add project ID in QuotaDefault requests https://review.openstack.org/420301
06:07:16 openstackgerrit Reedip proposed openstack/python-openstackclient: Overwrite/Clear Flavor property https://review.openstack.org/415369
06:09:15 openstackgerrit Hongbin Lu proposed openstack/python-openstackclient: [WIP] Handle 403 error on creating trust https://review.openstack.org/423917
06:41:34 openstackgerrit Reedip proposed openstack/python-openstacksdk: [WIP]Port identity-v2 to resource2/proxy2 https://review.openstack.org/423943
07:05:24 openstackgerrit Dinesh Bhor proposed openstack/python-openstacksdk: Fix error messages are not displayed correctly https://review.openstack.org/420722
07:26:05 openstackgerrit zhiyong.dai proposed openstack/python-openstackclient: Functional test for volume transfer request https://review.openstack.org/423960
07:35:52 openstackgerrit zhiyong.dai proposed openstack/python-openstackclient: Functional test for volume transfer request https://review.openstack.org/423960
07:51:51 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Add regex helper method for functional tests https://review.openstack.org/423970
08:16:06 openstackgerrit Rui Chen proposed openstack/python-openstackclient: Add regex helper method for functional tests https://review.openstack.org/423970
09:41:53 openstackgerrit Merged openstack/python-openstackclient: TrivialFix in helpMessage for readability https://review.openstack.org/420571
13:36:28 reedip_ briancurtin : ping ?
13:36:41 briancurtin reedip_: pong
13:36:44 briancurtin what’s up
13:36:59 reedip_ birancurtin : was trying to understand more about the porting fixes
13:37:08 reedip_ from resource to resource2
13:38:10 reedip_ I put a very basic patch ( basically does nothing much ) https://review.openstack.org/#/c/423943/
13:38:23 reedip_ but I guess its not ebough for the porting
13:39:31 briancurtin reedip_: porting the proxy side of it is pretty easy, and it’s mostly what you did there. for a lot of services, it’s just that, but when there were path_args involved that’s where you’ll do some small proxy changes

Earlier   Later