Posted	Nick	Remark
#openstack-sdks - 2017-01-14
04:41:03	stevemar	mordred: i wouldn't say you "suck", inhale quickly though for sure
04:41:14	stevemar	<3
04:41:37	stevemar	dtroyer: looks like your floating ip patch depends on SDK >=0.9.11
04:42:04	stevemar	dtroyer: i staged it on top of my "run tests with SDK 0.9.12" patch to see if it's true
04:44:13	reedip	stevemar : good morning :). Any help needed for OSC ?
04:49:18	stevemar	reedip: i think we're still looking at one last bug
04:49:41	stevemar	reedip: http://logs.openstack.org/50/418650/11/check/gate-osc-dsvm-functional-ubuntu-xenial/329d025/testr_results.html.gz
04:49:52	stevemar	the test_quota_set and test_quota_show
04:50:01	stevemar	they dont seem to work with SDK at 0.9.12
04:50:24	reedip	stevemar : see if this helps : https://review.openstack.org/#/c/419911/
04:50:29	stevemar	the rest of the failures should be fixed
04:56:07	stevemar	reedip: probably fixes it ;)
04:56:15	reedip	:D
04:56:33	reedip	Ok, I am looking into the default quota bug then
04:56:49	reedip	I mean test_quota_show_with_default_option
04:56:51	stevemar	reedip: probably need a test for the sdk change?
04:57:06	stevemar	reedip: looking like the quota show bug stems from the same error
04:57:15	reedip	stevemar : there was no test written earlier, but ok, I will fix it
04:57:18	reedip	is it ???
04:57:25	reedip	U mean does it fix both the issues ?
05:00:43	reedip	stevemar : no I dont think it fixes it
05:01:16	reedip	stevemar : but the solution is similar
06:04:11	stevemar	ah similar is good
06:55:24	reedip	stevemar : upcoming
06:55:33	reedip	sorry, it took some time to find out :)
06:57:16	openstackgerrit	Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301
07:11:28	stevemar	reedip: np! i'll review it tmrw
07:11:36	reedip	ok :)
07:25:55	RuiChen	hi reedip: I work on the bug test_quota_show_with_default_option, ready to push a patch to openstacksdk
07:26:28	reedip	RuiChen : ohh , I didnt know that. I already pushed a patch just a few minutes back
07:26:51	reedip	RuiChen : https://review.openstack.org/420301
07:27:00	RuiChen	ah, see your patch https://review.openstack.org/#/c/420301/
07:27:04	reedip	Maybe you can review and rebase it with your changes
07:27:17	reedip	if you think something which you have taken care but I have missed
07:27:23	reedip	can be added to that patch
07:27:29	RuiChen	yeah, never mind, I will review it
07:28:53	RuiChen	reedip: by the way, if you pip install -e openstacksdk, do you face the error?
07:29:15	RuiChen	https://www.irccloud.com/pastebin/7GdQciTn/
07:29:17	reedip	RuiChen : Never tried it
07:29:42	reedip	RuiChen: I saw it in devstack
07:30:04	reedip	I mean when I was reinstalling Openstack using devstack , on Thursday, I faced a similar issue
07:30:19	reedip	I then removed my directories, put reclone=true and restarted devstack
07:30:21	reedip	it worked
07:30:31	reedip	it was similar , but may be or may not be the same issue
07:30:45	RuiChen	weird, if pip install openstacksdk, no error exist
07:33:23	RuiChen	I'm not sure what the different between develop mode and regular mode...
07:33:50	reedip	RuiChen : I dont think it would be much of a difference, devstack jsut takes care of a lot of things
07:35:11	RuiChen	yeah, devstack do lots of thing that we don' know :)
07:43:12	RuiChen	reedip: a fresh comment :) https://review.openstack.org/#/c/420301
07:48:05	reedip	RuiChen : vv
07:48:13	openstackgerrit	Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301
07:48:35	reedip	RuiChen : UT and FT for quotas are not written in the SDK, I guess
07:49:13	RuiChen	reedip: i don't think so, i found one test_quota_default_get
07:49:33	reedip	RuiChen : dont know, maybe I missed it
07:49:57	reedip	RuiChen : the new patch will fail pep8 :P
07:50:01	reedip	sorry
07:50:47	RuiChen	looks like the UT test should be change with the current modification
07:51:46	RuiChen	i feel gate is slower than yesterday
07:56:41	reedip	RuiChen : done
07:56:50	openstackgerrit	Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301
07:57:59	RuiChen	it's great :)
09:25:38	openstackgerrit	Rui Chen proposed openstack/python-openstackclient: Fix OSC networking commands help errors https://review.openstack.org/418221
11:14:12	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326
12:01:32	openstackgerrit	yuval shalev proposed openstack/python-openstacksdk: Added project role assignment https://review.openstack.org/416598
12:29:41	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334
12:32:03	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326
13:30:34	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334
13:33:31	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326
13:57:29	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Add "encryption-*" options in volume type commands https://review.openstack.org/414197
14:59:45	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326
15:00:25	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: Fix network agent show command https://review.openstack.org/420326
15:32:58	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326
15:34:27	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326
15:52:23	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194
15:59:23	dtroyer	stevemar: I think your testing stack is upside-down, removing the skips from all of the broken tests before fixing the breaks makes the whole stack fail
16:01:16	dtroyer	I've rebased https://review.openstack.org/420194 to stand alone again, and am testing https://review.openstack.org/420154 the same way. Then the 0.9.12 can get stacked on top of all of these until the -tips job is working…
16:55:18	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194
17:00:01	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154
17:02:28	dtroyer	stevemar: , I made ^^^ stand-alone too. We're going to be chasing a long series of rebases and then have to re-test the entire series again once the last one in the chain passes, I'd rather be opportunistic and make the func test fixes stand-alone and then check them with the https://review.openstack.org/418650 review
17:09:24	dtroyer	argh…I thought the quota commands were fixed…
17:37:47	openstackgerrit	Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301
19:06:26	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: Fix quota show --default command https://review.openstack.org/420363
19:06:52	dtroyer	reedip: See if ^^^ works around the problem you just posted for the SDK...
19:07:06	dtroyer	stevemar: ^^^ should be the last of the functioanl test issues...
19:47:04	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: Fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154
19:56:32	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient: Fix quota show --default command https://review.openstack.org/420363
20:28:21	stevemar	dtroyer: reporting in
20:28:25	stevemar	dtroyer: yeah, i knew the testing stack was upside down :)
20:28:42	stevemar	dtroyer: was hoping to get a clean chain of patches at the end, then rearranging the puzzle, but fixing them upfront is fine too
20:39:15	stevemar	dtroyer: please push https://review.openstack.org/#/c/420162/ though
20:40:19	openstackgerrit	Steve Martinelli proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162
20:52:46	openstackgerrit	Steve Martinelli proposed openstack/python-openstackclient: SDK refactor: Prepare network agent commands https://review.openstack.org/420326
21:24:39	openstackgerrit	Merged openstack/python-openstackclient: Fix subnet creating failure in functional test https://review.openstack.org/420334
21:25:22	openstackgerrit	Merged openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194
21:55:36	stevemar	dtroyer: pushed a bunch of changes
21:55:49	stevemar	dtroyer: we should be all good to go with the exception of quota set
21:57:20	dtroyer	stevemar: re https://review.openstack.org/#/c/420162/, tips still wasn't passing, want it anyway?
23:11:29	openstackgerrit	Merged openstack/python-openstackclient: Fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154
23:24:13	stevemar	dtroyer: yes, its a non-voting job, 420162 made the results of the functional-tips usable (viewable in html)
23:24:43	stevemar	dtroyer: additionally, it made it possible to use "Depends-On" with osc-lib, occ, and sdk

Earlier   Later