Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-01-11
20:40:21 dtroyer erg, there are still 4
20:41:19 dtroyer stevemar: do you recall how many tests were being skipped before this mess started?
20:41:40 stevemar only 4 (they were conditional on a networking extension)
20:41:58 stevemar we had no skipped tests otherwise
20:42:04 dtroyer ok then, your 418650 has them all then
20:46:17 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611
20:47:08 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test https://review.openstack.org/419129
20:47:27 stevemar dtroyer: ^ i think that one worked, just a bad test
20:48:17 dtroyer I think it is more than a bad test, I get a 404 when I try the command
20:53:43 dtroyer #$^%&%$#$!@#$%^*%&$#@#$%^*&^&%^%$@#^$&%&^*&%^$%#$@#!@#$^%&^
20:54:01 dtroyer Why did we let an extension command into the main repo??????????????????
20:55:51 dtroyer so nevermind my 404, I don't have the (*&^%$#$%^&*( extension enabled
20:56:32 dtroyer we gotta handle that better… and by better I mean at all
20:56:45 dtroyer Is ther any way to make the tests discover and auto-skip this?
20:57:38 stevemar dtroyer: i thought there was a discover and skip mechanism
20:57:46 stevemar i guess not, since it didn't skip for you
20:58:33 stevemar dtroyer: that test and command was created by rich back in the early networking days, before we had a fleshed out plan for extensions and had the neutron team on board
21:00:09 dtroyer hmmm… git sez it was committed on Aug 12
21:00:27 dtroyer by https://github.com/ralonsoh
21:01:06 dtroyer well, that was an auto-complete
21:01:17 dtroyer ralonsoh, may or may not be the same person
21:02:09 stevemar dtroyer: i was referring to https://github.com/openstack/python-openstackclient/commit/4f23a77de04bfdfafd4bf8f16b0365df7663e9e5
21:02:51 stevemar dtroyer: skippage is here: https://github.com/openstack/python-openstackclient/blob/2026dee17e7b6b8d738345fd27dc905efb6561f1/openstackclient/tests/functional/network/v2/test_network_segment.py#L54-L66
21:02:54 dtroyer oh, I thought we were talking about qos rule type still
21:05:43 stevemar dtroyer: i thought we were tlaking about skipped tests -- 418650 unskips all the skipped ones, except those network segment ones
21:06:05 stevemar i have no idea what qos rule type is
21:06:24 dtroyer that's the one test that failed in your 418650 test with sdk 0.9.12
21:06:35 dtroyer I can't tell (yet) if it ever worked
21:07:02 dtroyer have to restart my devstack with q-qos running, and that takes a long time these days
21:07:30 stevemar dtroyer: wel https://review.openstack.org/#/c/419129/ fixes it, i think
21:07:31 dtroyer I believe this is the last blocker for sdk 0.9.12
21:07:33 stevemar let me run it for you
21:08:11 dtroyer so is that a fix or just not testing for the missing piece?
21:08:30 dtroyer ie, is something still broken since minimum_bandwidth was expected to be ther at one time?
21:12:19 stevemar dtroyer: i'm wondering that myself, looking at the neutron APIs while I'm stacking with qos enabled
21:12:56 dtroyer I don't see it in http://developer.openstack.org/api-ref/networking/v2/
21:13:54 stevemar dtroyer: looking at http://developer.openstack.org/api-ref/networking/v2/?expanded=#quality-of-service
21:14:07 stevemar theres definitely bandwidth_limit_rules and dscp_marking_rules
21:14:14 stevemar no idea where minimum bandwidth came from
21:14:30 dtroyer ok, that's good enough for moi
21:14:49 stevemar also, the functional command returned only the two, i added that to the commit message
21:15:07 stevemar dtroyer: did you want me to punt some things through while we're short on time?
21:16:30 dtroyer http://docs.openstack.org/developer/neutron/devref/quality_of_service.html#qos-versioned-objects lists a QosMinimumBandwidth object
21:19:05 stevemar dtroyer: *shrug*
21:20:12 dtroyer I guess at this point… if that passes, let's roll with it
21:21:37 dtroyer I just +W the hook_tips.sh review
21:23:18 dtroyer stevemar: if you have a minute, I think https://review.openstack.org/#/c/352477/ is ready
21:23:52 dtroyer and lookie there, it includes minimum-bandwidth
21:39:52 openstackgerrit Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183
21:43:01 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Add one option to "volume host set" command https://review.openstack.org/411259
22:12:58 stevemar dtroyer: ahh theres the bugger
22:21:42 stevemar dtroyer: punted
22:22:33 stevemar dtroyer: that should make https://review.openstack.org/#/c/419129/ unnecessary
22:23:38 stevemar dtroyer: so i'm not sure if briancurtin will release a new SDK in the next week or two, how do we want to handle the SDK version in our requirements file?
22:23:53 stevemar should we revert the SDK blacklist?
22:24:18 stevemar hmm... that'll cause gate issues with rally and others
22:24:34 dtroyer yeah, not until after we release, at least...
22:24:54 stevemar dtroyer: we may have to release osc 3.7.0, revert the sdk blacklist, and do a quick release with SDK 0.9.12 included?
22:25:19 stevemar it would be wonky to do all this compatability work and not have it work with sdk 0.9.12
22:25:38 dtroyer That's partly why I was wanting to do two releases before freeze, the second, without the blacklists, will become stable and we don't live with that for a long time
22:25:55 dtroyer also, there's stuff that wants sdk 0.9.11 as min anyway
22:26:21 dtroyer so maybe that's what we set when we remove the blacklist?
22:27:26 openstackgerrit Merged openstack/python-openstackclient: add support for running tests with master dependencies https://review.openstack.org/419032
22:28:06 openstackgerrit Merged openstack/python-openstackclient: Add support for Glance 'update image members' feature https://review.openstack.org/410848
22:28:19 openstackgerrit Merged openstack/python-openstackclient: Error handling for delete commands in identity https://review.openstack.org/415799
22:28:53 stevemar ok with me
22:30:05 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: Add unit test for multi volume types delete https://review.openstack.org/405947
23:04:47 openstackgerrit Ankur proposed openstack/python-openstackclient: Add meter rule to OSC https://review.openstack.org/378058
23:12:38 openstackgerrit Merged openstack/python-openstackclient: Add two consistency group commands https://review.openstack.org/407983
23:37:01 openstackgerrit Merged openstack/python-openstackclient: Add support for Network QoS rule commands https://review.openstack.org/352477
#openstack-sdks - 2017-01-12
01:06:10 openstackgerrit Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183
01:54:25 openstackgerrit Ha Van Tu proposed openstack/python-openstackclient: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236
02:17:41 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650
03:13:23 openstackgerrit Merged openstack/python-openstackclient: Add unit test for multi volume types delete https://review.openstack.org/405947
03:44:38 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650
03:45:19 openstackgerrit Abhishek Raut proposed openstack/python-openstackclient: SDK refactor: Prepare security group commands https://review.openstack.org/418183
03:52:54 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: Fix quota show output https://review.openstack.org/419067
04:51:54 openstackgerrit avnish proposed openstack/os-client-config: Use upper-constraints for tox envs https://review.openstack.org/419273
05:00:03 reedip stevemar : thanks for the reno :)
05:11:43 stevemar reedip: np ;)
05:53:53 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: unskip network qos rule type functional test https://review.openstack.org/419129
06:02:14 openstackgerrit zhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate. https://review.openstack.org/418685
06:15:13 openstackgerrit zhiyong.dai proposed openstack/python-openstackclient: Update functional test for aggregate. https://review.openstack.org/418685
08:06:56 openstackgerrit Ha Van Tu proposed openstack/python-openstackclient: Add "qos-policy" option to "port create" & "port set" https://review.openstack.org/419236
08:46:35 reedip ralonsoh : ping
08:46:48 ralonsoh reedip: hello
08:47:02 ralonsoh reedip: I know, the qos port cli
08:47:09 reedip ralonsoh : :D
08:47:12 reedip yup
08:47:18 ralonsoh I mean:
08:47:26 ralonsoh qos-policy is only an id
08:47:36 reedip I have updated my response in the PS. Can you verify the same?
08:47:43 reedip ralonsoh: ok
08:47:44 ralonsoh ok
08:48:08 reedip ralonsoh: I understand that we cannot append the QoS policy for a port
08:48:22 reedip ralonsoh : but we can handle it in the code itself
08:49:23 ralonsoh We can do what you are proposing: to fail if there is already a qos associated
08:49:39 ralonsoh This is the case of append
08:49:48 reedip ralonsoh : yes, for append
08:49:56 reedip We have 4 cases basically

Earlier   Later