| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-01-05 | |||
| 13:04:43 | dtroyer | Canada sends us cold stuff, Mexico sends us hot stuff, Pacific sends is wet stuff | |
| 13:04:59 | dtroyer | Atlantic just takes and takes and takes :) | |
| 13:05:03 | stevemar | hehe | |
| 13:05:18 | stevemar | thats one way of looking at it | |
| 13:05:19 | dtroyer | I'm sure Topol would argue with that when the hurricanes come though | |
| 13:05:34 | dtroyer | that's when the Atlantic gives it all back | |
| 13:06:08 | dtroyer | With that we conclude today's Weather Theory 101 | |
| 13:19:20 | stevemar | :) | |
| 13:50:12 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Functional tests - port https://review.openstack.org/416980 | |
| 13:52:40 | Dinesh_Bhor | briancurtin: Hi, Thanks for adding sort_key support for compute servers. I am curious to understand how I can pass multiple sort_keys like "GET /v2.1/servers/detail?sort_dir=desc&sort_dir=desc&sort_key=display_name&sort_key=vm_state" | |
| 13:53:15 | Dinesh_Bhor | briancurtin: I am using a small program similar to the mentioned here: https://pypi.python.org/pypi/openstacksdk | |
| 13:55:27 | Dinesh_Bhor | briancurtin: I am calling servers like "conn.compute.servers()" | |
| 14:09:00 | edleafe | stevemar: just saw your question. We generally recommend a 400 with a message that explains the problem | |
| 14:29:46 | sigmavirus | cdent: is there an API-WG meeting today? | |
| 14:30:15 | sigmavirus | etoews: ^ | |
| 14:30:22 | cdent | sigmavirus: yeah, in about 1.5 hours | |
| 14:30:29 | sigmavirus | cdent: excellent. Thank you! | |
| 14:38:47 | briancurtin | Dinesh_Bhor: is that supported by the server? | |
| 14:40:55 | Dinesh_Bhor | briancurtin: yes | |
| 14:41:14 | briancurtin | i can’t imagine they accept more than one sort_dir though, right? | |
| 14:43:10 | briancurtin | eh, either way, you can’t do that right now. it’s a dictionary, or rather there’s a small facade in front of a dictionary, but in the end query parameters are a dictionary | |
| 14:43:12 | Dinesh_Bhor | briancurtin: not sure, for my program if I pass conn.compute.servers(sort_key=['name', 'created_at']) like this then from openstacksdk it passes multiple sort keys successfully | |
| 14:44:08 | Dinesh_Bhor | briancurtin: "GET /v2.1/servers/detail?sort_key=name&sort_key=created_at" | |
| 14:44:11 | briancurtin | weird that it works like that, but if it does, then stick with it | |
| 14:45:30 | briancurtin | ahh, maybe that’s a feature of the requests library though | |
| 14:47:53 | Dinesh_Bhor | briancurtin: yes, Actually I am adding sort_keys support for 'masakariclient' which internally uses openstacksdk. While adding that I have now accepted list in the 'sort_key' from user and passed that to the masakari server directly and it works | |
| 14:51:23 | briancurtin | Dinesh_Bhor: it turns out that it is indeed a behavior of the requests library: http://stackoverflow.com/questions/22974772/querystring-array-parameters-in-python-using-requests#comment60268207_23347265 | |
| 14:53:41 | Dinesh_Bhor | briancurtin: Aah, ok thanks, so should we stick to this only? | |
| 14:54:13 | briancurtin | Dinesh_Bhor: yeah, if you do sort_key=[list, of, things] it will be fine | |
| 14:55:21 | Dinesh_Bhor | briancurtin: ok, thanks | |
| 14:57:03 | Dinesh_Bhor | briancurtin: bdw I have one more doubt if you have time then | |
| 14:58:02 | briancurtin | Dinesh_Bhor: sure, what’s up | |
| 14:58:15 | Dinesh_Bhor | briancurtin: If I pass any invalid sort_key to the servers then the nova-api returns the proper 400 but at the openstacksdk side I can just see "HttpException: Bad Request" | |
| 14:58:56 | Dinesh_Bhor | briancurtin: But at nova-api it has returned exception with message: Returning 400 to user: Sort key supplied was not valid. | |
| 14:59:35 | Dinesh_Bhor | briancurtin: conn.compute.servers(sort_key=['nadame', 'created_at']) | |
| 14:59:38 | openstackgerrit | Jens Rosenboom proposed openstack/python-openstackclient: Fix creating a private flavor with ID auto https://review.openstack.org/416940 | |
| 15:01:20 | Dinesh_Bhor | briancurtin: It looks like here https://github.com/openstack/python-openstacksdk/blob/master/openstack/session.py#L74 we are not getting anything in the message as well as in details | |
| 15:02:48 | briancurtin | yeah, a lot of projects do a lot of different/bad/wrong things with what they return. it’s probably best if you report a bug to https://bugs.launchpad.net/python-openstacksdk and myself or someone can take a look at it | |
| 15:03:25 | Dinesh_Bhor | briancurtin: ok, Can I take up this task? | |
| 15:03:40 | briancurtin | Dinesh_Bhor: sure, if you’d like to | |
| 15:04:08 | Dinesh_Bhor | briancurtin: ok, thanks I will push my patch soon | |
| 15:09:17 | briancurtin | Dinesh_Bhor: take a look at https://review.openstack.org/#/c/386440/ which did something about this same issue seen in Neutron, but it was reverted due to causing other issues. Qiming may know more about the other issues, i can’t remember what they were | |
| 15:13:45 | Dinesh_Bhor | briancurtin: ok, thanks I will take a look at it | |
| 15:15:26 | Qiming | Dinesh_Bhor, one thing worth a try is to wrap line 77 in that patch into a try...except statement | |
| 15:15:56 | Qiming | not all exceptions are returning things that can be converted to a JSON | |
| 15:16:33 | Qiming | that patch was reverted because it is over simplifying the situation | |
| 15:17:15 | Dinesh_Bhor | Qiming: can we do something like this: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/exc.py#L156 | |
| 15:17:55 | Qiming | looks nicer | |
| 15:19:09 | Qiming | just I'm not sure if there will always be a content-type header when an exception is raised | |
| 15:22:28 | stevemar | edleafe: thanks! | |
| 17:03:45 | openstackgerrit | Merged openstack/api-wg: Trivial fix: correct names of capitalization styles https://review.openstack.org/411391 | |
| 17:15:32 | cdent | elmiko or etoews or edleafe can you proofread https://etherpad.openstack.org/p/api-wg-newsletter please | |
| 17:18:30 | edleafe | cdent: made on quick change to add the review link. Thinking of lazy people who might not be up to 2 clicks | |
| 17:18:58 | cdent | edleafe: I did that on purpose. I didn't want people to read the review without looking at the etherpad :) | |
| 17:19:24 | cdent | context is everything, after all | |
| 17:19:47 | cdent | but yeah, your change is fine | |
| 17:20:03 | edleafe | and here I thought that looking at the review might spark interest in the issue, causing them to go back and read the whole etherpad discussion :) | |
| 17:20:31 | cdent | I think my bias is showing: I want the reading of the etherpad to predispose the person reading the review... | |
| 17:20:42 | cdent | I'll ship what we've got showing now unless you've got addtional changes | |
| 17:21:49 | cdent | thar she blows | |
| 17:25:53 | cdent | damn, found an old typo after sending it | |
| 18:02:23 | elmiko | cdent: sorry, missed the ping | |
| 18:02:40 | cdent | elmiko: no worries, edleafe and I figured it out. | |
| 18:02:58 | elmiko | awesome =) | |
| 18:34:20 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Functional tests - flavor https://review.openstack.org/417132 | |
| 18:45:10 | stevemar | dtroyer: so i guess you're around? :) | |
| 19:03:24 | dtroyer | hi ho! | |
| 20:02:05 | sshank | dtroyer, I have a question regarding adding '--option' (example: https://review.openstack.org/#/c/387611/28/doc/source/command-objects/network-agent.rst@39). Initially we are asked to change to have a --option. Please confirm which way to follow. | |
| 20:04:36 | sshank | dtroyer, ^^ | |
| 20:07:44 | sshank | dtroyer, In patch: https://review.openstack.org/#/c/385729/8/doc/source/command-objects/network-agent.rst@85 --router is suggested. But later in patch: https://review.openstack.org/#/c/387611/ it is suggested to not have --option. | |
| 20:16:55 | dtroyer | I don't see a —option anywhere? | |
| 20:18:04 | openstackgerrit | Ian Cordasco proposed openstack/api-wg: Define pagination guidelines https://review.openstack.org/390973 | |
| 20:18:05 | dtroyer | you may be getting confused between resources, this review has two different things it is addressing | |
| 20:18:41 | dtroyer | I'm heading out for a while, will be back later today to look at this again | |
| 20:18:48 | sshank | dtroyer, Okay. | |
| 20:18:56 | sshank | dtroyer, Thanks. | |
| 20:30:37 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/417175 | |
| 23:24:55 | openstackgerrit | Merged openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/417175 | |
| 23:28:12 | openstackgerrit | Eric Brown proposed openstack/keystoneauth: Remove references to Python 3.4 https://review.openstack.org/417236 | |
| #openstack-sdks - 2017-01-06 | |||
| 01:21:50 | openstackgerrit | Merged openstack/keystoneauth: Remove references to Python 3.4 https://review.openstack.org/417236 | |
| 02:56:22 | openstackgerrit | Merged openstack/python-openstacksdk: Add filter "user_id" for cluster receiver list https://review.openstack.org/416159 | |
| 04:50:40 | openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix "ip availability show" command https://review.openstack.org/417286 | |
| 05:00:53 | openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix "ip availability show" command https://review.openstack.org/417286 | |
| 05:38:16 | openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix network service provider functional test https://review.openstack.org/417289 | |
| 05:57:36 | openstackgerrit | Merged openstack/python-openstackclient: Fix creating a private flavor with ID auto https://review.openstack.org/416940 | |
| 06:23:49 | openstackgerrit | Zhou Zhihong proposed openstack/python-openstackclient: Add options to allow filtering on agent list https://review.openstack.org/398017 | |
| 07:48:57 | openstackgerrit | Abhishek Kekane proposed openstack/keystoneauth: Log request-id for each api call https://review.openstack.org/392442 | |
| 10:52:34 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: functional test for volume https://review.openstack.org/417349 | |
| 12:55:06 | openstackgerrit | Xinhui Li proposed openstack/python-openstacksdk: Add workflow service (mistral) https://review.openstack.org/414919 | |
| 13:07:59 | openstackgerrit | Xinhui Li proposed openstack/python-openstacksdk: Add workflow service (mistral) https://review.openstack.org/414919 | |
| 14:09:18 | openstackgerrit | Ed Leafe proposed openstack/api-wg: Clarify the status values in versions https://review.openstack.org/411849 | |
| 14:34:08 | openstackgerrit | David Stanek proposed openstack/keystoneauth: Add __ne__ built-in function https://review.openstack.org/398294 | |
| 15:08:53 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Add --project and --project-domain option to "volume snapshot list" https://review.openstack.org/417410 | |
| 15:13:25 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Fix filter error in os volume list https://review.openstack.org/416852 | |
| 16:36:08 | openstackgerrit | Ed Leafe proposed openstack/api-wg: Add guideline for invalid query parameters https://review.openstack.org/417441 | |
| 16:44:00 | openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | |
| 17:40:14 | openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | |
| 17:58:50 | openstackgerrit | Merged openstack/python-openstackclient: Fix "ip availability show" command https://review.openstack.org/417286 | |
| 18:12:48 | openstackgerrit | Merged openstack/keystoneauth: Add __ne__ built-in function https://review.openstack.org/398294 | |
| 18:53:17 | openstackgerrit | Sean Dague proposed openstack/service-types-authority: add ideas on naming https://review.openstack.org/286090 | |