| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-10-06 | |||
| 18:21:50 | clif | so you the the executor object would be a different type that does have _workers if the tests were configured correctly? | |
| 18:21:55 | clif | you think* | |
| 18:22:00 | sean-k-mooney | yes | |
| 18:22:07 | sean-k-mooney | the normal threadpool executor has that value | |
| 18:22:28 | sean-k-mooney | https://github.com/openstack/futurist/blob/master/futurist/_futures.py#L175 | |
| 18:22:49 | sean-k-mooney | and that is what we are expectign to use in that job but we are not for some reason | |
| 18:22:57 | clif | sounds reasonable | |
| 18:23:04 | clif | do you know how to fix the configuration | |
| 18:23:20 | sean-k-mooney | so you are mockign @mock.patch('nova.utils.spawn_on') | |
| 18:23:48 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/tests/unit/compute/test_compute_mgr.py#518 | |
| 18:23:55 | sean-k-mooney | so im wondering if its related to that in some way | |
| 18:25:16 | sean-k-mooney | althouhg at least in the test that is failing its in a completely unrealted part of the code | |
| 18:25:42 | clif | that's why I thought this change was indepedent of the failures | |
| 18:25:42 | sean-k-mooney | ah found the bug https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/compute/manager.py#674 | |
| 18:26:14 | sean-k-mooney | so you cant hardcode the executor type there | |
| 18:26:28 | clif | But that's what the line above it does? | |
| 18:26:39 | clif | line 671 also hardcodes a GreenThreadPoolExecutor | |
| 18:26:46 | clif | which exists prior to this change | |
| 18:27:09 | sean-k-mooney | yes but we have the power sysnt disbsle i think | |
| 18:27:28 | sean-k-mooney | so i dont think that executor is actully used in the tests | |
| 18:28:30 | sean-k-mooney | in newer verisons fo this patch on master for example | |
| 18:28:42 | sean-k-mooney | you were getting the executor form a util funciton that did the right thing | |
| 18:28:53 | sean-k-mooney | i.e. that checked if it shoudl be using real thread or not | |
| 18:29:14 | sean-k-mooney | in the backport your not doing that so eitehr we need to emulate that logic or backport hte helper funciton | |
| 18:30:00 | sean-k-mooney | this is the same line one release newer https://review.opendev.org/c/openstack/nova/+/1005115/1/nova/compute/manager.py#673 | |
| 18:30:13 | sean-k-mooney | your calling nova.utils.create_executor | |
| 18:30:59 | sean-k-mooney | so you coudl do a minimial backprot of just that one fuction in utils.py adn its assocated tets or backprot that as an addtional patch prior to this one | |
| 18:32:37 | sean-k-mooney | clif: its djust this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L116-L121 | |
| 18:32:49 | clif | ahh I see ok | |
| 18:33:01 | sean-k-mooney | and this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L1336-L1341 | |
| 18:33:15 | clif | yeah I can handle that | |
| 18:33:21 | sean-k-mooney | that was remvoed durign the hibiscus cycle after the chagne merged on master | |
| 18:52:48 | sean-k-mooney | clif: by the way when you fix this in your backport make sure to update the commit message to note the partical backport of those fucntiosn if you dont do it in a seperate commit | |
| 18:53:24 | clif | sure | |
| 18:53:32 | clif | do you prefer separate? | |
| 18:53:55 | sean-k-mooney | either is fine i would check the orginal commit that added the funciton | |
| 18:54:05 | sean-k-mooney | if that is a clean cherry pick then that is prefered | |
| 18:54:21 | sean-k-mooney | if not its ok ot pull it in just make note of the change id that orginally added them | |
| 18:54:23 | clif | gotcha | |
| 19:18:32 | opendevreview | Merged openstack/nova master: Replace deprecated sqlalchemy.orm.noload https://review.opendev.org/c/openstack/nova/+/1007632 | |
| 20:15:43 | opendevreview | Gabin Lanore proposed openstack/nova master: libvirt: stop the event dispatch loops on cleanup https://review.opendev.org/c/openstack/nova/+/1005022 | |
| 20:29:17 | opendevreview | Adam Harwell proposed openstack/nova master: Stop the service when its start fails https://review.opendev.org/c/openstack/nova/+/1009119 | |
| #openstack-nova - 2026-10-07 | |||
| 00:35:31 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after local delete https://review.opendev.org/c/openstack/nova/+/1008334 | |
| 00:43:12 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after failed build cleanup https://review.opendev.org/c/openstack/nova/+/1009134 | |
| 00:45:56 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce 409 on unprovision during deploy https://review.opendev.org/c/openstack/nova/+/1009135 | |
| 00:57:20 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Stop hanging the test if threadpool executor is stuck in cleanup https://review.opendev.org/c/openstack/nova/+/1006351 | |
| 01:47:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | |
| 01:48:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | |
| 01:48:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 01:48:20 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Stop testing missing sev capability in libvirt < 10.0.0 https://review.opendev.org/c/openstack/nova/+/1009084 | |
| 07:55:07 | opendevreview | Matěj Mudra proposed openstack/nova master: Add --verbose to nova-manage commands https://review.opendev.org/c/openstack/nova/+/999956 | |
| 07:56:06 | opendevreview | Thibaut Démaret proposed openstack/nova-specs master: Spec for default SSD rotation rate on instance disks https://review.opendev.org/c/openstack/nova-specs/+/979696 | |
| 07:56:30 | opendevreview | Markus Hentsch proposed openstack/nova master: Adapt to Cinder and Glance changes for image encryption https://review.opendev.org/c/openstack/nova/+/926326 | |
| 08:31:46 | bauzas | doh I just rechecked :( | |
| 08:49:30 | opendevreview | Lucas HENRY proposed openstack/nova master: Extract running a shutdown step with a timeout from Service https://review.opendev.org/c/openstack/nova/+/1009163 | |
| 08:49:31 | opendevreview | Lucas HENRY proposed openstack/nova master: compute: shut executors down after the RPC servers drain https://review.opendev.org/c/openstack/nova/+/1009165 | |
| 08:49:31 | opendevreview | Lucas HENRY proposed openstack/nova master: Shut down executors after the RPC servers drain https://review.opendev.org/c/openstack/nova/+/1009164 | |
| 08:49:48 | opendevreview | Konrad Gube proposed openstack/nova master: Add assisted volume extend API. https://review.opendev.org/c/openstack/nova/+/1009077 | |
| 11:20:38 | opendevreview | ChungWon Lee proposed openstack/placement master: Spec: allow to overcommit for HA https://review.opendev.org/c/openstack/placement/+/1009206 | |
| 11:30:03 | cw0306-lee[m] | Hi! I want to suggest two specs for nova and placement.... (full message at <https://matrix.org/oftc/media/v1/media/download/AW0Zu02QY1E5cI5ajhOGtU7XXnHC8IVcI34z0Y-Os25ypLL9BN18cMKu6OQd45aRNnxkvuRpdB3Q1j33Vx9b7yBCehXjm1ZAAG1hdHJpeC5vcmcvbGJKR3d5b3NHV0hkQ3dTeUd6dU5mZ3pI>) | |
| 12:38:50 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/1007361 | |
| 12:45:06 | opendevreview | Kamil Sambor proposed openstack/nova master: Create an executor wrapper that has task limit per type https://review.opendev.org/c/openstack/nova/+/975924 | |
| 15:17:37 | Uggla | Reminder: upstream triage in ~15mn. (https://meet.google.com/zjr-rxus-hzj) | |
| 15:37:25 | gmaan | gibi_: updated it as per comment, please check https://review.opendev.org/c/openstack/nova/+/1006351 | |
| 15:55:27 | gibi_ | gmaan: thanks, I cannot promise I get to it this week. I have to drop for today and tomorrow I need to use my time to read the cross cell live migration spec, and firday I'm off. But I will get back to it hopefully next week | |
| 15:57:45 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove test for local ServiceAuthTokenWrapper https://review.opendev.org/c/openstack/nova/+/1009297 | |
| 15:57:57 | stephenfin | melwitt: ^ easier than I thought: we can straight up remove it | |
| 15:59:07 | stephenfin | sean-k-mooney: you probably want to look at that also since you reviewed https://review.opendev.org/c/openstack/nova/+/1002540. We need it to unblock the ksa bump in upper-constraints | |
| 15:59:13 | melwitt | ahhh lol ... that was me again too. geesh. ok, well at least that makes the removal straightforward | |
| 16:00:22 | stephenfin | https://i.kym-cdn.com/entries/icons/original/000/037/468/cover5.jpg | |
| 16:01:33 | sean-k-mooney | ah ok that makes sense | |
| 16:01:57 | sean-k-mooney | i guess the way we were mockign did not catch the removal of our local versoin | |
| 16:02:44 | sean-k-mooney | im kind of surperise that this is broken by the new release if im honest | |
| 16:03:14 | sean-k-mooney | did | |
| 16:03:16 | sean-k-mooney | user_auth.get_endpoint_data.assert_called_once_with( | |
| 16:03:18 | sean-k-mooney | mock.sentinel.session) | |
| 16:03:29 | sean-k-mooney | stop passing because we didnt need to call it to fill in the data | |
| 16:05:43 | melwitt | I think it's due to this change https://review.opendev.org/c/openstack/keystoneauth/+/1002219/1/keystoneauth1/service_token.py | |
| 16:07:34 | melwitt | although it seems that was released a while ago | |
| 16:07:49 | sean-k-mooney | mostly likely i jsut dont see how that broke the test | |
| 16:08:13 | sean-k-mooney | the asset behvior we vhae shoudl have been the saem regardess of it was our wrapper or not | |
| 16:11:16 | melwitt | I was thinking the above change added **kwargs to the call which made it no longer match the assert | |
| 16:12:01 | sean-k-mooney | oh no it might be but i think its becasue its now caullign self.user_auth | |
| 16:12:21 | melwitt | but hm yeah the previous one was passing **kwargs too. nevermind | |
| 16:13:12 | sean-k-mooney | so we are creating a mock and passign that as the user aut when we get the service tone auth plugin | |
| 16:13:29 | sean-k-mooney | so i woudl expect our mock to be assigned to self.user_auth | |
| 16:13:49 | sean-k-mooney | and for that call to still cause or test to pass | |
| 16:14:03 | sean-k-mooney | stephenfin: do you have a link to the failure | |
| 16:14:09 | sean-k-mooney | i want to see which assert actully failed | |
| 16:14:20 | stephenfin | https://zuul.opendev.org/t/openstack/build/381a96a08d294adcbb4407e7bef15914 | |
| 16:14:29 | stephenfin | also linked from a comment on the change | |
| 16:14:43 | stephenfin | I didn't put it in the commit message since those links expire after ~30 days | |
| 16:14:58 | sean-k-mooney | oh i see | |
| 16:15:01 | sean-k-mooney | the argument changes | |
| 16:15:15 | sean-k-mooney | so its still being called but with diffenrt kwargs | |
| 16:15:58 | stephenfin | yep | |
| 16:16:25 | stephenfin | but as I've noted in the review, whether it's called or not is immaterial to Nova, at least in the context of a unit test | |
| 16:18:27 | melwitt | sean-k-mooney: ok I think it's from this change rather https://review.opendev.org/c/openstack/keystoneauth/+/1003778/3/keystoneauth1/service_token.py | |
| 16:18:57 | stephenfin | melwitt: beat me to it | |
| 16:19:17 | melwitt | \o/ did one thing right today. eventually. | |