| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-08-25 | |||
| 18:09:55 | melwitt | sean-k-mooney: hm ok, so that should be admin=False. I had thought it was but that must have been an earlier iteration | |
| 18:10:43 | sean-k-mooney | ya which means we take the if brnach here https://review.opendev.org/c/openstack/nova/+/1002007/8/nova/utils.py#940 | |
| 18:10:45 | sean-k-mooney | not the else | |
| 18:11:04 | sean-k-mooney | but if we take the if brnach we done need to chagne the signigure to pass in ksa_auth | |
| 18:12:06 | sean-k-mooney | if admin false branch already correctly constuct the service user token and uses the uers token form the context to constuct the sdk connection | |
| 18:12:23 | melwitt | argh dammit | |
| 18:13:01 | melwitt | sorry | |
| 18:13:42 | sean-k-mooney | on a side note i messed up my grub config on one of my dev hosts, i do not know the root password adn signle user mode didnt work so im not reinstalling an os | |
| 18:13:47 | sean-k-mooney | so its one of those days | |
| 18:14:15 | melwitt | I have been there | |
| 18:17:21 | sean-k-mooney | i didnt properly unstack and swift or rather the swift loopback volume we create in devstack is preventing the boot | |
| 18:18:12 | sean-k-mooney | melwitt: have you had a chance to check the auth change on a devstack by the way | |
| 18:19:41 | melwitt | sean-k-mooney: no, but cyborg-tempest-py3 was definitely showing when it fails | |
| 18:20:23 | sean-k-mooney | ack i was plannign to test it on the host im reinstalling before trying to test the nvme serise | |
| 18:23:01 | melwitt | ++ | |
| 18:30:17 | opendevreview | Merged openstack/nova master: Stabilize TestInstanceNotificationSample.test_instance_action https://review.opendev.org/c/openstack/nova/+/1002246 | |
| 18:32:06 | sean-k-mooney | melwitt: my main concern woudl be that all the attachment end up beign owned by nova instead of the end user | |
| 18:32:31 | sean-k-mooney | i.e. the client worked but the ownership was wrong | |
| 18:32:46 | melwitt | yeah, that is an important point | |
| 18:33:12 | sean-k-mooney | hence why i want to check it on a devstack si i can check the db to verify the ownership | |
| 18:36:35 | melwitt | yeah, you are right | |
| 19:06:52 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Fix graceful shutdown functional unstable tests https://review.opendev.org/c/openstack/nova/+/1002223 | |
| 20:11:16 | opendevreview | melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007 | |
| 20:28:02 | gmaan | melwitt: gibi updated this, matching the service_down_time with what any test can take time to execute, also added the root cause of why service down is happening in between of tests in note/commit msg https://review.opendev.org/c/openstack/nova/+/1002223 | |
| 20:52:42 | opendevreview | Merged openstack/nova master: Stabilize TestInstanceNotificationSampleWithMultipleCompute https://review.opendev.org/c/openstack/nova/+/1002281 | |
| 21:29:04 | opendevreview | melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007 | |
| 21:32:35 | opendevreview | melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007 | |
| 22:26:03 | melwitt | sean-k-mooney: ok, I think https://review.opendev.org/c/openstack/nova/+/1002007 should be in the right state now. I'm leaving it in WIP mode while we test it more | |
| 23:47:46 | melwitt | sean-k-mooney: seems to work as intended on my devstack, created a server with the fake_driver device and the extended_accelerator_requests table has a record with project_id of the "demo" project I created the server with | |
| #openstack-nova - 2026-08-26 | |||
| 00:20:12 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Shutdown thread pool executors during graceful shutdown https://review.opendev.org/c/openstack/nova/+/1000211 | |
| 00:21:58 | gmaan | gibi: dansmith ^^ updated the shutdown executors with wait=True | |
| 00:28:18 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141 | |
| 00:31:08 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141 | |
| 00:49:02 | gmaan | melwitt: gibi ^^ updated the doc change also | |
| 02:16:07 | opendevreview | Merged openstack/nova master: Bump python_version for mypy to 3.11 https://review.opendev.org/c/openstack/nova/+/1002290 | |
| 02:54:27 | opendevreview | Merged openstack/nova master: Do not use format string in logs https://review.opendev.org/c/openstack/nova/+/987016 | |
| 03:06:16 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Fix race between RPC method completion and task tracking updates https://review.opendev.org/c/openstack/nova/+/1002432 | |
| 04:33:58 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Extract share management from ComputeManager https://review.opendev.org/c/openstack/nova/+/999349 | |
| 04:33:59 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916 | |
| 04:33:59 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633 | |
| 05:02:06 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916 | |
| 05:48:33 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916 | |
| 06:22:48 | opendevreview | Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments when shelve is preempted by a delete https://review.opendev.org/c/openstack/nova/+/1002439 | |
| 06:24:05 | opendevreview | Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments when shelve is preempted by a delete https://review.opendev.org/c/openstack/nova/+/1002439 | |
| 06:25:16 | opendevreview | Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments by preemptive delete https://review.opendev.org/c/openstack/nova/+/1002439 | |
| 07:03:47 | opendevreview | Merged openstack/nova master: Use service shutdown related config options in nova-graceful-shutdown https://review.opendev.org/c/openstack/nova/+/1001017 | |
| 08:21:26 | antia | gibi: Is there anything to resolve, other than the gate errors, for the TDX series? | |
| 08:24:48 | gibi | antia: I'm not tracking anything else just the gate | |
| 08:25:01 | gibi | antia: if you have time contributing whitebox test for TDX would be nice | |
| 08:25:47 | gibi | also if you want you can write a blogpost somewhere about how to configured you HW and tested the series (or even about your overall contribution experience) and we will probably link to it in our doc :) | |
| 08:27:05 | antia | I already started on the whitebox testing, so I'll try to finish that :) | |
| 11:02:32 | stephenfin | sean-k-mooney: melwitt: Because we're doing some deeper diving on KSA at the moment... I've proposed https://review.opendev.org/c/openstack/nova/+/1002359. That is a small initial step that would allow us to move away from cinderclient in a future release. efried started the effort years ago but never closed it out. I'd appreciate your reviews if possible | |
| 11:03:11 | sean-k-mooney | stephenfin: i saw that in my notifications but didnt look so closely | |
| 11:03:30 | sean-k-mooney | i think some of the changes that melwitt has in the cybrog patch are still not required | |
| 11:03:45 | sean-k-mooney | i think it will now work | |
| 11:03:56 | sean-k-mooney | but im not sure why we need to pass in ksa_auth | |
| 11:04:15 | sean-k-mooney | stephenfin: do you know why https://review.opendev.org/c/openstack/nova/+/1002007/11/nova/utils.py is required | |
| 11:04:35 | sean-k-mooney | am i missing somthing in the admin false path? | |
| 11:05:26 | sean-k-mooney | its creating a service token and then usign the user token form the context to create the connections? | |
| 11:05:31 | sean-k-mooney | or is that wrong | |
| 11:06:38 | sean-k-mooney | was the previous admin=false path not passing a service token as well as the user token | |
| 11:06:45 | stephenfin | looking | |
| 11:15:22 | sean-k-mooney | stephenfin: ya thats the chnage | |
| 11:15:47 | sean-k-mooney | well | |
| 11:15:54 | stephenfin | sorry, wanted to double check stuff | |
| 11:16:01 | stephenfin | my understanding of those changes was that we needed to pre-build the auth plugin becuse one of the other services currently using SDK appear to be using service tokens | |
| 11:16:22 | stephenfin | (i.e. ironic and and manila) | |
| 11:16:58 | sean-k-mooney | so manila i think needed the service toke already | |
| 11:17:22 | sean-k-mooney | but in any case i can see that the new flow does build it correctly | |
| 11:17:37 | sean-k-mooney | the old flow might of or may have needed us to add it after the connection was created | |
| 11:17:59 | sean-k-mooney | so this is a bit cleaner in that when we get the adapter back we know it has it | |
| 11:18:12 | sean-k-mooney | but also less clean as it requires use to manually build it and pass it in | |
| 11:18:28 | stephenfin | we don't seem to be using service tokens for manila currently? https://github.com/openstack/nova/blob/master/nova/share/manila.py#L32-L48 | |
| 11:19:11 | stephenfin | unless I'm missing something (that's what I was looking for) | |
| 11:19:11 | sean-k-mooney | we are ment ot use service tokesn for ever call ot other services if tis defiend in the config | |
| 11:19:20 | sean-k-mooney | and you cant talk to cinder or cyrbog without them | |
| 11:19:28 | sean-k-mooney | so the service user section is effectivly alwasy required now | |
| 11:19:55 | sean-k-mooney | stephenfin: i rememebr there was a lot of issues tryign to figurfe out how to make serivce user tokens work before with the sdk | |
| 11:20:08 | sean-k-mooney | so my guess is this nerver got wiered in and we hav ejust and a bug the hwole time | |
| 11:20:59 | stephenfin | I suspect so, though again I might be missing something | |
| 11:21:44 | stephenfin | You're likely right about this not being as simple as it could be. we probably should have get_sdk_adapter handle the whole service token logic for us (and I assume it should default to doing just that) | |
| 11:21:48 | sean-k-mooney | well i think in either case if tis not obviouysly using it its a opertunity to impvoe it | |
| 11:22:04 | sean-k-mooney | stephenfin: that is waht i was expecting | |
| 11:22:29 | sean-k-mooney | for the get_sdk_adapter to uncondtionally add the service token when its in the config | |
| 11:23:07 | sean-k-mooney | i think we can likely proceed with mels patch for now, and then we can do that cleanup with or after your cidner one | |
| 11:23:53 | sean-k-mooney | alsthough we can see what mel things ill leave a suggestion in the review | |
| 11:24:05 | stephenfin | Yes, we dont want to block the other cyborg work you've got going on. I'll pull that down and see if I can tidy it up somewhat. We've still got another day or two before freeze for SDK so if there are feature gaps there, we could close them out | |
| 11:25:28 | sean-k-mooney | i think in the long term it might be nice to have a more native way to do this in the sdk, ie and interface that allwo use to pass 2 config section and optionally an exisitng token when we want to use that as the user token | |
| 11:25:45 | sean-k-mooney | and jsut let the sdk deal with it but not right now | |
| 11:42:41 | sean-k-mooney | stephenfin: ok left my comments and +2'd ill hold +w unitil mel is aroudn and she can catchup | |
| 11:42:51 | sean-k-mooney | ill go look at your cidner patch next | |
| 11:43:38 | sean-k-mooney | stephenfin: oh that `'[cinder] catalog_info` ya that annorying and we shoudl fix that | |
| 11:44:17 | sean-k-mooney | it was "special" when we were creating the now redhat installer and i rememebr havign to confirue it differencly | |
| 11:45:11 | sean-k-mooney | that shoudl allwo use to clean up some fo this in devstack also | |
| 11:45:36 | stephenfin | sean-k-mooney: I agree RE: SDK support here. I forgot that I wrote docs on this back when Uggla was working on the Manila stuff, but I think he never got it work (?) https://review.opendev.org/c/openstack/openstacksdk/+/893505 | |
| 11:45:37 | sean-k-mooney | we have some common fucntion for configruign the ksa sections which dont quite work with cidner if i recall | |
| 11:46:09 | stephenfin | sean-k-mooney: I looked at devstack and it doesn't set those weird Cinder options, thankfully | |
| 11:46:13 | sean-k-mooney | stephenfin: that or the patch is siting on review somewhere | |
| 11:46:32 | sean-k-mooney | stephenfin: oh good to know | |
| 11:47:13 | sean-k-mooney | https://github.com/openstack-k8s-operators/nova-operator/blob/main/templates/nova/nova.conf#L362-L377 | |