Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-08-05
13:10:41 sean-k-mooney you mentioned you just promoted the column right
13:11:23 sean-k-mooney i dont know that we ever join on that primary key so for that specici table droping that column might also be an option
13:12:22 sean-k-mooney the unique constraitn is the instance id or uuid and the metadata key i think and we alwasy join on the instance id
13:14:32 sean-k-mooney ya its on the instanfce uuid we actuly do not have a proper uniwue constrating on that table...
13:14:35 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/db/main/models.py#L987-L1004
13:15:23 sean-k-mooney i wonder if that would be the better fix in this case add a uniqeconstrat on instnace_uuid + key colum and drop id entirly
13:16:06 sean-k-mooney the instance uuid is effectivly the real "primary key" based on our actul usage which is why its already got its own index
13:21:35 sean-k-mooney ah this has the soft delete mixin
13:22:00 sean-k-mooney so ya we cant actully change the colume name like that or delete the id colume and use a compistie primay key
13:22:15 sean-k-mooney so the only options are reindex or promot to BigInt
13:25:10 sean-k-mooney jangutter[m]: you will need to promote the deleted colume to the same type because of softdelete fyi
13:25:25 sean-k-mooney otherwase you wont be abel to delete if the value exceeds int max
13:38:07 jangutter[m] oh yes, we saw you need to do it in pairs.
13:40:42 jangutter[m] We managed to speedrun it in 2-3 years with a combination of ~50 properties per instance and a tight create/delete loop.
13:41:02 sean-k-mooney yep that will do it
13:41:28 sean-k-mooney we did the reindex by sufflleing all the rows down to avoid needing to mess with the schema
13:43:04 sean-k-mooney as noted we dont actully use the id values
13:43:12 sean-k-mooney so the hack is basiclly
13:43:15 sean-k-mooney SET @num := 0;
13:43:17 sean-k-mooney UPDATE instance_system_metadata SET id = @num := (@num+1);
13:43:19 sean-k-mooney ALTER TABLE instance_system_metadata AUTO_INCREMENT =1;
13:44:35 sean-k-mooney i say basiclly becase if the deleted colum is non 0 you have to set delete=id as well
13:44:49 sean-k-mooney to keep the soft delete state correct
13:45:02 sean-k-mooney im sure you can express that as a single query but i think we didi it in python
13:45:51 jangutter[m] That would be a handy hack to have in nova-manage.
13:46:28 jangutter[m] but you have to be sure the id isn’t referenced elsewhere.
13:51:52 sean-k-mooney ya and there are other tabels that we can or coudl do the same for
13:52:09 sean-k-mooney basiclly a `nova-manage db compact` command
13:52:52 sean-k-mooney i think to do that properly you need to do it with a full table lock and batch it to now block operations
13:53:19 sean-k-mooney or do it offline but but if you do it 1000 rows at a time ectra you could do it online
14:13:20 MaxLamprecht[m] Hey folks, I wanted to ask regarding some attachment fixes I proposed a while ago(we merged 1 out of 3 fixes a while ago). https://review.opendev.org/c/openstack/nova/+/974832 and https://review.opendev.org/c/openstack/nova/+/972045 are still open with valid reproducers/regression tests. Is there something I can do to get more attention on this topic?
14:24:30 opendevreview minwoo seo proposed openstack/nova master: libvirt: Add volume migration bandwidth option to nova.conf https://review.opendev.org/c/openstack/nova/+/999841
14:39:26 tkajinam clif, hj could you try https://review.opendev.org/c/openstack/nova/+/999780 when you have time ?
14:39:41 tkajinam there are a few functional tests still failing but CI shows at least unit tests are passing
14:42:29 clif tkajinam: passes for me: py3: OK (113.29=setup[2.17]+cmd[99.77,7.69,3.66] seconds)
14:42:58 tkajinam clif, that's good. could you also run functional tests there, too ?
14:43:05 clif sure
14:43:06 tkajinam I expect two reshape tests may fail
14:49:07 clif tkajinam: I get two failures in functional: nova.tests.functional.libvirt.test_reshape.SevResphapeTests.test_create_servers_with_amd_sev and nova.tests.functional.libvirt.test_reshape.SevResphapeTests.test_create_servers_with_amd_sev_mixed
14:49:12 tkajinam yeah
14:49:40 tkajinam it's wired that update_available_resource is called there though it's mocked out
15:03:58 opendevreview Clif Houck proposed openstack/nova master: perf(ironic): eliminate O(N²) ProviderTree deepcopy at startup (B6) https://review.opendev.org/c/openstack/nova/+/980676
15:06:14 melwitt MaxLamprecht[m]: channel ping is good, both have green CI, i will try to look soon
15:08:47 Uggla Reminder upstream bug triage in ~20mn.
15:12:24 lajoskatona sean-k-mooney: Hi, there is a patch ( https://review.opendev.org/c/openstack/nova/+/982085) for https://bugs.launchpad.net/nova/+bug/2051685 (After repeat of incomplete migration nova applies wrong (status=error) migration context in update_available_resource periodic job)
15:12:48 lajoskatona sean-k-mooney: and a reproducer functional test under the commit. As I remember we had a short chat about it, if you have time can you please check it? Bence / rubasov started to work on it but He was moved to another project so I am kind of responsible for it now :)
15:15:19 opendevreview Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679
15:28:04 opendevreview minwoo seo proposed openstack/nova master: libvirt: Add volume migration bandwidth option to nova.conf https://review.opendev.org/c/openstack/nova/+/999841
15:33:38 Uggla Link reminder: meet.google.com/zjr-rxus-hzj (upstream triage)
15:40:34 opendevreview Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780
15:40:45 opendevreview Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729
16:37:26 opendevreview Balazs Gibizer proposed openstack/nova master: Add reproducer for bug/2162912 https://review.opendev.org/c/openstack/nova/+/999877
17:06:49 tkajinam sean-k-mooney dansmith https://review.opendev.org/c/openstack/nova/+/999780 fixes the unit/func tests in amd machine
17:07:00 tkajinam verified in ci by https://review.opendev.org/c/openstack/nova/+/999729
17:07:06 tkajinam just fyi
17:07:18 tkajinam (but appreciate your reviews, if you have time
17:08:57 sean-k-mooney i looked breifly this morningin the only thing i was debtin is if you shoudl pass in the var when constucting the fixture as you are doign or just have the class var defiend in the fixture and use it direcly
17:09:37 sean-k-mooney that would just avoid proxing it here https://review.opendev.org/c/openstack/nova/+/999780/6/nova/tests/functional/libvirt/base.py
17:19:26 sean-k-mooney but i see why you did it this way
17:22:03 sean-k-mooney +2 form me
17:46:03 sean-k-mooney gmaan: https://review.opendev.org/c/openstack/nova/+/980679 this is the patch that i mentioned today related to usign an executor to Parallelize per-node resource updates
17:46:32 sean-k-mooney its workign the exact same as the _sync_power_executor https://review.opendev.org/c/openstack/nova/+/980679/5/nova/compute/manager.py#669
19:06:20 gmaan sean-k-mooney: ack
19:20:54 opendevreview Bryan Fraschetti proposed openstack/nova master: add task state for attach volume and detach volume https://review.opendev.org/c/openstack/nova/+/985718
19:20:54 opendevreview Bryan Fraschetti proposed openstack/nova master: Feat: Add Command for Forceful BDM Deletion https://review.opendev.org/c/openstack/nova/+/985717
19:20:55 opendevreview Bryan Fraschetti proposed openstack/nova master: Reject Volume Attachment if task_state not Attaching https://review.opendev.org/c/openstack/nova/+/985719
19:20:55 opendevreview Bryan Fraschetti proposed openstack/nova master: Reject to attach and detach volume while task_state is not None https://review.opendev.org/c/openstack/nova/+/758918
20:07:57 opendevreview Merged openstack/placement stable/2026.1: Reproduce bug 2160721 https://review.opendev.org/c/openstack/placement/+/998873
20:07:59 opendevreview Merged openstack/placement stable/2026.1: Check overall capacity before generating candidates https://review.opendev.org/c/openstack/placement/+/998874
#openstack-nova - 2026-08-06
03:56:02 opendevreview Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299
04:13:48 opendevreview Ghanshyam Maan proposed openstack/nova master: Track and log the main RPC server in-progress task https://review.opendev.org/c/openstack/nova/+/999914
04:15:06 opendevreview Ghanshyam Maan proposed openstack/nova master: Track and log the main RPC server in-progress task https://review.opendev.org/c/openstack/nova/+/996583
04:17:36 opendevreview Takashi Kajinami proposed openstack/nova master: Fix SyntaxWarning https://review.opendev.org/c/openstack/nova/+/999915
04:30:30 opendevreview Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299
04:32:14 opendevreview Ghanshyam Maan proposed openstack/nova master: Track and log the main RPC server in-progress task https://review.opendev.org/c/openstack/nova/+/996583
07:57:08 masahito hi nova team, please review the API response code bug fixes.
07:57:49 masahito The reproducer only needs W+2. https://review.opendev.org/c/openstack/nova/+/946223 https://review.opendev.org/c/openstack/nova/+/971153
08:12:00 opendevreview chandan kumar proposed openstack/os-traits master: Add HW_NVME capability traits https://review.opendev.org/c/openstack/os-traits/+/999921
08:41:03 gibi based on my estimates we will have our 1Mth gerrit change created today https://opendev.gibi.dev/
08:46:17 bauzas when I started, I do remember when we git the 10kth :)
08:46:21 bauzas hit*
08:49:14 gibi nice
09:47:53 opendevreview Takashi Kajinami proposed openstack/nova master: Fix SyntaxWarning https://review.opendev.org/c/openstack/nova/+/999915
11:17:19 opendevreview Matěj Mudra proposed openstack/nova master: Add --verbose to nova-manage commands https://review.opendev.org/c/openstack/nova/+/999956
13:27:31 opendevreview minwoo seo proposed openstack/nova master: libvirt: Add volume migration bandwidth option to nova.conf https://review.opendev.org/c/openstack/nova/+/999841
14:25:13 opendevreview ribaudr proposed openstack/nova master: Fix CPU pinning reset during evacuate periodic race https://review.opendev.org/c/openstack/nova/+/999978
14:25:13 opendevreview ribaudr proposed openstack/nova master: Add regression test for bug 2162835 https://review.opendev.org/c/openstack/nova/+/999977
14:29:38 opendevreview ribaudr proposed openstack/nova master: Fix CPU pinning reset during evacuate periodic race https://review.opendev.org/c/openstack/nova/+/999978
16:31:43 opendevreview Balazs Gibizer proposed openstack/nova stable/2026.1: DNM: check CI https://review.opendev.org/c/openstack/nova/+/999997
16:32:27 opendevreview Balazs Gibizer proposed openstack/nova stable/2025.2: DNM: test CI https://review.opendev.org/c/openstack/nova/+/999998
16:32:51 opendevreview Balazs Gibizer proposed openstack/nova master: Happy One Millionth Gerrit Change! https://review.opendev.org/c/openstack/nova/+/1000001
16:33:33 gibi ahh zuul was faster
16:33:37 gibi https://review.opendev.org/c/zuul/zuul/+/1000000
16:37:36 elodilles i got all the nines o:) https://review.opendev.org/c/openstack/nova/+/999999
16:39:00 gibi lucky you :)
16:41:30 gmaan :)
17:15:45 sean-k-mooney :)
17:15:51 sean-k-mooney i didn even notice we were close
17:16:49 sean-k-mooney gibi: honestly off by one is better
18:00:06 dansmith I think elodilles actually got the millionth if my off-by-one math is correct

Earlier   Later