Earlier  
Posted Nick Remark
#openstack-nova - 2026-07-28
13:46:01 opendevreview Balazs Gibizer proposed openstack/nova master: [cover]stabilize test_migrate_from_disabled_host https://review.opendev.org/c/openstack/nova/+/998925
14:10:22 opendevreview Akash Roshan Chaurasia proposed openstack/nova master: Retry and record fault on network cleanup failure https://review.opendev.org/c/openstack/nova/+/998954
14:34:39 opendevreview Balazs Gibizer proposed openstack/nova master: Make functional-py313-threading voting https://review.opendev.org/c/openstack/nova/+/997216
14:34:39 opendevreview Balazs Gibizer proposed openstack/nova master: Stabilize func test waiting for VM ERROR state https://review.opendev.org/c/openstack/nova/+/998822
16:55:50 opendevreview Merged openstack/nova master: Add RBD XML update functionality for migration process https://review.opendev.org/c/openstack/nova/+/974032
#openstack-nova - 2026-07-29
06:16:02 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633
06:52:16 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Allow rebuild for instances with virtiofs shares https://review.opendev.org/c/openstack/nova/+/999048
06:53:31 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Allow rebuild for instances with virtiofs shares https://review.opendev.org/c/openstack/nova/+/999048
09:48:28 opendevreview Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299
09:48:29 opendevreview Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840
13:48:41 opendevreview Balazs Gibizer proposed openstack/nova master: Make functional-py313-threading voting https://review.opendev.org/c/openstack/nova/+/997216
13:48:42 opendevreview Balazs Gibizer proposed openstack/nova master: Stabilize functional test for slow instance.save https://review.opendev.org/c/openstack/nova/+/999121
13:49:04 gibi OK now that ^^ series feels complete to stabilize the functional-py313-threading tox target
13:50:59 opendevreview Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840
13:50:59 opendevreview Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299
15:05:28 ralonsoh sean-k-mooney, gibi hi folks, I've seen recently a raise in the live-migrations errors, in particular in the ML2/OVS jobs
15:05:35 ralonsoh I've reported https://bugs.launchpad.net/nova/+bug/2161894
15:06:05 ralonsoh can you please take a look? Because this is happening randomly. Most of the times is because the port ofport=-1
15:06:09 sean-k-mooney interesitng
15:06:16 sean-k-mooney yes we can take a look
15:06:26 ralonsoh with os_vif_delegation=True, that means this is created by qemu
15:06:32 ralonsoh (if I'm not wrong)
15:06:54 sean-k-mooney yes and no
15:07:09 ralonsoh I thought initially that could be related to the tap creation flag, but that was for ML2/OVN only (at least now)
15:07:22 sean-k-mooney so ml2/ovs is require to finish bidnign prot with of-port=-1
15:07:49 sean-k-mooney os_vif_delegation=True menas we use interface type ethernet
15:08:12 ralonsoh yes, but who creates the TAP?
15:08:32 sean-k-mooney libvirt
15:08:48 ralonsoh that's the point, the TAP is created when the VM is unpaused
15:08:51 sean-k-mooney if you want os-vif to create the tap then you need to tell os-vif ot do that with the new fucntioantly
15:08:54 ralonsoh or at least the ofport assigned
15:09:00 sean-k-mooney ralonsoh: yes
15:09:12 sean-k-mooney and ml2 ovs is not allowed to rely on the ofport being set
15:09:28 sean-k-mooney to send network-vif-plugged
15:09:45 ralonsoh yes, OVS agent needs to see ofport different from INVALID (-1)
15:10:01 ralonsoh and then Neutron API will send the vif-plugged event
15:10:02 sean-k-mooney that is a neutron bug
15:10:09 sean-k-mooney ti is not allowed to requrie that
15:10:14 sean-k-mooney because it will break dpdk if it does
15:10:59 ralonsoh this is why in dpdk we disable live_migration_wait_for_vif_plug
15:11:05 sean-k-mooney no
15:11:21 ralonsoh let's focus on the kernel datapath
15:11:23 sean-k-mooney for dpdk we shoudl not reuire that
15:11:56 sean-k-mooney ok well the ovs agent regardless of the kerle or dpdk
15:12:13 sean-k-mooney is not allowed to depen on osprot being set to a non -1 value
15:12:15 sean-k-mooney https://github.com/openstack/neutron/commit/7ebcce0b8dcd4cd482da92672f5ae7c51530a429
15:12:21 sean-k-mooney is likely a regression
15:12:52 sean-k-mooney well maybe not
15:13:10 sean-k-mooney ``network-vif-plugged`` shoudl be sent when osport is -1
15:13:57 ralonsoh we have never done this
15:14:25 sean-k-mooney we never depened on the ofport out side of the openflow security group driver
15:14:45 sean-k-mooney so if you use ip tbales ofport was never reuqired
15:15:11 sean-k-mooney and even with the ovs firewall driver we just defered the security gorup flwo setup
15:15:58 ralonsoh but regardless of the FW setup, that is done after the port receives a valid ofport
15:16:10 sean-k-mooney it wasnt in the past
15:16:40 ralonsoh I pushed this https://review.opendev.org/c/openstack/neutron/+/992423 1 month ago
15:16:42 sean-k-mooney the tap is created befor ethe vm is unpased by the way
15:16:47 ralonsoh (related to the previous patch)
15:16:48 sean-k-mooney but not a lot before it
15:17:53 ralonsoh yes, but the TAP is created by libvirt, and that requires the vif-plugged event
15:18:03 ralonsoh I really don't know how this could work now
15:18:21 sean-k-mooney no the vif plugged event does not depend on the tap exsiting in general
15:18:39 ralonsoh without the TAP, the ofport=-1
15:18:41 ralonsoh right?
15:18:46 sean-k-mooney yes
15:18:48 sean-k-mooney and that is valid
15:18:51 ralonsoh so yes, it depends
15:19:07 ralonsoh until we have a valid ofport, Neutron does not send vif-plugged
15:19:19 sean-k-mooney ml2/ovs need to supprot seting network-vif-plugged with ofport=-1
15:19:29 sean-k-mooney then that is a regression in neutron
15:19:39 ralonsoh we never did that before
15:19:42 sean-k-mooney yes we di
15:19:43 ralonsoh this could not be a regression
15:19:49 sean-k-mooney for a very very very long time
15:20:11 ralonsoh no no, hold on
15:20:13 sean-k-mooney this is how dpdk has worked for ever
15:20:24 ralonsoh I really need to understand how it could work now
15:20:36 ralonsoh because is working randonly, most of the times
15:20:48 sean-k-mooney https://github.com/openstack/neutron/commit/7fd2725cb14b81f442eb57a38755829270ff2c43
15:21:57 ralonsoh ok, I need to review this patch too (I remember it)
15:22:10 ralonsoh I think this is working by accident
15:22:26 opendevreview Philipp Dreesens proposed openstack/nova-specs master: Add spec for bidirectional RPC liveness handshake https://review.opendev.org/c/openstack/nova-specs/+/984384
15:22:28 ralonsoh --> The network-vif-plugged during live migration was sent by the SOURCE agent calling update_device_up (for the existing binding that's still active on the source), NOT by the destination agent.
15:23:11 sean-k-mooney that shoudl not happen becuse we set migrating_to
15:23:14 sean-k-mooney in the port profiel
15:23:23 ralonsoh I know, I changed this code
15:24:39 sean-k-mooney and only the host named there is ment to send it with yes you updated that code
15:25:56 ralonsoh sean-k-mooney, thanks a lot, I need to recheck the recent changes in the OVS agent
15:26:11 ralonsoh (done by me, trying to fix other issues)
15:32:18 sean-k-mooney as an aside "``os_vif_delegation=True`` and ``create_port=True``" will mena the tap is create before we add the ovs port
15:32:37 sean-k-mooney so in that case we wont see -1 for kernel ovs but we still will for dpdk
15:32:54 sean-k-mooney os we shoudl not have divergent code paths if we can aovid it and just alwasy supprot -1
15:38:45 ralonsoh but isn't supporting ofport=-1 something wrong?
15:39:14 ralonsoh with ``create_port=True``, when the port is created? who creates it?
15:40:45 ralonsoh I need to leave now, I'll check this chat later. I'll also review the current OVS agent code
15:42:22 sean-k-mooney not in general. with create_port=True its not required
15:42:34 sean-k-mooney for kernel ovs
15:44:52 sean-k-mooney this is not the first time we have had to revert skipping prot wot ofprot=-1 https://github.com/openstack/neutron/commit/f1fa9529ee6753e2a3f47e4a6eb0286118520d25
21:44:41 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Allow rebuild for instances with virtiofs shares https://review.opendev.org/c/openstack/nova/+/999048
22:12:20 opendevreview Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299

Earlier   Later