| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-07-14 | |||
| 11:26:20 | sean-k-mooney | im going to stop guessing if you come up with a test that works let me know and i can take a look | |
| 11:31:21 | gibi | sure I'm working on it | |
| 11:31:59 | gibi | it is a bit more complicated due to https://github.com/openstack/oslo.concurrency/blob/9aff32494fb97b7fc7508269224353aceb9ceef6/oslo_concurrency/lockutils.py#L101-L103 | |
| 11:32:23 | gibi | so they are also passing threading.current_thread to the parent | |
| 11:32:49 | gibi | sorry I ment https://github.com/openstack/oslo.concurrency/blob/9aff32494fb97b7fc7508269224353aceb9ceef6/oslo_concurrency/lockutils.py#L101-L108 | |
| 11:33:30 | sean-k-mooney | ya i was looking at that functor | |
| 11:34:19 | sean-k-mooney | threading.current_thread should be monkeypatch to eventlet.getcurrent in general before we hit this code | |
| 11:34:34 | sean-k-mooney | if we are usign eventlet | |
| 11:35:44 | sean-k-mooney | https://github.com/openstack/oslo.concurrency/commit/02dee958453513bb8a5aaae905312d306c2d9083#diff-60d0bce7c34c2c70cf4e3ac63060779235ede2a247bd39d1188f8fedd6306b38R109 | |
| 11:35:54 | sean-k-mooney | so that defaulting was added in the typeing patch | |
| 11:36:27 | gibi | ahh I see it, I need to use spawn_n not spawn to reproduce it | |
| 11:36:28 | sean-k-mooney | and it proably should not be | |
| 11:36:40 | gibi | the original eventlet issue is only affecting spawn_n | |
| 11:36:40 | sean-k-mooney | oh | |
| 11:36:46 | gibi | not spawn | |
| 11:36:54 | gibi | thanks melwitt for the good bug report | |
| 11:37:12 | sean-k-mooney | i know that changes between a raw greenlet and a greenthread | |
| 11:37:19 | sean-k-mooney | is that really the level where it broke | |
| 11:38:07 | gibi | yepp | |
| 11:38:09 | sean-k-mooney | i tought i had a patch to remove all useage of spawn_n at one point | |
| 11:38:23 | gibi | that is a good point ^^ we need to look | |
| 11:38:36 | sean-k-mooney | i am :) | |
| 11:39:20 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/892722 | |
| 11:40:27 | sean-k-mooney | so yes i did but we went with https://review.opendev.org/c/openstack/nova/+/873061 | |
| 11:40:29 | sean-k-mooney | instead | |
| 11:40:59 | sean-k-mooney | it would still be an oslo bug | |
| 11:41:10 | sean-k-mooney | but ya we can likely simplify now | |
| 11:42:11 | sean-k-mooney | oh we already have | |
| 11:42:38 | sean-k-mooney | spwan is now a call to spawn on with the default executor | |
| 11:43:24 | sean-k-mooney | but i bet the futurist executor might be using spwan_n somewhere along the way | |
| 11:44:32 | sean-k-mooney | we have a hacking check to prevent raw usage of spawn and spwan_n https://github.com/openstack/nova/commit/6179854ae77960d4ae883349626069023b407cb0 | |
| 11:45:22 | sean-k-mooney | well and eventlet in genreal so any usage is likely not in nova | |
| 11:46:01 | sean-k-mooney | gibi: yep https://github.com/openstack/futurist/blob/6f870896819197ca323b3dd8af8f3b0389aff69c/futurist/_futures.py#L718 | |
| 11:46:55 | sean-k-mooney | gibi: so the GreenThreadPoolExecotor uses spwan_n whne it spins up new workers | |
| 11:47:12 | gibi | I will be so happy when we finally delete eventlet :) | |
| 11:47:42 | sean-k-mooney | hehe so that litrally made me lol | |
| 11:47:48 | sean-k-mooney | but i agree | |
| 11:48:33 | sean-k-mooney | gibi: that can help you create a test case but i assume you already have one now | |
| 11:53:50 | opendevreview | sean mooney proposed openstack/nova stable/2025.2: Make QEMU_IMG_LIMITS process limits configurable https://review.opendev.org/c/openstack/nova/+/997028 | |
| 11:54:30 | opendevreview | sean mooney proposed openstack/nova stable/2025.1: Make QEMU_IMG_LIMITS process limits configurable https://review.opendev.org/c/openstack/nova/+/997029 | |
| 12:02:42 | gibi | sean-k-mooney: here is the repro and the fix https://review.opendev.org/c/openstack/oslo.concurrency/+/997200 | |
| 12:05:18 | sean-k-mooney | oh thats the fix :) | |
| 12:05:25 | sean-k-mooney | i was like wait they alrady have a bug for this | |
| 12:05:50 | sean-k-mooney | i.e. reading "# This is bug https://bugs.launchpad.net/oslo.concurrency/+bug/2160596" | |
| 12:06:59 | gibi | :) | |
| 12:07:10 | gibi | sean-k-mooney: thanks for the help root causing this issue | |
| 12:07:47 | sean-k-mooney | no worries i wrote the test that was beign broken so i was interested in the resolution | |
| 12:08:05 | sean-k-mooney | i tried really hard to make the FairLockGuard robust | |
| 12:08:22 | sean-k-mooney | so i was concerned i missed somthing | |
| 12:08:43 | gibi | sean-k-mooney: yeah all that effort is in vain if eventlet breaks you | |
| 12:17:59 | sean-k-mooney | minior nit in the commit messge of the second patch | |
| 12:18:07 | sean-k-mooney | but the logic in both looks good to me | |
| 12:18:50 | gibi | fixed | |
| 12:20:20 | sean-k-mooney | :) | |
| 12:59:39 | opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | |
| 12:59:39 | opendevreview | Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 13:10:55 | opendevreview | Merged openstack/nova master: Reproducer for https://bugs.launchpad.net/nova/+bug/2160224 https://review.opendev.org/c/openstack/nova/+/996756 | |
| 13:49:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not try to return empty attachment_id from API https://review.opendev.org/c/openstack/nova/+/996757 | |
| 13:52:37 | gibi | gmaan: sean-k-mooney: ^^ this is now ready to land ;) | |
| 13:53:38 | gibi | sean-k-mooney: also if you have a sec we have this small fix https://review.opendev.org/c/openstack/nova/+/996757/1 | |
| 13:54:01 | sean-k-mooney | isnt that te same link | |
| 13:54:02 | gibi | then when these are landed I will propose a patch to make the functional-py313-threading patch as voting | |
| 13:54:31 | gibi | https://review.opendev.org/c/openstack/nova/+/996793 this is the correct link for the small fix | |
| 13:54:39 | sean-k-mooney | :) | |
| 13:54:45 | gibi | (copy paste is hard as you see) | |
| 13:54:46 | sean-k-mooney | sure ill look at both now | |
| 13:54:49 | gibi | thanks | |
| 13:56:08 | sean-k-mooney | +2w on the fix the cyborg irc call is starting nowish so ill see if i can review the attachmet id one before then | |
| 13:56:23 | gibi | OK | |
| 13:56:46 | sean-k-mooney | ach cool you addeed the return code checks | |
| 13:57:16 | sean-k-mooney | well you added them as new tests | |
| 13:57:30 | sean-k-mooney | but ya i think thats ok | |
| 14:04:53 | sean-k-mooney | gibi: +2 on that too i dont really have any feedback to add so if gmaan is happy to proceed then cool | |
| 14:05:28 | sean-k-mooney | irc meting just started but are you plannning to follow up with the other bug to make repsonce validation return a 500 | |
| 14:06:28 | gibi | I will take a look on that bug too yes | |
| 14:12:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make functional-py313-threading voting https://review.opendev.org/c/openstack/nova/+/997216 | |
| 14:13:29 | gibi | sambork: am I correct that this is still valid as you only fixed something in vncproxy especially? https://bugs.launchpad.net/nova/+bug/2151537 | |
| 14:16:27 | sambork | gibi I think so because my fix was only in proxies | |
| 14:17:23 | sambork | but I can take a look and apply similar fix if it's applies also to this issue | |
| 14:17:58 | gibi | sambork: so far I only know it is a pickling issue but not more | |
| 14:18:33 | gibi | we don't need to rush, if you have time you can take it I'm not actively working on it. I just did a quick scrub of eventlet-removal bugs as some was outdated and I noticed this | |
| 14:18:48 | sambork | ack! | |
| 15:16:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stabilize test_create_images_negative_invalid_state https://review.opendev.org/c/openstack/nova/+/997222 | |
| 15:22:29 | opendevreview | Merged openstack/nova stable/2026.1: Make QEMU_IMG_LIMITS process limits configurable https://review.opendev.org/c/openstack/nova/+/997027 | |
| 17:39:00 | opendevreview | Mike Lowe proposed openstack/nova stable/2025.1: libvirt: Fix false mem-encryption/UEFI conflict with cpu_mode=custom https://review.opendev.org/c/openstack/nova/+/997258 | |
| 17:42:54 | opendevreview | Mike Lowe proposed openstack/nova master: libvirt: Fix false mem-encryption/UEFI conflict with cpu_mode=custom https://review.opendev.org/c/openstack/nova/+/997259 | |
| 18:14:07 | gmaan | gibi: sean-k-mooney lgtm, +w | |
| 18:20:12 | sean-k-mooney | gmaan: you may also be intrested in https://review.opendev.org/c/openstack/nova/+/971153/2 and the fix https://review.opendev.org/c/openstack/nova/+/946223/6 | |
| 18:20:36 | sean-k-mooney | there is a window where invoking instnace actions can reulst in a 500 before the inital server create is complete | |
| 18:21:03 | sean-k-mooney | those repoduce and adress that and call out that precondtion more explcitly | |
| 18:21:26 | gmaan | sean-k-mooney: ack, will check sometime today otherwise tomorrow | |
| 18:21:32 | sean-k-mooney | the repoducer need a littel work so no rush | |
| 18:21:59 | sean-k-mooney | the fix is more or less correct but ya just good to add to yoru queue | |
| 18:23:45 | gmaan | sure | |
| 18:28:59 | opendevreview | Fabian Wiesel proposed openstack/nova master: vmware: optionally combine host+datastore inventory query https://review.opendev.org/c/openstack/nova/+/997283 | |
| 18:34:30 | opendevreview | sean mooney proposed openstack/os-vif master: typing: Adapt to oslo.versionedobjects 3.11 https://review.opendev.org/c/openstack/os-vif/+/997289 | |
| 19:51:57 | opendevreview | sean mooney proposed openstack/os-vif master: typing: Adapt to oslo.versionedobjects 3.11 https://review.opendev.org/c/openstack/os-vif/+/997289 | |
| 19:51:58 | opendevreview | sean mooney proposed openstack/os-vif master: typing: Define supported OVS VIF types https://review.opendev.org/c/openstack/os-vif/+/997296 | |
| 19:51:59 | opendevreview | sean mooney proposed openstack/os-vif master: ovs: Preserve versioned field compatibility https://review.opendev.org/c/openstack/os-vif/+/997297 | |
| #openstack-nova - 2026-07-15 | |||
| 06:58:34 | opendevreview | Rodolfo Alonso proposed openstack/os-vif master: ovs: Pass ``multi_queue`` inside ``ifr`` dict for tuntap devices https://review.opendev.org/c/openstack/os-vif/+/995933 | |