Earlier  
Posted Nick Remark
#openstack-nova - 2026-07-09
13:18:38 gibi if we cannot show the attachment then I guess we cannot delete it either
13:18:57 gibi i.e. the user cannot show the attachment as we will return 404
13:19:05 gibi hm
13:19:39 gibi but deleting an attachment only needs the volume_id not the attachement_id
13:19:46 gibi then the user can delete a half baked attachemtn
13:19:51 gibi the it is OK
13:20:05 gibi I can return 404 in show until the attachment_id is None
14:26:49 opendevreview Balazs Gibizer proposed openstack/nova master: HACK:Speed up functional test in threading mode https://review.opendev.org/c/openstack/nova/+/996500
14:34:58 opendevreview Merged openstack/nova stable/2025.2: Fix mutating global config in websocket proxy https://review.opendev.org/c/openstack/nova/+/995957
14:59:51 sean-k-mooney gibi: melwitt do we want to proceed with https://review.opendev.org/c/openstack/nova/+/969538 for now and we can loop back to adress_space vs rss vs both later?
15:02:10 sean-k-mooney i am not sure i have the capsity to track that and rather then forget about it i think im ok to upgrade to +2w if ye are both happy with the current appoch
15:11:55 gibi lets land it and get back to it later if needed
16:01:37 melwitt thanks gibi and sean-k-mooney, if you prefer rss I can quickly change it to that, I am good either way
16:05:53 sean-k-mooney melwitt: while i do in general i dont know htat i want to have to try and validate that does not break anythign else. it shoudl not but lets leave it for a follow up
16:06:19 melwitt sean-k-mooney: yeah that's kinda where I was at too. thanks
16:07:22 sean-k-mooney cool noted in the review +2w
16:08:41 melwitt super thanks :)
16:10:17 sean-k-mooney one thing to note is this test is not failign because of debian 12 and now 13
16:11:07 sean-k-mooney so unless we try this on ubuntu 24.04 we wont know if its fully "fixed" i.e. if tweadkin the config option in the ci job is enough
16:16:16 melwitt yes that is true
16:17:52 melwitt IIRC the error was pretty clear it had hit the process limit, that combined with how ironic and cinder also have to configure it made me reasonably confident this would work
16:18:32 sean-k-mooney it shoudl but the defautl value might need to be higher, thats why i mentioned the job config. so one thing that might be interesting to try is how does ubuntu 26.04 and ceph intereact
16:19:00 sean-k-mooney although since debian 13 is fine
16:19:08 sean-k-mooney i think 26.04 will work as well
16:19:11 melwitt yeah, it was just the encryption overhead makes a 1G image slightly larger than 1G so the failure makes sense
16:32:14 opendevreview Ashish Gupta proposed openstack/placement master: tests: Support file-backed SQLite URL in placement fixtures https://review.opendev.org/c/openstack/placement/+/993106
16:59:48 gouthamr melwitt: bauzas gibi: could you folks review this OSSN for me: https://review.opendev.org/c/openstack/security-doc/+/996187
17:11:01 melwitt gouthamr: done
17:11:20 gouthamr thank you melwitt!
17:11:29 gmaan gibi: sean-k-mooney: on volume attachment id as None, agree on fixing the API and not schema. if atachment_id is not available we cannot guarantee that attachment is done in cinder side or not so returning 404 make sense .
17:13:33 gmaan gibi: sean-k-mooney now I am wondering that we used to return 200 before schema restriction which converted it to 400. now if I consider case where schema restriction is not enabled (actual production env) when by fixing this bug we will be converting 200 to 404 so we need microversion bump.
17:13:58 gmaan even tough it is bug fix, but need to take care of interoperability with version bump
17:14:50 sean-k-mooney gmaan: well if the attchment id is not avaibel the attchment is defnitly not don in nova yet
17:15:14 sean-k-mooney so regardless of cidner we have not compelted the attachment
17:15:30 sean-k-mooney so a 404 until that is fully compelt makes sense i think
17:17:04 sean-k-mooney the 200->404 change is worht consdiering but i agree that it should not need a microverion
17:19:04 gmaan think about users who used to call this API to monitor if attachment is ready until attachment_id is not None they will be broken from 200 to 404 so IMO it definitely need microversion
17:19:34 gmaan like server show to keep calling until server is active or ip addresses are pupulated in that
17:24:37 sean-k-mooney gmaan: right so that is alreayd broken
17:24:52 sean-k-mooney becuase it will be listed there before the attchment in nova is completed
17:25:08 sean-k-mooney gmaan: the only way to do that and not ahve a race today is via server show
17:26:45 sean-k-mooney gmaan: becasue of https://bugs.launchpad.net/nova/+bug/2058928
17:28:33 gmaan yes, that action finish time could be helpful
17:29:41 sean-k-mooney the api gibi is trying to fix just tell you that we have complete attachign the device in cinder but not to the vm or nova when the id is populated
17:30:22 sean-k-mooney tehre are actuly 2 more step to completing the volume attachment on the nova side although populating the attachment id in the bdms is near the end
20:49:19 opendevreview Merged openstack/nova master: Make QEMU_IMG_LIMITS process limits configurable https://review.opendev.org/c/openstack/nova/+/969538
21:09:42 opendevreview Merged openstack/nova master: tests: file-backed SQLite with WAL in threading mode for Database and CellDatabases Fixtures https://review.opendev.org/c/openstack/nova/+/988583
#openstack-nova - 2026-07-10
04:01:22 opendevreview Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299
04:03:40 opendevreview Ghanshyam Maan proposed openstack/nova master: Call manager graceful_shutdown while RPC server waits https://review.opendev.org/c/openstack/nova/+/996583
05:10:53 opendevreview Fabian Wiesel proposed openstack/nova master: vmware: Read iso file in binary mode during upload https://review.opendev.org/c/openstack/nova/+/996738
09:06:24 gibi gmaan: sean-k-mooney: I responed in the bug about the attachment show API issue
09:06:59 gibi A proper client should handle 404 already while the volume is being attached as nova returns 404 when BDM is nto yet exists.
09:07:16 sean-k-mooney yes it should
09:07:24 gibi so returning 404 while BDM exists but without attachment_id is backward compatible from that client perspectvie
09:07:54 sean-k-mooney i dont think a 200 -> 404 shoudl require a microversion as it should alreay be getting the 404 before while we are attaching and retrying
09:08:10 sean-k-mooney so i agree that is backwards compatiable
09:08:39 sean-k-mooney but also tahat api cant be used to know fi the volume is actully attached today
09:09:07 sean-k-mooney although it will get closer to working for that with your proposed chagne
09:09:48 gibi yeah just because we have attachment_id it does not tell us if the compute finished attaching the volume to the VM
09:10:01 gibi the versioned notification is better in this regard as that is sent from the compute side
09:10:02 sean-k-mooney if i recall the oder correctly , the volume gets attached in cinder, then we udate the bdms and finally attach it to the vm
09:10:07 sean-k-mooney the last 2 might be reversed
09:10:07 gibi yepp
09:10:36 sean-k-mooney so the way to do this reliabley todya is server show and look at the attachments there
09:10:39 gibi the attachment_id is added to the BDM by the conductor before the compute attaches the volume to the instance
09:10:56 sean-k-mooney ack ok then i did remember the order
09:58:56 opendevreview Balazs Gibizer proposed openstack/nova master: Do not try to return empty attachment_id from API https://review.opendev.org/c/openstack/nova/+/996757
09:58:56 opendevreview Balazs Gibizer proposed openstack/nova master: Reproducer for https://bugs.launchpad.net/nova/+bug/2160224 https://review.opendev.org/c/openstack/nova/+/996756
10:02:19 gibi sean-k-mooney: gmaan: ^^ this might help dicussing the situation further
10:06:21 sean-k-mooney gibi: woudl you agree that the bug shoudl be set to low an asgined to you give your working on it and respocen schema validation is not only off by defualt but docuemnted as never to be used in production only for testing?
11:02:56 gibi sean-k-mooney: sure
11:04:47 gibi I'm filing a separate bug to switch response schema validation errors to HTTP500 with a clear error message
11:07:42 sean-k-mooney ack just an fyi ill be finishing up in the next 2 hours so i will be unlike to be around when gmaan comes onlien but i sumemrised my toughts in the bug
11:07:52 gibi https://bugs.launchpad.net/nova/+bug/2160303
11:08:01 gibi sean-k-mooney: no worries
11:08:09 gibi and thanks for the response in the bug
11:09:43 sean-k-mooney in terems of the 404 responce it might evenually make sesen to only return the attahcment if the atttachment is fully compelte form a nova point of view but that out of scope fo the current bugs you filed
11:10:23 sean-k-mooney well or have a better way
11:10:30 sean-k-mooney to knwo if the attach is done
11:10:44 gibi yeah
11:10:45 sean-k-mooney which is actully tracked seperatly
11:11:17 sean-k-mooney https://bugs.launchpad.net/nova/+bug/2058928 and or hte spec rajesh started
11:11:44 sean-k-mooney ultimplate you shoudl be able to pool the intatnce actin event for completion
11:13:15 sean-k-mooney gibi: switching topics for a sec im going to see if i can quickly update the futureist patches to adress your feedback and split the fix and feature
11:13:34 sean-k-mooney gibi: do you want to proceed with the quick workaround in nova in the interim?
11:14:27 gibi sean-k-mooney: we can wait with the hack in nova as that is top of the functional test with threading series anyhow
11:14:54 sean-k-mooney well i was going to suggest rebasign to master
11:15:03 sean-k-mooney if we didnt want to wait to save some ci time
11:15:55 sean-k-mooney but ok ill see if i can get the actual fix tidied up quickly
13:14:32 opendevreview Balazs Gibizer proposed openstack/nova master: Check service_ref before destroy https://review.opendev.org/c/openstack/nova/+/996793
13:14:32 opendevreview Balazs Gibizer proposed openstack/nova master: HACK:Speed up functional test in threading mode https://review.opendev.org/c/openstack/nova/+/996500
14:10:38 opendevreview Merged openstack/placement master: tests: Support file-backed SQLite URL in placement fixtures https://review.opendev.org/c/openstack/placement/+/993106
14:21:20 sean-k-mooney gibi: sorry i just didnt get as far with the futurist work as i hoped for today. im going to wrap up shortly but ill take a look at it again on monday
14:21:55 gibi sean-k-mooney: no worries. Have a nice weekend
14:23:44 sean-k-mooney i might push what i have before i leave i need to pack a bag and trun on the ac in my car to cool it down or ill melt when i get into it
14:24:27 sean-k-mooney i plugged it in to charge ealer and the temperture in the car was 35c which is what i get for parking it facing uphil and south on a nice day
14:27:42 sean-k-mooney oh i was under estermating it say its at 44c right now. i am happy it also has a remote ac feature
15:32:48 opendevreview Mike Lowe proposed openstack/nova master: Fix PCI cleanup when a move claim is aborted https://review.opendev.org/c/openstack/nova/+/996822
17:57:15 opendevreview Merged openstack/nova master: tests: use file-backed Placement SQLite in functional threading https://review.opendev.org/c/openstack/nova/+/992581
19:47:29 gmaan gibi: sean-k-mooney[m] stuck on other things downstream but I will check and reply on bug/gerrit. most probably today otherwise Monday

Earlier   Later