| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-07-07 | |||
| 12:53:55 | tkajinam | sean-k-mooney, the question might be equivalent to whether you'll backport your fix to stable branches. | |
| 12:54:21 | tkajinam | the whole sev-snp series, I mean | |
| 12:55:45 | sean-k-mooney | am either that or put your new check in init_host in the driver and i can fix it in mine | |
| 12:55:58 | sean-k-mooney | but im hoping to backport my fixes so both oders wil work | |
| 12:56:56 | sean-k-mooney | tkajinam: so this function call in driver.init_host in the libvirt driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L924-L926 | |
| 12:57:15 | sean-k-mooney | is pulling all the instnaces form the db and backfilling the default for the image properties | |
| 12:57:44 | sean-k-mooney | so you could make https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L980-L997 return the list of instances | |
| 12:57:50 | sean-k-mooney | and hten use that ot do your check | |
| 12:57:59 | sean-k-mooney | but it woudl be cleaner ot rebase i think | |
| 12:58:30 | tkajinam | yeah I read your change and I think I now understand how the check should be implemented after that fix. | |
| 12:58:31 | sean-k-mooney | driver.init_host is called before we do the hostname validation and it really shoudl not have been loading the instance form the db like that | |
| 12:59:30 | tkajinam | I agree | |
| 13:03:36 | sean-k-mooney | i guess gibi or bauzas may have a prefernce but without https://github.com/openstack/nova/commit/2714c71d05e8501ddb3a8fc0c36f3406ef974072 those checks in the compute manager for self._validate_pinning_configuration(instances) and self._validate_vtpm_configuration(instances) were lazy loading the image propereis and flavor on every instance for every driver | |
| 13:04:07 | sean-k-mooney | so we need to backprot that at a mimim if we were to backport the sev check | |
| 13:04:32 | sean-k-mooney | but i woudl not like to backprot the sev check until we make it driver specirifc hostetly | |
| 13:04:54 | sean-k-mooney | we shoudl not be imposing that pelenty on the ironic driver ectra when it does not apply | |
| 13:05:41 | sean-k-mooney | that the whole premise behind https://review.opendev.org/c/openstack/nova/+/990552 | |
| 13:11:57 | bauzas | I don't honestly have a preference :) | |
| 14:43:41 | opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | |
| 14:43:41 | opendevreview | Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 14:47:55 | opendevreview | Joan Gilabert proposed openstack/nova master: Rename cyborg-tempest to cyborg-tempest-py3 https://review.opendev.org/c/openstack/nova/+/996297 | |
| 14:55:15 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299 | |
| 15:46:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | |
| 16:02:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | |
| 16:02:50 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | |
| 16:03:00 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | |
| 16:03:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | |
| 16:03:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 16:11:34 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | |
| 16:11:41 | opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | |
| 16:16:49 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 16:31:25 | melwitt | gmaan: dunno if you have seen this but it seems like unit test test_cold_migration_dest_compute_graceful_shutdown has been failing intermittently https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dc2/openstack/dc227da7383b4f62ab0731d251d86e2f/testr_results.html | |
| 16:32:07 | melwitt | https://opensearch.logs.openstack.org/_dashboards/app/data-explorer/discover?security_tenant=global#?_a=(discover:(columns:!(build_status,message,build_change,build_name),isDirty:!f,sort:!()),metadata:(indexPattern:'94869730-aea8-11ec-9e6a-83741af3fdcd',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))&_q=(filters:!(),query:(language:kuery,query:'message:%22in%20test_cold_migration_dest_compute | |
| 16:32:08 | melwitt | _graceful_shutdown%22')) | |
| 16:32:22 | melwitt | bah, sorry. link looked less long in my text box | |
| 16:43:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | |
| 16:45:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | |
| 16:45:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: compute: Validate SEV/SEV-ES support at start up https://review.opendev.org/c/openstack/nova/+/994342 | |
| 16:45:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: Accept hw_firmware_stateless=True for BIOS firmware type https://review.opendev.org/c/openstack/nova/+/995835 | |
| 16:45:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | |
| 16:45:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | |
| 16:45:42 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | |
| 16:45:56 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | |
| 16:46:04 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | |
| 16:46:24 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 16:46:33 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | |
| 16:46:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | |
| 16:46:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 16:47:02 | opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | |
| 17:16:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 17:19:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: ci: Remove GLANCE_STANDALONE https://review.opendev.org/c/openstack/nova/+/996322 | |
| 17:23:58 | gmaan | melwitt: yeah, sean-k-mooney also reported the same yesterday, I will check it today. it seems some timing issue | |
| 17:24:26 | sean-k-mooney | of hte graceful shutdown test? | |
| 17:25:11 | sean-k-mooney | melwitt: i use https://tinyurl.com/ for those urls | |
| 17:26:10 | gmaan | sean-k-mooney: yeah | |
| 17:26:25 | sean-k-mooney | https://tinyurl.com/2ver5rr6 | |
| 17:26:42 | sean-k-mooney | actully not hta tquey is broken | |
| 17:26:50 | gmaan | did not get time yesterday but I am on it | |
| 17:27:56 | melwitt | yeah it got cut off https://tinyurl.com/46cyby7t | |
| 17:30:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Accept hw_firmware_stateless=True for BIOS firmware type https://review.opendev.org/c/openstack/nova/+/995835 | |
| 17:30:51 | opendevreview | Takashi Kajinami proposed openstack/nova master: compute: Validate SEV/SEV-ES support at start up https://review.opendev.org/c/openstack/nova/+/994342 | |
| 17:31:02 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | |
| 17:31:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | |
| 17:31:24 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | |
| 17:31:33 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | |
| 17:31:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | |
| 17:31:52 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 17:32:01 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | |
| 17:32:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | |
| 17:32:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 17:34:44 | sean-k-mooney | ok ya so its happenign fairly consitently | |
| 18:05:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | |
| 18:05:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | |
| 18:05:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | |
| 18:05:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 18:05:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | |
| 18:05:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | |
| 18:05:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | |
| 18:05:15 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 18:34:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | |
| 18:34:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | |
| 18:34:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | |
| 18:34:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | |
| 18:34:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 18:34:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | |
| 18:34:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | |
| 18:34:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | |
| 18:34:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | |
| 18:48:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | |
| 18:48:11 | gmaan | sambork: gibi: after seeing openstack-tox-py313 and openstack-tox-py314 unit test jobs failing one of my test in eventlet mode (which i need to fix to handle both mode), i realized should not be run all our default unit tests jobs openstack-tox-py313, openstack-tox-py314 in threading mode and convert nova-tox-py313-threading->nova-tox-py313-eventlet ? | |
| 18:48:36 | gmaan | mainly openstack-tox-py314 or any new higher python versions testing can be done in threading mode | |
| 19:02:46 | sean-k-mooney | well we will next cycle right | |
| 19:03:03 | sean-k-mooney | the goal is to default to threaded mdoe this cycle | |
| 19:03:48 | sean-k-mooney | but form next cycel we defintly should | |
| 19:04:10 | sean-k-mooney | for this cycle if we now have everything defaulting to threaded | |
| 19:04:34 | sean-k-mooney | we could update the job/tox config i guess | |
| 19:05:03 | sean-k-mooney | gmaan: we are technaly supproting eventlet on 3.14 | |
| 19:05:20 | sean-k-mooney | so the eventlet supprot is more tied to the nova version then the python version | |
| 19:06:01 | gmaan | yeah, i mean we can run 3.14 version on eventlet but rest all jobs running on threading mode | |
| 19:06:03 | sean-k-mooney | although i dont know if 3.15 will ever be suproted by eventlet so that might eb threaded only as a side effect | |