Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-06-12
16:28:50 opendevreview melanie witt proposed openstack/nova master: Fix cover env HTML testr results missing unit tests https://review.opendev.org/c/openstack/nova/+/993151
16:28:56 sean-k-mooney hum so thinkign abou tthis a bit
16:29:28 sean-k-mooney your sill mockign all calls to open clsoe and unlink
16:30:34 sean-k-mooney which we need to do
16:31:08 sean-k-mooney but i one der if we shoudl make the call to open and unlink more robust as well
16:32:04 melwitt what do you have in mind?
16:32:05 sean-k-mooney on the ohter hand i have doen over 20 complet runs locally without any issue
16:32:37 sean-k-mooney removing the once assert_called_once_with
16:32:51 sean-k-mooney and juse using assert_called_with
16:33:07 melwitt yeah. I think the specific asserts are pretty much avoiding issues but maybe the mock_open.assert_called_once_with('/swap', os.O_CREAT | os.O_EXCL | os.O_WRONLY) could technically run into trouble somehow
16:33:49 sean-k-mooney well all 3 could use assert_called_with without really losing much in terms of coverage
16:34:22 melwitt true
16:35:13 sean-k-mooney i know normally we like to assert the call count as well but in this case i dont know if it get us much
16:35:30 melwitt yeah, I hear ya
16:35:36 sean-k-mooney if ci say no again we can try that
16:35:56 sean-k-mooney if it has not failed locally by the tim it report back i think im ok to leave it as is and proceed
16:36:37 melwitt yeah, same. I have a loop going too and if it's also still going then extra good haha
16:36:55 melwitt --until-failure is nice, I forgot about that
16:38:27 sean-k-mooney this is basiclly all i use if for but ya i think gibi first told me about it many moons ago
16:41:17 opendevreview Merged openstack/os-vif master: Make ``PyPyroute2._lookup_interface`` private https://review.opendev.org/c/openstack/os-vif/+/991292
16:46:25 opendevreview Balazs Gibizer proposed openstack/nova master: Avoid stacktrace at CLI exit https://review.opendev.org/c/openstack/nova/+/993153
16:52:50 gmaan dansmith: so you want to inherit it from ServersUpdateSampleJsonTest instead of ServersSampleBase, same way other update serve rmicroversion tests did https://review.opendev.org/c/openstack/nova/+/990682/comment/7a022078_05092941/
16:53:03 gmaan I also missed to check those update test
16:53:28 gmaan that way, you do not need to create the GET server samples in new microvesion dir
17:02:08 dansmith gmaan: ah meant to
17:02:53 dansmith I thought that still required the get samples though which is why I left them in there,
17:03:24 dansmith but perhaps I missed an editor save or something, saw it still requiring the get samples, put those back, and then never committed the save
17:05:07 gmaan ohk, this file is getting huge and difficult to read. I think I should split it.
17:06:14 dansmith yeah, it is for sure
17:09:28 opendevreview Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469
17:09:28 opendevreview Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682
17:09:46 dansmith okay sorry about that.. I had a successful run in my terminal buffer from when I removed everything but the update samples
17:10:36 dansmith then when I was rebasing to apply the change to the first commit I must have lost the inheritance part and then running made me add the get/list things back in so I thought I had stale samples on disk last time or something
17:11:11 gmaan k
17:11:41 dansmith trying to get claude to "help" with this stuff is maybe not the best plan past initial generation.. like having a pair programmer messing with things on disk while you're trying to clean up :)
17:12:25 gmaan yeah, i think you should change the tag also now as you updated it manually https://review.opendev.org/c/openstack/nova/+/990682/comment/9a9abe22_4f0d2b93/
17:13:00 dansmith gmaan: meh
17:13:19 dansmith it's still mostly generated and I think the tag is still okay
17:13:31 dansmith Generated-By: claude, Fixed-By: human meat bag
17:14:08 melwitt claude has been betraying me a lot lately
17:14:56 dansmith same
17:15:32 dansmith there's betrayal and there's also the aspect of just being a third thing competing for context... you have on-disk state, you have in-git state, you have the current state of your editor, and then whatever claude is doing
17:15:36 melwitt in my commit message tag I also include the claude code version bc I think it's interesting and it's been updated/upgraded at least twice since I stated this morning
17:15:45 melwitt *started
17:16:28 melwitt so I'm like 🙏 they are fixing things
17:16:41 gmaan it is difficult to say if Generated-By is still ok when we modified the generated code but does not matter much anyways
17:16:58 melwitt Clauded-By
17:18:21 sean-k-mooney well i nomrally update to assisted-by once i have reworked some
17:18:32 sean-k-mooney but generate by does not have to mean entrilly llm output
17:18:52 melwitt I never use Generated-By, problem solved
17:19:06 melwitt #efficiency
17:19:28 sean-k-mooney ya for many things is v 2 or 3 before i push for review the first time anyway
17:22:31 sean-k-mooney as an aside how ould folk feel about add a funtional py 3.14 job, myign the unit test job voting and maybe moving the coverage job to 3.14 as well
17:23:13 sean-k-mooney the reason i ask is openstack-tox-py314 has been passing stablty for a good few weeks
17:23:28 sean-k-mooney and if the funciotnal job also passes we coudl mvoe coverge to 3.14
17:23:51 sean-k-mooney and look into the alternitve backend that stephen mentioned that speed it up
17:24:59 melwitt on coverage, I asked claude about it again today and it said tl;dr that you can only get the speedup without eventlet
17:25:18 melwitt which I guess we can't do bc coverage runs functional now too
17:25:59 melwitt "There it is — concurrency = ["eventlet"] in pyproject.toml forces coverage.py to use sys.settrace instead of sys.monitoring, even on Python 3.12+. That's likely the biggest performance hit."
17:26:26 sean-k-mooney hum ok well we are getting closer on functionla coverage in threading mode
17:26:35 melwitt *we can't switch coverage to native threading bc we don't have the func tests sorted out yet
17:26:37 sean-k-mooney so maybe we can just run it in threading mode in a bit
17:26:45 melwitt yeah
17:28:09 sean-k-mooney i might put up a patch thetn jsut for makeing the py314 unit test voting and addign a non voting functionl 3.14 job to see how that goes
17:28:16 melwitt I had tried a patch to help with that and then lots of unrelated stuff happened and I dropped the ball
17:47:44 melwitt gmaan: fyi I noticed you got some questions on the graceful shutdown func tests https://review.opendev.org/c/openstack/nova/+/991743 so I cc'ed myself when you have got a chance to reply
17:49:46 melwitt sean-k-mooney: I just approved https://review.opendev.org/c/openstack/nova/+/993109 but then I wondered, shouldn't that change go in whitebox not nova?
17:50:13 sean-k-mooney whitebox is not branched
17:50:31 sean-k-mooney so normally in whitebox we do the opisce of tempet
17:50:44 sean-k-mooney we disabel new tests and make them opt in
17:50:59 melwitt ohhh ok
17:51:01 sean-k-mooney tempest enables them on master and then uses stable patchs
17:51:12 sean-k-mooney so gman wanted to go the tempest way which is fine
17:51:34 sean-k-mooney we did it the other way in whitebox historically because our downstream used ot direcly use master
17:51:58 sean-k-mooney so we coudl not assume the only user of whitebox was our first praty zuul
17:53:16 sean-k-mooney we also need to fix or disble the hugepage tests to get the stable branches green again it seams
17:53:20 melwitt yeah
17:55:07 sean-k-mooney im not entirly sure why
17:55:13 sean-k-mooney because i dont see those test runing on master
17:56:04 sean-k-mooney this is not a firday after noone problem
17:56:25 sean-k-mooney we can fix the rest later
17:57:40 melwitt yeah I am a bit lost tbh :)
17:57:55 sean-k-mooney we were not runing stable jobs on the plugin repo
17:58:01 melwitt you're saying from the periodic whitebox job you don't see hugepages test running
17:58:04 sean-k-mooney so we didnt notice when we broke stable
17:58:37 sean-k-mooney there is a seprate whitebox-devstack-multinode-hugepages job
17:59:11 sean-k-mooney https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_29c/openstack/29c8adb8349b437bb53993094287774d/testr_results.html
17:59:24 sean-k-mooney that was https://zuul.opendev.org/t/openstack/build/29c8adb8349b437bb53993094287774d
17:59:27 melwitt gibi: if you dare https://review.opendev.org/c/openstack/nova/+/993059 (had to change fix due to first fix not working). sean and I have been running all unit tests in a loop for > 1 hour and no fails yet so we are hoping this is stable now
17:59:43 melwitt oh, right
18:00:10 sean-k-mooney but that is not the hugepages job
18:00:19 sean-k-mooney so im not entirly sure why those ran
18:00:39 sean-k-mooney given it has tempest_exclude_regex:"^whitebox_tempest_plugin\.api\.compute\.test_hugepages"
18:00:42 melwitt _magic_
18:00:53 sean-k-mooney oh
18:01:03 sean-k-mooney ok no so gibie broke it in the previosu platch
18:01:11 sean-k-mooney when he added tempest_exclude_regex: (test_vtpm_live_migration_secret_security_host)
18:01:18 sean-k-mooney it overrote the hugepage exclude
18:01:24 sean-k-mooney so we need to exlude both
18:01:27 melwitt wait what

Earlier   Later