| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-06-12 | |||
| 13:22:39 | sean-k-mooney | but i didnt have a change to look at it beofre you and gmaan had already found it | |
| 13:23:23 | sean-k-mooney | @mock.patch('nova.virt.libvirt.driver.os.open', return_value=99) | |
| 13:23:23 | melwitt | yeah I wonder, will the gerrit Closes-Bug automation still work if I close the one I opened as a duplicate | |
| 13:23:45 | sean-k-mooney | ya so this is oen of the resaon i said mocking open is tricky | |
| 13:24:08 | gibi | melwitt: thanks for fixing that flakyness | |
| 13:24:31 | melwitt | sorry for introducing it /o\ | |
| 13:25:21 | gibi | nah, that was all of us reviewing and accepting it ;) | |
| 13:25:47 | sean-k-mooney | melwitt: both of those look fine to me so +w | |
| 13:26:33 | melwitt | thanks ! | |
| 13:31:18 | melwitt | sorting the gate-failure bug tag by most recent, I'm reminded I had proposed this other fix for a ceph memory allocation error https://review.opendev.org/c/openstack/nova/+/969538 | |
| 13:48:16 | opendevreview | Ashish Gupta proposed openstack/nova master: tests: use file-backed Placement SQLite in functional threading https://review.opendev.org/c/openstack/nova/+/992581 | |
| 13:48:17 | opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | |
| 13:48:18 | opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | |
| 13:48:48 | jgilaber | melwitt, Hi! I've been discussing with sean-k-mooney about this patch https://review.opendev.org/c/openstack/nova/+/922140 and would like your inpute as well | |
| 13:49:05 | jgilaber | I'm working on getting the whitebox vgpu tests running with mtty | |
| 13:50:22 | sean-k-mooney | jgilaber: melwitt so basiclly my comemnt was since nova-next is getting quite long, and since nova-vtpm is already using whitebox | |
| 13:50:31 | sean-k-mooney | why not rename that to say nova-whitebox | |
| 13:50:42 | sean-k-mooney | and just add the vgpu/mtty testing to that | |
| 13:51:22 | sean-k-mooney | then we have 1 whitebox job that we can selectivly enabel test in like the recent iothread ones gibi is workign on | |
| 13:52:37 | sean-k-mooney | we have a weakly perodic for whitebox which ahs been pretty stabel so i think we could effectily promote it to check and or remove it rom the perodic line too | |
| 13:52:38 | melwitt | yeah I think that sounds reasonable | |
| 13:53:24 | melwitt | nova-vtpm is a good candidate for rename + expand since it's very small currently | |
| 13:53:32 | sean-k-mooney | jgilaber: out of interst did the boot issues go away when you swap form the 64mb flavor to the standard sized ones? | |
| 13:54:11 | sean-k-mooney | melwitt: i have not had time to look but i also wonder what test in nova-next shoudl be in say the integrated comptue jobs or others | |
| 13:54:34 | sean-k-mooney | melwitt: i.e. is there any clean up on the options or thigns that are now default that are coverd elsewhere | |
| 13:55:01 | jgilaber | sean-k-mooney, the ssh seems to work fine after doubling the memory | |
| 13:55:07 | melwitt | sean-k-mooney: yeah, it's likely time for an audit there | |
| 13:55:28 | sean-k-mooney | i noticed it average runtim was over 2.5 hours | |
| 13:55:40 | sean-k-mooney | most of the other are 1-2 | |
| 13:55:57 | sean-k-mooney | so if we could get it below 2 that would be nice | |
| 13:56:25 | sean-k-mooney | given zuul reports only after the slowest job | |
| 14:14:31 | opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | |
| 14:14:31 | opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | |
| 14:15:03 | dansmith | melwitt: I had opened gmaan's comment when he made it and didn't see yours about the update tests, so this moves that down ^ | |
| 14:15:30 | dansmith | as noted it's a bit annoying that they're named that because I had missed them in my grepping of the file but alas | |
| 14:19:56 | opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty/mdpy support for testing fake mdevs https://review.opendev.org/c/openstack/nova/+/898100 | |
| 14:19:56 | opendevreview | Joan Gilabert proposed openstack/nova master: move compile earlier https://review.opendev.org/c/openstack/nova/+/950516 | |
| 14:19:57 | opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | |
| 14:21:13 | melwitt | dansmith: oh yeah I didn't notice it at first either and then was like wait a minute ... cool | |
| 14:47:32 | opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | |
| 14:53:46 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Propose assisted-volume-extend API https://review.opendev.org/c/openstack/nova-specs/+/949504 | |
| 15:17:57 | opendevreview | Joan Gilabert proposed openstack/nova master: Rename vtpm job and add mtty support for vpgu test https://review.opendev.org/c/openstack/nova/+/922140 | |
| 15:24:41 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron Ports https://review.opendev.org/c/openstack/nova/+/969298 | |
| 15:25:02 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron security-groups https://review.opendev.org/c/openstack/nova/+/981141 | |
| 15:44:13 | opendevreview | Joan Gilabert proposed openstack/nova master: Rename vtpm job and add mtty support for vpgu test https://review.opendev.org/c/openstack/nova/+/922140 | |
| 15:49:50 | opendevreview | melanie witt proposed openstack/nova master: Fix intermittent test_refresh_nfs_swap_cache_stale failure https://review.opendev.org/c/openstack/nova/+/993059 | |
| 15:54:11 | sean-k-mooney | sambork: so just enabling threaded mode didnt fix the novnc test on 3.14 with ubuntu 26.04 but https://review.opendev.org/c/openstack/nova/+/987815 did | |
| 15:54:26 | sean-k-mooney | so restoring fork seams to work | |
| 15:55:07 | sean-k-mooney | with threaded mode it fixed 1 of the these but the other got the token expired thing you were seeing on ubuntu 24.04 | |
| 15:55:46 | sean-k-mooney | so for now i think doing multiprocessing.set_start_method('fork', force=True) uncondtionaly regarless fo eventlet or threaidng is the right move | |
| 15:56:05 | sean-k-mooney | until we fiture out how to make novnc without that in general | |
| 16:00:21 | melwitt | sean-k-mooney: had to change approach on ^ due to it still failing bc the scoping of the mock did not actually help bc they apparently all resolve to the same place in the end | |
| 16:00:40 | sean-k-mooney | yes they do | |
| 16:00:41 | melwitt | I'll be rechecking it some times | |
| 16:00:49 | sean-k-mooney | did you swap to useign mock_open | |
| 16:01:43 | melwitt | no, used list.count() to assert the specified fd was called close with once. a claude idea that _seems_ ok afaict | |
| 16:01:49 | sean-k-mooney | yep just saw | |
| 16:01:55 | melwitt | to just ignore the rest. yeah | |
| 16:02:08 | sean-k-mooney | ill pull that patch locally and run it in a loop on one of my systems for like 30 mins | |
| 16:02:53 | melwitt | the shame deepens | |
| 16:03:05 | melwitt | I'll run a loop | |
| 16:03:13 | sean-k-mooney | --until-failure | |
| 16:03:43 | melwitt | although I guess I need to run all tests that's key to the issue | |
| 16:03:47 | sean-k-mooney | ill let it run on my mac mini for a while that really fast at this | |
| 16:04:16 | sean-k-mooney | yep but i have like 3 systems taht can do that pretty quickly | |
| 16:04:53 | melwitt | :) sean-k-mooney's data center | |
| 16:05:23 | melwitt | I'm lucky it failed in the gate. this sucks haha | |
| 16:05:30 | sean-k-mooney | my home sever may be 10+ years old but if you trho 48 cores at nova unit tests it still flies | |
| 16:06:28 | melwitt | 48 o_O | |
| 16:06:31 | opendevreview | Merged openstack/nova master: Add irrelevant-files for the graceful shutdown jobs https://review.opendev.org/c/openstack/nova/+/993063 | |
| 16:06:31 | sean-k-mooney | my m4 base spec mac mini almost but not quite catchs my server | |
| 16:06:49 | melwitt | my 10+ year old home server only has 12 and it finally got too slow | |
| 16:07:15 | sean-k-mooney | techinaly it 2 14 core cpus so 24 cores and 48 threads | |
| 16:08:37 | sean-k-mooney | https://paste.opendev.org/show/bzdwOUsGPvkQPl8HU6Rz/ | |
| 16:09:10 | melwitt | wow | |
| 16:09:59 | sean-k-mooney | oh i was wrong it 2 12 cores | |
| 16:10:18 | sean-k-mooney | but that still 24 cors and 48 threads im just bad at math | |
| 16:28:50 | opendevreview | melanie witt proposed openstack/nova master: Fix cover env HTML testr results missing unit tests https://review.opendev.org/c/openstack/nova/+/993151 | |
| 16:28:56 | sean-k-mooney | hum so thinkign abou tthis a bit | |
| 16:29:28 | sean-k-mooney | your sill mockign all calls to open clsoe and unlink | |
| 16:30:34 | sean-k-mooney | which we need to do | |
| 16:31:08 | sean-k-mooney | but i one der if we shoudl make the call to open and unlink more robust as well | |
| 16:32:04 | melwitt | what do you have in mind? | |
| 16:32:05 | sean-k-mooney | on the ohter hand i have doen over 20 complet runs locally without any issue | |
| 16:32:37 | sean-k-mooney | removing the once assert_called_once_with | |
| 16:32:51 | sean-k-mooney | and juse using assert_called_with | |
| 16:33:07 | melwitt | yeah. I think the specific asserts are pretty much avoiding issues but maybe the mock_open.assert_called_once_with('/swap', os.O_CREAT | os.O_EXCL | os.O_WRONLY) could technically run into trouble somehow | |
| 16:33:49 | sean-k-mooney | well all 3 could use assert_called_with without really losing much in terms of coverage | |
| 16:34:22 | melwitt | true | |
| 16:35:13 | sean-k-mooney | i know normally we like to assert the call count as well but in this case i dont know if it get us much | |
| 16:35:30 | melwitt | yeah, I hear ya | |
| 16:35:36 | sean-k-mooney | if ci say no again we can try that | |
| 16:35:56 | sean-k-mooney | if it has not failed locally by the tim it report back i think im ok to leave it as is and proceed | |
| 16:36:37 | melwitt | yeah, same. I have a loop going too and if it's also still going then extra good haha | |
| 16:36:55 | melwitt | --until-failure is nice, I forgot about that | |
| 16:38:27 | sean-k-mooney | this is basiclly all i use if for but ya i think gibi first told me about it many moons ago | |
| 16:41:17 | opendevreview | Merged openstack/os-vif master: Make ``PyPyroute2._lookup_interface`` private https://review.opendev.org/c/openstack/os-vif/+/991292 | |
| 16:46:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid stacktrace at CLI exit https://review.opendev.org/c/openstack/nova/+/993153 | |
| 16:52:50 | gmaan | dansmith: so you want to inherit it from ServersUpdateSampleJsonTest instead of ServersSampleBase, same way other update serve rmicroversion tests did https://review.opendev.org/c/openstack/nova/+/990682/comment/7a022078_05092941/ | |
| 16:53:03 | gmaan | I also missed to check those update test | |