| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-05-19 | |||
| 15:40:01 | opendevreview | Matt Crees proposed openstack/nova master: Add test_update_devices_preserves_vf_network_caps https://review.opendev.org/c/openstack/nova/+/989121 | |
| 16:01:55 | Uggla | melwitt, dansmith if you can have a look at 987704: Fix resize to unpermitted flavors | https://review.opendev.org/c/openstack/nova/+/987704, that should not take long | |
| 16:02:46 | dansmith | ? | |
| 16:08:20 | melwitt | Uggla: it looks like that is merged already? | |
| 16:09:40 | Uggla | melwitt, dansmith oops sory wrong CC here: I mean 988501: Do not log metadata proxy shared secret | https://review.opendev.org/c/openstack/nova/+/988501 | |
| 16:17:05 | melwitt | Uggla: ah ok, sure I will look | |
| 16:24:45 | sean-k-mooney | https://bugs.launchpad.net/nova/+bug/2150094 is a secuirty weakness more then a security vulnerablity | |
| 16:25:07 | sean-k-mooney | but we shoudl avoid logging it in general | |
| 16:26:30 | sean-k-mooney | im not sure that rotaion of the metadata_proxy_shared_secret is strictly require but it does not hurt | |
| 16:52:09 | sean-k-mooney | elodilles: mind addign a unit test for the log message just to assert the secret is not in it. https://review.opendev.org/c/openstack/nova/+/988501 | |
| 17:07:02 | melwitt | sean-k-mooney: thought you might find this interesting -- this is a bug that first appeared in downstream CI intermittently where I found the root cause ... but I figured it was probably too rare to prioritize. then it showed up again recently in a customer case so I proposed a fix for it https://review.opendev.org/c/openstack/nova/+/988547 you might be good to comment on it bc you know a lot about NFS | |
| 17:07:48 | sean-k-mooney | less then you might think and more then i ever wanted | |
| 17:07:59 | sean-k-mooney | but sure i can take a look | |
| 17:08:06 | melwitt | heheh | |
| 17:08:24 | sean-k-mooney | that sound liek a nfs lockign issue | |
| 17:09:22 | sean-k-mooney | melwitt: on enit. @mock.patch('os.open', | |
| 17:09:32 | sean-k-mooney | i belive we have mock open helper | |
| 17:09:42 | sean-k-mooney | because mocking builting like open is a littel od | |
| 17:09:47 | sean-k-mooney | it might be better to use that | |
| 17:10:05 | sean-k-mooney | ill read the rest but just somthign i notced initally | |
| 17:10:11 | melwitt | yeah in debugging the CI issue we put debug printing _everywhere_ in it and were able to confirm a false positive of the exists() call -- returned true when it was not there | |
| 17:10:22 | melwitt | oh gotcha | |
| 17:10:37 | melwitt | thanks, that sounds familiar. I'll go look for it | |
| 17:12:17 | sean-k-mooney | we might have got rid of our helper since mock not does if for you | |
| 17:12:26 | sean-k-mooney | we often do @mock.patch('builtins.open', new_callable=mock.mock_open()) | |
| 17:12:36 | sean-k-mooney | but mocing os.open will probaly work | |
| 17:13:46 | sean-k-mooney | melwitt: i just know that used to be a bit flaky in older version fo python so im alwasy a litte carful of it failing in the gate if we dotn do that correctly | |
| 17:14:16 | melwitt | yeah, it's a good point | |
| 17:17:11 | opendevreview | Maximilian Stinsky proposed openstack/nova master: Remove experimental warning from UnifiedLimitsDriver https://review.opendev.org/c/openstack/nova/+/989102 | |
| 17:17:34 | sean-k-mooney | melwitt: so the fix si to add O_CREAT|O_EXCL | |
| 17:17:55 | sean-k-mooney | to bypass the cache | |
| 17:19:49 | melwitt | that is the idea. I'm not aware if there could be any possible pitfall with that or rather if there is some way that it would not work | |
| 17:22:17 | sean-k-mooney | well the constrati woudl be if one of the open modes was not supproted by a given version of nfs or the kernel | |
| 17:22:29 | sean-k-mooney | i dont think you are usign anyting exotic in this patch | |
| 17:23:23 | opendevreview | Merged openstack/nova master: Reproduce bug/2152697 https://review.opendev.org/c/openstack/nova/+/988769 | |
| 17:23:34 | sean-k-mooney | we did have to do soem O_DIRECT check for a time but apprently that was added in kernel 2.4.10 so we may not need that anymore | |
| 17:24:08 | sean-k-mooney | O_EXCL Ensure that this call creates the file: if this flag is | |
| 17:24:10 | sean-k-mooney | specified in conjunction with O_CREAT, and path already | |
| 17:24:12 | sean-k-mooney | exists, then open() fails with the error EEXIST. | |
| 17:24:23 | sean-k-mooney | ok so that is the behvior we want for the probe | |
| 17:25:04 | sean-k-mooney | On NFS, O_EXCL is supported only when using NFSv3 or later | |
| 17:25:06 | sean-k-mooney | on kernel 2.6 or later. | |
| 17:25:17 | sean-k-mooney | ya i think we are good with those min versions in 2026 | |
| 17:25:53 | melwitt | yeah from what I saw O_EXCL not exotic | |
| 17:43:46 | melwitt | I have a couple of vtpm live migration follow up items, one small patch with corrected config help text https://review.opendev.org/c/openstack/nova/+/987312 and one small patch spec amendment to clarify secret access control language https://review.opendev.org/c/openstack/nova-specs/+/987310 for those reading the delivered spec as a reference, if anyone could help review | |
| 17:53:46 | sean-k-mooney | melwitt: by the way there is a somewat related but to that swap/epmereal issues tha twe shoudl evengually fix | |
| 17:54:43 | sean-k-mooney | when we created ephmeral and i belive swap disk with the qcow backend we share a backing file based on the size | |
| 17:55:35 | sean-k-mooney | and at leasat for the ephermal disk we can format the qcow for a given vm | |
| 17:56:12 | sean-k-mooney | but if im not mistaken that can casue filesysetm currption when we cold migrate if we resue a backign file form a diffent host | |
| 17:58:44 | sean-k-mooney | basiclly we shoudl just never use backign files for swap and ephmeral | |
| 17:58:54 | sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/allow-disabling-ephemeral-disk-formatting was sort of related to that | |
| 17:59:07 | sean-k-mooney | but there was bug for the actual issue somewhere | |
| 18:01:42 | sean-k-mooney | melwitt: this https://bugs.launchpad.net/nova/+bug/2095173 | |
| 18:02:08 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/940900 | |
| 18:03:08 | sean-k-mooney | melwitt: the swap thing just reminede me we hever actly fixed that | |
| 18:19:56 | melwitt | sean-k-mooney: ah yeah, I am aware of that general issue. good to have the links, I had not seen a bug report for it | |
| 19:19:30 | opendevreview | Stephen Finucane proposed openstack/os-vif master: typing: Updates for typed oslo.config https://review.opendev.org/c/openstack/os-vif/+/989206 | |
| 19:20:02 | opendevreview | Stephen Finucane proposed openstack/os-vif master: Remove linux bridge plugin https://review.opendev.org/c/openstack/os-vif/+/941586 | |
| 19:32:45 | opendevreview | Stephen Finucane proposed openstack/os-vif master: typing: Updates for typed oslo.config https://review.opendev.org/c/openstack/os-vif/+/989206 | |
| 19:32:57 | opendevreview | Stephen Finucane proposed openstack/os-vif master: Remove linux bridge plugin https://review.opendev.org/c/openstack/os-vif/+/941586 | |
| 19:36:18 | opendevreview | Stephen Finucane proposed openstack/nova master: Use static pages for eom release release notes https://review.opendev.org/c/openstack/nova/+/989211 | |
| 19:36:18 | opendevreview | Stephen Finucane proposed openstack/nova master: Use static pages for eol release release notes https://review.opendev.org/c/openstack/nova/+/989210 | |
| 19:36:19 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Speed up release notes builds https://review.opendev.org/c/openstack/nova/+/989212 | |
| 19:38:15 | stephenfin | melwitt: That should significantly speed up release notes builds. I recall you complaining about that a long time ago | |
| 19:38:18 | stephenfin | ☝️ | |
| 20:27:49 | melwitt | stephenfin: IIRC I added parallel build a long time ago for that :) thanks for the heads up, I will look at them | |
| #openstack-nova - 2026-05-20 | |||
| 01:43:32 | opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add virtiofs cold migration spec https://review.opendev.org/c/openstack/nova-specs/+/985738 | |
| 10:47:25 | opendevreview | Merged openstack/os-vif master: typing: Updates for typed oslo.config https://review.opendev.org/c/openstack/os-vif/+/989206 | |
| 10:52:27 | opendevreview | Merged openstack/os-vif master: Remove linux bridge plugin https://review.opendev.org/c/openstack/os-vif/+/941586 | |
| 13:05:42 | opendevreview | Elod Illes proposed openstack/nova master: Do not log metadata proxy shared secret https://review.opendev.org/c/openstack/nova/+/988501 | |
| 13:06:10 | elodilles | sean-k-mooney: i've extended a unit test ^^^ | |
| 13:07:39 | sean-k-mooney | self.assertIn('mismatched_signature', str(warning_calls)) | |
| 13:08:04 | sean-k-mooney | shoudl that not be assertNotIn | |
| 13:08:20 | sean-k-mooney | oh | |
| 13:08:22 | sean-k-mooney | no | |
| 13:08:27 | sean-k-mooney | that the value that was passed in teh header | |
| 13:08:37 | sean-k-mooney | ok and signed is the cofnig value | |
| 13:08:55 | sean-k-mooney | elodilles: ya ok that correct +2 | |
| 13:10:46 | sean-k-mooney | you could argure you shoudl not log either value but i think at that poitn it start to be a litte hard to debug | |
| 13:11:07 | sean-k-mooney | elodilles: im ok with this as a ok compromise for operational debugablity | |
| 13:12:30 | sean-k-mooney | at some point we shoudl split that test up into multiple tests but that out of scope of your change | |
| 13:16:32 | elodilles | ACK, thanks :) | |
| 13:21:34 | opendevreview | Masanori Ueno proposed openstack/nova master: NUMA live-migration: ensure allocation_ratio is respected https://review.opendev.org/c/openstack/nova/+/989378 | |
| 13:23:32 | opendevreview | Masanori Ueno proposed openstack/nova master: NUMA live-migration: ensure allocation_ratio is respected https://review.opendev.org/c/openstack/nova/+/989378 | |
| 13:24:13 | sean-k-mooney | elodilles: by the way the os-vif changes finally merged if you want to proceed with the release and have not already done so | |
| 13:24:36 | sean-k-mooney | we might need to update teh sha. if you arelady did the m1 release there is no rush to release again | |
| 13:25:29 | elodilles | sean-k-mooney: oh, cool, i've been waiting for the patch to merge. but then it did :) let me update the hash on the rel patch | |
| 13:29:55 | elodilles | sean-k-mooney: hash and version number is updated -> https://review.opendev.org/c/openstack/releases/+/988061 | |
| 13:32:02 | sean-k-mooney | that looks correct to me, i have commented the same on the patch | |
| 14:24:47 | elodilles | Uggla: when you have some time, could you please take a quick look at the os-vif release patch? Sean and Stephen are both +1'd it already ;) https://review.opendev.org/c/openstack/releases/+/988061 | |
| 14:25:52 | Uggla | elodilles, so I guess Stephen includes what he wanted in os-vif right ? | |
| 14:27:34 | elodilles | yepp | |
| 14:27:53 | elodilles | that patch has merged | |
| 14:44:02 | auniyal | https://review.opendev.org/c/openstack/requirements/+/988412 | |
| 14:44:45 | auniyal | gmaan this might be the reason for tempest bug - attachment issue | |
| 14:58:42 | auniyal | :( seems nope | |
| 15:46:55 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop description for ancient horizon https://review.opendev.org/c/openstack/nova/+/989419 | |
| 15:48:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop description for ancient horizon https://review.opendev.org/c/openstack/nova/+/989419 | |
| 16:57:49 | gmaan | auniyal: thanks, let's chat on cinder channel as it is not related to nova | |
| 17:00:12 | Uggla | sean-k-mooney, does the PCI tracker only read the libvirt pci device "inventory" at startup ? | |