Earlier  
Posted Nick Remark
#openstack-nova - 2026-05-15
20:58:26 melwitt I would think they should be easy small func tests that just try to set the quota and assert it's rejected in those scenarios
21:23:03 opendevreview melanie witt proposed openstack/nova master: Fix swap disk creation skipped on NFS during cold migration https://review.opendev.org/c/openstack/nova/+/988547
21:24:27 gmaan ++ thanks
21:27:03 opendevreview melanie witt proposed openstack/nova master: Use tempest_concurrency=1 for nova-vtpm job https://review.opendev.org/c/openstack/nova/+/984864
21:42:29 opendevreview Merged openstack/nova master: Reproducer for bug 2131272 https://review.opendev.org/c/openstack/nova/+/967147
21:49:31 melwitt I have a crazy old 4 character bug fix with one +2 on it if anyone wants an easy review https://review.opendev.org/c/openstack/nova/+/904155
22:25:40 opendevreview melanie witt proposed openstack/nova master: Fix usage count when user-scoped quota is set https://review.opendev.org/c/openstack/nova/+/967148
22:31:34 gmaan +w
23:07:27 melwitt thanks gmaan !
23:10:06 opendevreview Merged openstack/nova master: Implementing get_num_instances for ironic virt driver https://review.opendev.org/c/openstack/nova/+/955685
#openstack-nova - 2026-05-16
01:24:44 opendevreview Merged openstack/nova master: Fix logging of exc_info in compute.utils.delete_image() https://review.opendev.org/c/openstack/nova/+/904155
01:35:47 opendevreview Merged openstack/nova master: Clean up stale comments in ironic virt driver https://review.opendev.org/c/openstack/nova/+/988504
13:37:55 opendevreview Merged openstack/nova master: Fix usage count when user-scoped quota is set https://review.opendev.org/c/openstack/nova/+/967148
21:20:55 cardoe Uggla: would it be reasonable to request https://review.opendev.org/c/openstack/nova/+/955685 be backported?
#openstack-nova - 2026-05-18
09:10:54 elodilles stephenfin: don't you want to include this to os-vif's hibiscus-milestone-1 release? https://review.opendev.org/c/openstack/os-vif/+/941586
10:33:49 sean-k-mooney elodilles: i would love if that was in m1
10:33:59 sean-k-mooney elodilles: stephenfin proably is ok with it too
10:34:26 sean-k-mooney elodilles: but we need https://review.opendev.org/c/openstack/nova/+/957040 to merge first
10:34:44 sean-k-mooney elodilles: so as long as it happens this cycle its fine if its not there for m1
10:36:04 elodilles sean-k-mooney: ah, i see, thanks for the info. i see that the nova patch is on the gate already, so maybe it's OK to wait for that
10:37:08 elodilles (Hibiscus-1 milestone deadline was last week, but actually i've started to merge the remaining open hibiscus-1 release patches today, so we can still wait a bit)
10:37:09 sean-k-mooney elodilles: we can alway do another release of os-vif
10:37:36 sean-k-mooney stephen woudl liek the typehint to be in a release
10:37:42 sean-k-mooney and those are merged
10:37:48 elodilles sean-k-mooney: that's true, but if it's just a couple of hours waiting, then i'm OK to wait :]
10:38:10 elodilles sean-k-mooney: yepp, i saw that those have merged. +1
10:40:09 sean-k-mooney i woudl sayu if its not merge by end fo day just proceed
10:58:06 elodilles ACK, will do that
11:58:37 opendevreview Lajos Katona proposed openstack/nova master: Fix live migration with pinned VM and iothreads https://review.opendev.org/c/openstack/nova/+/988774
13:45:55 zigo It feels like it would have been nice to merge this one: https://review.opendev.org/c/openstack/nova/+/904060
13:45:55 zigo sean-k-mooney: Looks like we're affected by https://bugs.launchpad.net/nova/+bug/2028518
13:46:03 zigo (rather than nit-picking about tests...)
13:47:06 sean-k-mooney that not a nit pick and you note i idd orginally approve this.
13:47:41 sean-k-mooney we generally dont accpet chagne with no testing
13:48:20 sean-k-mooney zigo: the reall issue however is artom moved on form an ic role and is now a manager of one of our internal ci teams
13:48:42 sean-k-mooney zigo: so the reason this has not made any progress is 1 we forgot about it and 2 no one has been working on it since
13:49:16 zigo Sure, but it's very frustrating to see a valid fix from 3 years ago still not merged.
13:49:29 sean-k-mooney please dont look at my open reviews then :P
13:50:03 sean-k-mooney let me see if i can have ai rebase this and add the test coverage really quickly
13:51:10 zigo It applies cleanly on gazpacho, FYI.
13:51:20 zigo Good chance it does on master.
13:51:53 sean-k-mooney yep but we at the very least need a new ci run so ill do a trivial rebase add the requested unit test and push it up
13:51:53 zigo As for the policy to have tests: I very much support it and I thank you for making sure we follow the policy, no worries.
13:52:10 zigo Thanks a lot ! :)
13:52:39 sean-k-mooney this si kind fo one of the perfect usecase for ai. we have a patch we knew fixed the problem but it jsut needs a rebase adn trivial testing added
13:54:45 opendevreview Merged openstack/nova master: Remove Linux bridge VIF support from Nova https://review.opendev.org/c/openstack/nova/+/957040
13:55:08 sean-k-mooney woot!!
13:55:42 sean-k-mooney zigo: that ^ has been on my todolist for like over a year since neutron removed supprot in 2025.2?
13:56:12 zigo :)
14:08:24 opendevreview sean mooney proposed openstack/nova master: weights: fix TypeError in weight debug log serialization https://review.opendev.org/c/openstack/nova/+/904060
14:11:53 sean-k-mooney zigo: so i think ^ should be ok lets see what ci say
14:12:52 zigo Great ! Thanks.
14:13:16 sean-k-mooney we do use debug mode in ci so if that prints propelry and the output looks sane i may upgrade back to +2 but +1 for now since i have only run the unit test on that
14:13:34 zigo I believe the issue is debug + json, not just debug.
14:13:53 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/904060/4/nova/tests/unit/test_weights.py#87
14:14:01 sean-k-mooney shoudl hopefully validate it
14:14:22 sean-k-mooney but are you sayign its more that its a problem if you have debug logging + oslo log in json mode?
14:15:32 sean-k-mooney the orginal bug just mentions debug=true https://bugs.launchpad.net/nova/+bug/2028518
14:16:46 sean-k-mooney so i think the patch shoudl be sufficent but we can alwasy extened it again if needed
14:17:29 zigo The bug tells about oslo.log in json mode, yeah. And that's why we're affected (we use debug + json in production, so it's easier to stream to elastic search).
14:18:30 sean-k-mooney well https://bugs.launchpad.net/nova/+bug/2028518 does not mention json mode, that just about normla debug mode with an object that we happen to be serisalise as json which is slightly diffent
14:19:05 sean-k-mooney zigo: do you have the ablity to test this?
14:19:07 zigo Oh ok.
14:19:15 sean-k-mooney you mentioned seeing it in debian?
14:19:32 zigo I mentioned we have the issue in our public cloud with the scheduler.log.
14:19:40 sean-k-mooney ah ok
14:19:52 sean-k-mooney so we use debug logging in our downstream product as well
14:19:57 zigo That'd be on Caracal, for which I just backported the patch (not your revision though).
14:20:04 sean-k-mooney i.e. we have the schduler defautl to debug
14:20:21 sean-k-mooney im not aware of this impacting that but that based on antelope
14:20:56 sean-k-mooney how does it manifest is it jsut a traceback but otherwise it works?
14:21:20 sean-k-mooney im trying to undersand why this isnt breakign us hence the question
14:21:44 zigo Just traceback, VMs are still spawned, but it doesn't feel very right ! :)
14:22:05 sean-k-mooney ack ok so this is likely a "silgnet issue" we are not aware of in the ci
14:22:07 sean-k-mooney and yes
14:22:17 sean-k-mooney i hate "standared tracebacks/errors"
14:22:20 sean-k-mooney in logs
14:22:30 sean-k-mooney i.e. the ones form os-brick
14:22:39 sean-k-mooney so ya it woudl be good to fix and backport
14:53:00 sean-k-mooney dansmith: oh we dont need to read the full stream for any format? i tought one of the vmdk or ova format need that but that is good to know
14:53:26 sean-k-mooney im probaly miss rememberign but i thoguh one of the format had a triailer we needed to look at
14:54:08 sean-k-mooney althogh that really just an implamtion detial even in that case as the main point of it being stream based wehre we can reject it once we know its wrogn still holds
14:54:43 sean-k-mooney glance would still reject it at the first point it know tis wrong even if that is a trailer at the end of the format
14:55:05 dansmith sean-k-mooney: nope :)
14:55:39 sean-k-mooney cool
14:56:38 sean-k-mooney we do have EndCaptureRegion however https://github.com/openstack/oslo.utils/blob/master/oslo_utils/imageutils/format_inspector.py#L106
14:56:43 sean-k-mooney that the thing i was thinking of
14:57:28 sean-k-mooney which is for vmdk https://github.com/openstack/oslo.utils/blob/master/oslo_utils/imageutils/format_inspector.py#L942-L949
14:57:46 dansmith sean-k-mooney: we can capture the trailer yep
14:58:07 dansmith but we don't _have_ to do that, and we also don't need to store the image to do it
14:58:35 sean-k-mooney ack ok that fits with my recolection then
15:33:59 Uggla Reminder, upstream meeting in ~30mn
15:59:03 lajoskatona sean-k-mooney: Hi, I updated gibi's patch for iothreads (https://review.opendev.org/c/openstack/nova/+/988774 ) as the unit test failed i the right way :-)
16:00:18 lajoskatona sean-k-mooney: first I can't see if the patch is related to livemigration post_failure, but it is suspicious....
16:01:04 opendevmeet The meeting name has been set to 'nova'
16:01:04 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:04 opendevmeet Meeting started Mon May 18 16:01:04 2026 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:04 Uggla #startmeeting nova
16:01:10 Uggla Hello everyone
16:01:11 sean-k-mooney lajoskatona: we can chat after the meeting

Earlier   Later