Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-05-15
14:26:34 sean-k-mooney im personally fine with not doing that and just saying you need to reboot to get the iothread jsut notign that qemu/libvirt techniall supprot adding and removign them on a runing instance
14:27:36 gibi I think it is safer not to try to add it during live migration
14:27:47 sean-k-mooney ya that was my feelign too
14:27:52 sean-k-mooney just wanted to raise the possiblity
14:28:01 gibi so if somebody explicity want this then that is a new small feature to me
14:29:56 sean-k-mooney cool well still +1 lets see what ci says and ill loop back
14:31:11 sean-k-mooney gibi: nice find by the way idd you just come across it or was it somethign you noticed in a ci failreu or something
14:31:26 sean-k-mooney oh you were backporting this downstream right
14:31:38 gibi yepp I tested my backport downstream
14:31:53 gibi there it is simpler to thest the upgrade
14:32:16 gibi by just changing the nova-compute container image
14:32:42 gibi as we had bugs before with live migration and pinned CPUs, I tested the combination of those :)
14:32:56 sean-k-mooney ack i need to revive and rewrite my ci change
14:33:01 opendevreview Masanori Ueno proposed openstack/nova master: DNM: Add functional test for NUMA live migration overcommit bug https://review.opendev.org/c/openstack/nova/+/988777
14:33:03 sean-k-mooney that enabeld cpu pining upstream
14:33:20 gibi yeah I have a todo to add some iothread tests to whitebox
14:33:27 sean-k-mooney i never got aroudn to making the calulation of cpu_share_set and cpu_dedicated_set dynmic
14:33:36 sean-k-mooney whitebox woudl be good too ya
16:38:02 dansmith gibi_off: sean-k-mooney: but... people might want to use live migration to get iothreads without a guest restart
16:38:12 dansmith I mean, I know the risk is higher but.. I _know_ people will want that :D
17:10:32 sean-k-mooney dansmith: thats why i broguht it up. it would be nice if that worked but that is why i was suggesting perhaps a followup
17:10:49 sean-k-mooney i knwo there is an api to add an remove them at runtime
17:10:57 sean-k-mooney but i dont knwo if you can do this when live migrating
17:11:01 dansmith ack
19:37:04 melwitt gmaan: sorry to bug you with this but I'm trying to close out a quota bug fix I worked on awhile back that has got one +2 https://review.opendev.org/q/topic:%22bug/2131272%22 the CI results are old but I just rechecked it, if you might have a chance to look at it. it is not urgent
19:45:53 gmaan melwitt: ack, I will take a look
19:46:50 melwitt thanks gmaan
20:26:32 gmaan melwitt: one question. do we allow to set user quota >project quota OR set project quota < user quota ? if yes then that is the problem right?
20:30:48 gmaan so this is case when both are equal and multi users. got it but just wondering if we handle the above case ^^ (i assume yes)
20:49:42 melwitt gmaan: I think it is not allowed to set an individual user's quota to be larger than the quota of their project. And I don't think it's allowed to set project quota lower than an individual user's quota in the project but I am not as sure about that one. /me checks if we have tests for this and if not, it's probably worth adding a couple
20:53:24 gmaan yeah, I was thinking to have test for those cases. but anyways that is separate things came up in my mind. bug#2131272 fix lgtm, waiting for CI results
20:57:26 melwitt gmaan: yeah I think it's a good point. I might add the tests to this patch if I find we don't already have them, since we are waiting anyway
20:58:26 melwitt I would think they should be easy small func tests that just try to set the quota and assert it's rejected in those scenarios
21:23:03 opendevreview melanie witt proposed openstack/nova master: Fix swap disk creation skipped on NFS during cold migration https://review.opendev.org/c/openstack/nova/+/988547
21:24:27 gmaan ++ thanks
21:27:03 opendevreview melanie witt proposed openstack/nova master: Use tempest_concurrency=1 for nova-vtpm job https://review.opendev.org/c/openstack/nova/+/984864
21:42:29 opendevreview Merged openstack/nova master: Reproducer for bug 2131272 https://review.opendev.org/c/openstack/nova/+/967147
21:49:31 melwitt I have a crazy old 4 character bug fix with one +2 on it if anyone wants an easy review https://review.opendev.org/c/openstack/nova/+/904155
22:25:40 opendevreview melanie witt proposed openstack/nova master: Fix usage count when user-scoped quota is set https://review.opendev.org/c/openstack/nova/+/967148
22:31:34 gmaan +w
23:07:27 melwitt thanks gmaan !
23:10:06 opendevreview Merged openstack/nova master: Implementing get_num_instances for ironic virt driver https://review.opendev.org/c/openstack/nova/+/955685
#openstack-nova - 2026-05-16
01:24:44 opendevreview Merged openstack/nova master: Fix logging of exc_info in compute.utils.delete_image() https://review.opendev.org/c/openstack/nova/+/904155
01:35:47 opendevreview Merged openstack/nova master: Clean up stale comments in ironic virt driver https://review.opendev.org/c/openstack/nova/+/988504
13:37:55 opendevreview Merged openstack/nova master: Fix usage count when user-scoped quota is set https://review.opendev.org/c/openstack/nova/+/967148
21:20:55 cardoe Uggla: would it be reasonable to request https://review.opendev.org/c/openstack/nova/+/955685 be backported?
#openstack-nova - 2026-05-18
09:10:54 elodilles stephenfin: don't you want to include this to os-vif's hibiscus-milestone-1 release? https://review.opendev.org/c/openstack/os-vif/+/941586
10:33:49 sean-k-mooney elodilles: i would love if that was in m1
10:33:59 sean-k-mooney elodilles: stephenfin proably is ok with it too
10:34:26 sean-k-mooney elodilles: but we need https://review.opendev.org/c/openstack/nova/+/957040 to merge first
10:34:44 sean-k-mooney elodilles: so as long as it happens this cycle its fine if its not there for m1
10:36:04 elodilles sean-k-mooney: ah, i see, thanks for the info. i see that the nova patch is on the gate already, so maybe it's OK to wait for that
10:37:08 elodilles (Hibiscus-1 milestone deadline was last week, but actually i've started to merge the remaining open hibiscus-1 release patches today, so we can still wait a bit)
10:37:09 sean-k-mooney elodilles: we can alway do another release of os-vif
10:37:36 sean-k-mooney stephen woudl liek the typehint to be in a release
10:37:42 sean-k-mooney and those are merged
10:37:48 elodilles sean-k-mooney: that's true, but if it's just a couple of hours waiting, then i'm OK to wait :]
10:38:10 elodilles sean-k-mooney: yepp, i saw that those have merged. +1
10:40:09 sean-k-mooney i woudl sayu if its not merge by end fo day just proceed
10:58:06 elodilles ACK, will do that
11:58:37 opendevreview Lajos Katona proposed openstack/nova master: Fix live migration with pinned VM and iothreads https://review.opendev.org/c/openstack/nova/+/988774
13:45:55 zigo It feels like it would have been nice to merge this one: https://review.opendev.org/c/openstack/nova/+/904060
13:45:55 zigo sean-k-mooney: Looks like we're affected by https://bugs.launchpad.net/nova/+bug/2028518
13:46:03 zigo (rather than nit-picking about tests...)
13:47:06 sean-k-mooney that not a nit pick and you note i idd orginally approve this.
13:47:41 sean-k-mooney we generally dont accpet chagne with no testing
13:48:20 sean-k-mooney zigo: the reall issue however is artom moved on form an ic role and is now a manager of one of our internal ci teams
13:48:42 sean-k-mooney zigo: so the reason this has not made any progress is 1 we forgot about it and 2 no one has been working on it since
13:49:16 zigo Sure, but it's very frustrating to see a valid fix from 3 years ago still not merged.
13:49:29 sean-k-mooney please dont look at my open reviews then :P
13:50:03 sean-k-mooney let me see if i can have ai rebase this and add the test coverage really quickly
13:51:10 zigo It applies cleanly on gazpacho, FYI.
13:51:20 zigo Good chance it does on master.
13:51:53 sean-k-mooney yep but we at the very least need a new ci run so ill do a trivial rebase add the requested unit test and push it up
13:51:53 zigo As for the policy to have tests: I very much support it and I thank you for making sure we follow the policy, no worries.
13:52:10 zigo Thanks a lot ! :)
13:52:39 sean-k-mooney this si kind fo one of the perfect usecase for ai. we have a patch we knew fixed the problem but it jsut needs a rebase adn trivial testing added
13:54:45 opendevreview Merged openstack/nova master: Remove Linux bridge VIF support from Nova https://review.opendev.org/c/openstack/nova/+/957040
13:55:08 sean-k-mooney woot!!
13:55:42 sean-k-mooney zigo: that ^ has been on my todolist for like over a year since neutron removed supprot in 2025.2?
13:56:12 zigo :)
14:08:24 opendevreview sean mooney proposed openstack/nova master: weights: fix TypeError in weight debug log serialization https://review.opendev.org/c/openstack/nova/+/904060
14:11:53 sean-k-mooney zigo: so i think ^ should be ok lets see what ci say
14:12:52 zigo Great ! Thanks.
14:13:16 sean-k-mooney we do use debug mode in ci so if that prints propelry and the output looks sane i may upgrade back to +2 but +1 for now since i have only run the unit test on that
14:13:34 zigo I believe the issue is debug + json, not just debug.
14:13:53 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/904060/4/nova/tests/unit/test_weights.py#87
14:14:01 sean-k-mooney shoudl hopefully validate it
14:14:22 sean-k-mooney but are you sayign its more that its a problem if you have debug logging + oslo log in json mode?
14:15:32 sean-k-mooney the orginal bug just mentions debug=true https://bugs.launchpad.net/nova/+bug/2028518
14:16:46 sean-k-mooney so i think the patch shoudl be sufficent but we can alwasy extened it again if needed
14:17:29 zigo The bug tells about oslo.log in json mode, yeah. And that's why we're affected (we use debug + json in production, so it's easier to stream to elastic search).
14:18:30 sean-k-mooney well https://bugs.launchpad.net/nova/+bug/2028518 does not mention json mode, that just about normla debug mode with an object that we happen to be serisalise as json which is slightly diffent
14:19:05 sean-k-mooney zigo: do you have the ablity to test this?
14:19:07 zigo Oh ok.
14:19:15 sean-k-mooney you mentioned seeing it in debian?
14:19:32 zigo I mentioned we have the issue in our public cloud with the scheduler.log.
14:19:40 sean-k-mooney ah ok
14:19:52 sean-k-mooney so we use debug logging in our downstream product as well
14:19:57 zigo That'd be on Caracal, for which I just backported the patch (not your revision though).

Earlier   Later