| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-03-09 | |||
| 17:39:26 | dansmith | (from the etherpad, maybe should be copied into the bug) | |
| 17:39:30 | dansmith | yeah | |
| 17:39:44 | sean-k-mooney | ok that scaling diffently then i initally tought | |
| 17:39:59 | dansmith | and probably scales like n^2 almost because each compute doing it is scanning each other compute record that you ad | |
| 17:40:02 | dansmith | *add | |
| 17:40:04 | sean-k-mooney | although ya it makes sense this is per compute | |
| 17:41:04 | sean-k-mooney | we already have indexs on source_compute and dest_compute and source_node and dest node | |
| 17:41:07 | stephenfin | sean-k-mooney: I can't say, but we've never written our migrations on the assumption that the operator has manually hacked in their own migrations | |
| 17:41:20 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/958556/1/nova/db/main/models.py#895 | |
| 17:41:23 | stephenfin | so I'm not sure how this would be any different | |
| 17:41:52 | stephenfin | however, if they *had* done that, they can always dummy apply the migration using the stamp command | |
| 17:42:04 | sean-k-mooney | im actully surpised that a quey on teh subset is not coverd by htat | |
| 17:42:10 | stephenfin | https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.stamp | |
| 17:42:45 | sean-k-mooney | stephenfin: well in the very old days we assumed the dba may create indexes ro set coalation types to optimise for there usecase | |
| 17:43:10 | sean-k-mooney | im not saying that a good thing just that it was a thing | |
| 17:43:31 | sean-k-mooney | the ops guided uses to have soem recomentions for adding indexes but that was eons ago | |
| 18:25:46 | dansmith | Uggla: the other volume bugs there are good things to fix, but I'm not sure in the best way.. I've left some comments | |
| 18:42:54 | opendevreview | Merged openstack/os-traits master: Remove MANIFEST.in https://review.opendev.org/c/openstack/os-traits/+/975992 | |
| 18:44:20 | opendevreview | Merged openstack/osc-placement master: Remove MANIFEST.in https://review.opendev.org/c/openstack/osc-placement/+/975984 | |
| #openstack-nova - 2026-03-10 | |||
| 07:25:33 | opendevreview | Max proposed openstack/nova master: fix: leftover volume_attachment on instance delete https://review.opendev.org/c/openstack/nova/+/934984 | |
| 08:00:17 | jkulik | gibi, when you find some time, could your provide feedback to https://review.opendev.org/c/openstack/nova-specs/+/975698 ? it's a proposal to fix the race-condition you mentioned in my recent volume-attachment changes | |
| 09:40:05 | opendevreview | Max proposed openstack/nova master: Add regression test for bug #2139135 https://review.opendev.org/c/openstack/nova/+/974831 | |
| 09:40:06 | opendevreview | Max proposed openstack/nova master: fix: delete attachments after rescheduling delete https://review.opendev.org/c/openstack/nova/+/974832 | |
| 09:52:32 | opendevreview | Max proposed openstack/nova master: db: add indexes for source/dest migrations https://review.opendev.org/c/openstack/nova/+/958556 | |
| 10:28:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | |
| 10:54:51 | opendevreview | Seyeong Kim proposed openstack/nova master: libvirt: Support boot_index for multiple block devices https://review.opendev.org/c/openstack/nova/+/963665 | |
| 14:20:09 | opendevreview | Ashish Gupta proposed openstack/nova master: Run functional test with threading mode https://review.opendev.org/c/openstack/nova/+/979850 | |
| 15:04:10 | opendevreview | Merged openstack/nova master: Add regression test for bug #2088066 https://review.opendev.org/c/openstack/nova/+/965927 | |
| 15:11:39 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979864 | |
| 15:11:40 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Move cleanup of vTPM secret from driver to compute https://review.opendev.org/c/openstack/nova/+/979865 | |
| 15:11:41 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/979866 | |
| 15:25:32 | dansmith | Uggla: your -1 is still on here from Feb: https://review.opendev.org/c/openstack/nova/+/972045/2 | |
| 15:25:52 | dansmith | I guess because you -1'd this patch for the thing on the one below, and since this one didn't change it didn't reset | |
| 15:44:06 | bauzas | gibi: melwitt: just a note that I updated https://review.opendev.org/c/openstack/nova/+/845757 by adding the bug report in the reno file | |
| 15:44:18 | bauzas | (and thanks for your reviews <3 ) | |
| 15:53:04 | MaxLamprecht[m] | dansmith: thx for review of the attachment stuff. During debugging I found 2 more things that are really small and broken: https://review.opendev.org/c/openstack/nova/+/973103 and https://review.opendev.org/c/openstack/nova/+/975651 | |
| 16:01:47 | Uggla | dansmith yep unfortunately you are right. It has not change since that time. | |
| 16:04:26 | dansmith | MaxLamprecht[m]: I'm about to get on a couple _hours_ of calls but will look closer at the second in in a bit | |
| 16:05:56 | gibi | bauzas: +2 | |
| 16:06:05 | bauzas | <3 | |
| 16:11:03 | MaxLamprecht[m] | dansmith: thx :) | |
| 16:12:16 | gibi | I just caugth up on the nova meeting logs from yesterday (slow me). I see that the SEV refactor is on hold until branch is open. That is OK for me. | |
| 18:20:32 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | |
| 18:20:32 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | |
| 18:20:33 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron floating IPs https://review.opendev.org/c/openstack/nova/+/962604 | |
| 18:20:33 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | |
| 19:25:15 | melwitt | bauzas: cool thanks I will check the update | |
| #openstack-nova - 2026-03-11 | |||
| 00:55:45 | opendevreview | Merged openstack/nova stable/2025.2: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979041 | |
| 04:44:06 | opendevreview | Merged openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | |
| 08:05:33 | nicolairuckel | melwitt: Should I just abandon this https://review.opendev.org/c/openstack/nova/+/979866 and create a new one with the correct cherry-picks? | |
| 09:16:46 | opendevreview | Max proposed openstack/nova master: fix: orphaned attachments during migration delete https://review.opendev.org/c/openstack/nova/+/972045 | |
| 09:29:35 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979864 | |
| 09:29:36 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Move cleanup of vTPM secret from driver to compute https://review.opendev.org/c/openstack/nova/+/979865 | |
| 09:29:37 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/979866 | |
| 09:55:06 | nicolairuckel | The gate fails with an sqlalchemy error for me: https://b49a1a6bd7022e637e55-03d448e06513a4e4bb78797852449f92.ssl.cf1.rackcdn.com/openstack/cf4f116365064c10b0f3e76c6db33568/testr_results.html I vaguely remember people here talking about some sqlalchemy stuff. Was that related to that? | |
| 09:55:56 | nicolairuckel | I ran the same command (tox -epy312-threading -vv --skip-missing-interpreters=false) locally without any errors. | |
| 10:34:04 | gibi | nicolairuckel: am I blind or that job should not even run that test case due to the known issue https://github.com/openstack/nova/blob/master/threading_unit_test_excludes.txt#L38 | |
| 10:42:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add functional tests for NUMA aware vswitches https://review.opendev.org/c/openstack/nova/+/979999 | |
| 10:45:08 | nicolairuckel | gibi: That test doesn't seem to be excluded for 2025.2 though. | |
| 11:02:28 | opendevreview | Thibaut Démaret proposed openstack/nova master: libvirt: add disk rotation_rate support for local disks https://review.opendev.org/c/openstack/nova/+/979693 | |
| 11:09:36 | gibi | I will investigate | |
| 11:10:59 | nicolairuckel | https://github.com/openstack/nova/blob/stable/2025.2/threading_unit_test_excludes.txt | |
| 11:24:42 | elodilles | sorry, i did not see the discussion and rechecked it, but at least nova-tox-py312-threading has passed now o:) | |
| 11:25:36 | gibi | OK so https://review.opendev.org/c/openstack/nova/+/953475 is in 2025.2 so the job expected to run that branch | |
| 11:25:50 | gibi | I guess there was a fix on the exclude list that was not backported to 2025.2 | |
| 11:26:40 | nicolairuckel | and 2025.1 if I see that correctly | |
| 11:27:34 | gibi | yepp https://review.opendev.org/c/openstack/nova/+/961781 this is missing from stable. I will do the backports | |
| 11:27:41 | nicolairuckel | thank you | |
| 11:27:50 | gibi | thanks for notifying | |
| 11:28:25 | gibi | nicolairuckel: I don't think the job should run on 2025.1 | |
| 11:28:30 | gibi | but let me double check | |
| 11:28:33 | nicolairuckel | It's very self-serving for me. :D | |
| 11:29:42 | gibi | :) that is fine | |
| 11:29:51 | gibi | yeah it does not exists on 2025.1 | |
| 11:30:54 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [nova-tox-py312-threading]Ignore failing tests https://review.opendev.org/c/openstack/nova/+/980013 | |
| 11:31:03 | gibi | elodilles: ^^ | |
| 11:31:54 | elodilles | thanks, looking o/ | |
| 11:34:18 | elodilles | gibi: +2+W'd it | |
| 11:34:31 | elodilles | thanks for backporting it o/ | |
| 11:39:11 | gibi | thanks for the quick review | |
| 11:46:08 | r-taketn | Hello, Uggla, gibi, bauzas. Regarding sev refactor series, my understanding from this week's irclogs is that reviews will restart after stable/2026.01(RC1) branch is cut. Is that correct? | |
| 11:46:58 | gibi | r-taketn: yes that was agreed on the last nova meeting on Monday | |
| 11:48:42 | r-taketn | Got it. Thanks for confirming. | |
| 13:23:57 | DominikDanelski[m] | sean-k-mooney: If you were interested, I addressed your comments and finally dealt with the flaky tests in https://review.opendev.org/c/openstack/nova/+/969251 and https://review.opendev.org/c/openstack/nova/+/968446 so both now pass. | |
| 13:28:16 | opendevreview | Dominik proposed openstack/nova master: NUMA Topology with Resource Providers: Object changes https://review.opendev.org/c/openstack/nova/+/978209 | |
| 13:30:39 | opendevreview | Dominik proposed openstack/nova master: NUMA Topology with Resource Providers: Scheduler changes https://review.opendev.org/c/openstack/nova/+/971176 | |
| 13:37:18 | opendevreview | Dominik proposed openstack/nova master: Regression test for Placement allocations remaining during failed schedule https://review.opendev.org/c/openstack/nova/+/969251 | |
| 13:38:27 | opendevreview | Dominik proposed openstack/nova master: Remove Placement allocations in the broken build cleanup https://review.opendev.org/c/openstack/nova/+/968446 | |
| 13:39:44 | sean-k-mooney | DominikDanelski[m]: ill need to find some dedicated time to reveiw the actual fix but we can likely proceed with the repoducer | |
| 13:40:06 | sean-k-mooney | i think the acual fix is reasonable | |
| 13:40:21 | nicolairuckel | I noticed something else that seems odd to me. The CI fails for one of my backports to 2025.1 (https://review.opendev.org/c/openstack/nova/+/979866) because of the check-cherry-pick job. Since the cherry-picked commit wasn't merged to 2025.2 yet that makes sense to me. But shouldn't this also fail then? https://review.opendev.org/c/openstack/nova/+/979865. | |
| 13:40:25 | sean-k-mooney | but i have not loaded context on the code to really say definititvly | |
| 13:55:37 | opendevreview | Akira KAMIO proposed openstack/nova master: libvirt: honor flavor disk bus and SCSI model for BFV https://review.opendev.org/c/openstack/nova/+/980072 | |
| 14:05:15 | opendevreview | Thibaut Démaret proposed openstack/nova master: libvirt: add disk rotation_rate support for local disks https://review.opendev.org/c/openstack/nova/+/979693 | |
| 14:46:05 | Uggla | gibi or melwitt can you have a look at https://review.opendev.org/c/openstack/nova/+/934984/9 there is a +2 from dansmith and sean-k-mooney previously. So I think it can be merged. Unless dansmith has an objection ? | |
| 14:47:46 | dansmith | no direct objection other than that rc1 is tomorrow and we really need to be quieting down.. you decide if it's better to do that now vs backport on friday.. like, if we start seeing failures after rc1 is cut... | |
| 14:48:58 | sean-k-mooney | i can review again im not against +2ing but im inclidned to hold +w until rc1 is tagged | |
| 14:52:06 | Uggla | sean-k-mooney, dansmith, we merged the reproducer. Is it ok if we don't merge the fix before rc1 ? | |
| 14:52:23 | sean-k-mooney | sure why would it not be | |
| 14:52:26 | opendevreview | Max proposed openstack/nova master: fix: device_by_alias should respect config type https://review.opendev.org/c/openstack/nova/+/975651 | |