Earlier  
Posted Nick Remark
#openstack-nova - 2026-02-26
15:21:40 gibi Uggla: I spotted a potential bug in the sev refactor series in https://review.opendev.org/c/openstack/nova/+/967972
15:28:35 tkajinam Returning 400 to user: Invalid input for field/attribute addresses. Value: {'': [{'version': 4, 'addr': '10.1.1.162', 'OS-EXT-IPS:type': 'fixed', 'OS-EXT-IPS-MAC:mac_addr': 'fa:16:3e:cb:ae:2e'}]}. '' does not match any of the regexes: '^.+$'
15:28:47 tkajinam it seems some of the GET requests are broken by schema validation
15:37:23 gibi tkajinam: is it a fresh one? did we landed some new schema validation thst break it?
15:37:58 tkajinam these were caught in https://zuul.opendev.org/t/openstack/build/d293798e270240c18bbfbb8d02d1ed4b which completed a few hours ago
15:38:05 tkajinam https://bugs.launchpad.net/nova/+bug/2142767
15:38:11 tkajinam https://bugs.launchpad.net/nova/+bug/2142765
15:38:24 tkajinam I have to dig into the latter because it is blocking instance creation by heat, it seems
15:40:07 tkajinam hmm I guess these two are connected because the failure might be detected during returning a response
15:41:33 bauzas I reviewed the first patch and I'm looking into the second, but I still have a bit of concerns, so I guess we gonna have to make a draw
15:49:26 opendevreview Takashi Kajinami proposed openstack/nova master: Accept an empty key for addresses https://review.opendev.org/c/openstack/nova/+/978089
15:49:32 gibi both seems to complaim that addresses are empty
15:49:42 Uggla gibi, bauzas ok
15:50:25 tkajinam gibi, yeah. I think the problem is the top key under the addresses are empty and IIUC these keys are network names in neutron
15:50:49 tkajinam and ... name in neutron networks is optional.
15:51:44 tkajinam testing the above patch by https://review.opendev.org/c/openstack/ceilometermiddleware/+/978090 ...
15:54:13 opendevreview Merged openstack/nova master: db: Move regex helpers to utils https://review.opendev.org/c/openstack/nova/+/958745
15:54:32 opendevreview Merged openstack/nova master: tests: Clean up flavors tests https://review.opendev.org/c/openstack/nova/+/958746
15:56:29 sean-k-mooney cardoe: we only allow exepciton that have no hostspecif info to get to the user
15:56:55 sean-k-mooney or ratehr we often only show the name of the exctpion to non admins
15:57:27 cardoe yeah this makes the behavior identical to KVM/libvirt driver for this error
15:58:08 cardoe because the ironic driver has prepare_networks_before_block_device_mapping, it sets up the networks earlier than the KVM/libvirt does.
15:58:34 sean-k-mooney on the nova side we treat any exposure of the hypervior/compute node name as a security hardenign opertunity
15:59:14 sean-k-mooney not nessiarly a cve but we try to treat that as privldage so we are a bit carfeul with the raw tracebacks as a result
16:00:08 sean-k-mooney cardoe: ya idely the behvior shoudl be the same give me a sec to finsih up something now im off a call and ill take a look again
16:01:58 gibi tkajinam: make sense +2
16:20:56 opendevreview Merged openstack/nova master: api: Simplify API version check for flavor description https://review.opendev.org/c/openstack/nova/+/958747
16:59:33 opendevreview Merged openstack/nova master: Deprecate unlimited compute actions https://review.opendev.org/c/openstack/nova/+/975833
16:59:50 opendevreview Merged openstack/nova master: [compute]Use single long task executor https://review.opendev.org/c/openstack/nova/+/977251
17:02:54 sean-k-mooney gibi: ^ :)
17:06:58 gibi \○/
17:07:10 gibi one more to go
17:07:25 sean-k-mooney im watching nova-next finish its tempest run
17:07:28 gibi then we can root for the graceful series on top
17:08:42 sean-k-mooney yep also https://review.opendev.org/c/openstack/nova/+/958748/6 if we can land that
17:14:37 gmaan finally :)
17:20:31 gmaan I think there are 3 changes competing for microversion 2.101
17:20:49 dansmith I just approved the async volume attach one that wants 101
17:20:51 gmaan this one is in gate, which should get it https://review.opendev.org/c/openstack/nova/+/971068
17:20:56 gmaan dansmith: yeah
17:21:44 gmaan I am reviewing the remove-os-volumes_boot which is almost ready but remember the async volume one
17:22:11 gmaan stephenfin: do you want to update remove-os-volumes_boot on top of async vol one?
17:31:34 gmaan stephenfin: I am holding the +w and one comment to update the spec whihc mentioned to return 410 instead of 404
17:32:01 gmaan sean-k-mooney: also, you tagged this cleanup as part of this BP but that is not related, it will be good to keep that separate https://review.opendev.org/c/openstack/nova/+/958863
17:32:30 gmaan stephenfin: ^^
17:33:01 gmaan sean-k-mooney: please ignore, i need to start my auto tab after typing two letter :)
17:41:17 sean-k-mooney ya i mented that seperatly to stephenfin, that it woudl be better to flip the order of that and teh one on top
17:42:07 sean-k-mooney gmaan: i was debeaitn if i shoudl rasie the 404 vs 410 point
17:42:36 sean-k-mooney i decied not to becasue i think the pattern we have is we only return 410 if we remove it form all micoverions
17:43:07 sean-k-mooney but use a 404 if its only remove in a specific microverison
17:43:59 gmaan yes, because we have same patter for other APIs also for example proxy one. and the one which are gone for all microversion they return 410
17:44:46 opendevreview Merged openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467
17:45:02 opendevreview Merged openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588
17:45:15 gibi \○/
17:45:16 gmaan \o/ gibi grab a beer
17:45:30 gibi I'm done for today :)
17:45:46 opendevreview Merged openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182
17:45:48 gmaan o/
17:45:52 sean-k-mooney gmaan: so this doesnt remvoe it outright right
17:45:56 gibi o/
17:46:28 opendevreview Merged openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405
17:46:45 gibi when things start moving...
17:46:47 opendevreview Merged openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590
17:46:48 gmaan sean-k-mooney: did not get, you mean for spec update?
17:47:05 sean-k-mooney i ment https://review.opendev.org/c/openstack/nova/+/958864
17:47:35 gibi gmaan: you reached early beer state today :)
17:47:46 sean-k-mooney so ya im jsut clarifyign are you asking for a 410 to be returend or the spec to be updated to 404
17:47:52 gmaan yeah, gate check our patient level and gives blessing
17:48:02 gmaan gibi: heh yeah
17:48:40 gmaan sean-k-mooney: ohk, I am saying code is good i am +2 there. i am asking spec to update once we land the code
17:48:46 gmaan just paper work nothing else
17:48:59 sean-k-mooney ack stephenfin ^ you might want to read back
17:49:45 gmaan which can be done later but I am holding +w due to microversion conflict only
17:52:35 sean-k-mooney stephen wont be around for the next 2 hours but they will be back on line later
17:57:24 gmaan ack, no issue, I will check as soon as it is updated
18:14:22 opendevreview Sebastian Krott proposed openstack/nova master: network: Add host filtering to `cleanup_instance_network_on_host` https://review.opendev.org/c/openstack/nova/+/978122
18:14:22 opendevreview Sebastian Krott proposed openstack/nova master: conductor: Clean up port-bindings for live migrations https://review.opendev.org/c/openstack/nova/+/978121
18:19:07 opendevreview melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724
18:19:07 opendevreview melanie witt proposed openstack/nova master: TPM: fixups for live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/976316
18:19:08 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
18:19:08 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
18:19:09 opendevreview melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052
18:19:09 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
18:19:10 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
18:21:13 opendevreview melanie witt proposed openstack/nova master: TPM: fixups for live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/976316
18:21:14 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
18:21:14 opendevreview melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724
18:21:15 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
18:21:15 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
18:21:16 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
18:21:16 opendevreview melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052
18:24:52 opendevreview melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724
18:24:53 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
18:24:53 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
18:24:54 opendevreview melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052
18:24:54 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
18:24:55 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
18:27:33 melwitt bauzas, dansmith: fyi I had to manually rebase and change service version 71 => 72 due to merge conflict in objects/service.py after https://review.opendev.org/c/openstack/nova/+/975588 merged
18:28:08 dansmith ack
18:30:56 gmaan melwitt: ah, sorry for that, I did not realise that vtpm also bumping service version

Earlier   Later