Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-02-25
08:50:06 gibi frickler: yes please Signed-off-by: Balazs Gibizer <gibi@redhat.com>
08:50:10 gibi https://review.opendev.org/c/openstack/tempest/+/977922
08:50:18 gibi (sorry wrong buffer)
08:52:52 gibi cc Uggla gmaan ^^
08:54:03 Uggla gibi :+1
08:59:38 frickler and done. gibi can you please also create a revert of the revert and add a nova testing patch this time?
09:01:22 gibi sure I can
09:01:27 gibi thanks for the help
09:21:35 gibi frickler: this is the reapply patch with nova-next testing now https://review.opendev.org/c/openstack/tempest/+/977930
09:22:26 frickler thx
11:37:50 sean-k-mooney gibi: i have not looks but we could also just skip that test in nova-next quickly
11:39:54 sean-k-mooney ah i see the revert is merged already
12:13:09 gibi yep
12:27:17 r-taketn gibi: Uggla: Hello. Thank you for reviewing the SEV refactoring patches despite your busy schedule. I'd appreciate it if you could also take a look at the remaining patches.
12:27:58 sean-k-mooney gibi: im going to review gmaan graceful shutdown patches now but ill hold +w on the bottom patch until we hopefully see your 3 eventlet removal patchs merge
12:28:15 sean-k-mooney gibi: but we can check in on that in the call later today
12:30:19 gibi sean-k-mooney: ack thanks. I saw the merge conflict. Hopefully we land the eventlet patches soon. They are approved but needed a recheck due to the tempest issue
12:30:52 opendevreview Bence Romsics proposed openstack/nova master: Functional reproducer for #2051685 https://review.opendev.org/c/openstack/nova/+/977331
12:32:20 opendevreview Stephen Finucane proposed openstack/nova master: api: Remove errant field https://review.opendev.org/c/openstack/nova/+/976765
12:32:43 stephenfin gmaan: sean-k-mooney: Addressed gmaan's comment on ☝️ if you could revisit 🙏
12:32:46 sean-k-mooney gibi: yep i checked them when i logged on this morning
12:33:51 sean-k-mooney stephenfin: done
12:33:55 stephenfin ty
13:00:35 tkajinam gibi, thanks !
13:06:21 tkajinam bauzas, I'm wondering if you have chance to re-review https://review.opendev.org/c/openstack/nova/+/969132 ? I think I addressed your previous comments blocking +2 (If I took these right, hopefully
13:06:29 tkajinam the others are being merged
14:12:27 opendevreview Stephen Finucane proposed openstack/nova master: api: Add runtime check for general additionalProperties https://review.opendev.org/c/openstack/nova/+/958858
14:12:28 opendevreview Stephen Finucane proposed openstack/nova master: api: Fix issue with instance usage audit log schema https://review.opendev.org/c/openstack/nova/+/977967
14:12:55 stephenfin gmaan: sean-k-mooney: I had to rework that second patch slightly to handle a few more corner cases. Also found a bug in one of the more complicated schemas. Would appreciate a once-over ☝️
14:14:09 stephenfin s/second/first/
14:22:45 opendevreview Stephen Finucane proposed openstack/nova master: db: Move regex helpers to utils https://review.opendev.org/c/openstack/nova/+/958745
14:22:46 opendevreview Stephen Finucane proposed openstack/nova master: api: Simplify API version check for flavor description https://review.opendev.org/c/openstack/nova/+/958747
14:22:46 opendevreview Stephen Finucane proposed openstack/nova master: tests: Clean up flavors tests https://review.opendev.org/c/openstack/nova/+/958746
14:22:47 opendevreview Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749
14:22:47 opendevreview Stephen Finucane proposed openstack/nova master: api: Add ability to filter flavors by name https://review.opendev.org/c/openstack/nova/+/958748
14:22:48 opendevreview Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855
14:22:48 opendevreview Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750
14:22:49 opendevreview Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857
14:22:49 opendevreview Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856
14:55:47 opendevreview Nope proposed openstack/nova master: scheduler: re-query Placement after stale-snapshot claim failures https://review.opendev.org/c/openstack/nova/+/977908
15:40:34 bauzas tkajinam: done now :)
15:48:57 bauzas gmaan: gibi: there is a potential merge conflict in between https://review.opendev.org/c/openstack/nova/+/975588/26 (2nd RPC service) and n-cpu threading support so I won't accept the former until there is a rebase
15:49:20 bauzas threading support is more important for the cycle, I hope you get it
15:49:44 sean-k-mooney yep that is why we are merging the eventlet patches first
15:50:31 gibi sorry folks I totally missed the eventlet call today
15:50:32 gibi :/
15:51:21 sean-k-mooney ^ cordiating with graceful shutdown was the only topic i was going to raise
15:51:47 sean-k-mooney im review that serice now but honestly i was expect gmann ot have creted fucntionla test to test graceful shutdown
15:51:48 gibi bauzas: yeah the eventlet series is approved but gate is slow and unstable so it will take time.
15:52:05 gibi I'm monitoring it...
15:52:17 sean-k-mooney so im not sure that is ready i am also not really ok with callign it anything more then expreimetnal until we comple phase 2 and 3
15:58:59 bauzas I guess I'll give another swing to vtpm live-migration series
16:41:42 tkajinam bauzas, thanks !
16:42:20 melwitt bauzas, dansmith: for vtpm the patches targeted for FF are the fixups patch https://review.opendev.org/c/openstack/nova/+/976316 and the service version bump https://review.opendev.org/c/openstack/nova/+/975724 (since we got 'host' secret security mode available at this time). the rest will have to wait until H
16:45:47 dansmith melwitt: ack, I'll try to circle back soon, sorry for being pulled in multiple directions
16:46:11 melwitt thanks 🙏
17:08:04 bauzas melwitt: noted, I'll look at those before ending my day
17:09:08 melwitt thanks 🙏
17:20:56 opendevreview Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.101 https://review.opendev.org/c/openstack/nova/+/978002
17:36:32 opendevreview Takashi Kajinami proposed openstack/nova master: Remove unused gabbi https://review.opendev.org/c/openstack/nova/+/978006
17:47:48 opendevreview Merged openstack/nova master: libvirt: Add capability to load smm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131
18:13:11 opendevreview Merged openstack/nova master: libvirt: Use firmware auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132
19:47:38 gmaan sean-k-mooney: thanks for review on graceful shutdown, i am ok to callout the experimental in releasenotes and once we finish the all phases we will have exact list/things which finish or move to safe state in shitdown
19:48:26 gmaan sean-k-mooney: bauzas gibi seeing the gate eventlet series might take time to merge and rebasing the graceful shutdown can miss the FF date.
19:48:57 gmaan as eventlet changes are with +w let me rebase in advance so that graceful shutdown can be in gate in parallel
19:49:35 sean-k-mooney ack
19:50:17 sean-k-mooney i really jsut dont want to get a custoemr case in the future whre the go "you said shutdown was graceful" and the interupted a live migration and got into an underined state
19:50:55 sean-k-mooney so if we call it experimetal untill pahse 2 or 3 is done i think its fine to merge although i woudl really like to see functional tests added next cycle to buidl conficance in this
19:51:08 gmaan for me interrupted is fine as it can be solved with the configured timeout but an underined state i agree that we should make sure
19:51:10 sean-k-mooney the ansible/bash tests help
19:51:56 gmaan sean-k-mooney: functional test for phase 2 and 3 will cover the things but for phase1 which is all about RPC redesign cannot be cover by functional tests as they use fake driver
19:52:01 sean-k-mooney oh ya i have said its totally fine with me if we just abort the ongoing live migration or interupt them in a fixable state.
19:52:13 gmaan yeah
19:52:21 sean-k-mooney the funcitonl tests can use the livbirt driver
19:52:28 sean-k-mooney and we have live migration fucntional test already
19:52:32 gmaan I mean fake RPC driver
19:52:51 gmaan they do not use real RPC
19:53:37 sean-k-mooney thye use the fake rpc yes, the in memory one but ya the reaosn i bring it up was it was stated we would have them in the spec and i was expecting to see them in the code when i went to review
19:54:16 sean-k-mooney so we need to modify oslo to make the fake tansport supprot more the one rpc server ?
19:54:29 sean-k-mooney or can we make that work form the nova side?
19:55:02 gmaan I will say integration tests which is doable are ok for the RPC part
19:55:42 gmaan sand for phase 2/3 yes, it can be covered in functional with better control
19:56:18 sean-k-mooney ack, i can live with that. i dont relaly trust the integration tests to test this on its own
19:56:40 sean-k-mooney but we agree to make incremental progress so thats ok
19:57:24 gmaan k, let me rebase and fix the other comments you have
20:22:52 opendevreview Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588
20:32:58 opendevreview Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588
20:36:08 opendevreview Ghanshyam Maan proposed openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182
20:46:25 opendevreview Ghanshyam Maan proposed openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405
21:00:51 opendevreview Merged openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239
21:19:06 gmaan bauzas: sean-k-mooney gibi it seems, there is no merge conflict between eventlet and graceful shutdown changes, but anyways I have rebased latter one on eventlet.
21:19:12 opendevreview Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590
21:19:18 gmaan sean-k-mooney: updated ^^ doc change also
21:33:13 sean-k-mooney gmaan: im +2 on all of your changes thanks for the update
21:34:32 sean-k-mooney gmaan: gibi is unfutently not have great luck with the ci gods at the moment but maybe you can recheck the eventlet patches later in NA time when the ci might be less flaky
21:45:00 gmaan sean-k-mooney: thanks, I will keep eyes on CI
22:02:15 cardoe sean-k-mooney: ping https://review.opendev.org/c/openstack/nova/+/972601
22:02:47 cardoe I just posted a reply to you but I wanted to discuss it.
22:03:49 cardoe I believe you're misunderstanding what my change did. My change is matching the behavior of KVM/libvirt with the ironic driver. And making it so that the full backtrace is unnecessary to the end user to troubleshoot.
22:09:25 cardoe There's half a dozen bug reports / issues today where if I do X with KVM/libvirt, I get a clear error message explaining why it didn't work. But when I use the ironic driver via nova, the error message I get as a user is either wrong or generic and the only way to work out what happened is to read the full backtrace. Inside of that full backtrace is the same one that's being delivered back to the user in the KVM/libvirt case.

Earlier   Later