| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-11-21 | |||
| 11:02:27 | gibi | I'm not sure about the impl | |
| 11:02:39 | gibi | but any call on the Proxy object will be run in the tpool | |
| 11:02:45 | gibi | that is the contract | |
| 11:03:10 | stephenfin | okay, I'm still not getting it but you seem to understand my confusion and I trust you've done the right thing. Sorry for the noise! | |
| 11:04:05 | gibi | https://github.com/eventlet/eventlet/blob/8cb20296f3455a1836cdbcbf1d3545666ee7f867/eventlet/tpool.py#L207-L211 | |
| 11:04:13 | gibi | indeed it has a __call__ | |
| 11:04:42 | gibi | so yes on the impl question as well | |
| 11:04:48 | stephenfin | yup, okay, that checks out. Thanks for confirming 🙏 | |
| 11:05:20 | gibi | thanks for the review. I will refine the commit message based on this | |
| 11:05:33 | gibi | (I just have to redo one unintended squash in my rebase) | |
| 11:13:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 11:13:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 11:13:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make image upload tpool usage conditional https://review.opendev.org/c/openstack/nova/+/966505 | |
| 11:13:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make guestfs' Tpool usage optional https://review.opendev.org/c/openstack/nova/+/965821 | |
| 11:13:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 11:13:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove tpool_execute as it is unused https://review.opendev.org/c/openstack/nova/+/966552 | |
| 11:13:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 11:13:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Compute manager to use thread pools selectively https://review.opendev.org/c/openstack/nova/+/966016 | |
| 11:13:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not fork compute workers in native threading mode https://review.opendev.org/c/openstack/nova/+/965466 | |
| 11:13:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 11:13:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 11:13:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Move eventlet specific libvirt event handling https://review.opendev.org/c/openstack/nova/+/967178 | |
| 11:13:53 | gibi | OK I think I managed to restore sanity in the seriese | |
| 11:20:38 | jkulik | hm ... I don't seem to be able to run unit-tests (tox -e py) on nova master anymore unless I specify OS_NOVA_DISABLE_EVENTLET_PATCHING (with either true or false) | |
| 11:24:06 | jkulik | https://paste.opendev.org/show/b8uHX1hkkuwNJnQhni4L/ is the error I get | |
| 11:29:02 | opendevreview | Johannes Kulik proposed openstack/nova master: Enhance performance of get instance groups from DB https://review.opendev.org/c/openstack/nova/+/967977 | |
| 11:30:42 | jkulik | sean-k-mooney: ^ the other commit for server group performance. I'd appreciate a review. | |
| 11:37:32 | sean-k-mooney | jkulik: ah cool and for tox its "tox -e py3" | |
| 11:37:56 | sean-k-mooney | tox -e unit might also work i dont recally if i did that in nova or not | |
| 11:39:00 | jkulik | oh, -e py3 works. thanks. -e py worked until a couple of weeks ago | |
| 11:39:07 | sean-k-mooney | https://github.com/openstack/nova/blob/master/tox.ini#L59 | |
| 11:40:02 | sean-k-mooney | jkulik: -e py was never officlaly supported, that ahs not changed in our config in a long time but if a env starts with py | |
| 11:40:03 | jkulik | yeah, took a look already. not sure why I thought it should be py. env variable is set when using one of these testenvs, yes | |
| 11:40:15 | sean-k-mooney | tox will invent it nd run the command form the base target | |
| 11:40:28 | sean-k-mooney | https://github.com/openstack/nova/blob/master/tox.ini#L54-L57 | |
| 11:40:33 | sean-k-mooney | which happens to be our unit tests | |
| 11:40:45 | sean-k-mooney | my guess is this behvior has changed in a new version of tox | |
| 11:41:12 | sean-k-mooney | we coudl trivially add py | |
| 11:41:40 | sean-k-mooney | but ya its been py3 since we added python 3 support i tas py27 i thnk orginally | |
| 11:41:40 | jkulik | I can easily adapt :D | |
| 11:59:35 | nelljerram | elodilles: it looks like https://review.opendev.org/c/openstack/grenade/+/963716 is ready to proceed now (i.e. for a +W), and hopefully that will then unblock https://review.opendev.org/c/openstack/nova/+/967569 | |
| 12:30:53 | elodilles | nelljerram: yepp-yepp. i'll keep an eye on that patch and recheck the nova patch after that merged :) | |
| 12:31:29 | nelljerram | elodilles: thanks | |
| 12:42:03 | nicolairuckel | sean-k-mooney, I started to look into cold migration. You said that we need to use `copy_image` and I'm wondering where exactly I should do this to only do that for cold migration. My guess would be to add that to the `snapshot` function but I'm not sure about that. | |
| 14:24:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Move eventlet specific libvirt event handling https://review.opendev.org/c/openstack/nova/+/967178 | |
| 14:27:02 | opendevreview | Merged openstack/nova master: Init virt driver before use https://review.opendev.org/c/openstack/nova/+/966446 | |
| 14:38:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 14:38:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 14:38:47 | jkulik | hey, can we merge this docs typo fix? https://review.opendev.org/c/openstack/nova/+/922850 | |
| 14:39:24 | jkulik | seems non-controversial to me that this is wrong in the docs. one line change :) | |
| 14:39:29 | sean-k-mooney | hum | |
| 14:39:48 | sean-k-mooney | well teh only contoveral part is we try not to use _ like that in parmater names | |
| 14:39:56 | sean-k-mooney | let me check tha actual code | |
| 14:40:03 | jkulik | sure. thanks | |
| 14:40:51 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L2790-L2792 | |
| 14:40:56 | sean-k-mooney | so it is uesing an underscore | |
| 14:41:13 | jkulik | yes. | |
| 14:41:18 | sean-k-mooney | i woudl personlly prefer to supprot both but we coudl do that in a follow up i guess | |
| 14:42:00 | opendevreview | Merged openstack/nova-specs master: Repropose openapi spec for Gazpacho https://review.opendev.org/c/openstack/nova-specs/+/958869 | |
| 14:42:03 | sean-k-mooney | the i guess we are inconsitent | |
| 14:42:15 | sean-k-mooney | we use '--until-complete' but also --max_rows | |
| 14:42:39 | sean-k-mooney | we shoudl proably normalise al of these to the gnu convention of only using hyphens in a sperate patch | |
| 14:42:55 | jkulik | I agree. do we need a bug to remember this? | |
| 14:43:06 | sean-k-mooney | it would not hurt | |
| 14:43:11 | jkulik | I'll create one | |
| 14:45:18 | opendevreview | Merged openstack/nova-specs master: Repropose remove-os-volumes_boot-api https://review.opendev.org/c/openstack/nova-specs/+/958865 | |
| 14:48:33 | jkulik | https://bugs.launchpad.net/nova/+bug/2132130 hope the description fits the discussion | |
| 15:05:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 15:05:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make guestfs' Tpool usage optional https://review.opendev.org/c/openstack/nova/+/965821 | |
| 15:05:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 15:05:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove tpool_execute as it is unused https://review.opendev.org/c/openstack/nova/+/966552 | |
| 15:05:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make image upload tpool usage conditional https://review.opendev.org/c/openstack/nova/+/966505 | |
| 15:05:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 15:05:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 15:05:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not fork compute workers in native threading mode https://review.opendev.org/c/openstack/nova/+/965466 | |
| 15:05:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 15:05:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Compute manager to use thread pools selectively https://review.opendev.org/c/openstack/nova/+/966016 | |
| 15:05:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 15:23:32 | opendevreview | Merged openstack/nova master: docs: Corrects a typo on a placement audit command https://review.opendev.org/c/openstack/nova/+/922850 | |
| 18:14:46 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Clean up flavors tests https://review.opendev.org/c/openstack/nova/+/958746 | |
| 18:14:46 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Move regex helpers to utils https://review.opendev.org/c/openstack/nova/+/958745 | |
| 18:14:47 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add ability to filter flavors by name https://review.opendev.org/c/openstack/nova/+/958748 | |
| 18:14:47 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify API version check for flavor description https://review.opendev.org/c/openstack/nova/+/958747 | |
| 18:14:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750 | |
| 18:14:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749 | |
| 18:14:49 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | |
| 18:14:49 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | |
| 18:14:50 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | |
| 18:19:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for general additionalProperties https://review.opendev.org/c/openstack/nova/+/958858 | |
| 19:46:09 | opendevreview | Phillip Toohill proposed openstack/nova-specs master: WIP: Improve image caching behavior https://review.opendev.org/c/openstack/nova-specs/+/968065 | |
| 20:07:46 | opendevreview | Phillip Toohill proposed openstack/nova-specs master: WIP: Improve image caching behavior https://review.opendev.org/c/openstack/nova-specs/+/968065 | |
| 20:25:25 | JayF | If some folks could make time to review https://review.opendev.org/c/openstack/nova/+/967941 -- it represents a very straightforward fix to a nasty bug for users of the Ironic virt driver. Thanks o/ | |
| 22:18:30 | nicolairuckel | Did anyone have this error before? https://paste.opendev.org/show/b1ZNcgc3WxTDchUGR0Yg/ | |
| 22:19:30 | JayF | nicolairuckel: ensure your dependency versions, specifically oslo.service, match the version required in requirements.txt and upper-constraints.txt for the version you're using. | |
| 22:20:25 | nicolairuckel | Let me check where to do this in DevStack | |
| 22:21:33 | nicolairuckel | I was assuming that would work automatically. | |
| 22:25:56 | nicolairuckel | thanks, that helped! | |
| 22:28:26 | JayF | good luck; fwiw I don't think this channel is usually used for support; you might wanna email openstack-discuss@ next time instead :) | |
| 22:29:23 | nicolairuckel | I thought it makes sense because I thought it was a Nova problem. | |
| 22:31:47 | JayF | Well and I helped you with it :) Just letting you know that may not always be the case, async via mailing list is often more successful. YMMV :) | |